[GitHub] [dubbo-go] sxllwx opened a new issue #580: [Enhance] help learn and become familiar with dubbo-go

sxllwx opened a new issue #580: URL: https://github.com/apache/dubbo-go/issues/580 **What would you like to be added**: Introduce how to use Docker to help learn and become familiar with dubbo-go **Why is this needed**:

[GitHub] [dubbo-go] relaxedCat opened a new pull request #582: feat: support grpc json protocol

relaxedCat opened a new pull request #582: URL: https://github.com/apache/dubbo-go/pull/582 Fixes #437 comment This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [dubbo-samples] AlexStocks closed pull request #156: feat(rocketmq): support json protocol

AlexStocks closed pull request #156: URL: https://github.com/apache/dubbo-samples/pull/156 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [dubbo-go] Patrick0308 commented on a change in pull request #549: Improve code coverage of zookeeper config center

Patrick0308 commented on a change in pull request #549: URL: https://github.com/apache/dubbo-go/pull/549#discussion_r433843925 ## File path: config_center/zookeeper/impl.go ## @@ -81,32 +79,6 @@ func newZookeeperDynamicConfiguration(url *common.URL) (*zookeeperDynamicConfigu

[GitHub] [dubbo-go] AlexStocks commented on pull request #579: Feat: add comments for config

AlexStocks commented on pull request #579: URL: https://github.com/apache/dubbo-go/pull/579#issuecomment-637533703 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #495: Imp: refactor the network transport layer

codecov-commenter edited a comment on pull request #495: URL: https://github.com/apache/dubbo-go/pull/495#issuecomment-630637394 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/495?src=pr=h1) Report > Merging [#495](https://codecov.io/gh/apache/dubbo-go/pull/495?src=pr=desc)

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #578: Rft : Optimize lock for zookeeper registry

codecov-commenter edited a comment on pull request #578: URL: https://github.com/apache/dubbo-go/pull/578#issuecomment-636663654 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr=h1) Report > Merging [#578](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr=desc)

[GitHub] [dubbo-go] zouyx commented on a change in pull request #579: Feat: add comments for config

zouyx commented on a change in pull request #579: URL: https://github.com/apache/dubbo-go/pull/579#discussion_r433889968 ## File path: config/registry_config.go ## @@ -47,7 +47,7 @@ type RegistryConfig struct { Params map[string]string `yaml:"params"

[GitHub] [dubbo-go] Isaac-Zhang opened a new pull request #581: updated the dubbo-go-ext image

Isaac-Zhang opened a new pull request #581: URL: https://github.com/apache/dubbo-go/pull/581 updated the dubbo-go-ext image This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [dubbo-go] AlexStocks merged pull request #578: Rft : Optimize lock for zookeeper registry

AlexStocks merged pull request #578: URL: https://github.com/apache/dubbo-go/pull/578 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [dubbo-go] AlexStocks commented on pull request #582: feat: support grpc json protocol

AlexStocks commented on pull request #582: URL: https://github.com/apache/dubbo-go/pull/582#issuecomment-637644936 @relaxedCat pls add comment for the public structs/funcs. This is an automated message from the Apache Git

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #578: Rft : Optimize lock for zookeeper registry

codecov-commenter edited a comment on pull request #578: URL: https://github.com/apache/dubbo-go/pull/578#issuecomment-636663654 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr=h1) Report > Merging [#578](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr=desc)

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #495: Imp: refactor the network transport layer

codecov-commenter edited a comment on pull request #495: URL: https://github.com/apache/dubbo-go/pull/495#issuecomment-630637394 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/495?src=pr=h1) Report > Merging [#495](https://codecov.io/gh/apache/dubbo-go/pull/495?src=pr=desc)

[GitHub] [dubbo-go] codecov-commenter commented on pull request #581: updated the dubbo-go-ext image

codecov-commenter commented on pull request #581: URL: https://github.com/apache/dubbo-go/pull/581#issuecomment-637593448 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/581?src=pr=h1) Report > Merging [#581](https://codecov.io/gh/apache/dubbo-go/pull/581?src=pr=desc) into

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #579: Feat: add comments for config

codecov-commenter edited a comment on pull request #579: URL: https://github.com/apache/dubbo-go/pull/579#issuecomment-637287472 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/579?src=pr=h1) Report > Merging [#579](https://codecov.io/gh/apache/dubbo-go/pull/579?src=pr=desc)

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #579: Feat: add comments for config

codecov-commenter edited a comment on pull request #579: URL: https://github.com/apache/dubbo-go/pull/579#issuecomment-637287472 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/579?src=pr=h1) Report > Merging [#579](https://codecov.io/gh/apache/dubbo-go/pull/579?src=pr=desc)

[GitHub] [dubbo-go] Patrick0308 commented on a change in pull request #579: Feat: add comments for config

Patrick0308 commented on a change in pull request #579: URL: https://github.com/apache/dubbo-go/pull/579#discussion_r433853168 ## File path: config/config_center_config.go ## @@ -31,7 +31,13 @@ import ( "github.com/apache/dubbo-go/common/constant" ) -//

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #579: Feat: add comments for config

codecov-commenter edited a comment on pull request #579: URL: https://github.com/apache/dubbo-go/pull/579#issuecomment-637287472 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/579?src=pr=h1) Report > Merging [#579](https://codecov.io/gh/apache/dubbo-go/pull/579?src=pr=desc)

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #522: Nacos MetadataReport implementation

codecov-commenter edited a comment on pull request #522: URL: https://github.com/apache/dubbo-go/pull/522#issuecomment-630889858 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/522?src=pr=h1) Report > Merging [#522](https://codecov.io/gh/apache/dubbo-go/pull/522?src=pr=desc)

[GitHub] [dubbo-go] Patrick0308 commented on a change in pull request #549: Improve code coverage of zookeeper config center

Patrick0308 commented on a change in pull request #549: URL: https://github.com/apache/dubbo-go/pull/549#discussion_r433843925 ## File path: config_center/zookeeper/impl.go ## @@ -81,32 +79,6 @@ func newZookeeperDynamicConfiguration(url *common.URL) (*zookeeperDynamicConfigu

[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #579: Feat: add comments for config

AlexStocks commented on a change in pull request #579: URL: https://github.com/apache/dubbo-go/pull/579#discussion_r433790438 ## File path: config/graceful_shutdown_config.go ## @@ -31,7 +31,7 @@ const ( defaultStepTimeout = 10 * time.Second ) -// ShutdownConfig ...

[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #578: Rft : Optimize lock for zookeeper registry

AlexStocks commented on a change in pull request #578: URL: https://github.com/apache/dubbo-go/pull/578#discussion_r433794835 ## File path: remoting/zookeeper/client.go ## @@ -487,7 +493,9 @@ func (z *ZookeeperClient) RegisterTempSeq(basePath string, data []byte) (string,

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #579: Feat: add comments for config

codecov-commenter edited a comment on pull request #579: URL: https://github.com/apache/dubbo-go/pull/579#issuecomment-637287472 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/579?src=pr=h1) Report > Merging [#579](https://codecov.io/gh/apache/dubbo-go/pull/579?src=pr=desc)

[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #522: Nacos MetadataReport implementation

AlexStocks commented on a change in pull request #522: URL: https://github.com/apache/dubbo-go/pull/522#discussion_r433793258 ## File path: metadata/report/nacos/report.go ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #522: Nacos MetadataReport implementation

codecov-commenter edited a comment on pull request #522: URL: https://github.com/apache/dubbo-go/pull/522#issuecomment-630889858 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/522?src=pr=h1) Report > Merging [#522](https://codecov.io/gh/apache/dubbo-go/pull/522?src=pr=desc)

[GitHub] [dubbo-go] Patrick0308 commented on a change in pull request #549: Improve code coverage of zookeeper config center

Patrick0308 commented on a change in pull request #549: URL: https://github.com/apache/dubbo-go/pull/549#discussion_r433840386 ## File path: config_center/zookeeper/impl.go ## @@ -81,32 +79,6 @@ func newZookeeperDynamicConfiguration(url *common.URL) (*zookeeperDynamicConfigu

[GitHub] [dubbo-go] codecov-commenter commented on pull request #583: modify_registry_panic_msg

codecov-commenter commented on pull request #583: URL: https://github.com/apache/dubbo-go/pull/583#issuecomment-637938956 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/583?src=pr=h1) Report > Merging [#583](https://codecov.io/gh/apache/dubbo-go/pull/583?src=pr=desc) into

[GitHub] [dubbo-go] watermelo commented on pull request #584: Feat: add comment for cluster

watermelo commented on pull request #584: URL: https://github.com/apache/dubbo-go/pull/584#issuecomment-637960995 #564 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [dubbo-go] watermelo commented on issue #573: [Enhance] Add comments for registry directory

watermelo commented on issue #573: URL: https://github.com/apache/dubbo-go/issues/573#issuecomment-637961233 1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [dubbo-go] watermelo opened a new pull request #584: Feat: add comment for cluster

watermelo opened a new pull request #584: URL: https://github.com/apache/dubbo-go/pull/584 **What this PR does**: add comment for cluster directory **Which issue(s) this PR fixes**: Fixes # **Special notes for your reviewer**: **Does this PR introduce

[GitHub] [dubbo-go] codecov-commenter commented on pull request #584: Feat: add comment for cluster

codecov-commenter commented on pull request #584: URL: https://github.com/apache/dubbo-go/pull/584#issuecomment-637963062 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/584?src=pr=h1) Report > Merging [#584](https://codecov.io/gh/apache/dubbo-go/pull/584?src=pr=desc) into

[GitHub] [dubbo-go] zouyx commented on a change in pull request #584: Feat: add comment for cluster

zouyx commented on a change in pull request #584: URL: https://github.com/apache/dubbo-go/pull/584#discussion_r434323352 ## File path: cluster/loadbalance/least_active.go ## @@ -28,7 +28,6 @@ import ( ) const ( - // LeastActive ... LeastActive = "leastactive"

[GitHub] [dubbo-go] ZYB-J opened a new pull request #583: modify_registry_panic_msg

ZYB-J opened a new pull request #583: URL: https://github.com/apache/dubbo-go/pull/583 **What this PR does**: modify_registry_panic_msg **Which issue(s) this PR fixes**: Fixes # **Special notes for your reviewer**: **Does this PR introduce a user-facing

[GitHub] [dubbo-go] zouyx commented on pull request #582: feat: support grpc json protocol

zouyx commented on pull request #582: URL: https://github.com/apache/dubbo-go/pull/582#issuecomment-637922442 Travis still failing This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [dubbo-go] Patrick0308 merged pull request #579: Feat: add comments for config

Patrick0308 merged pull request #579: URL: https://github.com/apache/dubbo-go/pull/579 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [dubbo-go] zouyx merged pull request #583: Rft: modify registry panic msg

zouyx merged pull request #583: URL: https://github.com/apache/dubbo-go/pull/583 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to