[GitHub] [incubator-dubbo] codecov-io commented on issue #2591: FailbackRegistry Test: recover method

2018-09-30 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2591?src=pr=h1) Report > Merging > [#2591](https://codecov.io/gh/apache/incubator-dubbo/pull/2591?src=pr=desc) > into >

[GitHub] [incubator-dubbo] codecov-io commented on issue #2591: FailbackRegistry Test: recover method

2018-09-30 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2591?src=pr=h1) Report > Merging > [#2591](https://codecov.io/gh/apache/incubator-dubbo/pull/2591?src=pr=desc) > into >

[GitHub] [incubator-dubbo] dugenkui03 opened issue #2592: 缓存对象回收

2018-09-30 Thread GitHub
https://github.com/apache/incubator-dubbo/tree/master/dubbo-filter/dubbo-filter-cache/src/main/java/org/apache/dubbo/cache/support/expiring 您好,ExpiringCache对象是否创建了便永远不可被回收? 原因: 1. `ExpiringCache` 对象变量的`store.clear()`方法没有被调用的入口。 2. 获取`ExpiringCache`对象时,会启动线程执行 检查缓存数据是否过期

[GitHub] [incubator-dubbo] tswstarplanet opened pull request #2591: FailbackRegistry Test: recover method

2018-09-30 Thread GitHub
for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when

[GitHub] [incubator-dubbo] ralf0131 commented on issue #2538: 使用JavaConfig搭建框架时报错。 Throw Error:BeanDefinitionStoreException when build by JavaConfig

2018-10-05 Thread GitHub
I reproduce the same problem locally. when using dubbo like this,it will load two ContextLoaderListeners,the first in the `org.springframework.web.context.AbstractContextLoaderInitializer#registerContextLoaderListener` by Spring,the second in the dubbo-config-spring/web-fragment.xml(This file

[GitHub] [incubator-dubbo] ralf0131 commented on issue #2586: Optimize RoundRobinLoadBalance

2018-10-05 Thread GitHub
This pull request looks good to me. Nice work! The time complexity is O(n), where n is the number of invokers, which is a significant improvement to the previous one, which is O(n*w), where n is the number of invokers, and w is the max weight of the invokers. I'd prefer to have more unit tests

[GitHub] [incubator-dubbo] chickenlj commented on issue #2599: 消费者调用报java.lang.NoSuchMethod异常

2018-10-07 Thread GitHub
I think most likely you are using different versions of service definition on the Consumer and Provider side. Have you changed the method signature recently? Can you please paste the exception stack trace? [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2599 ]

[GitHub] [incubator-dubbo] diecui1202 commented on issue #2459: The sha512 hashes are missing the '*' marker that indicates

2018-10-07 Thread GitHub
>From Mark: > The sha512 hash is missing the '*' marker to indicate that this is a binary file. Minor issue but one that was present on the previous release and should have been fixed by now. This issue must be fixed in 2.6.5. [ Full content available at:

[GitHub] [incubator-dubbo] carryxyh commented on issue #2596: 2.5.x

2018-10-07 Thread GitHub
Please specify the theme of your pr. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2596 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,

[GitHub] [incubator-dubbo-ops] nzomkxia commented on issue #132: mvn package showing Installing node version v9.11.1

2018-10-07 Thread GitHub
nodeVersion is specified [here](https://github.com/apache/incubator-dubbo-ops/blob/develop/dubbo-admin-frontend/pom.xml#L51) [ Full content available at: https://github.com/apache/incubator-dubbo-ops/issues/132 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] dugenkui03 commented on issue #2592: 缓存对象回收

2018-10-07 Thread GitHub
> @dugenkui03 with the clear method introduced on `Cache` interface, how do you > plan to use it? @beiwei30 when we want to invalidate a ExpiringCache object and gc it.for example,yesterday's data does not apply today. i think there should be implements of 'clear' and 'remove',because

[GitHub] [incubator-dubbo] diecui1202 closed pull request #2582: applicationmodel provider & consumer serviceName is not unique

2018-10-08 Thread GitHub
[ pull request closed by diecui1202 ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2582 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,

[GitHub] [incubator-dubbo] beiwei30 closed issue #2599: 消费者调用报java.lang.NoSuchMethod异常

2018-10-07 Thread GitHub
[ issue closed by beiwei30 ] [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2599 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] beiwei30 commented on issue #2592: 缓存对象回收

2018-10-07 Thread GitHub
@dugenkui03 with the clear method introduced on `Cache` interface, how do you plan to use it? [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2592 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 closed issue #2590: dubbo发布http服务后 http客户端访问问题

2018-10-07 Thread GitHub
[ issue closed by beiwei30 ] [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2590 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo-ops] nzomkxia commented on issue #131: Service Search:POST http://localhost:8080/api/service/search 405

2018-10-07 Thread GitHub
@wzlee try the latest version, is the problem still exits? [ Full content available at: https://github.com/apache/incubator-dubbo-ops/issues/131 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 commented on issue #2598: 继承集合对象的序列化

2018-10-07 Thread GitHub
yes, this is a limitation from hessian. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2598 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,

[GitHub] [incubator-dubbo] beiwei30 closed issue #2598: 继承集合对象的序列化

2018-10-07 Thread GitHub
[ issue closed by beiwei30 ] [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2598 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] beiwei30 commented on issue #2583: ApplicationModel serviceName is not unique

2018-10-07 Thread GitHub
@haiyang1985 I drop a comment in https://github.com/apache/incubator-dubbo/pull/2582#pullrequestreview-162318577, pls. take a look. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2583 ] This message was relayed via gitbox.apache.org for

[GitHub] [incubator-dubbo] zyh1218 commented on issue #2588: dubbo泛化调用的时候传parameterTypes问题

2018-10-07 Thread GitHub
我在调用 GenericService 这个接口的时候 其中接口里面yo(parameterTypes) 我传空值也可以获取到值,并且这样我没有办法去调用接口直接调用的协议参数了。 At 2018-09-30 20:24:06, "kimmking" wrote: So your question is what? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute

[GitHub] [incubator-dubbo] cvictory commented on issue #1784: Dubbo调用超时,服务端历史统计的处理耗时很短且找不到对应超时上下文的超时日志

2018-10-08 Thread GitHub
@Jaskey is it ok now? [ Full content available at: https://github.com/apache/incubator-dubbo/issues/1784 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] Rominez closed issue #2538: 使用JavaConfig搭建框架时报错。 Throw Error:BeanDefinitionStoreException when build by JavaConfig

2018-10-07 Thread GitHub
[ issue closed by Rominez ] [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2538 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] chickenlj commented on issue #2598: 继承集合对象的序列化

2018-10-07 Thread GitHub
As far as I know, it's a known restriction of Hessian serialization protocol. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2598 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh closed pull request #2596: 2.5.x

2018-10-07 Thread GitHub
[ pull request closed by carryxyh ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2596 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,

[GitHub] [incubator-dubbo] dugenkui03 commented on issue #2592: 缓存对象回收

2018-10-07 Thread GitHub
> @dugenkui03 with the clear method introduced on `Cache` interface, how do you > plan to use it? @beiwei30 when we want to invalidate a ExpiringCache object and gc it.for example,yesterday's data does not apply today. i think there should be implements of 'clear' and 'remove',because

[GitHub] [incubator-dubbo] dugenkui03 commented on issue #2592: 缓存对象回收

2018-10-07 Thread GitHub
> @dugenkui03 with the clear method introduced on `Cache` interface, how do you > plan to use it? @beiwei30 when we want to invalidate a ExpiringCache object and gc it.for example,yesterday's data does not apply today. i think there should be implements of 'clear' and 'remove',because

[GitHub] [incubator-dubbo] Createst opened issue #2599: 消费者调用报java.lang.NoSuchMethod异常

2018-10-07 Thread GitHub
Environment * Dubbo version:2.6.1 * Java version: 1.8 问题描述: dubbo消费者调用服务提示找不到该方法,通过查看zookeeper已经注册了,通过invoke直接调用是没有问题的,方法调用的参数和名称都是正确的,只有部分方法出现这个问题。这个问题出现两次,第一次是将服务和消费者重新部署就自动好了,第二次是修改了那个方法的名称,重新部署好的。至今不知道为啥出现这样的问题。 [ Full content available at:

[GitHub] [incubator-dubbo] diecui1202 opened issue #2600: add javadoc to dubbo-all module

2018-10-08 Thread GitHub
``` release maven-javadoc-plugin ${maven_javadoc_version} attach-javadoc

[GitHub] [incubator-dubbo] beiwei30 commented on issue #2599: 消费者调用报java.lang.NoSuchMethod异常

2018-10-07 Thread GitHub
it should be interface compatibility issue in your system. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2599 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-spring-boot-project] mercyblitz closed issue #287: 我用的还可以啊

2018-10-07 Thread GitHub
[ issue closed by mercyblitz ] [ Full content available at: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/287 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To

[GitHub] [incubator-dubbo] ralf0131 commented on pull request #2586: Optimize RoundRobinLoadBalance

2018-10-05 Thread GitHub
The name `invokerToWeightList` can be improved. I think `weightedInvokerList` or `nonZeroWeightedInvokers` should be better. :) [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2586 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #2586: Optimize RoundRobinLoadBalance

2018-10-07 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2586?src=pr=h1) Report > Merging > [#2586](https://codecov.io/gh/apache/incubator-dubbo/pull/2586?src=pr=desc) > into >

[GitHub] [incubator-dubbo-ops] wzlee opened issue #131: Service Search:POST http://localhost:8080/api/service/search 405

2018-10-07 Thread GitHub
``` xhr.js:178 POST http://localhost:8080/api/service/search 405 (anonymous) @ xhr.js:178 e.exports @ xhr.js:12 e.exports @ dispatchRequest.js:57 Promise.then (async) XmWM.s.request @ Axios.js:51 s.(anonymous function) @ Axios.js:71 (anonymous) @ bind.js:9 search @ ServiceSearch.vue:150 submit @

[GitHub] [incubator-dubbo-ops] nzomkxia commented on issue #131: Service Search:POST http://localhost:8080/api/service/search 405

2018-10-07 Thread GitHub
I've fix it, please try again, thanks [ Full content available at: https://github.com/apache/incubator-dubbo-ops/issues/131 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,

[GitHub] [incubator-dubbo-ops] nzomkxia closed issue #131: Service Search:POST http://localhost:8080/api/service/search 405

2018-10-07 Thread GitHub
[ issue closed by nzomkxia ] [ Full content available at: https://github.com/apache/incubator-dubbo-ops/issues/131 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] cvictory commented on issue #1770: [Enhancement] @EnableDubboConfigBinding annotates @Repeatable

2018-10-08 Thread GitHub
I think we can add this annotation at both 2.7.x version. @Repeatable is effcient after jdk1.8. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/1770 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] Jeff-Lv opened issue #2606: Rest-Rpc adds a uncommon class ServiceClassHolder

2018-10-08 Thread GitHub
As the class ServiceClassHolder's javadoc saying, “TODO this is just a workaround for rest protocol, and now we just ensure it works in the most common dubbo usages” We need to refactor it and remove this temp solution with a common way. ### Expected Result Impove the way of rest impletation

[GitHub] [incubator-dubbo] codecov-io commented on issue #2601: update lastest version to 2.6.4

2018-10-08 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2601?src=pr=h1) Report > Merging > [#2601](https://codecov.io/gh/apache/incubator-dubbo/pull/2601?src=pr=desc) > into >

[GitHub] [incubator-dubbo] diecui1202 closed pull request #2601: update lastest version to 2.6.4

2018-10-08 Thread GitHub
[ pull request closed by diecui1202 ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2601 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,

[GitHub] [incubator-dubbo] codecov-io commented on issue #2602: fix #2600, add javadoc plugin to dubbo-all module

2018-10-08 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2602?src=pr=h1) Report > Merging > [#2602](https://codecov.io/gh/apache/incubator-dubbo/pull/2602?src=pr=desc) > into >

[GitHub] [incubator-dubbo] codecov-io commented on issue #2601: update lastest version to 2.6.4

2018-10-08 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2601?src=pr=h1) Report > Merging > [#2601](https://codecov.io/gh/apache/incubator-dubbo/pull/2601?src=pr=desc) > into >

[GitHub] [incubator-dubbo] diecui1202 opened pull request #2601: update lastest version to 2.6.4

2018-10-08 Thread GitHub
-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX

[GitHub] [incubator-dubbo-ops] nzomkxia opened issue #133: i18n support

2018-10-08 Thread GitHub
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/issues/133 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] diecui1202 opened issue #2605: remove java9 in .travis.yml on 2.6.x

2018-10-08 Thread GitHub
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2605 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] cvictory opened pull request #2603: [Dubbo-2298] Add Annotation-Driven for MethodConfig and ArgumentConfig

2018-10-08 Thread GitHub
not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have

[GitHub] [incubator-dubbo] diecui1202 opened pull request #2602: fix #2600, add javadoc plugin to dubbo-all module

2018-10-08 Thread GitHub
/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title

[GitHub] [incubator-dubbo] mercyblitz commented on issue #1770: [Enhancement] @EnableDubboConfigBinding annotates @Repeatable

2018-10-08 Thread GitHub
@cvictory it both works Dubbo 2.6.x and 2.7.x, and may do later [ Full content available at: https://github.com/apache/incubator-dubbo/issues/1770 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] diecui1202 opened pull request #2604: fix #2600 add javadoc-plugin to dubbo-all module

2018-10-08 Thread GitHub
/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title

[GitHub] [incubator-dubbo] Jeff-Lv opened pull request #2607: remove serviceclassHolder

2018-10-08 Thread GitHub
Fix the issue #2606 [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2607 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] carryxyh commented on issue #2595: Fixed a minor issue with doConnect not using getConnectTimeout() in NettyClient

2018-10-08 Thread GitHub
LGTM. Nice work. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2595 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] diecui1202 closed pull request #2602: fix #2600, add javadoc plugin to dubbo-all module

2018-10-08 Thread GitHub
[ pull request closed by diecui1202 ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2602 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,

[GitHub] [incubator-dubbo] carryxyh opened pull request #2608: Remove unuse class.

2018-10-08 Thread GitHub
Remove unuse class. * DelegateExporter.java * DelegateInvoker.java [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2608 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #2608: Remove unuse class.

2018-10-08 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2608?src=pr=h1) Report > Merging > [#2608](https://codecov.io/gh/apache/incubator-dubbo/pull/2608?src=pr=desc) > into >

[GitHub] [incubator-dubbo] cbolgiano commented on issue #2605: remove java9 in .travis.yml on 2.6.x

2018-10-08 Thread GitHub
Created PR to fix this issue: https://github.com/apache/incubator-dubbo/pull/2609 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2605 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cbolgiano opened pull request #2609: Dubbo-2605 Removed java9 from .travis.yml

2018-10-08 Thread GitHub
ike typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request sho

[GitHub] [incubator-dubbo] codecov-io commented on issue #2609: Dubbo-2605 Removed java9 from .travis.yml

2018-10-08 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2609?src=pr=h1) Report > Merging > [#2609](https://codecov.io/gh/apache/incubator-dubbo/pull/2609?src=pr=desc) > into >

[GitHub] [incubator-dubbo] tswstarplanet commented on pull request #2597: 【Code Optimization】Optimize the doSelect method of RandomLoadBalance

2018-10-11 Thread GitHub
I think it is not necessary to check because the select method of AbstractLoadBalance that invoke the method has check the null pointer and the size of the invoker list. If the size of the list is 0, it will not reach here. [ Full content available at:

[GitHub] [incubator-dubbo] Jeff-Lv commented on issue #2637: AbstractInterfaceConfigTest failed

2018-10-11 Thread GitHub
please check this PR https://github.com/apache/incubator-dubbo/pull/2607 时无两丶 于2018年10月11日周四 下午5:51写道: > Reopened #2637 <https://github.com/apache/incubator-dubbo/issues/2637>. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view

[GitHub] [incubator-dubbo] chickenlj commented on issue #2636: [Dubbo] move the classes of model from config to rpc-api for reusing

2018-10-11 Thread GitHub
If it prevents reuse when staying in the config module, then let's move these classes to the rpc module. This migration will have no effect on other functionalities but for telnet, please make sure telnet still works fine when doing this. [ Full content available at:

[GitHub] [incubator-dubbo] beiwei30 closed issue #2635: 不看pojo类或代码,能否通过telnet等命令查看pojo类的属性信息?

2018-10-11 Thread GitHub
[ issue closed by beiwei30 ] [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2635 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] beiwei30 commented on issue #2635: 不看pojo类或代码,能否通过telnet等命令查看pojo类的属性信息?

2018-10-11 Thread GitHub
可以使用 [Arthas](https://github.com/alibaba/arthas) 中的 [jad](https://alibaba.github.io/arthas/jad.html) 来查看。这个功能不适合放在 telnet 中。 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2635 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] yuhui0531 opened pull request #2638: sync with original

2018-10-11 Thread GitHub
/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix

[GitHub] [incubator-dubbo] cvictory commented on issue #2301: [BUG] @Reference#parameters() does not work

2018-10-11 Thread GitHub
@mercyblitz I saw you have a commit to this issue. Maybe you should commit a dependent pr and related to this issue. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2301 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] Jeff-Lv commented on pull request #2618: [Dubbo-1983] Support Protobuf Serialization

2018-10-11 Thread GitHub
It is not recommended like this "import io.protostuff.*;" as the checkstyle will report error "Using the '.*' form of import should be avoided" [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2618 ] This message was relayed via gitbox.apache.org for

[GitHub] [incubator-dubbo] Jeff-Lv commented on issue #2618: [Dubbo-1983] Support Protobuf Serialization

2018-10-11 Thread GitHub
I found a quote from [stackoverflow ](https://stackoverflow.com/questions/38245281/protobuf-payload-bigger-than-json) I found the using of protobufIOUtil instead of ProtostuffIoUtil, but still confusing is there any good support protocol buffer for the Protostuff with popular using? `

[GitHub] [incubator-dubbo] Jeff-Lv commented on issue #2618: [Dubbo-1983] Support Protobuf Serialization

2018-10-11 Thread GitHub
I found a quote from [stackoverflow ](https://stackoverflow.com/questions/38245281/protobuf-payload-bigger-than-json) I found the using of protobufIOUtil instead of ProtostuffIoUtil, but still confusing is there any good support protocol buffer for the Protostuff with popular using? >

[GitHub] [incubator-dubbo] cvictory commented on issue #2297: [Enhancement] Resolve the placeholders for sub-properties

2018-10-11 Thread GitHub
@mercyblitz My be you should commit a pr for this issue. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2297 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] chickenlj closed pull request #2636: [Dubbo] move the classes of model from config to rpc-api for reusing

2018-10-11 Thread GitHub
[ pull request closed by chickenlj ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2636 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,

[GitHub] [incubator-dubbo] codecov-io commented on issue #2638: sync with original

2018-10-11 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2638?src=pr=h1) Report > Merging > [#2638](https://codecov.io/gh/apache/incubator-dubbo/pull/2638?src=pr=desc) > into >

[GitHub] [incubator-dubbo] Veryfirefly commented on issue #2179: Kryo serialization fails when the service is both a provider and a consumer(Help Help!!!!)

2018-10-11 Thread GitHub
When serializing kryo in my project, the consumer call will also report an error. No provider available for the service com.lewanwuxian.service.AccountService:1.0 from registry 192.168.1.3:2181 on the consumer 192.168.1.29 using the dubbo version 2.6.3. Please check if the providers have been

[GitHub] [incubator-dubbo] SKYhuangjing commented on issue #2570: dubbo无法在 【非spring + tomcat】环境下运行

2018-10-11 Thread GitHub
> @diecui1202 > > > I think he uses com.alibaba:dubbo, all in one jar, so can not exclude this > > dependency. > > Why we need to shade all the dependency into one jar? This make it difficult > to customize the dependency. > I think this is something worth discussion. provide

[GitHub] [incubator-dubbo] rhwayfun opened issue #2639: Custom router does not support configuration on Provider side

2018-10-11 Thread GitHub
I have a requirement: According to the client's request, the specified machine is called for the qualified request, and the other machine is called for the unqualified request. So I customize a route, but I find that the route can only take effect on the client. The server(Provider) does not

[GitHub] [incubator-dubbo] Jeff-Lv commented on pull request #2618: [Dubbo-1983] Support Protobuf Serialization

2018-10-11 Thread GitHub
advice to refactor here by method extraction because here is a lot of replicated codes. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2618 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] Jeff-Lv commented on pull request #2618: [Dubbo-1983] Support Protobuf Serialization

2018-10-11 Thread GitHub
The buffer's mainly purpose is for performance with caching. Here is created everytime. The following is a good sample. ` // Re-use (manage) this buffer to avoid allocating on every serialization LinkedBuffer buffer = LinkedBuffer.allocate(512); // ser final byte[] protostuff;

[GitHub] [incubator-dubbo] jasonjoo2010 commented on issue #2578: The current RoundRobinLoadBalance implementation performance is not satisfactory

2018-10-13 Thread GitHub
> Hi, > The `RoundRobinLoadBalance Algorithm` is not smoothing. > For example, assuming that the weight of **Server A** is five, the weight of > **Server B** is one, the weight of **Server C** is one. > When calling the service seven times, the responding order is **[A ,A, A, A, > A, B, C]**. >

[GitHub] [incubator-dubbo] kimmking commented on issue #2639: Custom router does not support configuration on Provider side

2018-10-13 Thread GitHub
r/demos/routing-rule.html > <http://dubbo.apache.org/zh-cn/docs/user/demos/routing-rule.html> — You are > receiving this because you authored the thread. Reply to this email directly, > view it on GitHub <[#2639 > (comment)](https://github.com/apache/incubator-dubbo/issues/2639#

[GitHub] [incubator-dubbo] kimmking commented on issue #2641: When to support parameter routing?

2018-10-13 Thread GitHub
can you provide a case for usage? [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2641 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,

[GitHub] [incubator-dubbo] kimmking commented on issue #2628: provider不指定分组group时,会默认在zk中每个分组都实现服务吗?

2018-10-13 Thread GitHub
the provider will be registered to registries you configured in you application. Provider -> one or more Registry by your config -> ZK different context path. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2628 ] This message was relayed via gitbox.apache.org for

[GitHub] [incubator-dubbo] renlei413326889 commented on issue #2006: consumer 抛出Dubbo client can not supported string message原因分析

2018-10-13 Thread GitHub
@fingthinking 我按照你的这样处理了,没毛病!现在没有这种乱码问题,最新的dubbo的代码也有处理这种异常情况! [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2006 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] rhwayfun commented on issue #2639: Custom router does not support configuration on Provider side

2018-10-11 Thread GitHub
provider finds that the > request is illegal, as you said, do you want the current provider to send the > request to another provider? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github

[GitHub] [incubator-dubbo] carryxyh commented on issue #2425: FailbackClusterInvoker should limit the size of failed invocations

2018-10-12 Thread GitHub
This issue has been prevented for some time and I will start to solve this problem in the near future. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2425 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on issue #2310: Bootstrap blocked

2018-10-12 Thread GitHub
Hi, @bobchengit Pls push your demo onto github and provide a link to us. We will check the problem soon. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2310 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] rhwayfun commented on issue #2639: Custom router does not support configuration on Provider side

2018-10-12 Thread GitHub
request? > If you want to solve this problem on the P side, then any P needs to maintain > the information of all other providers, which is unreasonable. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <

[GitHub] [incubator-dubbo] carryxyh commented on issue #2638: sync with original

2018-10-11 Thread GitHub
Nothing changed. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2638 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] ralf0131 commented on issue #2570: dubbo无法在 【非spring + tomcat】环境下运行

2018-10-12 Thread GitHub
Hi, I would suggest to use maven profile to do this kind of customization. For example, use the `default` profile for most of the dependencies, and use `spring` profile to include spring dependency. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2570 ] This

[GitHub] [incubator-dubbo] codecov-io commented on issue #2603: [Dubbo-2298] Add Annotation-Driven for MethodConfig and ArgumentConfig

2018-10-12 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2603?src=pr=h1) Report > Merging > [#2603](https://codecov.io/gh/apache/incubator-dubbo/pull/2603?src=pr=desc) > into >

[GitHub] [incubator-dubbo] codecov-io commented on issue #2603: [Dubbo-2298] Add Annotation-Driven for MethodConfig and ArgumentConfig

2018-10-12 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2603?src=pr=h1) Report > Merging > [#2603](https://codecov.io/gh/apache/incubator-dubbo/pull/2603?src=pr=desc) > into >

[GitHub] [incubator-dubbo] carryxyh commented on issue #2639: Custom router does not support configuration on Provider side

2018-10-12 Thread GitHub
Sorry, it is not currently supported. But I think your needs can be achieved by customizing the router. In addition, I assume that Provider1 fails to process. How does Provider1 know which other Providers can handle this request? If you want to solve this problem on the P side, then any P needs

[GitHub] [incubator-dubbo] carryxyh closed issue #2592: Cache object recovery

2018-10-12 Thread GitHub
[ issue closed by carryxyh ] [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2592 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] carryxyh commented on issue #2592: Cache object recovery

2018-10-12 Thread GitHub
Close via https://github.com/apache/incubator-dubbo/pull/2594 a complete set of expiration policies is wanted. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2592 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on issue #2400: ReferenceConfig(dubbo://127.0.0.1:20880) is not DESTROYED when FINALIZ

2018-10-12 Thread GitHub
Hi, I can not reproduce this issue on my env. Could u send your demo onto github and provide a link to us? [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2400 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 opened pull request #2640: prototype for issue2570

2018-10-12 Thread GitHub
changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request

[GitHub] [incubator-dubbo] beiwei30 commented on issue #2570: dubbo all in one fail to start from a tomcat server when spring framework is absent

2018-10-12 Thread GitHub
@yangfuhai, would you mind to try out the change I proposed in https://github.com/apache/incubator-dubbo/pull/2640 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2570 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh closed pull request #2638: sync with original

2018-10-11 Thread GitHub
[ pull request closed by carryxyh ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2638 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,

[GitHub] [incubator-dubbo] rhwayfun opened issue #2641: When to support parameter routing?

2018-10-12 Thread GitHub
As the doc shows, it does't support parameter router currently, is there a plan for it? Wiki: [http://dubbo.apache.org/zh-cn/docs/user/demos/routing-rule.html](http://dubbo.apache.org/zh-cn/docs/user/demos/routing-rule.html) [ Full content available at:

[GitHub] [incubator-dubbo-spring-boot-project] WangDaoO opened issue #294: 调用低版本dubbo

2018-10-12 Thread GitHub
现在我们已经有相当数量的服务通过dubbo-2.5.3对外服务, 现在有一个新项目欲使用dubbo-spring-boot-starter,但其内置dubbo为2.6.2, 调用服务会因版本问题无法获取, `No provider available for the service ... from the url ... use dubbo version 2.6.2` 请问有什么特殊的处理方式吗? [ Full content available at:

[GitHub] [incubator-dubbo-ops] blackdancers opened issue #136: 无法加载 “https://fonts.googleapis.com/css?family=Roboto:300,400,500,700|Material+Icons”

2018-10-14 Thread GitHub
https://fonts.googleapis.com/css?family=Roboto:300,400,500,700|Material+Icons 加载失败,页面布局异常 [ Full content available at: https://github.com/apache/incubator-dubbo-ops/issues/136 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] rhwayfun commented on issue #2639: Custom router does not support configuration on Provider side

2018-10-14 Thread GitHub
/demos/routing-rule.html> > http://dubbo.apache.org/zh-cn/docs/user/demos/routing-rule.html > <http://dubbo.apache.org/zh-cn/docs/user/demos/routing-rule.html> — You are > receiving this because you authored the thread. Reply to this email directly, > view it on GitHub <#263

[GitHub] [incubator-dubbo] htynkn opened pull request #2643: Jacoco aggregate report

2018-10-14 Thread GitHub
## What is the purpose of the change JaCoCo Maven goals used to work on single modules only: Tests are executed within the module and contributed coverage only to code within the same module. Dubbo is a multi module project which combine by api and their implements, current configuration is not

[GitHub] [incubator-dubbo] SKYhuangjing commented on issue #2570: dubbo all in one fail to start from a tomcat server when spring framework is absent

2018-10-14 Thread GitHub
provide dubbo-all can be easy integrate to our app, if no dubbo-all, we have to need rely multi dubbo-xxx, it's not easy job(That is very painful for rookie(just like me...)) and may be dev don't wanna change the tomcat(or wildfly), in my humble opinion, this work is also more hardly. as a

  1   2   3   4   5   6   7   8   9   10   >