[GitHub] [dubbo] T-baby commented on issue #13146: 在没有使用 SpringBoot 的情况下如何使用 Metrics
T-baby commented on issue #13146: URL: https://github.com/apache/dubbo/issues/13146#issuecomment-1742246773 > > http://127.0.0.1:2/metrics/ 这个地址的 metrics 可以直接给 Prometheus 采集吗？ > > 可以的，这个就是标准的 prometheus 输出 谢谢，国庆快乐。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #13147: Update to curator 5 by default in dependencies bom
codecov-commenter commented on PR #13147: URL: https://github.com/apache/dubbo/pull/13147#issuecomment-1742114804 ## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/13147?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#13147](https://app.codecov.io/gh/apache/dubbo/pull/13147?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (522ec1d) into [3.2](https://app.codecov.io/gh/apache/dubbo/commit/8b0bd8a043d5b77a485a22e429b9fcb953d5e099?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8b0bd8a) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ##3.2 #13147 +/- ## - Coverage 69.44% 69.43% -0.01% Complexity22 Files 1648 1648 Lines 6868868688 Branches 1001410014 - Hits 4769747695 -2 - Misses1639916416 +17 + Partials 4592 4577 -15 ``` [see 22 files with indirect coverage changes](https://app.codecov.io/gh/apache/dubbo/pull/13147/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #13147: Update to curator 5 by default in dependencies bom
sonarcloud[bot] commented on PR #13147: URL: https://github.com/apache/dubbo/pull/13147#issuecomment-1742113614 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13147) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13147&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13147&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13147&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13147&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13147&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13147&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13147&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13147&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13147&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13147&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13147&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13147&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13147&metric=coverage&view=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13147&metric=duplicated_lines_density&view=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on issue #13146: 在没有使用 SpringBoot 的情况下如何使用 Metrics
AlbumenJ commented on issue #13146: URL: https://github.com/apache/dubbo/issues/13146#issuecomment-1742102936 > http://127.0.0.1:2/metrics/ 这个地址的 metrics 可以直接给 Prometheus 采集吗？ 可以的，这个就是标准的 prometheus 输出 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ opened a new pull request, #13147: Update to curator 5 by default in dependencies bom
AlbumenJ opened a new pull request, #13147: URL: https://github.com/apache/dubbo/pull/13147 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] T-baby commented on issue #13146: 在没有使用 SpringBoot 的情况下如何使用 Metrics
T-baby commented on issue #13146: URL: https://github.com/apache/dubbo/issues/13146#issuecomment-1742085516 http://127.0.0.1:2/metrics/ 这个地址的 metrics 可以直接给 Prometheus 采集吗？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] T-baby opened a new issue, #13146: 在没有使用 SpringBoot 的情况下如何使用 Metrics
T-baby opened a new issue, #13146: URL: https://github.com/apache/dubbo/issues/13146 看了下没有 MeterBinder 这类，没法像 Micrometer 官方提供的，使用类似 `JvmGcMetrics().bindTo(prometheusMeterRegistry)` 的方式注册。有什么其它方式在没有使用 Spring Boot 的情况下使用吗，如在 Vert.x 中使用？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-samples] AlbumenJ opened a new pull request, #998: Try test on jdk 21
AlbumenJ opened a new pull request, #998: URL: https://github.com/apache/dubbo-samples/pull/998 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-samples] AlbumenJ merged pull request #997: Add test case to verify async
AlbumenJ merged PR #997: URL: https://github.com/apache/dubbo-samples/pull/997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-spi-extensions] codecov-commenter commented on pull request #224: Auto gen doc
codecov-commenter commented on PR #224: URL: https://github.com/apache/dubbo-spi-extensions/pull/224#issuecomment-1741940052 ## [Codecov](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/224?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#224](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/224?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (499f6de) into [master](https://app.codecov.io/gh/apache/dubbo-spi-extensions/commit/a6e6eb1ae338a7e2d5c304bcfc8eb607b1db39fd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a6e6eb1) will **increase** coverage by `0.07%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #224 +/- ## + Coverage 33.83% 33.90% +0.07% Complexity 505 505 Files 156 156 Lines 5326 5320 -6 Branches662 661 -1 + Hits 1802 1804 +2 + Misses 3326 3314 -12 - Partials198 202 +4 ``` [see 7 files with indirect coverage changes](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/224/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-samples] AlbumenJ opened a new pull request, #997: Add test case to verify async
AlbumenJ opened a new pull request, #997: URL: https://github.com/apache/dubbo-samples/pull/997 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-spi-extensions] songxiaosheng closed issue #89: 请问一下有计划支持dubbo3吗
songxiaosheng closed issue #89: 请问一下有计划支持dubbo3吗 URL: https://github.com/apache/dubbo-spi-extensions/issues/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-spi-extensions] songxiaosheng commented on issue #89: 请问一下有计划支持dubbo3吗
songxiaosheng commented on issue #89: URL: https://github.com/apache/dubbo-spi-extensions/issues/89#issuecomment-1741929729 begin support -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-spi-extensions] songxiaosheng opened a new pull request, #224: Auto gen doc
songxiaosheng opened a new pull request, #224: URL: https://github.com/apache/dubbo-spi-extensions/pull/224 ## What is the purpose of the change - use code to find all spi extension then gen doc to readme.md  ## Brief changelog - add new module dubbo-doc-auto-gen ## Verifying this change you can run then main method of DocAutoGen to gen doc Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] kimmking commented on issue #13088: dubbo远程调用，卡调用主线程了， 提供方已经触发超时了但是消费方 调用主线程还是卡住了挂起了
kimmking commented on issue #13088: URL: https://github.com/apache/dubbo/issues/13088#issuecomment-1741818649 蛮奇怪的，提供方如果已经超时，那么应该返回异常信息给调用方了，按理调用方也不会一直阻塞。必定在什么地方存在了其他问题？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] kimmking commented on issue #13047: 拦截扩展的类加载器疑问
kimmking commented on issue #13047: URL: https://github.com/apache/dubbo/issues/13047#issuecomment-1741818162 最开始的截图就能看出来，两个类的id不一样，一个是22718，一个是7773，说明不是一个类，存在两个不同cl加载的Aop类，导致LISTS静态对象也不是一个。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go-samples] yuluo-yx commented on issue #615: Java-server Demo 文件报错
yuluo-yx commented on issue #615: URL: https://github.com/apache/dubbo-go-samples/issues/615#issuecomment-1741792572 If need fix. pls assign to me, I will fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go-samples] yuluo-yx opened a new issue, #615: Java-server Demo 文件报错
yuluo-yx opened a new issue, #615: URL: https://github.com/apache/dubbo-go-samples/issues/615 https://github.com/apache/dubbo-go-samples/blob/e83dbf31955cd679c56089f2b6a9ad9e3e5755e0/helloworld/java-server/src/main/java/com/apache/dubbo/sample/basic/ApiProvider.java#L35 将上述代码内容复制到 ide 中报错，详情如下：  观察代码发现，在 DubboBootstrap.getInstance() 时设置了对应的 app name 和 RegistryConfig ,可以删除 service 中的 setApplicaiton 和 setRegisterConfig 方法。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sadfera opened a new pull request, #13145: feat:remove jprotoc
sadfera opened a new pull request, #13145: URL: https://github.com/apache/dubbo/pull/13145 ## What is the purpose of the change dubbo-compiler remove jprotoc dependecy ## Brief changelog 1.Remove jprotc dependency and add mustache dependency for template generation code 2.Retain the ProtoTypeMap provided by the original jprotc for storing message types parsed from proto 3.Remove ProtocPlugin and use Dubbo's own DubboProtocPlugin as the main entry point for protoc plugin calls 4.DubboProtocPlugin no longer provides debug methods and only supports FEATURE_ PROTO3_ OPTIONAL 5.dubbo-maven-plugin supported dubbo-protoc-compiler mojo ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #13045: Remaining works of config-api refactor
sonarcloud[bot] commented on PR #13045: URL: https://github.com/apache/dubbo/pull/13045#issuecomment-1741722507 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13045) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13045&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13045&resolved=false&types=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13045&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13045&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13045&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13045&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13045&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13045&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13045&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13045&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13045&resolved=false&types=CODE_SMELL) [106 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13045&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13045&metric=new_coverage&view=list) [9.3% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13045&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13045&metric=new_duplicated_lines_density&view=list) [0.6% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13045&metric=new_duplicated_lines_density&view=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #13144: Remove duplicated class
sonarcloud[bot] commented on PR #13144: URL: https://github.com/apache/dubbo/pull/13144#issuecomment-1741645677 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13144) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13144&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13144&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13144&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13144&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13144&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13144&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13144&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13144&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13144&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13144&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13144&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13144&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13144&metric=coverage&view=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13144&metric=duplicated_lines_density&view=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #13144: Remove duplicated class
AlbumenJ merged PR #13144: URL: https://github.com/apache/dubbo/pull/13144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ opened a new pull request, #13144: Remove duplicated class
AlbumenJ opened a new pull request, #13144: URL: https://github.com/apache/dubbo/pull/13144 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #13104: Add metrics version compare
AlbumenJ merged PR #13104: URL: https://github.com/apache/dubbo/pull/13104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] wxbty commented on a diff in pull request #13104: Add metrics version compare
wxbty commented on code in PR #13104:
URL: https://github.com/apache/dubbo/pull/13104#discussion_r1341511869
##
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/data/BaseStatComposite.java:
##
@@ -133,4 +133,14 @@ public ApplicationStatComposite
getApplicationStatComposite() {
public RtStatComposite getRtStatComposite() {
return rtStatComposite;
}
+
+@Override
+public boolean calSamplesChanged() {
+// Should ensure that all the composite's samplesChanged have been
compareAndSet, and cannot flip the `or` logic
+boolean changed = applicationStatComposite.calSamplesChanged();
+changed = rtStatComposite.calSamplesChanged() || changed;
+changed = serviceStatComposite.calSamplesChanged() || changed;
+changed = methodStatComposite.calSamplesChanged() || changed;
+return changed;
+}
Review Comment:
Understood
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] andotorg commented on issue #13142: 使用triple协议，提供方provider方法重载，consumer方消费报错，provider方空指针
andotorg commented on issue #13142: URL: https://github.com/apache/dubbo/issues/13142#issuecomment-1740994666 I'm fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #13104: Add metrics version compare
sonarcloud[bot] commented on PR #13104: URL: https://github.com/apache/dubbo/pull/13104#issuecomment-1740891825 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13104) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13104&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13104&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13104&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13104&metric=new_coverage&view=list) [33.0% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13104&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13104&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13104&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on pull request #13137: feat: multiple支持 service discovery模式
AlbumenJ commented on PR #13137: URL: https://github.com/apache/dubbo/pull/13137#issuecomment-1740834093  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on pull request #13067: The handling of jsr310 times (package names start with java.time) is open to customization with dubbo's own spi implementation, which provid
AlbumenJ commented on PR #13067: URL: https://github.com/apache/dubbo/pull/13067#issuecomment-1740829512 ![Uploading image.png…]() Test cases failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #13139: fix https://github.com/apache/dubbo/issues/13135
AlbumenJ commented on code in PR #13139:
URL: https://github.com/apache/dubbo/pull/13139#discussion_r1341313898
##
dubbo-cluster/pom.xml:
##
@@ -91,5 +92,10 @@
micrometer-tracing-integration-test
test
+
+org.openjdk.nashorn
+nashorn-core
+${nashorn-core.version}
+
Review Comment:
Test scope would be better. We should not import such engine by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on issue #13142: 使用triple协议，提供方provider方法重载，consumer方消费报错，provider方空指针
AlbumenJ commented on issue #13142: URL: https://github.com/apache/dubbo/issues/13142#issuecomment-1740822990 @EarthChen PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #13138: delete useless parts and rewrite the code
AlbumenJ merged PR #13138: URL: https://github.com/apache/dubbo/pull/13138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-samples] AlbumenJ merged pull request #996: Bump org.apache.tomcat.embed:tomcat-embed-core from 7.0.88 to 7.0.107 in /3-extensions/protocol/dubbo-samples-resilience4j/dubbo-samples-res
AlbumenJ merged PR #996: URL: https://github.com/apache/dubbo-samples/pull/996 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #13104: Add metrics version compare
AlbumenJ commented on code in PR #13104:
URL: https://github.com/apache/dubbo/pull/13104#discussion_r1341303921
##
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/data/BaseStatComposite.java:
##
@@ -133,4 +133,14 @@ public ApplicationStatComposite
getApplicationStatComposite() {
public RtStatComposite getRtStatComposite() {
return rtStatComposite;
}
+
+@Override
+public boolean calSamplesChanged() {
+// Should ensure that all the composite's samplesChanged have been
compareAndSet, and cannot flip the `or` logic
+boolean changed = applicationStatComposite.calSamplesChanged();
+changed = rtStatComposite.calSamplesChanged() || changed;
+changed = serviceStatComposite.calSamplesChanged() || changed;
+changed = methodStatComposite.calSamplesChanged() || changed;
+return changed;
+}
Review Comment:
`calSamplesChanged` before check `changed` can ensure that all the samples
has been updated at once.
For examle, if a composite contains A and B samples and these two samples
are changed. If `calSamplesChanged` before check `changed` can update all the
flags both in A and B. Thus, one time `refresh` can refresh all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #13136: Enhance spring security class check
AlbumenJ merged PR #13136: URL: https://github.com/apache/dubbo/pull/13136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-samples] dependabot[bot] opened a new pull request, #996: Bump org.apache.tomcat.embed:tomcat-embed-core from 7.0.88 to 7.0.107 in /3-extensions/protocol/dubbo-samples-resilience4j/dub
dependabot[bot] opened a new pull request, #996: URL: https://github.com/apache/dubbo-samples/pull/996 Bumps org.apache.tomcat.embed:tomcat-embed-core from 7.0.88 to 7.0.107. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/dubbo-samples/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] kimmking commented on a diff in pull request #13110: feat: Support native steram calls in generic call(#13109)
kimmking commented on code in PR #13110:
URL: https://github.com/apache/dubbo/pull/13110#discussion_r1340412641
##
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/GenericFilter.java:
##
@@ -191,6 +192,26 @@ public Result invoke(Invoker invoker, Invocation inv)
throws RpcException {
args.length + " and type is" +
args[0].getClass().getName());
}
+} else if
(ProtocolUtils.isNativeStreamGenericSerialization(generic)) {
+for (int i = 0; i < args.length; i++) {
+if (byte[].class == args[i].getClass()) {
+try (UnsafeByteArrayInputStream is = new
UnsafeByteArrayInputStream((byte[]) args[i])) {
+args[i] =
applicationModel.getExtensionLoader(Serialization.class)
+
.getExtension(invoker.getUrl().getParameter(Constants.SERIALIZATION_KEY))
+.deserialize(null,
is).readObject(method.getParameterTypes()[i]);
+} catch (Exception e) {
+throw new RpcException("Deserialize argument
[" + (i + 1) + "] failed.", e);
+}
+} else {
+throw new RpcException(
+"Generic serialization [" +
+
invoker.getUrl().getParameter(Constants.SERIALIZATION_KEY) +
+"] only support message type " +
+byte[].class +
+" and your message type is " +
+args[i].getClass());
+}
+}
Review Comment:
ensure data types in runtime by an external filter is more compatible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] wxbty commented on a diff in pull request #13104: Add metrics version compare
wxbty commented on code in PR #13104:
URL: https://github.com/apache/dubbo/pull/13104#discussion_r1340358256
##
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/data/BaseStatComposite.java:
##
@@ -133,4 +133,14 @@ public ApplicationStatComposite
getApplicationStatComposite() {
public RtStatComposite getRtStatComposite() {
return rtStatComposite;
}
+
+@Override
+public boolean calSamplesChanged() {
+// Should ensure that all the composite's samplesChanged have been
compareAndSet, and cannot flip the `or` logic
+boolean changed = applicationStatComposite.calSamplesChanged();
+changed = rtStatComposite.calSamplesChanged() || changed;
+changed = serviceStatComposite.calSamplesChanged() || changed;
+changed = methodStatComposite.calSamplesChanged() || changed;
+return changed;
+}
Review Comment:
changed = changed || rtStatComposite.calSamplesChanged() ;
This would be better，Similar in other places.
##
dubbo-metrics/dubbo-metrics-api/src/main/java/org/apache/dubbo/metrics/data/BaseStatComposite.java:
##
@@ -133,4 +133,14 @@ public ApplicationStatComposite
getApplicationStatComposite() {
public RtStatComposite getRtStatComposite() {
return rtStatComposite;
}
+
+@Override
+public boolean calSamplesChanged() {
+// Should ensure that all the composite's samplesChanged have been
compareAndSet, and cannot flip the `or` logic
+boolean changed = applicationStatComposite.calSamplesChanged();
+changed = rtStatComposite.calSamplesChanged() || changed;
+changed = serviceStatComposite.calSamplesChanged() || changed;
+changed = methodStatComposite.calSamplesChanged() || changed;
+return changed;
+}
Review Comment:
changed = changed || rtStatComposite.calSamplesChanged() ;
This would be better，Similar in other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] DMwangnima commented on issue #2403: 调用java服务报错reflect: call of reflect.Value.MethodByName on zero Value
DMwangnima commented on issue #2403: URL: https://github.com/apache/dubbo-go/issues/2403#issuecomment-1739599890 @ssfyn 可以给一份go侧的配置内容吗？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] sonarcloud[bot] commented on pull request #2425: feat: finish server layer
sonarcloud[bot] commented on PR #2425: URL: https://github.com/apache/dubbo-go/pull/2425#issuecomment-1739582510 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2425) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=CODE_SMELL) [52 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2425) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2425&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2425&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] sonarcloud[bot] commented on pull request #2425: feat: finish server layer
sonarcloud[bot] commented on PR #2425: URL: https://github.com/apache/dubbo-go/pull/2425#issuecomment-1739578747 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2425) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=CODE_SMELL) [52 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2425&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2425) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2425&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2425&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] kimmking commented on issue #13095: dubbo cannot transfer Integer value to String value int the PojoUtils by gerneric
kimmking commented on issue #13095: URL: https://github.com/apache/dubbo/issues/13095#issuecomment-1739480495 can you make a test case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] sonarcloud[bot] commented on pull request #2435: feat: Triple protocol unique metadata
sonarcloud[bot] commented on PR #2435: URL: https://github.com/apache/dubbo-go/pull/2435#issuecomment-1739466298 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2435) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2435) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2435&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2435&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #13143: Move dubbo-filter module to dubbo-plugin
sonarcloud[bot] commented on PR #13143: URL: https://github.com/apache/dubbo/pull/13143#issuecomment-1738765184 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13143) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13143&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13143&resolved=false&types=BUG) [4 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13143&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13143&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13143&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13143&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13143&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13143&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13143&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13143&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13143&resolved=false&types=CODE_SMELL) [46 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13143&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13143&metric=new_coverage&view=list) [51.3% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13143&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13143&metric=new_duplicated_lines_density&view=list) [14.8% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13143&metric=new_duplicated_lines_density&view=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] CrazyHZM opened a new pull request, #13143: Move dubbo-filter module to dubbo-plugin
CrazyHZM opened a new pull request, #13143: URL: https://github.com/apache/dubbo/pull/13143 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #2436: fix: config random port
codecov-commenter commented on PR #2436: URL: https://github.com/apache/dubbo-go/pull/2436#issuecomment-1738626739 ## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/2436?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#2436](https://app.codecov.io/gh/apache/dubbo-go/pull/2436?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (77a95b0) into [main](https://app.codecov.io/gh/apache/dubbo-go/commit/5ac057d3ca6c3c0ea1fa355c6dcdf64a0813c6b9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5ac057d) will **decrease** coverage by `0.09%`. > The diff coverage is `0.00%`. > :exclamation: Current head 77a95b0 differs from pull request most recent head ea3d664. Consider uploading reports for the commit ea3d664 to get more accurate results ```diff @@Coverage Diff @@ ## main#2436 +/- ## == - Coverage 45.18% 45.09% -0.09% == Files 269 269 Lines 1822018167 -53 == - Hits 8233 8193 -40 + Misses 9110 9102 -8 + Partials 877 872 -5 ``` | [Files](https://app.codecov.io/gh/apache/dubbo-go/pull/2436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [config/service\_config.go](https://app.codecov.io/gh/apache/dubbo-go/pull/2436?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `50.62% <0.00%> (ø)` | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/apache/dubbo-go/pull/2436/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] zlshi commented on issue #13121: Dubbo3.2.0版本，ServiceConfig export到多Nacos注册中心后unexport不能取消所有Nacos上的注册
zlshi commented on issue #13121: URL: https://github.com/apache/dubbo/issues/13121#issuecomment-1738554284 了解，谢谢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] SpringStudent closed issue #13142: 使用triple协议，提供方provider方法重载，consumer方消费报错，provider方空指针
SpringStudent closed issue #13142: 使用triple协议，提供方provider方法重载，consumer方消费报错，provider方空指针 URL: https://github.com/apache/dubbo/issues/13142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] SpringStudent commented on issue #13142: 使用triple协议，提供方provider方法重载，consumer方消费报错，provider方空指针
SpringStudent commented on issue #13142: URL: https://github.com/apache/dubbo/issues/13142#issuecomment-1738389553  是否 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] SpringStudent opened a new issue, #13142: triple协议实现provider方法重载，consumer方消费报错，provider方空指针
SpringStudent opened a new issue, #13142: URL: https://github.com/apache/dubbo/issues/13142 ### Environment * Dubbo version: 3.2 * Operating System version: windows 10 * Java version:1.8 ### Steps to reproduce this issue 1. 在provider侧提供重载方法如下  2. 在consumer侧分别调用两个重载方法 3. provider报错NPE  ### Expected Behavior 期望能正常调用 ### Actual Behavior provider  consumer  ``` Just put your stack trace here! ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #13140: Support customize collector sync period
AlbumenJ merged PR #13140: URL: https://github.com/apache/dubbo/pull/13140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] sonarcloud[bot] commented on pull request #2436: fix config random port
sonarcloud[bot] commented on PR #2436: URL: https://github.com/apache/dubbo-go/pull/2436#issuecomment-1738364590 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2436) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2436&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2436&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2436&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2436&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2436&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2436&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2436&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2436&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2436&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2436&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2436&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2436&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2436) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2436&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2436&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] maguowei opened a new pull request, #2436: fix config random port
maguowei opened a new pull request, #2436: URL: https://github.com/apache/dubbo-go/pull/2436 refs: https://github.com/apache/dubbo-go/pull/2384 This pull request is missing a condition check, so it still cannot use random ports. @chickenlj @AlexStocks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] vio-lin commented on pull request #11965: optimize ThreadlessExecutor
vio-lin commented on PR #11965:
URL: https://github.com/apache/dubbo/pull/11965#issuecomment-1738360416
timeout 超时回调加了一个 isShutdown的判断。
我们线上也出现了 线程池被关掉的情况。 问下当时是有什么逻辑 触发了这个shutdonw 吗。
```
ExecutorService executor = future.getExecutor();
if (executor != null && !executor.isShutdown()) {
executor.execute(() -> notifyTimeout(future));
} else {
notifyTimeout(future);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] Goddywu closed issue #13044: wireshark支持解析dubbo协议
Goddywu closed issue #13044: wireshark支持解析dubbo协议 URL: https://github.com/apache/dubbo/issues/13044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #13104: Add metrics version compare
sonarcloud[bot] commented on PR #13104: URL: https://github.com/apache/dubbo/pull/13104#issuecomment-1737588761 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13104) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13104&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13104&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13104&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13104&metric=new_coverage&view=list) [33.0% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13104&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13104&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13104&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] sonarcloud[bot] commented on pull request #2435: feat: Triple protocol unique metadata
sonarcloud[bot] commented on PR #2435: URL: https://github.com/apache/dubbo-go/pull/2435#issuecomment-1737536032 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2435) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2435&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2435) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2435&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2435&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] DMwangnima opened a new pull request, #2435: feat: Triple protocol unique metadata
DMwangnima opened a new pull request, #2435: URL: https://github.com/apache/dubbo-go/pull/2435 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] xiaomiusa87 commented on issue #2428: [zookeeper][service_discovery] rootPath support customize，not just "/services"
xiaomiusa87 commented on issue #2428: URL: https://github.com/apache/dubbo-go/issues/2428#issuecomment-1737206124 > why not use different application name or group name to manage multiple clusters application name or group name is business attributes，has already been used. we are middleware developer ，plan multiple clusters by business type. may use multi zk or one zk，so need use different rootPath -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #13045: Remaining works of config-api refactor
sonarcloud[bot] commented on PR #13045: URL: https://github.com/apache/dubbo/pull/13045#issuecomment-1737089492 SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13045) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13045&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13045&resolved=false&types=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13045&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13045&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13045&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13045&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13045&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13045&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13045&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13045&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13045&resolved=false&types=CODE_SMELL) [106 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13045&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13045&metric=new_coverage&view=list) [9.2% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13045&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13045&metric=new_duplicated_lines_density&view=list) [0.6% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13045&metric=new_duplicated_lines_density&view=list)  Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #13102: Release ByteBuf when handle onData failed
codecov-commenter commented on PR #13102: URL: https://github.com/apache/dubbo/pull/13102#issuecomment-1737076825 ## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/13102?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#13102](https://app.codecov.io/gh/apache/dubbo/pull/13102?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (64b7d22) into [3.2](https://app.codecov.io/gh/apache/dubbo/commit/0d88f6283033e2389cdd4c044da0d67a6f6c6ed1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0d88f62) will **increase** coverage by `2.44%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ##3.2 #13102 +/- ## + Coverage 66.89% 69.34% +2.44% Complexity22 Files 1783 1649 -134 Lines 7202668587-3439 Branches 1027110001 -270 - Hits 4818447561 -623 + Misses1919816425-2773 + Partials 4644 4601 -43 ``` [see 165 files with indirect coverage changes](https://app.codecov.io/gh/apache/dubbo/pull/13102/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #13102: Release ByteBuf when handle onData failed
sonarcloud[bot] commented on PR #13102: URL: https://github.com/apache/dubbo/pull/13102#issuecomment-1737069531 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13102) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13102&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13102&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13102&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13102&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13102&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13102&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13102&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13102&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13102&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13102&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13102&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13102&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13102&metric=new_coverage&view=list) [46.7% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13102&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13102&metric=new_duplicated_lines_density&view=list) [42.4% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13102&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] finefuture commented on pull request #13102: Release ByteBuf when handle onData failed
finefuture commented on PR #13102: URL: https://github.com/apache/dubbo/pull/13102#issuecomment-1737002582 > If ondata is successful, is there no need to manually release it? But the current way of writing will lead to a certain release   Yes, It would handle in TriDecoder when submit success -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] wjzxc123 opened a new issue, #13141: 使用组播作为注册中心无法注册服务
wjzxc123 opened a new issue, #13141:
URL: https://github.com/apache/dubbo/issues/13141
尊敬的开发者
你好
我的服务配置如下
```yaml
dubbo:
application:
name: ${spring.application.name}
register-mode: instance
qos-port: 3
registry:
address: multicast://224.5.6.7:1234?unicast=false
protocol:
name: tri
port: 20880
consumer:
check: false
cache: false
validation: true
timeout: 3000
```
出现了官方文档说的 5-10 问题
https://cn.dubbo.apache.org/zh-cn/overview/mannual/java-sdk/faq/5/10/
版本：dubbo-spring-boot-starter:3.2.0 spring-boot:2.7.2
调用该服务报错，提示No provider available for the service x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #13139: fix https://github.com/apache/dubbo/issues/13135
sonarcloud[bot] commented on PR #13139: URL: https://github.com/apache/dubbo/pull/13139#issuecomment-1736956795 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13139) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13139&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13139&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13139&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13139&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13139&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13139&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13139&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13139&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13139&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13139&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13139&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13139&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13139&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13139&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13139&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13139&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #13139: fix https://github.com/apache/dubbo/issues/13135
sonarcloud[bot] commented on PR #13139: URL: https://github.com/apache/dubbo/pull/13139#issuecomment-1736952816 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13139) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13139&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13139&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13139&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13139&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13139&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13139&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13139&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13139&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13139&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13139&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13139&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13139&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13139&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13139&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13139&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13139&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] EarthChen closed issue #12980: Dubbo使用triple协议，同一个类中存在重载方法，onnext回调方法将会失效
EarthChen closed issue #12980: Dubbo使用triple协议，同一个类中存在重载方法，onnext回调方法将会失效 URL: https://github.com/apache/dubbo/issues/12980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] FoghostCn commented on issue #2428: [zookeeper][service_discovery] rootPath support customize，not just "/services"
FoghostCn commented on issue #2428: URL: https://github.com/apache/dubbo-go/issues/2428#issuecomment-1736932054 why not use different application name or group name to manage multiple clusters -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] FoghostCn commented on issue #2434: 加入opentelemetry后，启动异常
FoghostCn commented on issue #2434: URL: https://github.com/apache/dubbo-go/issues/2434#issuecomment-1736920345 maybe related to #2394 ,you can take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] EarthChen merged pull request #13057: fix：onnext callback method would be invalid when the provider method with triple protocol is overloaded.
EarthChen merged PR #13057: URL: https://github.com/apache/dubbo/pull/13057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] WPZC opened a new issue, #2434: 加入opentelemetry后，启动异常
WPZC opened a new issue, #2434: URL: https://github.com/apache/dubbo-go/issues/2434 ### Environment - Server: Dubbo-go, v3.1.0 - Client: Dubbo-go, v3.1.0 - Protocol: gRPC - Registry: Nacos, v2.1.0 ### Issue description 引入opentelemetry出现问题 `panic: proto: file "grpc/health/v1/health.proto" has a name conflict over grpc.health.v1.HealthCheckResponse previously from: "dubbo.apache.org/dubbo-go/v3/protocol/dubbo3/health/triple_health_v1" currently from: "google.golang.org/grpc/health/grpc_health_v1"` ### Logs Click me to check logs ``` Copy logs to here. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #13104: Add metrics version compare
sonarcloud[bot] commented on PR #13104: URL: https://github.com/apache/dubbo/pull/13104#issuecomment-1736763956 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13104) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13104&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13104&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13104&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13104&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13104&metric=new_coverage&view=list) [33.0% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13104&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13104&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13104&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #13140: Support customize collector sync period
sonarcloud[bot] commented on PR #13140: URL: https://github.com/apache/dubbo/pull/13140#issuecomment-1736722378 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13140) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13140&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13140&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13140&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13140&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13140&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13140&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13140&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13140&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13140&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13140&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13140&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13140&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13140&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13140&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13140&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13140&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #13138: delete useless parts and rewrite the code
sonarcloud[bot] commented on PR #13138: URL: https://github.com/apache/dubbo/pull/13138#issuecomment-1736656482 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13138) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13138&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13138&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13138&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13138&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13138&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13138&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13138&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13138&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13138&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13138&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13138&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13138&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13138&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13138&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13138&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13138&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #13136: Enhance spring security class check
sonarcloud[bot] commented on PR #13136: URL: https://github.com/apache/dubbo/pull/13136#issuecomment-1736656002 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13136) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13136&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13136&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13136&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13136&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13136&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13136&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13136&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13136&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13136&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13136&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13136&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13136&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13136&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13136&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13136&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13136&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ opened a new pull request, #13140: Support customize collector sync period
AlbumenJ opened a new pull request, #13140: URL: https://github.com/apache/dubbo/pull/13140 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #13137: feat: multiple支持 service discovery模式
codecov-commenter commented on PR #13137: URL: https://github.com/apache/dubbo/pull/13137#issuecomment-1736644385 ## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/13137?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#13137](https://app.codecov.io/gh/apache/dubbo/pull/13137?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f91ecfe) into [3.2](https://app.codecov.io/gh/apache/dubbo/commit/5aa99c526f2e089c86ad1a9e8f7d670463ec1fc7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5aa99c5) will **decrease** coverage by `0.06%`. > Report is 4 commits behind head on 3.2. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ##3.2 #13137 +/- ## - Coverage 69.43% 69.37% -0.06% Complexity22 Files 1649 1649 Lines 6856668595 +29 Branches 10005 +6 - Hits 4760947588 -21 - Misses1637816408 +30 - Partials 4579 4599 +20 ``` [see 57 files with indirect coverage changes](https://app.codecov.io/gh/apache/dubbo/pull/13137/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #13137: feat: multiple支持 service discovery模式
sonarcloud[bot] commented on PR #13137: URL: https://github.com/apache/dubbo/pull/13137#issuecomment-1736642063 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13137) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13137&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13137&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13137&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13137&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13137&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13137&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13137&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13137&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13137&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13137&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13137&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13137&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13137&metric=new_coverage&view=list) [30.8% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13137&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13137&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13137&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #13136: Enhance spring security class check
codecov-commenter commented on PR #13136: URL: https://github.com/apache/dubbo/pull/13136#issuecomment-1736629138 ## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/13136?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#13136](https://app.codecov.io/gh/apache/dubbo/pull/13136?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7cbf0ef) into [3.2](https://app.codecov.io/gh/apache/dubbo/commit/26174f05486cb8b5f449bd4f2debf9837d1b1f17?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (26174f0) will **increase** coverage by `2.48%`. > The diff coverage is `n/a`. > :exclamation: Current head 7cbf0ef differs from pull request most recent head c07b696. Consider uploading reports for the commit c07b696 to get more accurate results ```diff @@ Coverage Diff @@ ##3.2 #13136 +/- ## + Coverage 66.88% 69.37% +2.48% Complexity22 Files 1783 1649 -134 Lines 7202068571-3449 Branches 10270 -271 - Hits 4817447572 -602 + Misses1921016412-2798 + Partials 4636 4587 -49 ``` [see 174 files with indirect coverage changes](https://app.codecov.io/gh/apache/dubbo/pull/13136/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #13136: Enhance spring security class check
sonarcloud[bot] commented on PR #13136: URL: https://github.com/apache/dubbo/pull/13136#issuecomment-1736626437 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=13136) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13136&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13136&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13136&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13136&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13136&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13136&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13136&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13136&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=13136&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13136&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13136&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=13136&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13136&metric=coverage&view=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13136&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=13136&metric=new_duplicated_lines_density&view=list) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] andotorg commented on issue #13135: dubbo 3.2 branch source code dubbo-cluster build fail
andotorg commented on issue #13135:
URL: https://github.com/apache/dubbo/issues/13135#issuecomment-1736625975
> fix method
>
> ```java
> if (StringUtils.isBlank(serviceUniqueName)) {
> return "";
> }
> String[] arr = serviceUniqueName.split(PATH_SEPARATOR);
> ```
The measurement NPE has also been fixed, and judgment conditions have been
added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] andotorg commented on issue #13135: dubbo 3.2 branch source code dubbo-cluster build fail
andotorg commented on issue #13135: URL: https://github.com/apache/dubbo/issues/13135#issuecomment-1736625123 @AlbumenJ Can you help me see if it can be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] andotorg opened a new pull request, #13139: fix https://github.com/apache/dubbo/issues/13135
andotorg opened a new pull request, #13139: URL: https://github.com/apache/dubbo/pull/13139 ## What is the purpose of the change add openjdk support javascript unit test jar pom ## Brief changelog Fix the problem of maven build interruption due to lack of js script parsing jar package ## Verifying this change build successful！ ## Checklist - [✅] fix [GitHub_issue](https://github.com/apache/dubbo/issues/13135) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-rust] liudada114 opened a new pull request, #162: [ISSUE #161] #[serde(default)] can only be used on structs, not enum
liudada114 opened a new pull request, #162: URL: https://github.com/apache/dubbo-rust/pull/162 Fix: `#[serde(default)]` can only be used on structs #161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] liuzg-coder commented on pull request #13138: 3.3
liuzg-coder commented on PR #13138: URL: https://github.com/apache/dubbo/pull/13138#issuecomment-1736613435 delete useless parts and rewrite the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] liuzg-coder opened a new pull request, #13138: 3.3
liuzg-coder opened a new pull request, #13138: URL: https://github.com/apache/dubbo/pull/13138 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] zhengkaifor opened a new pull request, #13137: feat: multiple支持 service discovery模式
zhengkaifor opened a new pull request, #13137: URL: https://github.com/apache/dubbo/pull/13137 ## What is the purpose of the change 参见 https://github.com/apache/dubbo/issues/12975 ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] andotorg commented on issue #13135: dubbo 3.2 branch source code dubbo-cluster build fail
andotorg commented on issue #13135: URL: https://github.com/apache/dubbo/issues/13135#issuecomment-1736608000 [ERROR] ScriptStateRouterTest.testRouteHostFilter:121 » IllegalState unsupported route engine type: javascript [ERROR] ScriptStateRouterTest.testRoutePickInvokers:80 » IllegalState unsupported route engine type: javascript [ERROR] ScriptStateRouterTest.testRouteReturnAll:59 » IllegalState unsupported route engine type: javascript [ERROR] ScriptStateRouterTest.testRoute_throwException:139 » IllegalState unsupported route engine type: javascript -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] andotorg commented on issue #13135: dubbo 3.2 branch source code dubbo-cluster build fail
andotorg commented on issue #13135:
URL: https://github.com/apache/dubbo/issues/13135#issuecomment-1736592438
fix method
```java
if (StringUtils.isBlank(serviceUniqueName)) {
return "";
}
String[] arr = serviceUniqueName.split(PATH_SEPARATOR);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ closed pull request #12811: fix(sec): upgrade org.springframework.boot:spring-boot-autoconfigure to 3.0.7
AlbumenJ closed pull request #12811: fix(sec): upgrade org.springframework.boot:spring-boot-autoconfigure to 3.0.7 URL: https://github.com/apache/dubbo/pull/12811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ opened a new pull request, #13136: Enhance spring security class check
AlbumenJ opened a new pull request, #13136: URL: https://github.com/apache/dubbo/pull/13136 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] andotorg commented on issue #13135: dubbo 3.2 branch source code dubbo-cluster build fail
andotorg commented on issue #13135:
URL: https://github.com/apache/dubbo/issues/13135#issuecomment-1736588167
`public static String getInterfaceName(Invocation invocation) {
if (invocation.getServiceModel() != null &&
invocation.getServiceModel().getServiceMetadata() != null) {
return
invocation.getServiceModel().getServiceMetadata().getServiceInterfaceName();
} else {
String serviceUniqueName =
invocation.getTargetServiceUniqueName();
String interfaceAndVersion;
String[] arr = serviceUniqueName.split(PATH_SEPARATOR);
if (arr.length == 2) {
interfaceAndVersion = arr[1];
} else {
interfaceAndVersion = arr[0];
}
String[] ivArr = interfaceAndVersion.split(GROUP_CHAR_SEPARATOR);
return ivArr[0];
}
}`
Cannot invoke "String.split(String)" because "serviceUniqueName" is null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] andotorg commented on issue #13135: dubbo 3.2 branch source code dubbo-cluster build fail
andotorg commented on issue #13135: URL: https://github.com/apache/dubbo/issues/13135#issuecomment-1736585811 I'm checking it too, and I'll fix it after I find it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on a diff in pull request #13102: Release ByteBuf when handle onData failed
EarthChen commented on code in PR #13102:
URL: https://github.com/apache/dubbo/pull/13102#discussion_r1337976696
##
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/stream/TripleClientStream.java:
##
@@ -449,23 +449,25 @@ public void onHeader(Http2Headers headers, boolean
endStream) {
@Override
public void onData(ByteBuf data, boolean endStream) {
-executor.execute(() -> {
-if (transportError != null) {
-transportError.appendDescription(
-"Data:" + data.toString(StandardCharsets.UTF_8));
-ReferenceCountUtil.release(data);
-if (transportError.description.length() > 512 ||
endStream) {
-handleH2TransportError(transportError);
-}
-return;
-}
-if (!headerReceived) {
-
handleH2TransportError(TriRpcStatus.INTERNAL.withDescription(
-"headers not received before payload"));
-return;
+executor.execute(() -> doOnData(data, endStream), () ->
ReferenceCountUtil.release(data));
Review Comment:
Ok.fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on issue #13135: dubbo 3.2 branch source code dubbo-cluster build fail
AlbumenJ commented on issue #13135: URL: https://github.com/apache/dubbo/issues/13135#issuecomment-1736572409 Which case failed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] andotorg commented on issue #13135: dubbo 3.2 branch source code dubbo-cluster build fail
andotorg commented on issue #13135: URL: https://github.com/apache/dubbo/issues/13135#issuecomment-1736569544 Skipping tests is certainly possible, but is there any other way to fix it? Unit tests can be executed normally -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on issue #13135: dubbo 3.2 branch source code dubbo-cluster build fail
AlbumenJ commented on issue #13135: URL: https://github.com/apache/dubbo/issues/13135#issuecomment-1736564398 Try use `./mvnw clean install -Dmaven.test.skip=true`. Unit test cases are very very complexed and easy to fail on local env(due to network and so on). :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on issue #13106: triple+protobuf服务不支持泛化调用吗？泛化调用时报错：Cannot invoke "java.lang.reflect.Method.getParameterTypes()" because "method" is null
AlbumenJ commented on issue #13106: URL: https://github.com/apache/dubbo/issues/13106#issuecomment-1736563496 > > 使用的什么版本的 Dubbo > > 3.2.6版本的 可以测试下 3.2.7 版本（准备投票，可以用 3.2 或者 3.2.7-release 分支本地 install 先），这个问题应该是修复了的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on issue #13100: Does dubbo invoke not perform parameter verification?
AlbumenJ commented on issue #13100: URL: https://github.com/apache/dubbo/issues/13100#issuecomment-1736562864 Qos is designed to test user impl not for total. You can create a real Dubbo client to test. BTW, Dubbo is developing a native testing way using cURL on Triple protocol. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] andotorg opened a new issue, #13135: dubbo 3.2 branch source code dubbo-cluster build fail
andotorg opened a new issue, #13135: URL: https://github.com/apache/dubbo/issues/13135 ### Environment * Dubbo version: 3.2 * Operating System version: mac 10.15 * Java version: JDK8 or JDK 17 ### Steps to reproduce this issue 1. mvn clean install 2. show build error dubbo-cluster build fail ### Expected Behavior ### Actual Behavior If there is an exception, please attach the exception trace: error log ``` Please refer to /Users/lucas/github/dubbo/dubbo-cluster/target/surefire-reports for the individual test results. Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.�� ``` �� -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
