[GitHub] [dubbo] codecov-io commented on issue #4397: fix register config not take effect because of url simplified

2019-09-11 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr=h1) Report
> Merging [#4397](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr=desc) 
> into 
> [master](https://codecov.io/gh/apache/dubbo/commit/7d564e75fe776681e9e3c0a6f6bd1c4ad1ea51af?src=pr=desc)
>  will **increase** coverage by `0.01%`.
> The diff coverage is `100%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/dubbo/pull/4397/graphs/tree.svg?width=650=VnEIkiFQT0=150=pr)](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr=tree)

```diff
@@ Coverage Diff  @@
## master#4397  +/-   ##

+ Coverage 63.96%   63.97%   +0.01% 
  Complexity  452  452  

  Files   769  769  
  Lines 3320633206  
  Branches   5237 5237  

+ Hits  2123921244   +5 
+ Misses 9546 9543   -3 
+ Partials   2421 2419   -2
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr=tree) 
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
| 
[...e/dubbo/registry/integration/RegistryProtocol.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeVByb3RvY29sLmphdmE=)
 | `82.69% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| 
[...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==)
 | `55.68% <0%> (-4.55%)` | `20% <0%> (-1%)` | |
| 
[.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh)
 | `64.77% <0%> (-2.28%)` | `0% <0%> (ø)` | |
| 
[...rg/apache/dubbo/common/timer/HashedWheelTimer.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGltZXIvSGFzaGVkV2hlZWxUaW1lci5qYXZh)
 | `62.75% <0%> (+0.34%)` | `0% <0%> (ø)` | :arrow_down: |
| 
[...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==)
 | `69.68% <0%> (+0.45%)` | `0% <0%> (ø)` | :arrow_down: |
| 
[...dubbo/metadata/support/AbstractMetadataReport.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLXJlcG9ydC1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL3N1cHBvcnQvQWJzdHJhY3RNZXRhZGF0YVJlcG9ydC5qYXZh)
 | `72.83% <0%> (+1.73%)` | `0% <0%> (ø)` | :arrow_down: |
| 
[...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvcHJvdG9jb2wvcmVzdC9SZXN0UHJvdG9jb2wuamF2YQ==)
 | `71.31% <0%> (+3.1%)` | `0% <0%> (ø)` | :arrow_down: |
| 
[...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh)
 | `73.21% <0%> (+3.57%)` | `9% <0%> (+1%)` | :arrow_up: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr=continue).
> **Legend** - [Click here to learn 
> more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
> [Codecov](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr=footer). 
> Last update 
> [7d564e7...b905448](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr=lastupdated).
>  Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo/pull/4397 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] codecov-io commented on issue #4397: fix register config not take effect because of url simplified

2019-09-11 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr=h1) Report
> Merging [#4397](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr=desc) 
> into 
> [master](https://codecov.io/gh/apache/dubbo/commit/7d564e75fe776681e9e3c0a6f6bd1c4ad1ea51af?src=pr=desc)
>  will **decrease** coverage by `0.01%`.
> The diff coverage is `82.69%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/dubbo/pull/4397/graphs/tree.svg?width=650=VnEIkiFQT0=150=pr)](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr=tree)

```diff
@@ Coverage Diff  @@
## master#4397  +/-   ##

- Coverage 63.93%   63.92%   -0.02% 
  Complexity  451  451  

  Files   769  769  
  Lines 3320633206  
  Branches   5237 5237  

- Hits  2123121226   -5 
  Misses 9552 9552  
- Partials   2423 2428   +5
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr=tree) 
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
| 
[...e/dubbo/registry/integration/RegistryProtocol.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeVByb3RvY29sLmphdmE=)
 | `82.69% <82.69%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| 
[...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=)
 | `75% <0%> (-12.5%)` | `0% <0%> (ø)` | |
| 
[...bbo/registry/support/ProviderConsumerRegTable.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L1Byb3ZpZGVyQ29uc3VtZXJSZWdUYWJsZS5qYXZh)
 | `80.48% <0%> (-4.88%)` | `0% <0%> (ø)` | |
| 
[.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=)
 | `58.69% <0%> (-4.35%)` | `0% <0%> (ø)` | |
| 
[.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh)
 | `63.63% <0%> (-3.41%)` | `0% <0%> (ø)` | |
| 
[...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==)
 | `78.04% <0%> (-2.44%)` | `0% <0%> (ø)` | |
| 
[...dubbo/metadata/support/AbstractMetadataReport.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLXJlcG9ydC1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL3N1cHBvcnQvQWJzdHJhY3RNZXRhZGF0YVJlcG9ydC5qYXZh)
 | `72.83% <0%> (+1.73%)` | `0% <0%> (ø)` | :arrow_down: |
| 
[...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==)
 | `83.33% <0%> (+3.33%)` | `0% <0%> (ø)` | :arrow_down: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr=continue).
> **Legend** - [Click here to learn 
> more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
> [Codecov](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr=footer). 
> Last update 
> [7d564e7...4c9fe00](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr=lastupdated).
>  Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo/pull/4397 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org