[GitHub] [dubbo-go] codecov-io commented on issue #358: Fix:deal the panic when invoker destroy
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=h1) Report > Merging [#358](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/d0d3ac1985a2da5a9e03b662ff5c320aa4a2f1ea?src=pr=desc) > will **decrease** coverage by `0.18%`. > The diff coverage is `63.88%`. [](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=tree) ```diff @@ Coverage Diff @@ ## develop #358 +/- ## === - Coverage66.74% 66.55% -0.19% === Files 150 150 Lines 7936 7960 +24 === + Hits 5297 5298 +1 - Misses2137 2157 +20 - Partials 502 505 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=tree) | Coverage Δ | | |---|---|---| | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `82.58% <61.11%> (-0.99%)` | :arrow_down: | | [protocol/dubbo/dubbo\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9faW52b2tlci5nbw==) | `82.25% <66.66%> (-7.11%)` | :arrow_down: | | [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `35.29% <0%> (-29.42%)` | :arrow_down: | | [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: | | [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0%> (-1.71%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=footer). > Last update > [d0d3ac1...873c7d9](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo-go/pull/358 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #358: Fix:deal the panic when invoker destroy
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=h1) Report > Merging [#358](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/d0d3ac1985a2da5a9e03b662ff5c320aa4a2f1ea?src=pr=desc) > will **decrease** coverage by `0.01%`. > The diff coverage is `63.88%`. [](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=tree) ```diff @@ Coverage Diff @@ ## develop #358 +/- ## === - Coverage66.74% 66.73% -0.02% === Files 150 150 Lines 7936 7960 +24 === + Hits 5297 5312 +15 - Misses2137 2145 +8 - Partials 502 503 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=tree) | Coverage Δ | | |---|---|---| | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `82.58% <61.11%> (-0.99%)` | :arrow_down: | | [protocol/dubbo/dubbo\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9faW52b2tlci5nbw==) | `82.25% <66.66%> (-7.11%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=footer). > Last update > [d0d3ac1...167d221](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo-go/pull/358 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #358: Fix:deal the panic when invoker destroy
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=h1) Report > Merging [#358](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/d0d3ac1985a2da5a9e03b662ff5c320aa4a2f1ea?src=pr=desc) > will **decrease** coverage by `0.18%`. > The diff coverage is `65.71%`. [](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=tree) ```diff @@ Coverage Diff @@ ## develop #358 +/- ## === - Coverage66.74% 66.56% -0.19% === Files 150 150 Lines 7936 7959 +23 === + Hits 5297 5298 +1 - Misses2137 2156 +19 - Partials 502 505 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=tree) | Coverage Δ | | |---|---|---| | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `82.58% <61.11%> (-0.99%)` | :arrow_down: | | [protocol/dubbo/dubbo\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9faW52b2tlci5nbw==) | `83.6% <70.58%> (-5.76%)` | :arrow_down: | | [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `35.29% <0%> (-29.42%)` | :arrow_down: | | [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: | | [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0%> (-1.71%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=footer). > Last update > [d0d3ac1...167d221](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo-go/pull/358 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #358: Fix:deal the panic when invoker destroy
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=h1) Report > Merging [#358](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/d0d3ac1985a2da5a9e03b662ff5c320aa4a2f1ea?src=pr=desc) > will **decrease** coverage by `0.18%`. > The diff coverage is `65.71%`. [](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=tree) ```diff @@ Coverage Diff @@ ## develop #358 +/- ## === - Coverage66.74% 66.56% -0.19% === Files 150 150 Lines 7936 7959 +23 === + Hits 5297 5298 +1 - Misses2137 2156 +19 - Partials 502 505 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=tree) | Coverage Δ | | |---|---|---| | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `82.58% <61.11%> (-0.99%)` | :arrow_down: | | [protocol/dubbo/dubbo\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9faW52b2tlci5nbw==) | `83.6% <70.58%> (-5.76%)` | :arrow_down: | | [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `35.29% <0%> (-29.42%)` | :arrow_down: | | [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: | | [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0%> (-1.71%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=footer). > Last update > [d0d3ac1...0ee1cd4](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo-go/pull/358 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #358: Fix:deal the panic when invoker destroy
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=h1) Report > Merging [#358](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/d0d3ac1985a2da5a9e03b662ff5c320aa4a2f1ea?src=pr=desc) > will **decrease** coverage by `0.18%`. > The diff coverage is `65.71%`. [](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=tree) ```diff @@ Coverage Diff @@ ## develop #358 +/- ## === - Coverage66.74% 66.56% -0.19% === Files 150 150 Lines 7936 7959 +23 === + Hits 5297 5298 +1 - Misses2137 2156 +19 - Partials 502 505 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=tree) | Coverage Δ | | |---|---|---| | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `82.58% <61.11%> (-0.99%)` | :arrow_down: | | [protocol/dubbo/dubbo\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9faW52b2tlci5nbw==) | `83.6% <70.58%> (-5.76%)` | :arrow_down: | | [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `35.29% <0%> (-29.42%)` | :arrow_down: | | [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0%> (-2.16%)` | :arrow_down: | | [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0%> (-1.71%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=footer). > Last update > [d0d3ac1...7f6fd6a](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo-go/pull/358 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #358: Fix:deal the panic when invoker destroy
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=h1) Report > Merging [#358](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/d0d3ac1985a2da5a9e03b662ff5c320aa4a2f1ea?src=pr=desc) > will **decrease** coverage by `0.13%`. > The diff coverage is `70.96%`. [](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=tree) ```diff @@ Coverage Diff @@ ## develop #358 +/- ## === - Coverage66.74% 66.61% -0.14% === Files 150 150 Lines 7936 7955 +19 === + Hits 5297 5299 +2 - Misses2137 2153 +16 - Partials 502 503 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=tree) | Coverage Δ | | |---|---|---| | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `82.58% <61.11%> (-0.99%)` | :arrow_down: | | [protocol/dubbo/dubbo\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9faW52b2tlci5nbw==) | `87.71% <84.61%> (-1.65%)` | :arrow_down: | | [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `35.29% <0%> (-29.42%)` | :arrow_down: | | [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/358/diff?src=pr=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0%> (-1.71%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=footer). > Last update > [d0d3ac1...7f6fd6a](https://codecov.io/gh/apache/dubbo-go/pull/358?src=pr=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo-go/pull/358 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
