Re: [PR] feat(ospp): task 10 [dubbo-go]
Alanxtl merged PR #3662: URL: https://github.com/apache/dubbo-go/pull/3662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] feat(ospp): task 10 [dubbo-go]
Copilot commented on code in PR #3662:
URL: https://github.com/apache/dubbo-go/pull/3662#discussion_r3788383133
##
cluster/router/options.go:
##
@@ -31,6 +33,7 @@ func defaultOptions() *Options {
}
}
+// NewOptions returns router options initialized with the default router
configuration.
Review Comment:
The comment for `NewOptions` says it returns “router options”, but the
function returns an `*Options` value. Tweaking the wording makes the public API
doc clearer and less ambiguous.
##
cluster/router/chain/cache.go:
##
@@ -62,6 +63,8 @@ func (c *routerCache) GetInvokers() []base.Invoker {
// snapshot for the given Poolable. The returned invokers slice is shared and
must not be
// modified by the caller. The generation is always returned (even on a miss)
so callers can
// detect a snapshot rebuilt by a concurrent SetInvokers.
+// The lookup key is Poolable.Name. A hit returns the pool with its invoker
snapshot and
+// generation; a miss returns a nil pool, nil invokers, and the current
generation.
Review Comment:
The doc comment says the cache key is `Poolable.Name`, but the code uses
`p.Name()` (the method call). Using `Poolable.Name()` in the comment avoids
ambiguity and matches the interface contract.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] feat(ospp): task 10 [dubbo-go]
sonarqubecloud[bot] commented on PR #3662: URL: https://github.com/apache/dubbo-go/pull/3662#issuecomment-5299973133 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3662) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3662&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3662&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3662&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3662&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3662&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3662) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] feat(ospp): task 10 [dubbo-go]
codecov-commenter commented on PR #3662: URL: https://github.com/apache/dubbo-go/pull/3662#issuecomment-5294000843 ## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/3662?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 54.64%. Comparing base ([`60d1c2a`](https://app.codecov.io/gh/apache/dubbo-go/commit/60d1c2a949f0ee0da4be3fe09fb79d295491e040?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d7aada4`](https://app.codecov.io/gh/apache/dubbo-go/commit/d7aada4e0da2f3fb40df34676520da17e3ae3b65?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 923 commits behind head on develop. Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#3662 +/- ## === + Coverage46.76% 54.64% +7.87% === Files 295 474 +179 Lines1717236731 +19559 === + Hits 803120071 +12040 - Misses828715044+6757 - Partials 854 1616 +762 ``` [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/dubbo-go/pull/3662?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] feat(ospp): task 10 [dubbo-go]
Alanxtl commented on PR #3662: URL: https://github.com/apache/dubbo-go/pull/3662#issuecomment-5293983803 update to the latest develop to fix the ci fail -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] feat(ospp): task 10 [dubbo-go]
sonarqubecloud[bot] commented on PR #3662: URL: https://github.com/apache/dubbo-go/pull/3662#issuecomment-5293942100 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3662) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3662&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3662&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3662&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3662&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3662&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3662) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] feat(ospp): task 10 [dubbo-go]
SouthwestAsiaFloat opened a new pull request, #3662: URL: https://github.com/apache/dubbo-go/pull/3662 ### Description Part of #3644 Completes Task 10: Router Chain comments and unit test coverage. - Add Go doc comments for Router Chain, Router Options, and Cache. - Document the Router Chain execution order, cache key, and cache hit behavior. - Add tests for an empty router, router priority order, cache hit/invalidation, and a nil invoker list. ### Checklist - [x] I confirm the target branch is `develop` - [x] I have run `make fmt` to format my code - [x] I have run `make test` to run local tests - [x] I have added tests that prove my fix is effective or that my feature works -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
