Re: [PR] [Optimize]Added the dubbo-plugin-loom module to the pom.xml of dubbo-parent. [dubbo]

2024-11-27 Thread via GitHub


CrazyHZM closed pull request #14949: [Optimize]Added the dubbo-plugin-loom 
module to the pom.xml of dubbo-parent.
URL: https://github.com/apache/dubbo/pull/14949


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] [Optimize]Added the dubbo-plugin-loom module to the pom.xml of dubbo-parent. [dubbo]

2024-11-27 Thread via GitHub


CrazyHZM commented on code in PR #14949:
URL: https://github.com/apache/dubbo/pull/14949#discussion_r1861516060


##
pom.xml:
##
@@ -108,11 +108,13 @@
 dubbo-plugin/dubbo-rest-spring
 dubbo-plugin/dubbo-triple-servlet
 dubbo-plugin/dubbo-triple-websocket
+dubbo-plugin/dubbo-plugin-loom

Review Comment:
   loom is currently only supported in jdk21 and above and cannot be added to 
parent by default.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org



Re: [PR] [Optimize]Added the dubbo-plugin-loom module to the pom.xml of dubbo-parent. [dubbo]

2024-11-27 Thread via GitHub


wcy666103 commented on PR #14949:
URL: https://github.com/apache/dubbo/pull/14949#issuecomment-2505188794

   format code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org