Re: [PR] [PR] #15935 Improve NetUtils unit test coverage and fix IPv4 validation logic [dubbo]
zrlw closed pull request #15936: [PR] #15935 Improve NetUtils unit test coverage and fix IPv4 validation logic URL: https://github.com/apache/dubbo/pull/15936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [PR] #15935 Improve NetUtils unit test coverage and fix IPv4 validation logic [dubbo]
zrlw commented on PR #15936: URL: https://github.com/apache/dubbo/pull/15936#issuecomment-3707825213 you'd better run ```./mvnw -e --batch-mode --no-snapshot-updates --no-transfer-progress --fail-fast clean install -Psources,skip-spotless,checkstyle -Dmaven.test.skip=true``` on your local machine first to ensure your codes correctness before submitting a PR with many errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [PR] #15935 Improve NetUtils unit test coverage and fix IPv4 validation logic [dubbo]
LI123456mo commented on PR #15936: URL: https://github.com/apache/dubbo/pull/15936#issuecomment-3702876780 I tried to fix the IP validation but ran into multiple build/test conflicts. I'm stepping back from this PR for now." ### 4. My Promise to You If you decide you want to try one last "Clean Fix" later, I will give you one single block of code that is 100% guaranteed to work because it changes only your one fix and nothing else. But for now, step away. Programming is supposed to be a normal, manageable life, not a source of constant frustration. You’ve put in more work today than most people do in a week of open-source contributing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [PR] #15935 Improve NetUtils unit test coverage and fix IPv4 validation logic [dubbo]
LI123456mo commented on PR #15936: URL: https://github.com/apache/dubbo/pull/15936#issuecomment-3702750601 @RainYuY , thanks , working on it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [PR] #15935 Improve NetUtils unit test coverage and fix IPv4 validation logic [dubbo]
RainYuY commented on PR #15936: URL: https://github.com/apache/dubbo/pull/15936#issuecomment-3701269839 check the ci pls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] [PR] #15935 Improve NetUtils unit test coverage and fix IPv4 validation logic [dubbo]
codecov-commenter commented on PR #15936: URL: https://github.com/apache/dubbo/pull/15936#issuecomment-3694873982 ## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/15936?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `40.0%` with `3 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 32.08%. Comparing base ([`a3a35b5`](https://app.codecov.io/gh/apache/dubbo/commit/a3a35b5f8cb7d8bf8004f4fcc6063fbcaf945a96?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`cdaed99`](https://app.codecov.io/gh/apache/dubbo/commit/cdaed99452599bdeff45c894862d8a5d93e3c0c8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). | [Files with missing lines](https://app.codecov.io/gh/apache/dubbo/pull/15936?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...n/java/org/apache/dubbo/common/utils/NetUtils.java](https://app.codecov.io/gh/apache/dubbo/pull/15936?src=pr&el=tree&filepath=dubbo-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdubbo%2Fcommon%2Futils%2FNetUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvTmV0VXRpbHMuamF2YQ==) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo/pull/15936?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (a3a35b5) and HEAD (cdaed99). Click for more details. > > HEAD has 7 uploads less than BASE > >| Flag | BASE (a3a35b5) | HEAD (cdaed99) | >|--|--|--| >|integration-tests-java8|1|0| >|integration-tests-java21|1|0| >|unit-tests-java8|1|0| >|unit-tests-java25|1|0| >|unit-tests-java11|1|0| >|unit-tests-java17|1|0| >|unit-tests-java21|1|0| > Additional details and impacted files ```diff @@ Coverage Diff @@ ##3.3 #15936 +/- ## = - Coverage 60.74% 32.08% -28.67% + Complexity1170210122 -1580 = Files 1938 1937-1 Lines 8869488676 -18 Branches 1338713303 -84 = - Hits 5387928451-25428 - Misses2929156056+26765 + Partials 5524 4169 -1355 ``` | [Flag](https://app.codecov.io/gh/apache/dubbo/pull/15936/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [integration-tests-java21](https://app.codecov.io/gh/apache/dubbo/pull/15936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration-tests-java8](https://app.codecov.io/gh/apache/dubbo/pull/15936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [samples-tests-java21](https://app.codecov.io/gh/apache/dubbo/pull/15936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.05% <40.00%> (+0.02%)` | :arrow_up: | | [samples-tests-java8](https://app.codecov.io/gh/apache/dubbo/pull/15936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `29.69% <40.00%> (+<0.01%)` | :arrow_up: | | [unit-tests-java11](https://app.codecov.io/gh/apache/dubbo/pull/15936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unit-tests-java17](https://app.codecov.io/gh/apache/dubbo/pull/15936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unit-tests-java21](https://app.codecov.io/gh/apache/dubbo/pull/15936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unit-tests-java25](https://app.codecov.io/gh/apache/dubbo/pull/15936/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?
