Re: [PR] Fixed dubbo cni potential bugs and boundary validation [dubbo-kubernetes]
github-actions[bot] commented on PR #988: URL: https://github.com/apache/dubbo-kubernetes/pull/988#issuecomment-5202745317 Merged on behalf of @mfordjody via `/lgtm`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Fixed dubbo cni potential bugs and boundary validation [dubbo-kubernetes]
github-actions[bot] merged PR #988: URL: https://github.com/apache/dubbo-kubernetes/pull/988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Fixed dubbo cni potential bugs and boundary validation [dubbo-kubernetes]
mfordjody commented on PR #988: URL: https://github.com/apache/dubbo-kubernetes/pull/988#issuecomment-5202742951 /lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Fixed dubbo cni potential bugs and boundary validation [dubbo-kubernetes]
codecov-commenter commented on PR #988: URL: https://github.com/apache/dubbo-kubernetes/pull/988#issuecomment-5187698205 ## [Codecov](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/988?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `50.15674%` with `159 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 19.45%. Comparing base ([`6c3e8a4`](https://app.codecov.io/gh/apache/dubbo-kubernetes/commit/6c3e8a446547f204920fc7c11b7a6f2ab4e4ec61?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`875d567`](https://app.codecov.io/gh/apache/dubbo-kubernetes/commit/875d56751066368cf42283c954354ab55fa3a579?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 1 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/988?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [cni/main.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/988?src=pr&el=tree&filepath=cni%2Fmain.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y25pL21haW4uZ28=) | 0.00% | [47 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [cni/pkg/nodeagent/k8s.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/988?src=pr&el=tree&filepath=cni%2Fpkg%2Fnodeagent%2Fk8s.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y25pL3BrZy9ub2RlYWdlbnQvazhzLmdv) | 0.00% | [34 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [cni/pkg/nodeagent/iptables.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/988?src=pr&el=tree&filepath=cni%2Fpkg%2Fnodeagent%2Fiptables.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y25pL3BrZy9ub2RlYWdlbnQvaXB0YWJsZXMuZ28=) | 38.46% | [14 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [cni/pkg/nodeagent/dataplane.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/988?src=pr&el=tree&filepath=cni%2Fpkg%2Fnodeagent%2Fdataplane.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y25pL3BrZy9ub2RlYWdlbnQvZGF0YXBsYW5lLmdv) | 47.50% | [18 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [pkg/kube/inject/proxyless.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/988?src=pr&el=tree&filepath=pkg%2Fkube%2Finject%2Fproxyless.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2t1YmUvaW5qZWN0L3Byb3h5bGVzcy5nbw==) | 84.00% | [4 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [cni/pkg/nodeagent/plugin.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/988?src=pr&el=tree&filepath=cni%2Fpkg%2Fnodeagent%2Fplugin.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y25pL3BrZy9ub2RlYWdlbnQvcGx1Z2luLmdv) | 80.55% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [cni/pkg/nodeagent/state.go](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/988?src=pr&el=tree&filepath=cni%2Fpkg%2Fnodeagent%2Fstate.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y25pL3BrZy9ub2RlYWdlbnQvc3RhdGUuZ28=) | 65.00% | [4 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/988?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
Re: [PR] Fixed dubbo cni potential bugs and boundary validation [dubbo-kubernetes]
github-actions[bot] commented on PR #988: URL: https://github.com/apache/dubbo-kubernetes/pull/988#issuecomment-5187604331 `/lgtm` recorded by @mfordjody. GitHub Auto-merge will squash merge the PR after required CI passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Fixed dubbo cni potential bugs and boundary validation [dubbo-kubernetes]
mfordjody commented on PR #988: URL: https://github.com/apache/dubbo-kubernetes/pull/988#issuecomment-5187602361 /lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
