Re: [PR] docs(metrics): document RPC error classifier categories [dubbo-go]
Alanxtl merged PR #3603: URL: https://github.com/apache/dubbo-go/pull/3603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs(metrics): document RPC error classifier categories [dubbo-go]
Aias00 commented on PR #3603: URL: https://github.com/apache/dubbo-go/pull/3603#issuecomment-5204109138 > Codec errors are not surfaced through a single status code at the protocol layer — they are spread across three different codes: > > Codec failure Actual code > marshal / compress / recycle compressor`CodeInternal` > unmarshal / decompress / invalid encoding `CodeInvalidArgument` > envelope read/write I/O / get compressor `CodeUnknown` should this be handled or later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs(metrics): document RPC error classifier categories [dubbo-go]
Aias00 commented on PR #3603: URL: https://github.com/apache/dubbo-go/pull/3603#issuecomment-5204105312 Codec errors are not surfaced through a single status code at the protocol layer — they are spread across three different codes: | Codec failure | Actual code | | --- | --- | | marshal / compress / recycle compressor | `CodeInternal` | | unmarshal / decompress / invalid encoding | `CodeInvalidArgument` | | envelope read/write I/O / get compressor | `CodeUnknown` | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs(metrics): document RPC error classifier categories [dubbo-go]
codecov-commenter commented on PR #3603: URL: https://github.com/apache/dubbo-go/pull/3603#issuecomment-5204106173 ## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/3603?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 53.86%. Comparing base ([`48d6e69`](https://app.codecov.io/gh/apache/dubbo-go/commit/48d6e696e755d46df2425bbf71c413bbd1887f3f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bb686e9`](https://app.codecov.io/gh/apache/dubbo-go/commit/bb686e98e2076a943726ed7d92528183544657b7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 8 commits behind head on develop. Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#3603 +/- ## === - Coverage54.57% 53.86% -0.72% === Files 460 474 +14 Lines3544336388 +945 === + Hits 1934419601 +257 - Misses 1454315211 +668 - Partials 1556 1576 +20 ``` [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/dubbo-go/pull/3603?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] docs(metrics): document RPC error classifier categories [dubbo-go]
sonarqubecloud[bot] commented on PR #3603: URL: https://github.com/apache/dubbo-go/pull/3603#issuecomment-5204078192 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3603) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3603&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3603&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3603&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3603&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3603&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3603) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
