Re: [PR] refactor(hessian2): use generic exception from hessian2 [dubbo-go]
wyf027 closed pull request #3378: refactor(hessian2): use generic exception from hessian2 URL: https://github.com/apache/dubbo-go/pull/3378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] refactor(hessian2): use generic exception from hessian2 [dubbo-go]
sonarqubecloud[bot] commented on PR #3378: URL: https://github.com/apache/dubbo-go/pull/3378#issuecomment-4776862146 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3378) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3378&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3378&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3378&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3378&metric=new_coverage&view=list)  [0.8% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3378&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3378) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] refactor(hessian2): use generic exception from hessian2 [dubbo-go]
leno23 commented on PR #3378: URL: https://github.com/apache/dubbo-go/pull/3378#issuecomment-4701575432 Thanks, I agree with the direction. I checked the current dependency versions: `github.com/apache/dubbo-go-hessian2 v1.13.1` still has `NewDubboGenericException` only populate `ExceptionClass` / `ExceptionMessage`, so removing `newGenericException` here now would make `Error()` return an empty `DetailMessage` and break the behavior covered by these tests. The constructor-side fix is still in apache/dubbo-go-hessian2#396 and is not available from an upstream module version yet. Once that hessian2 PR is merged and available to dubbo-go, I can update the dependency here and replace `newGenericException` with the constructor directly to avoid maintaining the formatting in both places. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] refactor(hessian2): use generic exception from hessian2 [dubbo-go]
xxs588 commented on PR #3378: URL: https://github.com/apache/dubbo-go/pull/3378#issuecomment-4700997718 1. DetailMessage 的格式化逻辑在 #396 构造器和这个 PR 的 newGenericException 里都写了一遍如果构造器那边已经负责设置 DetailMessage 的话，这边可以直接用构造器，避免两边维护同一套逻辑？ 2. Copilot 提到的测试 case（wantDetailString 为空导致断言 Error() == ""）这个是否需要补回来捏？ 以上仅供参考 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] refactor(hessian2): use generic exception from hessian2 [dubbo-go]
Alanxtl commented on PR #3378: URL: https://github.com/apache/dubbo-go/pull/3378#issuecomment-4698556094 @Snow-kal @xxs588 help review this and https://github.com/apache/dubbo-go-hessian2/pull/396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] refactor(hessian2): use generic exception from hessian2 [dubbo-go]
sonarqubecloud[bot] commented on PR #3378: URL: https://github.com/apache/dubbo-go/pull/3378#issuecomment-4665648749 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3378) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3378&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3378&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3378&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3378&metric=new_coverage&view=list)  [0.8% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3378&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3378) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] refactor(hessian2): use generic exception from hessian2 [dubbo-go]
Copilot commented on code in PR #3378:
URL: https://github.com/apache/dubbo-go/pull/3378#discussion_r3384842329
##
protocol/dubbo/hessian2/hessian_response_test.go:
##
@@ -205,6 +208,180 @@ func TestIsSupportResponseAttachmentConcurrent(t
*testing.T) {
wg.Wait()
}
+func TestToGenericExceptionUsesHessianExceptionType(t *testing.T) {
+ exception, ok :=
ToGenericException(java_exception.DubboGenericException{
+ ExceptionClass: "com.example.UserNotFoundException",
+ ExceptionMessage: "user not found",
+ })
+
+ require.True(t, ok)
+ require.IsType(t, &java_exception.DubboGenericException{}, exception)
+ assert.Equal(t, "com.example.UserNotFoundException",
exception.ExceptionClass)
+ assert.Equal(t, "user not found", exception.ExceptionMessage)
+}
+
+func TestToGenericExceptionConversions(t *testing.T) {
+ pointerException :=
java_exception.NewDubboGenericException("com.example.PointerException",
"pointer message")
+
+ tests := []struct {
+ name string
+ inputany
+ wantOK bool
+ wantClassstring
+ wantMessage string
+ wantDetailString string
+ }{
+ {
+ name:"generic exception pointer",
+ input: pointerException,
+ wantOK: true,
+ wantClass: "com.example.PointerException",
+ wantMessage: "pointer message",
+ },
+ {
+ name: "throwable",
+ input:
java_exception.NewThrowable("throwable message"),
+ wantOK: true,
+ wantClass:"java.lang.Throwable",
+ wantMessage: "throwable message",
+ wantDetailString: "java exception: java.lang.Throwable
- throwable message",
+ },
+ {
+ name: "legacy exception string",
+ input:"java exception: user not found",
+ wantOK: true,
+ wantClass:"java.lang.Exception",
+ wantMessage: "user not found",
+ wantDetailString: "java exception: java.lang.Exception
- user not found",
+ },
+ {
+ name: "plain string",
+ input:"plain failure",
+ wantOK: true,
+ wantClass:"java.lang.Exception",
+ wantMessage: "plain failure",
+ wantDetailString: "java exception: java.lang.Exception
- plain failure",
+ },
+ {
+ name: "unsupported type",
+ input: 42,
+ wantOK: false,
+ },
+ }
+
+ for _, test := range tests {
+ t.Run(test.name, func(t *testing.T) {
+ exception, ok := ToGenericException(test.input)
+ assert.Equal(t, test.wantOK, ok)
+ if !test.wantOK {
+ assert.Nil(t, exception)
+ return
+ }
+
+ require.NotNil(t, exception)
+ assert.Equal(t, test.wantClass,
exception.ExceptionClass)
+ assert.Equal(t, test.wantMessage,
exception.ExceptionMessage)
+ assert.Equal(t, test.wantDetailString,
exception.Error())
+ })
Review Comment:
In TestToGenericExceptionConversions, the "generic exception pointer" case
leaves wantDetailString unset, but the loop unconditionally asserts
exception.Error() equals wantDetailString. This makes the test assert Error()
== "" for that case, which is very likely unintended and can cause a failing
test or a meaningless assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] refactor(hessian2): use generic exception from hessian2 [dubbo-go]
leno23 commented on PR #3378: URL: https://github.com/apache/dubbo-go/pull/3378#issuecomment-4656269600 Follow-up on the hessian2-side direction from the review: I opened apache/dubbo-go-hessian2#396 to complete the library-side change. It makes `java_exception.DubboGenericException` populate and expose a stable detail message from `ExceptionClass` / `ExceptionMessage`, while preserving decoded Java `DetailMessage` behavior. With that hessian2 PR in place, this dubbo-go PR can stay focused on removing the local GenericException definition and using the hessian2 type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] refactor(hessian2): use generic exception from hessian2 [dubbo-go]
sonarqubecloud[bot] commented on PR #3378: URL: https://github.com/apache/dubbo-go/pull/3378#issuecomment-4655976167 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3378) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3378&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3378&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3378&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3378&metric=new_coverage&view=list)  [0.8% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3378&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3378) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] refactor(hessian2): use generic exception from hessian2 [dubbo-go]
leno23 commented on PR #3378: URL: https://github.com/apache/dubbo-go/pull/3378#issuecomment-4655969268 Follow-up for the remaining Codecov patch coverage warning: added packResponse coverage for the value DubboGenericException and Throwabler branches. Local validation still passes: go test ./protocol/dubbo/hessian2 ./protocol/dubbo/impl, go test -cover ./protocol/dubbo/hessian2 ./protocol/dubbo/impl, git diff --check, and the local audit script. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] refactor(hessian2): use generic exception from hessian2 [dubbo-go]
sonarqubecloud[bot] commented on PR #3378: URL: https://github.com/apache/dubbo-go/pull/3378#issuecomment-4655941317 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3378) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3378&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3378&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3378&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3378&metric=new_coverage&view=list)  [1.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3378&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3378) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] refactor(hessian2): use generic exception from hessian2 [dubbo-go]
leno23 commented on PR #3378: URL: https://github.com/apache/dubbo-go/pull/3378#issuecomment-4655935926 Added focused tests for the Codecov patch coverage feedback. The new coverage exercises ToGenericException conversions, GenericException DetailMessage formatting, and the pointer DubboGenericException encode paths in both hessian2 packResponse and impl marshalResponse. Local validation: go test ./protocol/dubbo/hessian2 ./protocol/dubbo/impl, go test -cover ./protocol/dubbo/hessian2 ./protocol/dubbo/impl, git diff --check, and the local audit script all pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] refactor(hessian2): use generic exception from hessian2 [dubbo-go]
codecov-commenter commented on PR #3378: URL: https://github.com/apache/dubbo-go/pull/3378#issuecomment-4655827911 ## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/3378?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `43.47826%` with `13 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 52.53%. Comparing base ([`60d1c2a`](https://app.codecov.io/gh/apache/dubbo-go/commit/60d1c2a949f0ee0da4be3fe09fb79d295491e040?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2f19e80`](https://app.codecov.io/gh/apache/dubbo-go/commit/2f19e801a7e861f0b8f0555b07a9f84a2c14d7f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 821 commits behind head on develop. | [Files with missing lines](https://app.codecov.io/gh/apache/dubbo-go/pull/3378?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [protocol/dubbo/hessian2/hessian\_response.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3378?src=pr&el=tree&filepath=protocol%2Fdubbo%2Fhessian2%2Fhessian_response.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJvdG9jb2wvZHViYm8vaGVzc2lhbjIvaGVzc2lhbl9yZXNwb25zZS5nbw==) | 42.10% | [8 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [protocol/dubbo/impl/hessian.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3378?src=pr&el=tree&filepath=protocol%2Fdubbo%2Fimpl%2Fhessian.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#3378 +/- ## === + Coverage46.76% 52.53% +5.76% === Files 295 492 +197 Lines1717237872 +20700 === + Hits 803119897 +11866 - Misses828716369+8082 - Partials 854 1606 +752 ``` [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/dubbo-go/pull/3378?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] refactor(hessian2): use generic exception from hessian2 [dubbo-go]
leno23 commented on PR #3378: URL: https://github.com/apache/dubbo-go/pull/3378#issuecomment-4655777024 Updated this PR to target develop and rebased the branch on upstream/develop. The local validation still passes: go test ./protocol/dubbo/hessian2 ./protocol/dubbo/impl and git diff --check. The previous failed CI job failed during Codecov CLI signature verification (gpg: Can't check signature: No public key), after Go tests had completed, so there was no code/test failure in that run. Regarding the hessian2 direction: this PR removes the local dubbo-go GenericException definition and uses dubbo-go-hessian2's java_exception.DubboGenericException directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] refactor(hessian2): use generic exception from hessian2 [dubbo-go]
sonarqubecloud[bot] commented on PR #3378: URL: https://github.com/apache/dubbo-go/pull/3378#issuecomment-4655763515 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3378) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3378&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3378&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3378&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3378&metric=new_coverage&view=list)  [4.7% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3378&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3378) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] refactor(hessian2): use generic exception from hessian2 [dubbo-go]
Alanxtl commented on PR #3378: URL: https://github.com/apache/dubbo-go/pull/3378#issuecomment-4655425552 please update **all of your prs**, your base branch should be develop and your target branch should be develop -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] refactor(hessian2): use generic exception from hessian2 [dubbo-go]
Alanxtl commented on PR #3378: URL: https://github.com/apache/dubbo-go/pull/3378#issuecomment-4648507807 you should contribute to https://github.com/apache/dubbo-go-hessian2 , the purpose of this issue is to move these definations to dubbo-go-hessian2 instead of define these definations in dubbo-go -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] refactor(hessian2): use generic exception from hessian2 [dubbo-go]
sonarqubecloud[bot] commented on PR #3378: URL: https://github.com/apache/dubbo-go/pull/3378#issuecomment-4647441803 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3378) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3378&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3378&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3378&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3378&metric=new_coverage&view=list)  [4.7% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3378&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3378) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
