[GitHub] kpm1985 commented on issue #941: WIP: Fix for FLUO-938

2017-10-18 Thread GitBox
kpm1985 commented on issue #941: WIP: Fix for FLUO-938 URL: https://github.com/apache/fluo/pull/941#issuecomment-337762153 @keith-turner thank you, I made a few changes to the constructor On Oct 18, 2017 1:58 PM, "Keith Turner" wrote: > @kpm1985

[GitHub] asfgit closed issue #938: Make transaction info cache size configurable.

2017-10-18 Thread GitBox
asfgit closed issue #938: Make transaction info cache size configurable. URL: https://github.com/apache/fluo/issues/938 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] keith-turner closed pull request #941: WIP: Fix for FLUO-938

2017-10-18 Thread GitBox
keith-turner closed pull request #941: WIP: Fix for FLUO-938 URL: https://github.com/apache/fluo/pull/941 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] kpm1985 commented on issue #939: Make TransactorCache size configurable

2017-10-18 Thread GitBox
kpm1985 commented on issue #939: Make TransactorCache size configurable URL: https://github.com/apache/fluo/issues/939#issuecomment-337768966 Would you like me to take this or work on something else @keith-turner ? I don't want to be a hog, and there was a person on the mailing list

[GitHub] keith-turner commented on issue #939: Make TransactorCache size configurable

2017-10-18 Thread GitBox
keith-turner commented on issue #939: Make TransactorCache size configurable URL: https://github.com/apache/fluo/issues/939#issuecomment-337768884 The commit 650f044b7db16e732cfbf32f484f05ec34837df8 for #938 can be used as a template for this issue.

[GitHub] kpm1985 opened a new pull request #943: FLUO-942 The constructor for VisibilityCache now uses the values from?

2017-10-19 Thread GitBox
kpm1985 opened a new pull request #943: FLUO-942 The constructor for VisibilityCache now uses the values from? URL: https://github.com/apache/fluo/pull/943 ? FluoConfigurationImpl. Also, an instantiation test has been included in the event that properties are invalidated in the future.

[GitHub] kpm1985 opened a new issue #944: Refactor Bytes - Remove duplicate call to expensive function whos ret val is ignored

2017-10-19 Thread GitBox
kpm1985 opened a new issue #944: Refactor Bytes - Remove duplicate call to expensive function whos ret val is ignored URL: https://github.com/apache/fluo/issues/944 '''java private int compareToUnchecked(byte[] bytes, int offset, int len) { if (this.length == this.data.length &&

[GitHub] kpm1985 opened a new pull request #945: Remove redundant call whos value is not used anyways

2017-10-19 Thread GitBox
kpm1985 opened a new pull request #945: Remove redundant call whos value is not used anyways URL: https://github.com/apache/fluo/pull/945 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] kpm1985 commented on issue #942: VisibilityCache constructor is out of date

2017-10-19 Thread GitBox
kpm1985 commented on issue #942: VisibilityCache constructor is out of date URL: https://github.com/apache/fluo/issues/942#issuecomment-337826720 While I notice I did not earse TxInfoCache.CACHE_TIMEOUT_MIN, it is still cleaner to use the values from FluoConfigurationImpl and the following

[GitHub] kpm1985 opened a new issue #942: VisibilityCache constructor is out of date

2017-10-19 Thread GitBox
kpm1985 opened a new issue #942: VisibilityCache constructor is out of date URL: https://github.com/apache/fluo/issues/942 ``` private final Cache visCache; VisibilityCache() { visCache =

[GitHub] keith-turner commented on a change in pull request #941: WIP: Fix for FLUO-938

2017-10-18 Thread GitBox
keith-turner commented on a change in pull request #941: WIP: Fix for FLUO-938 URL: https://github.com/apache/fluo/pull/941#discussion_r145514539 ## File path: modules/core/src/main/java/org/apache/fluo/core/impl/FluoConfigurationImpl.java ## @@ -102,6 +104,51 @@ public

[GitHub] keith-turner commented on a change in pull request #941: WIP: Fix for FLUO-938

2017-10-18 Thread GitBox
keith-turner commented on a change in pull request #941: WIP: Fix for FLUO-938 URL: https://github.com/apache/fluo/pull/941#discussion_r145514924 ## File path: modules/core/src/main/java/org/apache/fluo/core/impl/FluoConfigurationImpl.java ## @@ -102,6 +104,51 @@ public

[GitHub] keith-turner commented on a change in pull request #941: WIP: Fix for FLUO-938

2017-10-18 Thread GitBox
keith-turner commented on a change in pull request #941: WIP: Fix for FLUO-938 URL: https://github.com/apache/fluo/pull/941#discussion_r145515154 ## File path: modules/core/src/main/java/org/apache/fluo/core/impl/FluoConfigurationImpl.java ## @@ -102,6 +104,51 @@ public

[GitHub] keith-turner commented on a change in pull request #941: WIP: Fix for FLUO-938

2017-10-18 Thread GitBox
keith-turner commented on a change in pull request #941: WIP: Fix for FLUO-938 URL: https://github.com/apache/fluo/pull/941#discussion_r145514670 ## File path: modules/core/src/main/java/org/apache/fluo/core/impl/FluoConfigurationImpl.java ## @@ -102,6 +104,51 @@ public

[GitHub] keith-turner commented on a change in pull request #941: WIP: Fix for FLUO-938

2017-10-18 Thread GitBox
keith-turner commented on a change in pull request #941: WIP: Fix for FLUO-938 URL: https://github.com/apache/fluo/pull/941#discussion_r145514042 ## File path: modules/core/src/main/java/org/apache/fluo/core/impl/FluoConfigurationImpl.java ## @@ -102,6 +104,51 @@ public

[GitHub] kpm1985 commented on issue #941: WIP: Fix for FLUO-938

2017-10-18 Thread GitBox
kpm1985 commented on issue #941: WIP: Fix for FLUO-938 URL: https://github.com/apache/fluo/pull/941#issuecomment-337706073 I changed the data type for the default property to simply be a long instead of an int. Same functionality, no more boxing or casting and can use conf.getLong().

[GitHub] keith-turner commented on a change in pull request #941: WIP: Fix for FLUO-938

2017-10-18 Thread GitBox
keith-turner commented on a change in pull request #941: WIP: Fix for FLUO-938 URL: https://github.com/apache/fluo/pull/941#discussion_r145524430 ## File path: modules/core/src/main/java/org/apache/fluo/core/impl/FluoConfigurationImpl.java ## @@ -102,6 +104,46 @@ public

[GitHub] keith-turner commented on a change in pull request #941: WIP: Fix for FLUO-938

2017-10-18 Thread GitBox
keith-turner commented on a change in pull request #941: WIP: Fix for FLUO-938 URL: https://github.com/apache/fluo/pull/941#discussion_r145524525 ## File path: modules/core/src/main/java/org/apache/fluo/core/impl/FluoConfigurationImpl.java ## @@ -102,6 +104,46 @@ public

[GitHub] keith-turner commented on a change in pull request #941: WIP: Fix for FLUO-938

2017-10-18 Thread GitBox
keith-turner commented on a change in pull request #941: WIP: Fix for FLUO-938 URL: https://github.com/apache/fluo/pull/941#discussion_r145524292 ## File path: modules/core/src/main/java/org/apache/fluo/core/impl/FluoConfigurationImpl.java ## @@ -102,6 +104,46 @@ public

[GitHub] ctubbsii opened a new pull request #955: Update plugin versions in parent POM

2017-10-23 Thread GitBox
ctubbsii opened a new pull request #955: Update plugin versions in parent POM URL: https://github.com/apache/fluo/pull/955 Update plugin versions, especially the formatter (to fix bug in javadoc formatting). This is an

[GitHub] jkosh44 commented on issue #946: Create a column buffer class for GarbageCollectionIterator

2017-10-23 Thread GitBox
jkosh44 commented on issue #946: Create a column buffer class for GarbageCollectionIterator URL: https://github.com/apache/fluo/issues/946#issuecomment-338845840 Hey @keith-turner, I just want to make sure I understand the GarbageCollectionIterator class correctly. Is the idea to replace

[GitHub] kpm1985 commented on issue #951: FLUO-950 Make VisibilityCache customizable

2017-10-23 Thread GitBox
kpm1985 commented on issue #951: FLUO-950 Make VisibilityCache customizable URL: https://github.com/apache/fluo/pull/951#issuecomment-338787690 @keith-turner Nice catch! This is an automated message from the Apache Git

[GitHub] keith-turner opened a new issue #954: Support passing java options via enviroment variable

2017-10-23 Thread GitBox
keith-turner opened a new issue #954: Support passing java options via enviroment variable URL: https://github.com/apache/fluo/issues/954 In order to support apache/fluo-docker#2 it would be nice if the fluo scripts supported passing java options via environment variables.

[GitHub] kpm1985 commented on issue #901: Reformat properties

2017-10-23 Thread GitBox
kpm1985 commented on issue #901: Reformat properties URL: https://github.com/apache/fluo/issues/901#issuecomment-338810176 It is a lot easier to read with spaces. This is an automated message from the Apache Git Service. To

[GitHub] kpm1985 commented on issue #951: FLUO-950 Make VisibilityCache customizable

2017-10-23 Thread GitBox
kpm1985 commented on issue #951: FLUO-950 Make VisibilityCache customizable URL: https://github.com/apache/fluo/pull/951#issuecomment-338854113 @keith-turner Let me know if this looks ok to you when you have time, and I'll start on FLUO-939 next.

[GitHub] kpm1985 commented on issue #951: FLUO-950 Make VisibilityCache customizable

2017-10-23 Thread GitBox
kpm1985 commented on issue #951: FLUO-950 Make VisibilityCache customizable URL: https://github.com/apache/fluo/pull/951#issuecomment-338854113 @keith-turner Let me know if this looks ok to you, and I'll start on FLUO-939 next.

[GitHub] jkosh44 commented on issue #946: Create a column buffer class for GarbageCollectionIterator

2017-10-22 Thread GitBox
jkosh44 commented on issue #946: Create a column buffer class for GarbageCollectionIterator URL: https://github.com/apache/fluo/issues/946#issuecomment-338527932 Hey @keith-turner I pushed some code and added comments about things I wasn't sure about. Can you take a look at it and let me

[GitHub] kpm1985 commented on issue #951: FLUO-950 Make VisibilityCache customizable

2017-10-22 Thread GitBox
kpm1985 commented on issue #951: FLUO-950 Make VisibilityCache customizable URL: https://github.com/apache/fluo/pull/951#issuecomment-338538784 @keith-turner I've pushed some changes. Build fails but I looked it seems unrelated (timeout stuff again). On Oct 22, 2017 6:58 PM,

[GitHub] ctubbsii opened a new pull request #5: [WIP] DO NOT MERGE - Initial implementation

2017-10-18 Thread GitBox
ctubbsii opened a new pull request #5: [WIP] DO NOT MERGE - Initial implementation URL: https://github.com/apache/fluo-bytes/pull/5 This is a work in progress. It is not quite ready to merge. I want to make it available for review/feedback before I make any more progress, to make sure

[GitHub] kpm1985 commented on issue #941: WIP: Fix for FLUO-938

2017-10-18 Thread GitBox
kpm1985 commented on issue #941: WIP: Fix for FLUO-938 URL: https://github.com/apache/fluo/pull/941#issuecomment-337745507 @keith-turner Thank you, I've modified the constructor to take the new methods This is an automated

[GitHub] kpm1985 commented on issue #941: WIP: Fix for FLUO-938

2017-10-18 Thread GitBox
kpm1985 commented on issue #941: WIP: Fix for FLUO-938 URL: https://github.com/apache/fluo/pull/941#issuecomment-337722536 @keith-turner I get what the intent was. Hopefully QED On Oct 18, 2017 12:59 PM, "Keith Turner" wrote: > *@keith-turner*

[GitHub] keith-turner commented on issue #941: WIP: Fix for FLUO-938

2017-10-18 Thread GitBox
keith-turner commented on issue #941: WIP: Fix for FLUO-938 URL: https://github.com/apache/fluo/pull/941#issuecomment-337725888 @kpm1985 these changes look great. After make the cache code call these new config methods, this will be ready to merge.

[GitHub] kpm1985 commented on issue #943: FLUO-942 The constructor for VisibilityCache now uses the values from?

2017-10-19 Thread GitBox
kpm1985 commented on issue #943: FLUO-942 The constructor for VisibilityCache now uses the values from? URL: https://github.com/apache/fluo/pull/943#issuecomment-337990736 @keith-turner I have fixed my git config --global user.name and user.email. Thank you very much for the heads up.

[GitHub] keith-turner commented on a change in pull request #5: [WIP] DO NOT MERGE - Initial implementation

2017-10-19 Thread GitBox
keith-turner commented on a change in pull request #5: [WIP] DO NOT MERGE - Initial implementation URL: https://github.com/apache/fluo-bytes/pull/5#discussion_r145786386 ## File path: src/main/java/org/apache/bytes/Bytes.java ## @@ -0,0 +1,452 @@ +/* + * Licensed to the

[GitHub] ctubbsii commented on a change in pull request #5: [WIP] DO NOT MERGE - Initial implementation

2017-10-19 Thread GitBox
ctubbsii commented on a change in pull request #5: [WIP] DO NOT MERGE - Initial implementation URL: https://github.com/apache/fluo-bytes/pull/5#discussion_r145805466 ## File path: src/main/java/org/apache/bytes/Bytes.java ## @@ -0,0 +1,452 @@ +/* + * Licensed to the

[GitHub] kpm1985 commented on issue #943: FLUO-942 The constructor for VisibilityCache now uses the values from?

2017-10-19 Thread GitBox
kpm1985 commented on issue #943: FLUO-942 The constructor for VisibilityCache now uses the values from? URL: https://github.com/apache/fluo/pull/943#issuecomment-337990736 @keith-turner I have fixed my git config --global user.name and user.email. Thank you very much for the heads up.

[GitHub] keith-turner commented on issue #946: Create a column buffer class for GarbageCollectionIterator

2017-10-22 Thread GitBox
keith-turner commented on issue #946: Create a column buffer class for GarbageCollectionIterator URL: https://github.com/apache/fluo/issues/946#issuecomment-338485826 @jkosh44 same folder is good. This is an automated

[GitHub] jkosh44 opened a new pull request #952: [WIP] Issue 946

2017-10-22 Thread GitBox
jkosh44 opened a new pull request #952: [WIP] Issue 946 URL: https://github.com/apache/fluo/pull/952 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] keith-turner commented on issue #939: Make TransactorCache size configurable

2017-10-22 Thread GitBox
keith-turner commented on issue #939: Make TransactorCache size configurable URL: https://github.com/apache/fluo/issues/939#issuecomment-338484445 ok thanks @kpm1985 This is an automated message from the Apache Git Service.

[GitHub] keith-turner commented on a change in pull request #953: fixes #917 Added read locks

2017-10-23 Thread GitBox
keith-turner commented on a change in pull request #953: fixes #917 Added read locks URL: https://github.com/apache/fluo/pull/953#discussion_r146361167 ## File path: modules/integration/src/test/resources/log4j.properties ## @@ -36,3 +36,5 @@

[GitHub] mikewalch commented on a change in pull request #953: fixes #917 Added read locks

2017-10-23 Thread GitBox
mikewalch commented on a change in pull request #953: fixes #917 Added read locks URL: https://github.com/apache/fluo/pull/953#discussion_r146357935 ## File path: modules/integration/src/test/resources/log4j.properties ## @@ -36,3 +36,5 @@

[GitHub] keith-turner commented on a change in pull request #951: FLUO-950 Make VisibilityCache customizable

2017-10-23 Thread GitBox
keith-turner commented on a change in pull request #951: FLUO-950 Make VisibilityCache customizable URL: https://github.com/apache/fluo/pull/951#discussion_r146360582 ## File path: modules/core/src/main/java/org/apache/fluo/core/impl/VisibilityCache.java ## @@ -46,11

[GitHub] keith-turner commented on issue #971: IT's error out when calling mvn verify

2017-11-27 Thread GitBox
keith-turner commented on issue #971: IT's error out when calling mvn verify URL: https://github.com/apache/fluo/issues/971#issuecomment-347248752 > After removing the ZKSecretIT the "NoAuth" errors have gone away. Is there a way to for this IT to go last or should we just fix the "Auth"

[GitHub] cjmctague commented on issue #971: IT's error out when calling mvn verify

2017-11-27 Thread GitBox
cjmctague commented on issue #971: IT's error out when calling mvn verify URL: https://github.com/apache/fluo/issues/971#issuecomment-347221853 After removing the `ZKSecretIT` the "NoAuth" errors have gone away. Is there a way to for this IT to go last or should we just fix the "Auth"

[GitHub] keith-turner commented on issue #969: [WIP] Issue-967

2017-11-27 Thread GitBox
keith-turner commented on issue #969: [WIP] Issue-967 URL: https://github.com/apache/fluo/pull/969#issuecomment-347307505 @jkosh44 these changes are looking good. I am still puzzling out the async story for Fluo. Currently there are a few areas I have identified and opened issue about.

[GitHub] keith-turner commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture

2017-11-28 Thread GitBox
keith-turner commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture URL: https://github.com/apache/fluo/issues/722#issuecomment-347562463 @jkosh44 this will be a very involved change. I can assist as needed, let me know if you have any questions. You

[GitHub] keith-turner commented on issue #971: IT's error out when calling mvn verify

2017-11-28 Thread GitBox
keith-turner commented on issue #971: IT's error out when calling mvn verify URL: https://github.com/apache/fluo/issues/971#issuecomment-347554053 @cjmctague can you try removing the timeout rule and see if it ever completes... or set it really high. Also when its stuck, can you

[GitHub] keith-turner commented on issue #969: [WIP] Issue-967

2017-11-28 Thread GitBox
keith-turner commented on issue #969: [WIP] Issue-967 URL: https://github.com/apache/fluo/pull/969#issuecomment-347557885 > On an unrelated note, I feel like all my commits fail on the continuous-integration Travis CI build. Is there a specific reason? The builds on travis are not

[GitHub] cjmctague commented on issue #971: IT's error out when calling mvn verify

2017-11-27 Thread GitBox
cjmctague commented on issue #971: IT's error out when calling mvn verify URL: https://github.com/apache/fluo/issues/971#issuecomment-347401335 My environment currently is on a mid 2012 macOS laptop with the latest version that the issues are occurring on. I run`brew update` and `brew

[GitHub] cjmctague commented on issue #971: IT's error out when calling mvn verify

2017-11-28 Thread GitBox
cjmctague commented on issue #971: IT's error out when calling mvn verify URL: https://github.com/apache/fluo/issues/971#issuecomment-347635816 @keith-turner Removing the timeout rule just made the test never end. I just emailed you the jStack dump

[GitHub] keith-turner commented on issue #971: IT's error out when calling mvn verify

2017-11-28 Thread GitBox
keith-turner commented on issue #971: IT's error out when calling mvn verify URL: https://github.com/apache/fluo/issues/971#issuecomment-347672768 I looked at the jstack you sent, it seems like the file contains 4 jstacks. Are those for 4 different test runs? It seems in two the of

[GitHub] srikailash commented on issue #530: Improve 'fluo list' command to print Fluo application start time

2017-11-25 Thread GitBox
srikailash commented on issue #530: Improve 'fluo list' command to print Fluo application start time URL: https://github.com/apache/fluo/issues/530#issuecomment-346949735 @mikewalch working on this . Information seems fine , will update here if any thing is needed .

[GitHub] mikewalch commented on issue #971: IT's error out when calling mvn verify

2017-11-30 Thread GitBox
mikewalch commented on issue #971: IT's error out when calling mvn verify URL: https://github.com/apache/fluo/issues/971#issuecomment-348273977 I am seeing the same problem with `OracleIT` on a Mac. I will look into this.

[GitHub] keith-turner opened a new issue #973: MiniFluo fails to start when running from mvn exec

2017-11-30 Thread GitBox
keith-turner opened a new issue #973: MiniFluo fails to start when running from mvn exec URL: https://github.com/apache/fluo/issues/973 When trying to use maven exec to start a 1.2.0-SNAPSHOT instance of mini fluo it fails with the following exeception. I think what is happening is that

[GitHub] cjmctague commented on issue #971: IT's error out when calling mvn verify

2017-11-30 Thread GitBox
cjmctague commented on issue #971: IT's error out when calling mvn verify URL: https://github.com/apache/fluo/issues/971#issuecomment-348279132 @keith-turner Yea sorry those were two different test runs. This is an automated

[GitHub] cjmctague commented on issue #971: IT's error out when calling mvn verify

2017-11-30 Thread GitBox
cjmctague commented on issue #971: IT's error out when calling mvn verify URL: https://github.com/apache/fluo/issues/971#issuecomment-348279132 @keith-turner Yea sorry those were four different test runs. This is an automated

[GitHub] keith-turner opened a new pull request #974: fixes #973 default fluo.dfs.root to empty string

2017-11-30 Thread GitBox
keith-turner opened a new pull request #974: fixes #973 default fluo.dfs.root to empty string URL: https://github.com/apache/fluo/pull/974 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] keith-turner closed pull request #974: fixes #973 default fluo.dfs.root to empty string

2017-11-30 Thread GitBox
keith-turner closed pull request #974: fixes #973 default fluo.dfs.root to empty string URL: https://github.com/apache/fluo/pull/974 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] keith-turner closed issue #973: MiniFluo fails to start when running from mvn exec

2017-11-30 Thread GitBox
keith-turner closed issue #973: MiniFluo fails to start when running from mvn exec URL: https://github.com/apache/fluo/issues/973 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture

2017-11-27 Thread GitBox
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture URL: https://github.com/apache/fluo/issues/722#issuecomment-347378967 Since I just got some experience using CompletableFutures I'd like to give this a shot.

[GitHub] ctubbsii closed pull request #972: Update parent to 3

2017-11-27 Thread GitBox
ctubbsii closed pull request #972: Update parent to 3 URL: https://github.com/apache/fluo/pull/972 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork),

[GitHub] ctubbsii opened a new pull request #145: Update parent to 3

2017-11-27 Thread GitBox
ctubbsii opened a new pull request #145: Update parent to 3 URL: https://github.com/apache/fluo-recipes/pull/145 Two commits. The first updates the parent POM to version 3, and strips out tasks that are now in the parent POM. The second applies formatter changes based on the updated

[GitHub] ctubbsii opened a new pull request #972: Update parent to 3

2017-11-27 Thread GitBox
ctubbsii opened a new pull request #972: Update parent to 3 URL: https://github.com/apache/fluo/pull/972 Two commits in this PR. The first updates the parent POM. The second applies formatting changes resulting from the new formatter in the new parent POM, and some manual whitespace

[GitHub] ctubbsii opened a new pull request #10: Update fluo-parent to version 3

2017-11-27 Thread GitBox
ctubbsii opened a new pull request #10: Update fluo-parent to version 3 URL: https://github.com/apache/fluo-yarn/pull/10 * Update parent POM to fluo-parent version 3 * Apply formatter changes (usually would go in a separate commit, but the changeset was small enough that it didn't

[GitHub] jwonders commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture

2017-12-01 Thread GitBox
jwonders commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture URL: https://github.com/apache/fluo/issues/722#issuecomment-348667973 Hi folks, I've been lurking around on the mailing lists for awhile as I haven't really had much time to start contributing.

[GitHub] jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture

2017-12-04 Thread GitBox
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture URL: https://github.com/apache/fluo/issues/722#issuecomment-349050151 Hey sorry I've had an extremely hectic week and haven't been able to look at this yet. I'm going to start on this tonight.

[GitHub] jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture

2017-12-04 Thread GitBox
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture URL: https://github.com/apache/fluo/issues/722#issuecomment-349050151 Hey sorry I've had an extremely hectic week and haven't been able to look at this yet. I'm going to start on this tonight.

[GitHub] keith-turner commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture

2017-12-04 Thread GitBox
keith-turner commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture URL: https://github.com/apache/fluo/issues/722#issuecomment-349057460 @jwonders I am not sure if ax-accumulo would be relevant for this PR because I have not had enough time to look at in

[GitHub] jwonders commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture

2017-12-04 Thread GitBox
jwonders commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture URL: https://github.com/apache/fluo/issues/722#issuecomment-349138723 @keith-turner I agree it might not be relevant and I'm not familar enough with fluo to know all of the touchpoints for this

[GitHub] jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture

2017-12-04 Thread GitBox
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture URL: https://github.com/apache/fluo/issues/722#issuecomment-349184990 Did some analysis of where ListenableFuture is used and here's what I found: Classes that use ListenableFuture:

[GitHub] jwonders commented on issue #978: Use CompleteableFuture compose to centralize commit logic

2017-12-14 Thread GitBox
jwonders commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351738004 @jkosh44 I'm interested in looking at it. I probably can't get to it until this weekend rthough. Hopefully the

[GitHub] jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic

2017-12-14 Thread GitBox
jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351726809 If anyone's interested I started to try and see how this would look/work in code.

[GitHub] jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic

2017-12-14 Thread GitBox
jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351726809 If anyone's interested I started to try and see how this would look/work in code.

[GitHub] jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic

2017-12-14 Thread GitBox
jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351726809 If anyone's interested I started to try and see how this would look/work in code.

[GitHub] jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture

2017-12-12 Thread GitBox
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture URL: https://github.com/apache/fluo/issues/722#issuecomment-351151776 @jwonders I've been looking at your suggestions and had a question. I'm still unclear as to what AsynCommitResult's purpose

[GitHub] keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic

2017-12-18 Thread GitBox
keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-352465141 > In terms of exception handling for CommitStep, I thin we can append compose with .exceptionally(e -> getFailureOp(cd)) or

[GitHub] mikewalch opened a new pull request #12: Fixes #11 Apps are failing to run on cluster

2017-12-18 Thread GitBox
mikewalch opened a new pull request #12: Fixes #11 Apps are failing to run on cluster URL: https://github.com/apache/fluo-yarn/pull/12 * Created new property so that 'fs.defaultFS' is set in hadoop config that is passed to YarnTwillRunnerService

[GitHub] mikewalch opened a new issue #11: Apps are failing to launch when running on cluster

2017-12-18 Thread GitBox
mikewalch opened a new issue #11: Apps are failing to launch when running on cluster URL: https://github.com/apache/fluo-yarn/issues/11 I think this is due to Twill not storing the files it needs in HDFS because `fs.defaultFS` is not configured in Hadoop configuration that is passed to

[GitHub] keith-turner opened a new issue #9: Download from Apache mirrors instead of archive

2017-12-19 Thread GitBox
keith-turner opened a new issue #9: Download from Apache mirrors instead of archive URL: https://github.com/apache/fluo-docker/issues/9 Currently the dockerfile downloads dependencies like Hadoop and Zookeeper from Apache's archive site. It would be much better to download from Apache

[GitHub] keith-turner commented on issue #9: Download from Apache mirrors instead of archive

2017-12-19 Thread GitBox
keith-turner commented on issue #9: Download from Apache mirrors instead of archive URL: https://github.com/apache/fluo-docker/issues/9#issuecomment-352809208 Also the Accumulo docker file uses the technique mentioned in the comment

[GitHub] keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic

2017-12-19 Thread GitBox
keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-352818006 @jwonders the flow chart is really awesome! What did you use to create it? Would you be willing to contribute it? I

[GitHub] keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic

2017-12-19 Thread GitBox
keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-352818006 @jwonders the flow chart is really awesome! What did you use to create it? Would you be willing to contribute it? I

[GitHub] jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic

2017-12-13 Thread GitBox
jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351572833 @keith-turner I've been trying to think of a way to synthesize @jwonders idea of an AysncCommitResult and your idea of having

[GitHub] jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic

2017-12-13 Thread GitBox
jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351581495 I was going to try and see how this worked in actual code and I noticed that this would not cover the case where we commit and

[GitHub] jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic

2017-12-13 Thread GitBox
jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351564607 Just wanted to also copy some relevant comments from #722 by @jwonders, to avoid having to flip back and forth. >Assuming

[GitHub] jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic

2017-12-13 Thread GitBox
jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351564607 Just wanted to also copy some relevant comments from #722 by @jwonders, to avoid having to flip back and forth. >Assuming

[GitHub] jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic

2017-12-13 Thread GitBox
jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351573940 `AsyncCommitResult` would look like ``` public class AsyncCommitResult { private CommitData cd; private

[GitHub] ctubbsii commented on issue #978: Use CompleteableFuture compose to centralize commit logic

2017-12-13 Thread GitBox
ctubbsii commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351458579 @keith-turner that Gist isn't public. This is an automated

[GitHub] keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic

2017-12-13 Thread GitBox
keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351458277 I created a [Gist](https://gist.github.com/keith-turner/387dc83332bc330fee673be146848994) containing some local

[GitHub] keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic

2017-12-13 Thread GitBox
keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351458277 I created a [Gist](https://gist.github.com/keith-turner/387dc83332bc330fee673be14684899) containing some local

[GitHub] keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic

2017-12-13 Thread GitBox
keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351460771 This is the commit code as it existed before being converted to an async process.

[GitHub] keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic

2017-12-13 Thread GitBox
keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351458277 I created a [Gist](https://gist.github.com/keith-turner/387dc83332bc330fee673be146848994) containing some local

[GitHub] ctubbsii commented on issue #978: Use CompleteableFuture compose to centralize commit logic

2017-12-13 Thread GitBox
ctubbsii commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351458579 @keith-turner that Gist isn't public. This is an automated

[GitHub] jwonders commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture

2017-12-12 Thread GitBox
jwonders commented on issue #722: Move from Guava ListenableFuture to Java 8 CompletableFuture URL: https://github.com/apache/fluo/issues/722#issuecomment-351266088 The purpose of `AsyncCommitResult` is to capture the result of the async operation. Terminal steps would be able to create

[GitHub] mikewalch closed issue #11: Apps are failing to launch when running on cluster

2017-12-19 Thread GitBox
mikewalch closed issue #11: Apps are failing to launch when running on cluster URL: https://github.com/apache/fluo-yarn/issues/11 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] mikewalch closed pull request #12: Fixes #11 Apps are failing to run on cluster

2017-12-19 Thread GitBox
mikewalch closed pull request #12: Fixes #11 Apps are failing to run on cluster URL: https://github.com/apache/fluo-yarn/pull/12 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] alanblueshift opened a new pull request #10: Fix to download from Apache mirrors instead of archive #9

2017-12-19 Thread GitBox
alanblueshift opened a new pull request #10: Fix to download from Apache mirrors instead of archive #9 URL: https://github.com/apache/fluo-docker/pull/10 This is an automated message from the Apache Git Service. To respond

[GitHub] jwonders commented on issue #978: Use CompleteableFuture compose to centralize commit logic

2017-12-19 Thread GitBox
jwonders commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-352944995 I used gliffy. Definitely willing to contribute it. Here is a gist of the json.

[GitHub] keith-turner closed pull request #10: Fix to download from Apache mirrors instead of archive #9

2017-12-20 Thread GitBox
keith-turner closed pull request #10: Fix to download from Apache mirrors instead of archive #9 URL: https://github.com/apache/fluo-docker/pull/10 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] keith-turner commented on issue #10: Fix to download from Apache mirrors instead of archive #9

2017-12-20 Thread GitBox
keith-turner commented on issue #10: Fix to download from Apache mirrors instead of archive #9 URL: https://github.com/apache/fluo-docker/pull/10#issuecomment-353055580 @ctubbsii I opened #11 This is an automated message

  1   2   3   4   5   6   7   8   9   10   >