[GitHub] keith-turner commented on issue #1013: Making changes in the file according to issue 1011

2018-02-13 Thread GitBox
keith-turner commented on issue #1013: Making changes in the file according to 
issue 1011
URL: https://github.com/apache/fluo/pull/1013#issuecomment-365293338
 
 
   > Thanks Keith, this contribution is too small for me to be listed as a 
contributor.
   
   No contribution is too small, all take time and effort and that is 
appreciated.
   
   > You did most of the heavy lifting by specifying what needs to be done.
   
   Once after taking the [golang tour](https://tour.golang.org/welcome/1) I 
decided I wanted to make a quick contribution to an open source Go project.  I 
decided to try to make a contribution to 
[syncthing/syncthing](https://github.com/syncthing/syncthing).  I consider 
myself a capable programmer, however I was a newby to Go and its eco-system.  I 
spent a few hours looking for a way to contribute and could not find an easy 
in.  It made me realize how daunting getting started on a completely new open 
source project can be.  So I tried to do some things to make getting started 
with Fluo easier based on that experience.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] keith-turner commented on issue #1013: Making changes in the file according to issue 1011

2018-02-12 Thread GitBox
keith-turner commented on issue #1013: Making changes in the file according to 
issue 1011
URL: https://github.com/apache/fluo/pull/1013#issuecomment-365053800
 
 
   @asr21 thanks for the contribution.  This change uncovered some bad behavior 
in the test code that would result in SyncCommitObs being called twice.  I 
fixed this in #1014 by changing the finishCommit method.
   
   If you would like to be listed on the [Fluo people 
page](http://fluo.apache.org/people/) as contributor, let us know what info you 
would like listed OR make a PR to the [Fluo 
website](https://github.com/apache/fluo-website).
   
   We tweet about new contributors from 
[ApacheFluo](https://twitter.com/apachefluo).  Are you ok with a tweet about 
this PR and if so do you have a twitter user to mention?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services