[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79888429
--- Diff: src/main/java/ft/Main.java ---
@@ -0,0 +1,44 @@
+package ft;
+
+import java.io.File;
+import java.nio.file.Files;
+
+// Normaly using * with imports is a bad practice, however in this case it
makes experimenting with
+// Fluo easier.
+import org.apache.fluo.api.client.*;
+import org.apache.fluo.api.config.*;
+import org.apache.fluo.api.data.*;
+import org.apache.fluo.api.mini.MiniFluo;
+import org.apache.fluo.api.observer.*;
+
+public class Main {
+ public static void main(String[] args) throws Exception {
+
+String tmpDir = Files.createTempDirectory(new File("target").toPath(),
"mini").toString();
--- End diff --
Ok I see. I made that change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79886627
--- Diff: pom.xml ---
@@ -0,0 +1,93 @@
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+ 4.0.0
+
+ org.apache.fluo
+ fluo-tour
+ 0.0.1-SNAPSHOT
+ jar
+
+ fluo-tour
+ https://fluo.apache.org/tour
+
+
+UTF-8
+1.7.2
+1.0.0-incubating
+
+
+
+
+
+maven-compiler-plugin
+3.1
+
+ 1.8
+ 1.8
+ true
+ UTF-8
+
+
+
+org.codehaus.mojo
+exec-maven-plugin
+1.5.0
+
+ ft.Main
+ false
+
+
+
+
+
+
+
+
+org.apache.accumulo
+accumulo-minicluster
+${accumulo.version}
+
+
+org.apache.accumulo
+accumulo-core
+${accumulo.version}
+
+
+
+
+
+
+ junit
+ junit
+ 4.11
+ test
+
+
--- End diff --
They don't seem to be used by the tour at the moment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79886585
--- Diff: src/main/java/ft/Main.java ---
@@ -0,0 +1,44 @@
+package ft;
+
+import java.io.File;
+import java.nio.file.Files;
+
+// Normaly using * with imports is a bad practice, however in this case it
makes experimenting with
+// Fluo easier.
+import org.apache.fluo.api.client.*;
+import org.apache.fluo.api.config.*;
+import org.apache.fluo.api.data.*;
+import org.apache.fluo.api.mini.MiniFluo;
+import org.apache.fluo.api.observer.*;
+
+public class Main {
+ public static void main(String[] args) throws Exception {
+
+String tmpDir = Files.createTempDirectory(new File("target").toPath(),
"mini").toString();
--- End diff --
My comment was that you can replace `new File("target").toPath()` with
`Paths.get("target")`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79885872
--- Diff: pom.xml ---
@@ -0,0 +1,93 @@
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+ 4.0.0
+
+ org.apache.fluo
+ fluo-tour
+ 0.0.1-SNAPSHOT
+ jar
+
+ fluo-tour
+ https://fluo.apache.org/tour
+
+
+UTF-8
+1.7.2
+1.0.0-incubating
+
+
+
+
+
+maven-compiler-plugin
+3.1
+
+ 1.8
+ 1.8
+ true
+ UTF-8
+
+
+
+org.codehaus.mojo
+exec-maven-plugin
+1.5.0
+
+ ft.Main
+ false
+
+
+
+
+
+
+
+
+org.apache.accumulo
+accumulo-minicluster
+${accumulo.version}
+
+
+org.apache.accumulo
+accumulo-core
+${accumulo.version}
+
+
+
+
+
+
+ junit
+ junit
+ 4.11
+ test
+
+
--- End diff --
I need to look into if the tour is using these
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79885237
--- Diff: src/main/java/ft/Main.java ---
@@ -0,0 +1,44 @@
+package ft;
+
+import java.io.File;
+import java.nio.file.Files;
+
+// Normaly using * with imports is a bad practice, however in this case it
makes experimenting with
+// Fluo easier.
+import org.apache.fluo.api.client.*;
+import org.apache.fluo.api.config.*;
+import org.apache.fluo.api.data.*;
+import org.apache.fluo.api.mini.MiniFluo;
+import org.apache.fluo.api.observer.*;
+
+public class Main {
+ public static void main(String[] args) throws Exception {
+
+String tmpDir = Files.createTempDirectory(new File("target").toPath(),
"mini").toString();
+// System.out.println("tmp dir : "+tmpDir);
--- End diff --
I left it there commented out in case a user had a problem. I found it
annoying to always print it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79884981
--- Diff: src/main/java/ft/Main.java ---
@@ -0,0 +1,44 @@
+package ft;
+
+import java.io.File;
+import java.nio.file.Files;
+
+// Normaly using * with imports is a bad practice, however in this case it
makes experimenting with
+// Fluo easier.
+import org.apache.fluo.api.client.*;
+import org.apache.fluo.api.config.*;
+import org.apache.fluo.api.data.*;
+import org.apache.fluo.api.mini.MiniFluo;
+import org.apache.fluo.api.observer.*;
+
+public class Main {
+ public static void main(String[] args) throws Exception {
+
+String tmpDir = Files.createTempDirectory(new File("target").toPath(),
"mini").toString();
--- End diff --
I don't see a method on Paths to create a tmp dir. I am using Files and
not File.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79828012 --- Diff: src/main/java/ft/Main.java --- @@ -0,0 +1,44 @@ +package ft; + +import java.io.File; +import java.nio.file.Files; + +// Normaly using * with imports is a bad practice, however in this case it makes experimenting with --- End diff -- Should be `Normally` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79831447
--- Diff: src/main/java/ft/Main.java ---
@@ -0,0 +1,44 @@
+package ft;
+
+import java.io.File;
+import java.nio.file.Files;
+
+// Normaly using * with imports is a bad practice, however in this case it
makes experimenting with
+// Fluo easier.
+import org.apache.fluo.api.client.*;
+import org.apache.fluo.api.config.*;
+import org.apache.fluo.api.data.*;
+import org.apache.fluo.api.mini.MiniFluo;
+import org.apache.fluo.api.observer.*;
+
+public class Main {
+ public static void main(String[] args) throws Exception {
+
+String tmpDir = Files.createTempDirectory(new File("target").toPath(),
"mini").toString();
--- End diff --
Could use Paths instead of File:
```java
String tmpDir = Files.createTempDirectory(Paths.get("target"),
"mini-").toString();
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fluo-website pull request #18: turned quickstart into fluo tour
Github user mikewalch commented on a diff in the pull request: https://github.com/apache/incubator-fluo-website/pull/18#discussion_r79826320 --- Diff: README.md --- @@ -1,4 +1,17 @@ Fluo Tour - +The git repository provides a barebones Maven+Java environment for the [Fluo Tour][tour]. As you go +through the Tour edit [Main.java] and then use the following command to execute Main. This command --- End diff -- could be `use the following command to get all of the correct dependencies on the classpath and execute Main` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
