[GitHub] [freemarker] ddekany merged pull request #76: Fix: Typos "clalc." in TemplateException

2021-09-12 Thread GitBox
ddekany merged pull request #76: URL: https://github.com/apache/freemarker/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [freemarker] yuanjunxiaoli commented on pull request #75: fix typo 'TemplatException' to 'TemplateException'

2021-11-05 Thread GitBox
yuanjunxiaoli commented on pull request #75: URL: https://github.com/apache/freemarker/pull/75#issuecomment-962378267 Great! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [freemarker] powercomstar opened a new pull request #77: Update malformed.tld

2021-11-08 Thread GitBox
powercomstar opened a new pull request #77: URL: https://github.com/apache/freemarker/pull/77 the should be , it is correct -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [freemarker] ddekany commented on pull request #77: Update malformed.tld

2021-11-08 Thread GitBox
ddekany commented on pull request #77: URL: https://github.com/apache/freemarker/pull/77#issuecomment-963880953 That's an intentionally malformed XML. However, it's not actually used in any tests, so that file should be just deleted. -- This is an automated message from the Apache Git Se

[GitHub] [freemarker] ddekany merged pull request #77: Update malformed.tld

2021-11-10 Thread GitBox
ddekany merged pull request #77: URL: https://github.com/apache/freemarker/pull/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [freemarker] ddekany merged pull request #78: Small fixes/ improved readability

2022-02-08 Thread GitBox
ddekany merged pull request #78: URL: https://github.com/apache/freemarker/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [freemarker] kelemen opened a new pull request #79: FREEMARKER-204 Change build from Ant to Gradle

2022-02-14 Thread GitBox
kelemen opened a new pull request #79: URL: https://github.com/apache/freemarker/pull/79 For easier review: - Many files were moved around for easier compilation (i.e., there is no need to add file filters due to different dependencies) - Most files were just moved without any c

[GitHub] [freemarker] kelemen opened a new pull request #80: Ported JIRA-204 Gradle build to version 3

2022-02-16 Thread GitBox
kelemen opened a new pull request #80: URL: https://github.com/apache/freemarker/pull/80 In addition to the port. This also makes `SimpleCharStream` (generated by javacc) package private (as was intended). -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [freemarker] kelemen closed pull request #79: FREEMARKER-204 Change build from Ant to Gradle

2022-02-16 Thread GitBox
kelemen closed pull request #79: URL: https://github.com/apache/freemarker/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [freemarker] kelemen opened a new pull request #81: Gradle GitHub actions for version 3

2022-02-16 Thread GitBox
kelemen opened a new pull request #81: URL: https://github.com/apache/freemarker/pull/81 > :warning: This PR is on top of #80 (Ported JIRA-204 Gradle build to version 3) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [freemarker-docgen] dependabot[bot] opened a new pull request, #2: Bump minimist from 1.2.5 to 1.2.6 in /freemarker-docgen-core

2022-04-12 Thread GitBox
dependabot[bot] opened a new pull request, #2: URL: https://github.com/apache/freemarker-docgen/pull/2 Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. Commits https://github.com/substack/minimist/commit/7efb22a518b53b06f5b02a1038a88bd6290c2846";>7efb2

[GitHub] [freemarker-docgen] JacquesLeRoux closed pull request #2: Bump minimist from 1.2.5 to 1.2.6 in /freemarker-docgen-core

2022-05-21 Thread GitBox
JacquesLeRoux closed pull request #2: Bump minimist from 1.2.5 to 1.2.6 in /freemarker-docgen-core URL: https://github.com/apache/freemarker-docgen/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [freemarker-docgen] JacquesLeRoux commented on pull request #2: Bump minimist from 1.2.5 to 1.2.6 in /freemarker-docgen-core

2022-05-21 Thread GitBox
JacquesLeRoux commented on PR #2: URL: https://github.com/apache/freemarker-docgen/pull/2#issuecomment-1133587424 This does not need to be merged: https://lists.apache.org/thread/86fv45vksxcs3j1j5cq4t6jsho9jqv6o -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [freemarker-docgen] dependabot[bot] commented on pull request #2: Bump minimist from 1.2.5 to 1.2.6 in /freemarker-docgen-core

2022-05-21 Thread GitBox
dependabot[bot] commented on PR #2: URL: https://github.com/apache/freemarker-docgen/pull/2#issuecomment-1133587434 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version,

[GitHub] [freemarker] GVDV opened a new pull request, #82: replace String by StringBuilder in ElementModel

2022-06-13 Thread GitBox
GVDV opened a new pull request, #82: URL: https://github.com/apache/freemarker/pull/82 I had a problem when using Freemarker with xml 's containing large content ( > 600KB) The number of nodes were high, more then 10 000 and when using String concatenation as in the following snippet the

[GitHub] [freemarker] ddekany commented on pull request #82: replace String by StringBuilder in ElementModel

2022-06-15 Thread GitBox
ddekany commented on PR #82: URL: https://github.com/apache/freemarker/pull/82#issuecomment-1156754365 Yeah, that was a quite bad there. Thanks! On the other hand, even if the file is huge, I would expect one big text node, unless there were lot of comments slicing it up. -- This is an a

[GitHub] [freemarker] ddekany merged pull request #82: replace String by StringBuilder in ElementModel

2022-06-15 Thread GitBox
ddekany merged PR #82: URL: https://github.com/apache/freemarker/pull/82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@freem

[GitHub] [freemarker-docgen] dependabot[bot] opened a new pull request, #3: Bump copy-props from 2.0.4 to 2.0.5 in /freemarker-docgen-core

2022-06-27 Thread GitBox
dependabot[bot] opened a new pull request, #3: URL: https://github.com/apache/freemarker-docgen/pull/3 Bumps [copy-props](https://github.com/gulpjs/copy-props) from 2.0.4 to 2.0.5. Release notes Sourced from https://github.com/gulpjs/copy-props/releases";>copy-props's releases.

[GitHub] [freemarker] chrisrueger opened a new pull request, #84: Add support for bndtools in Eclipse

2022-10-08 Thread GitBox
chrisrueger opened a new pull request, #84: URL: https://github.com/apache/freemarker/pull/84 ## What This PR is to make it possible to import freemarker in a bndtools Eclipse project (OSGI). See https://bndtools.org/concepts.html This allows for easier debugging and develop

[GitHub] [freemarker] chrisrueger commented on pull request #84: Add support for bndtools in Eclipse

2022-10-08 Thread GitBox
chrisrueger commented on PR #84: URL: https://github.com/apache/freemarker/pull/84#issuecomment-1272405394 @ddekany could you review this PR, please? Is there anything else I need to do? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [freemarker] ddekany commented on pull request #84: Add support for bndtools in Eclipse

2022-10-09 Thread GitBox
ddekany commented on PR #84: URL: https://github.com/apache/freemarker/pull/84#issuecomment-1272581009 Only the legal part... Do you have a CLA at Apache? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [freemarker] chrisrueger commented on pull request #84: Add support for bndtools in Eclipse

2022-10-09 Thread GitBox
chrisrueger commented on PR #84: URL: https://github.com/apache/freemarker/pull/84#issuecomment-1272597224 > Do you have a CLA at Apache? Yes I received a confirmation from apache around 2017 Jan: > This message acknowledges receipt of your ICLA, which has been filed in the Apa

[GitHub] [freemarker] SaraAspery opened a new pull request, #85: 2.3.31 alfresco patched

2022-10-11 Thread GitBox
SaraAspery opened a new pull request, #85: URL: https://github.com/apache/freemarker/pull/85 This PR includes changes for [ACS-2579](https://alfresco.atlassian.net/browse/ACS-2579) and is based on apache/freemarker v2.3.31: Update tags from apache/freemarker Added unsafe methods f

[GitHub] [freemarker] SaraAspery closed pull request #85: 2.3.31 alfresco patched

2022-10-11 Thread GitBox
SaraAspery closed pull request #85: 2.3.31 alfresco patched URL: https://github.com/apache/freemarker/pull/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [freemarker] SaraAspery closed pull request #86: WIP: Acs 2579 upgrade to freemarker 2 3 31

2022-10-11 Thread GitBox
SaraAspery closed pull request #86: WIP: Acs 2579 upgrade to freemarker 2 3 31 URL: https://github.com/apache/freemarker/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [freemarker] ddekany commented on pull request #84: Add support for bndtools in Eclipse

2022-10-16 Thread GitBox
ddekany commented on PR #84: URL: https://github.com/apache/freemarker/pull/84#issuecomment-1280057497 Thanks, I managed to check that the ICLA was indeed submitted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [freemarker] ddekany merged pull request #84: Add support for bndtools in Eclipse

2022-10-16 Thread GitBox
ddekany merged PR #84: URL: https://github.com/apache/freemarker/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@freem

[GitHub] [freemarker-docgen] dependabot[bot] opened a new pull request, #4: Bump decode-uri-component from 0.2.0 to 0.2.2 in /freemarker-docgen-core

2022-12-06 Thread GitBox
dependabot[bot] opened a new pull request, #4: URL: https://github.com/apache/freemarker-docgen/pull/4 Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2. Release notes Sourced from https://github.com/SamVerschueren/decode-uri-

[GitHub] [freemarker] ddekany commented on pull request #83: Add fine-grained mixed-content support to markup output formats.

2022-12-19 Thread GitBox
ddekany commented on PR #83: URL: https://github.com/apache/freemarker/pull/83#issuecomment-1358014496 Do you have an ICLA (Individual Contributor License Agreement) at Apache? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [freemarker] nolaviz commented on pull request #83: Add fine-grained mixed-content support to markup output formats.

2022-12-27 Thread GitBox
nolaviz commented on PR #83: URL: https://github.com/apache/freemarker/pull/83#issuecomment-1366380791 Yes, I have an ICLA (under my @google.com email address). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [freemarker] ddekany commented on pull request #83: Add fine-grained mixed-content support to markup output formats.

2022-12-28 Thread GitBox
ddekany commented on PR #83: URL: https://github.com/apache/freemarker/pull/83#issuecomment-1366722444 OK. However, I can't only check if I know the full address, so please send that to private@freemarker.a.o (replace a.o with the real domain)! Only the project managers will see it. Thanks!

[GitHub] [freemarker] ddekany commented on pull request #83: Add fine-grained mixed-content support to markup output formats.

2022-12-28 Thread GitBox
ddekany commented on PR #83: URL: https://github.com/apache/freemarker/pull/83#issuecomment-1366725217 OK, got the ICLA. (Never mind my deleted message.) Will double check if it's how we want this, then merge. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [freemarker] ddekany merged pull request #80: Ported JIRA-204 Gradle build to version 3

2022-12-31 Thread GitBox
ddekany merged PR #80: URL: https://github.com/apache/freemarker/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@freem

[GitHub] [freemarker] ddekany merged pull request #81: Gradle GitHub actions for version 3

2022-12-31 Thread GitBox
ddekany merged PR #81: URL: https://github.com/apache/freemarker/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@freem

[GitHub] [freemarker] ddekany merged pull request #83: Add fine-grained mixed-content support to markup output formats.

2023-01-04 Thread GitBox
ddekany merged PR #83: URL: https://github.com/apache/freemarker/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@freem

[GitHub] [freemarker] nolaviz opened a new pull request, #87: Fix string comparison to avoid using the collator.

2023-01-13 Thread GitBox
nolaviz opened a new pull request, #87: URL: https://github.com/apache/freemarker/pull/87 Benchmarking at Google has shown an up-to-1000x performance degradation from using the collator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [freemarker] ddekany commented on pull request #87: Fix string comparison to avoid using the collator.

2023-01-13 Thread GitBox
ddekany commented on PR #87: URL: https://github.com/apache/freemarker/pull/87#issuecomment-1381604286 There's a complication here. The Collator does UNICODE normalization, while String.equals does not. Like if you put together "á" from "a" and the combining accent character, they won't be

[GitHub] [freemarker] ddekany commented on pull request #87: Fix string comparison to avoid using the collator.

2023-01-13 Thread GitBox
ddekany commented on PR #87: URL: https://github.com/apache/freemarker/pull/87#issuecomment-1381615100 Also, when it comes to backward compatibility, I don't know right now what other magic Collators do... Like if different kind of dashes are equal and such. So probably this will need a `co

[GitHub] [freemarker] ddekany commented on pull request #74: Fixed deprecated method that caused Spring loading of Configuration to fail

2023-01-13 Thread GitBox
ddekany commented on PR #74: URL: https://github.com/apache/freemarker/pull/74#issuecomment-1381640417 In case you don't get notification about that, note that I have commented on the Jira issue. I can't recreate the issue, and I want to, to explore alternatives. -- This is an automated

[GitHub] [freemarker] nolaviz commented on pull request #87: Fix string comparison to avoid using the collator.

2023-01-13 Thread GitBox
nolaviz commented on PR #87: URL: https://github.com/apache/freemarker/pull/87#issuecomment-1381702733 The collator used here (`Environment.getCollator()`) is always initialized to `Collator.getInstance(getLocale())`; OpenJDK's `CollatorProviderImpl` disables decomposition on the collators

[GitHub] [freemarker] ddekany commented on pull request #87: Fix string comparison to avoid using the collator.

2023-01-13 Thread GitBox
ddekany commented on PR #87: URL: https://github.com/apache/freemarker/pull/87#issuecomment-1382094899 Quickly checked on Windows 10, Oracle Java 8... it does (de)normalization apparently: ``` String s1 = "a\u0301"; String s2 = "á"; System.out.println(

[GitHub] [freemarker] nolaviz commented on pull request #87: Fix string comparison to avoid using the collator.

2023-01-13 Thread GitBox
nolaviz commented on PR #87: URL: https://github.com/apache/freemarker/pull/87#issuecomment-1382158222 Just to note - a very simplistic benchmark (https://gist.github.com/nolaviz/94455756da704892c4dca377062ab82a) shows the following results: ``` String.compareTo: PT0.804698705S

[GitHub] [freemarker-docgen] dependabot[bot] opened a new pull request, #5: Bump minimatch from 3.0.4 to 3.1.2 in /freemarker-docgen-core

2023-01-15 Thread GitBox
dependabot[bot] opened a new pull request, #5: URL: https://github.com/apache/freemarker-docgen/pull/5 Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. Commits https://github.com/isaacs/minimatch/commit/699c459443a6bd98f5b28197978f76e7f71467ac";>699c45

[GitHub] [freemarker-docgen] dependabot[bot] opened a new pull request, #6: Bump lodash from 4.17.19 to 4.17.21 in /freemarker-docgen-core

2023-01-15 Thread GitBox
dependabot[bot] opened a new pull request, #6: URL: https://github.com/apache/freemarker-docgen/pull/6 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.19 to 4.17.21. Commits https://github.com/lodash/lodash/commit/f299b52f39486275a9e6483b60a410e06520c538";>f299b52 Bu

[GitHub] [freemarker-docgen] dependabot[bot] opened a new pull request, #7: Bump postcss from 7.0.32 to 7.0.39 in /freemarker-docgen-core

2023-01-15 Thread GitBox
dependabot[bot] opened a new pull request, #7: URL: https://github.com/apache/freemarker-docgen/pull/7 Bumps [postcss](https://github.com/postcss/postcss) from 7.0.32 to 7.0.39. Release notes Sourced from https://github.com/postcss/postcss/releases";>postcss's releases. 7.0.

[GitHub] [freemarker-docgen] dependabot[bot] opened a new pull request, #8: Bump commons-text from 1.9 to 1.10.0 in /freemarker-docgen-core

2023-01-15 Thread GitBox
dependabot[bot] opened a new pull request, #8: URL: https://github.com/apache/freemarker-docgen/pull/8 Bumps commons-text from 1.9 to 1.10.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.commons:co

[GitHub] [freemarker] ddekany commented on pull request #87: Fix string comparison to avoid using the collator.

2023-01-17 Thread GitBox
ddekany commented on PR #87: URL: https://github.com/apache/freemarker/pull/87#issuecomment-1385126729 The last thing we have to figure out if we can always do this (normalize then `equals`), or it has to be activated by `cfg.incompatibleImprovements >= 2.3.33`. That depends on whether some

[GitHub] [freemarker] nolaviz opened a new pull request, #88: Support "forced" auto-escaping policy.

2023-01-20 Thread GitBox
nolaviz opened a new pull request, #88: URL: https://github.com/apache/freemarker/pull/88 When the "forced auto-escaping" policy is in effect, only output formats that support auto-escaping may be used; also, the `?no_esc` built-in and the `<#noautoesc>` directive are disabled. -- This i

[GitHub] yuchi opened a new pull request #10: Fix typos in Built Ins for Numbers

2019-01-24 Thread GitBox
yuchi opened a new pull request #10: Fix typos in Built Ins for Numbers URL: https://github.com/apache/freemarker-site/pull/10 Please verify those are not written wrong on pourpose. This is an automated message from the Apache

[GitHub] yuchi commented on issue #10: Fix typos in Built Ins for Numbers

2019-01-24 Thread GitBox
yuchi commented on issue #10: Fix typos in Built Ins for Numbers URL: https://github.com/apache/freemarker-site/pull/10#issuecomment-457149818 Also, is editing the HTMLs the correct approach to propose a change? I cannot find any documentation on this… I expected to find some ASCIIDOC or MD

[GitHub] ddekany commented on issue #10: Fix typos in Built Ins for Numbers

2019-01-25 Thread GitBox
ddekany commented on issue #10: Fix typos in Built Ins for Numbers URL: https://github.com/apache/freemarker-site/pull/10#issuecomment-457711706 These HTML-s are generated from https://github.com/apache/freemarker/blob/2.3-gae/src/manual/en_US/book.xml (XDocbok format). But I will do the f

[GitHub] ddekany commented on issue #10: Fix typos in Built Ins for Numbers

2019-01-25 Thread GitBox
ddekany commented on issue #10: Fix typos in Built Ins for Numbers URL: https://github.com/apache/freemarker-site/pull/10#issuecomment-457721262 And actually "multipier" is a typo in the decimal format parser... fixed that in the code as well (will recognize both spellings in 2.3.29).

[GitHub] yuchi commented on issue #10: Fix typos in Built Ins for Numbers

2019-01-25 Thread GitBox
yuchi commented on issue #10: Fix typos in Built Ins for Numbers URL: https://github.com/apache/freemarker-site/pull/10#issuecomment-457754194 Thanks so much for taking care of it for me! May I suggest to revise the documentation on how to contribute? A good approach is to split every pa

[GitHub] ddekany commented on issue #10: Fix typos in Built Ins for Numbers

2019-01-26 Thread GitBox
ddekany commented on issue #10: Fix typos in Built Ins for Numbers URL: https://github.com/apache/freemarker-site/pull/10#issuecomment-457873420 Well, at least we could provide a link to the source file on Git (be it one big or several smaller XML-s). Can you please close this PR? Be

[GitHub] yuchi closed pull request #10: Fix typos in Built Ins for Numbers

2019-01-26 Thread GitBox
yuchi closed pull request #10: Fix typos in Built Ins for Numbers URL: https://github.com/apache/freemarker-site/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHu

[GitHub] ILyaCyclone opened a new pull request #56: fix typo 'namesoace' to 'namespace'

2019-02-05 Thread GitBox
ILyaCyclone opened a new pull request #56: fix typo 'namesoace' to 'namespace' URL: https://github.com/apache/freemarker/pull/56 Fix typo 'namesoace' to 'namespace' in `src/manual/en_US/book.xml` and `src/manual/zh_CN/book.xml`. -

[GitHub] ddekany merged pull request #56: fix typo 'namesoace' to 'namespace'

2019-02-05 Thread GitBox
ddekany merged pull request #56: fix typo 'namesoace' to 'namespace' URL: https://github.com/apache/freemarker/pull/56 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] ddekany commented on issue #56: fix typo 'namesoace' to 'namespace'

2019-02-05 Thread GitBox
ddekany commented on issue #56: fix typo 'namesoace' to 'namespace' URL: https://github.com/apache/freemarker/pull/56#issuecomment-460812101 Thanks! This is an automated message from the Apache Git Service. To respond to the m

[GitHub] amaxama opened a new pull request #11: Fixed a few minor typos in book.xml

2019-02-20 Thread GitBox
amaxama opened a new pull request #11: Fixed a few minor typos in book.xml URL: https://github.com/apache/freemarker-site/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] ddekany merged pull request #11: Fixed a few minor typos in book.xml

2019-02-21 Thread GitBox
ddekany merged pull request #11: Fixed a few minor typos in book.xml URL: https://github.com/apache/freemarker-site/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on Gi

[GitHub] ddekany commented on issue #11: Fixed a few minor typos in book.xml

2019-02-21 Thread GitBox
ddekany commented on issue #11: Fixed a few minor typos in book.xml URL: https://github.com/apache/freemarker-site/pull/11#issuecomment-466064239 Thanks! This is an automated message from the Apache Git Service. To respond to

[GitHub] [freemarker] ajbanck opened a new pull request #57: clearClassIntrospecitonCache typo correction

2019-03-29 Thread GitBox
ajbanck opened a new pull request #57: clearClassIntrospecitonCache typo correction URL: https://github.com/apache/freemarker/pull/57 BeansWrapper method clearClassIntrospecitonCache contains a typo. Added clearClassIntrospectionCache and marked the misspelled method as deprecated ---

[GitHub] [freemarker] ddekany merged pull request #57: clearClassIntrospecitonCache typo correction

2019-04-06 Thread GitBox
ddekany merged pull request #57: clearClassIntrospecitonCache typo correction URL: https://github.com/apache/freemarker/pull/57 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [freemarker] robin850 opened a new pull request #58: Fix a tiny typo

2019-06-26 Thread GitBox
robin850 opened a new pull request #58: Fix a tiny typo URL: https://github.com/apache/freemarker/pull/58 Hello, This pull request simply fixes a typo in the documentation of the `BeansWrapper#unwrap` method. Have a nice day. --

[GitHub] [freemarker] ddekany merged pull request #58: Fix a tiny typo

2019-06-26 Thread GitBox
ddekany merged pull request #58: Fix a tiny typo URL: https://github.com/apache/freemarker/pull/58 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [freemarker] ddekany commented on issue #58: Fix a tiny typo

2019-06-26 Thread GitBox
ddekany commented on issue #58: Fix a tiny typo URL: https://github.com/apache/freemarker/pull/58#issuecomment-506079877 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [freemarker] vocatan opened a new pull request #59: fix very small grammar issue

2019-07-10 Thread GitBox
vocatan opened a new pull request #59: fix very small grammar issue URL: https://github.com/apache/freemarker/pull/59 "useful when you developing non-HTML templates" -> "useful when you **are** developing non-HTML templates" "useful when you developing HTML templates" -> "useful when

[GitHub] [freemarker] ddekany merged pull request #59: fix very small grammar issue

2019-07-11 Thread GitBox
ddekany merged pull request #59: fix very small grammar issue URL: https://github.com/apache/freemarker/pull/59 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [freemarker] tokuhirom opened a new pull request #60: Make `js_string` more safety.

2019-09-18 Thread GitBox
tokuhirom opened a new pull request #60: Make `js_string` more safety. URL: https://github.com/apache/freemarker/pull/60 I want to escape the `'` and `"` in hex way. For example, there's a template like this. <#assign v='"'>

[GitHub] [freemarker] ddekany commented on issue #60: Make `js_string` more safety.

2019-09-18 Thread GitBox
ddekany commented on issue #60: Make `js_string` more safety. URL: https://github.com/apache/freemarker/pull/60#issuecomment-532982038 If we are talking about security, you should use auto-escaping (https://freemarker.apache.org/docs/dgui_quickstart_template.html#dgui_quickstart_template_a

[GitHub] [freemarker-docgen] dependabot[bot] opened a new pull request #1: Bump eslint-utils from 1.4.0 to 1.4.3

2019-11-01 Thread GitBox
dependabot[bot] opened a new pull request #1: Bump eslint-utils from 1.4.0 to 1.4.3 URL: https://github.com/apache/freemarker-docgen/pull/1 Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.4.0 to 1.4.3. Commits - [`23f4ddc`](https://github.com/mysticat

[GitHub] [freemarker] quaff opened a new pull request #61: Fix typo

2019-12-03 Thread GitBox
quaff opened a new pull request #61: Fix typo URL: https://github.com/apache/freemarker/pull/61 ?count should be ?counter This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [freemarker] ddekany merged pull request #61: Fix typo

2019-12-05 Thread GitBox
ddekany merged pull request #61: Fix typo URL: https://github.com/apache/freemarker/pull/61 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [freemarker] galusben opened a new pull request #62: add unsafe method java.security.ProtectionDomain.getClassLoader

2019-12-09 Thread GitBox
galusben opened a new pull request #62: add unsafe method java.security.ProtectionDomain.getClassLoader URL: https://github.com/apache/freemarker/pull/62 See https://ackcent.com/blog/in-depth-freemarker-template-injection/

[GitHub] [freemarker] DreamSkyOk opened a new pull request #63: 2.3.29 maintenance

2019-12-11 Thread GitBox
DreamSkyOk opened a new pull request #63: 2.3.29 maintenance URL: https://github.com/apache/freemarker/pull/63 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [freemarker] DreamSkyOk commented on issue #63: 2.3.29 maintenance

2019-12-11 Thread GitBox
DreamSkyOk commented on issue #63: 2.3.29 maintenance URL: https://github.com/apache/freemarker/pull/63#issuecomment-564821122 add new field pathClassicCompatible for control singly the paths parameter of include or import whether classicCompatible.

[GitHub] [freemarker] DreamSkyOk removed a comment on issue #63: 2.3.29 maintenance

2019-12-11 Thread GitBox
DreamSkyOk removed a comment on issue #63: 2.3.29 maintenance URL: https://github.com/apache/freemarker/pull/63#issuecomment-564821122 add new field pathClassicCompatible for control singly the paths parameter of include or import whether classicCompatible.

[GitHub] [freemarker] aschi opened a new pull request #64: fix constructor of ExtendedDecimalFormatParser

2019-12-19 Thread GitBox
aschi opened a new pull request #64: fix constructor of ExtendedDecimalFormatParser URL: https://github.com/apache/freemarker/pull/64 use DecimalFormatSymbols.getInstance(locale) instead of the constructor to properly work with other DecimalFormatSymbolsProvider implementations. S

[GitHub] [freemarker] ddekany commented on issue #62: add unsafe method java.security.ProtectionDomain.getClassLoader

2020-01-04 Thread GitBox
ddekany commented on issue #62: add unsafe method java.security.ProtectionDomain.getClassLoader URL: https://github.com/apache/freemarker/pull/62#issuecomment-570794868 I close this, as it's not this simple to address this problem. Anyone interested in the status of this, see this: https:

[GitHub] [freemarker] ddekany closed pull request #62: add unsafe method java.security.ProtectionDomain.getClassLoader

2020-01-04 Thread GitBox
ddekany closed pull request #62: add unsafe method java.security.ProtectionDomain.getClassLoader URL: https://github.com/apache/freemarker/pull/62 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [freemarker] galusben commented on issue #62: add unsafe method java.security.ProtectionDomain.getClassLoader

2020-01-10 Thread GitBox
galusben commented on issue #62: add unsafe method java.security.ProtectionDomain.getClassLoader URL: https://github.com/apache/freemarker/pull/62#issuecomment-572925085 I know it is not simple to address, but it adds a quick fix to something many are exposed to. I agree that the trust lev

[GitHub] [freemarker] galusben edited a comment on issue #62: add unsafe method java.security.ProtectionDomain.getClassLoader

2020-01-10 Thread GitBox
galusben edited a comment on issue #62: add unsafe method java.security.ProtectionDomain.getClassLoader URL: https://github.com/apache/freemarker/pull/62#issuecomment-572925085 I know it is not simple to address, but it adds a quick fix to something many are exposed to. I agree that the tr

[GitHub] [freemarker] ddekany commented on issue #62: add unsafe method java.security.ProtectionDomain.getClassLoader

2020-01-10 Thread GitBox
ddekany commented on issue #62: add unsafe method java.security.ProtectionDomain.getClassLoader URL: https://github.com/apache/freemarker/pull/62#issuecomment-573131352 The recipe in that blog entry won't work anymore with the next release (2.3.30). But it's addressed differently (and some

[GitHub] [freemarker] galusben commented on issue #62: add unsafe method java.security.ProtectionDomain.getClassLoader

2020-01-11 Thread GitBox
galusben commented on issue #62: add unsafe method java.security.ProtectionDomain.getClassLoader URL: https://github.com/apache/freemarker/pull/62#issuecomment-573319401 Cool. Thanks! This is an automated message from the Apa

[GitHub] [freemarker] ddekany merged pull request #64: fix constructor of ExtendedDecimalFormatParser

2020-01-12 Thread GitBox
ddekany merged pull request #64: fix constructor of ExtendedDecimalFormatParser URL: https://github.com/apache/freemarker/pull/64 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [freemarker] ddekany commented on issue #63: 2.3.29 maintenance

2020-01-14 Thread GitBox
ddekany commented on issue #63: 2.3.29 maintenance URL: https://github.com/apache/freemarker/pull/63#issuecomment-574501015 Looks like a quite special need. Can you tell about the use case? This is an automated message from th

[GitHub] [freemarker] Jaaap opened a new pull request #65: Freemarker 35

2020-04-08 Thread GitBox
Jaaap opened a new pull request #65: Freemarker 35 URL: https://github.com/apache/freemarker/pull/65 Support for Java8 temporal formatting (from temporal to string). The supported temporal types are: java.time.Instant; java.time.LocalDate; java.time.LocalDateTime; java.tim

[GitHub] [freemarker] ddekany closed pull request #60: Make `js_string` more safety.

2020-04-11 Thread GitBox
ddekany closed pull request #60: Make `js_string` more safety. URL: https://github.com/apache/freemarker/pull/60 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [freemarker] ddekany merged pull request #65: Freemarker 35

2020-04-11 Thread GitBox
ddekany merged pull request #65: Freemarker 35 URL: https://github.com/apache/freemarker/pull/65 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [freemarker] DreamSkyOk commented on issue #63: 2.3.29 maintenance

2020-04-15 Thread GitBox
DreamSkyOk commented on issue #63: 2.3.29 maintenance URL: https://github.com/apache/freemarker/pull/63#issuecomment-613925546 > Looks like a quite special need. Can you tell about the use case? > Looks like a quite special need. Can you tell about the use case? for thi

[GitHub] [freemarker] DreamSkyOk edited a comment on issue #63: 2.3.29 maintenance

2020-04-15 Thread GitBox
DreamSkyOk edited a comment on issue #63: 2.3.29 maintenance URL: https://github.com/apache/freemarker/pull/63#issuecomment-613925546 > Looks like a quite special need. Can you tell about the use case? > Looks like a quite special need. Can you tell about the use case?

[GitHub] [freemarker] DreamSkyOk edited a comment on issue #63: 2.3.29 maintenance

2020-04-15 Thread GitBox
DreamSkyOk edited a comment on issue #63: 2.3.29 maintenance URL: https://github.com/apache/freemarker/pull/63#issuecomment-613925546 > Looks like a quite special need. Can you tell about the use case? > Looks like a quite special need. Can you tell about the use case?

[GitHub] [freemarker] DreamSkyOk edited a comment on issue #63: 2.3.29 maintenance

2020-04-15 Thread GitBox
DreamSkyOk edited a comment on issue #63: 2.3.29 maintenance URL: https://github.com/apache/freemarker/pull/63#issuecomment-613925546 @ddekany > Looks like a quite special need. Can you tell about the use case? for this, when use classic_compatible model, the #include in ftl file

[GitHub] [freemarker] ddekany commented on issue #63: 2.3.29 maintenance

2020-04-16 Thread GitBox
ddekany commented on issue #63: 2.3.29 maintenance URL: https://github.com/apache/freemarker/pull/63#issuecomment-614467635 What I meant is that using `classic_compatible` in 2020 is already a quite special need (or I hope so), and then, using that, but not expecting exactly the classic be

[GitHub] [freemarker] alexkarezin opened a new pull request #66: Linking project overview dashboard to README

2020-04-30 Thread GitBox
alexkarezin opened a new pull request #66: URL: https://github.com/apache/freemarker/pull/66 Adding a link to the README header. The linked dashboard describes overall repository structure. The goal is to help new developers explore project and understand architecture/dependencies. Direct

[GitHub] [freemarker] ddekany commented on pull request #66: Linking project overview dashboard to README

2020-05-01 Thread GitBox
ddekany commented on pull request #66: URL: https://github.com/apache/freemarker/pull/66#issuecomment-622368080 I would refrain from promoting development tools, especially on a place associated with the ASF, unless they already had significant role in the development. Also, I think

[GitHub] [freemarker] rototor opened a new pull request #67: Implement a #ftl onlyIncludeOnce setting.

2020-05-21 Thread GitBox
rototor opened a new pull request #67: URL: https://github.com/apache/freemarker/pull/67 Using this setting allows files to be only included and interpreted once. This is the freemarker equivalent of MS C++ ```[#pragma once]```. Which was a fix for the common C-header pattern:

[GitHub] [freemarker] ddekany commented on pull request #67: Implement a #ftl onlyIncludeOnce setting.

2020-05-22 Thread GitBox
ddekany commented on pull request #67: URL: https://github.com/apache/freemarker/pull/67#issuecomment-632887321 `#import` has that feature (among others), and is generally recommended if you need many macros/functions. Was that considered? -

[GitHub] [freemarker] rototor commented on pull request #67: Implement a #ftl onlyIncludeOnce setting.

2020-05-23 Thread GitBox
rototor commented on pull request #67: URL: https://github.com/apache/freemarker/pull/67#issuecomment-633005977 Using ```#import``` in the first place would have made sense. But changing our 65k lines freemarker template codebase, which built up the last 10 years, to use ```#import``` ins

[GitHub] [freemarker] ddekany commented on pull request #67: Implement a #ftl onlyIncludeOnce setting.

2020-05-23 Thread GitBox
ddekany commented on pull request #67: URL: https://github.com/apache/freemarker/pull/67#issuecomment-633016699 The idea of `#include` was simply to behave as if you have copy-pasted the other template there. That's a very simple concept to understand for the users. But it becomes unwieldy

  1   2   >