[ pull request closed by mmartell ]
[ Full content available at: https://github.com/apache/geode-native/pull/411 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
What's the difference between the two cases when service is not null and
service is null? The error messages are the same. However one is a info, and
the other is an error. I assume the messages would be different. Would you
please explain a bit more?
[ Full content available at:
It looks like we will be setting empty string ("") as asyncId, if the queue
becomes empty after removal, do we need a check for empty queue here.
[ Full content available at: https://github.com/apache/geode/pull/2905 ]
This message was relayed via gitbox.apache.org for
Good idea. We will change the name to "pooledDataSource"
[ Full content available at: https://github.com/apache/geode/pull/2907 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by nabarunnag ]
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/10
]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
upthewaterspout closed pull request #8: Clean up prerequisites documentation.
URL: https://github.com/apache/geode-benchmarks/pull/8
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
We will change it to GfshCommand since this command does not change cluster
config
[ Full content available at: https://github.com/apache/geode/pull/2907 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by dschneider-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/2905 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has
The only failure here appears to be
https://issues.apache.org/jira/browse/GEODE-6046
The JIRA is still open.
[ Full content available at: https://github.com/apache/geode/pull/2917 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
nabarunnag opened a new pull request #10: GEODE-6084: Adding mulitple key put
and get benchmark.
URL: https://github.com/apache/geode-benchmarks/pull/10
This is an automated message from the Apache Git Service.
To respond
CacheJTAPooledDataSourceFactory is a test implementation of the public
PooledDataSourceFactory interface. This test is not attempting to test our
default hikari implementation. Instead we just wanted a simple test
implementation that uses embedded derby so that everything can be in a single
Old versions are only used by tests, not any production runtime. Do not
publish to Maven that we need it for all runtime. Mark the modules that
need old-versions for testing appropriately.
Authored-by: Robert Houghton
Thank you for submitting a contribution to Apache Geode.
In order to
* Move all dunit internals to test.dunit.internal package.
* Move VersionManager to test.version package.
* Rename some classes to be more informative.
* Reduce public to package-protected where it's appropriate.
[ Full content available at: https://github.com/apache/geode/pull/2919 ]
This
In that case we set this attribute to the empty string which means it has no
asyncQueueIds. We have a unit test that confirms this. So I don't see any need
to check for an empty queue here. The String.join call handles it correctly.
[ Full content available at:
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/10
]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by PurelyApplied ]
[ Full content available at: https://github.com/apache/geode/pull/2917 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Commits temporarily left un-squashed to better follow changes, if desired. I
will certainly squash before any merge.
[ Full content available at: https://github.com/apache/geode/pull/2920 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
There should be no change in execution logic. Methods were extracted, typos
corrected in field names, and such, but an actual fix to the suspect string
scanning is intended as a future PR.
[ Full content available at: https://github.com/apache/geode/pull/2920 ]
This message was relayed via
Delete SingleHopClientExecutorWithLoggingIntegrationTest_log4j2.xml
[ Full content available at: https://github.com/apache/geode/pull/2916 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
done
[ Full content available at: https://github.com/apache/geode/pull/2907 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has
* Check putIfAbsent return value from server if it could caused by retry.
* Make sure client putIfAbsent operation message.isRetry is set if it retries
after failed when using singleHop.
[ Full content available at: https://github.com/apache/geode/pull/2925 ]
This message was relayed via
Multiple regions can be configured to have same AsyncEventQueue; Not sure if
jdbc connector allows multiple regions to have the same async queue; if it
allows, it will be good to have tests that make sure the event queue mapping
is removed from only the expected region.
[ Full content
create jdbc-mapping always creates a unique queue for each region. It is
1-to-1. It does not support sharing a single queue on multiple regions.
[ Full content available at: https://github.com/apache/geode/pull/2905 ]
This message was relayed via gitbox.apache.org for
upthewaterspout closed pull request #9: Allowing JVM options to be set by test
URL: https://github.com/apache/geode-benchmarks/pull/9
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
[ pull request closed by upthewaterspout ]
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/9 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
nabarunnag opened a new pull request #11: GEODE-6106: Adding spotless and rat
to the benchmark build.
URL: https://github.com/apache/geode-benchmarks/pull/11
This is an automated message from the Apache Git Service.
To
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/11
]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
We looked into changing the OK status from servers into ERROR to make it more
clear when individual servers have issues, but this causes problems with the
CliFunctionResult resolution in gfsh which disrupts behavior with the
"ifExists" flag. Basically, if all the servers return the ERROR status
nabarunnag commented on issue #11: GEODE-6106: Adding spotless and rat to the
benchmark build.
URL: https://github.com/apache/geode-benchmarks/pull/11#issuecomment-443052710
This PR contains mostly cosmetic changes except in
build.gradle
spotless.gradle
rat.gradle
the etc
This PR contains mostly cosmetic changes except in
build.gradle
spotless.gradle
rat.gradle
the etc folder
and the gradle folder
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/11
]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by nabarunnag ]
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/11
]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Throwing an exception works and is what create jndi-binding does. Also the
EntityNotFoundException has special handling in gfsh to support "--ifexist" so
I think we should stick with throwing the exception. You could submit a
refactor request that all the gfsh commands that throw
ditto
[ Full content available at: https://github.com/apache/geode/pull/2918 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by nabarunnag ]
[ Full content available at: https://github.com/apache/geode/pull/2910 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I do think there should be tests for this, I just wanted to see if I would
break anything else by doing this before putting too much time into unit tests
for it
[ Full content available at: https://github.com/apache/geode/pull/2923 ]
This message was relayed via gitbox.apache.org for
MANAGE was the permission on destroy jndi-binding which this command used as a
template.
I think MANAGE makes more sense than WRITE. I think WRITE has to do with
changing user data (i.e. doing a put on a region). MANAGE allows you to change
configuration but not user data.
[ Full content
We broke this unit test:
org.apache.geode.management.internal.cli.commands.DestroyJndiBindingCommandTest
> whenMembersFoundAndNoClusterConfigRunningThenOnlyInvokeFunction FAILED
java.lang.ClassCastException: [Ljava.lang.Object; cannot be cast to
java.lang.String
at
This comment came from DestroyJndiBinding. We will update it.
[ Full content available at: https://github.com/apache/geode/pull/2918 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
That issue no longer exists because I have seen locator processes outlive gfsh.
But there is another issue with this implementation, which is that ctrl-c with
text in the prompt kills gfsh instead of just getting rid of the text like a
normal terminal does, which would be extremely frustrating
Because the existing "destroy jndi-binding" did not want to report a problem if
a server did not have the jndi-binding. This also looked wrong to us but we
were concerned about changing the behaviour of an existing command. However,
destroy jndi-binding only fails if all the servers fail. So it
After looking over this, there is no code path which would allow us to attempt
updating cluster config in the event the binding is not found within cluster
config.
@jchen21 The reason you might see those two messages together is in the event
that there are no servers but cluster config is
@kirklund Do you know why SIGINT was being tossed?
[ Full content available at: https://github.com/apache/geode/pull/2923 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has
I think SpringShell which GFSH extends has or had a bug (possibly caused by the
version of JLine it uses) which caused CTRL-C of GFSH to also terminate any
processes that GFSH had launched. I'm not sure if this problem still exists or
if it was specific to an OS or version of an OS. Jens may
I agree with @jdeppe-pivotal that a process started in the foreground should be
logging to stdout. The intent of the command is to make it easier to run geode
in containers and allow the "platform" to collect and manage logs. For
example, see the `docker logs` command:
I think SpringShell which GFSH extends has or had a bug (possibly caused by the
version of JLine it uses) which caused CTRL-C of GFSH to also terminate any
processes that GFSH had launched. I'm not sure if this problem still exists.
Jens may know more about it -- I think he was working on the
The "Change" message is a recent addition of the management team. It is not
part of this pull request. But what we can do is change our implementation of
updateConfigForGroup to return false in this case instead of true.
[ Full content available at: https://github.com/apache/geode/pull/2918 ]
[ pull request closed by nabarunnag ]
[ Full content available at: https://github.com/apache/geode/pull/2909 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has
I think it just allows you to run all gfsh tests from gradle. We also have a
category for jdbcTests and a chore that we should add it to all the jdbc
commands.
[ Full content available at: https://github.com/apache/geode/pull/2918 ]
This message was relayed via gitbox.apache.org for
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has
Instead of throwing exception, how about put the exception in CliFunctionResult?
[ Full content available at: https://github.com/apache/geode/pull/2918 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Why the status here is still `OK`?
[ Full content available at: https://github.com/apache/geode/pull/2918 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I am not sure whether it should be `ResourcePermission.Operation.MANAGE` or
`ResourcePermission.Operation.WRITE`.
[ Full content available at: https://github.com/apache/geode/pull/2918 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
What is this test category `GfshTest` for? I don't see it in the other data
source command dunit tests. e.g. `ListDataSourceCommandDUnitTest`. If it is
something we need, we'd better add it other dunit tests as well for consistency.
[ Full content available at:
Just a minor pick. The CC in the comments stands for "Cluster Config"?
[ Full content available at: https://github.com/apache/geode/pull/2918 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Instead of throwing exception, how about put the exception in
`CliFunctionResult`?
[ Full content available at: https://github.com/apache/geode/pull/2918 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
"No members found." and "Changes to configuration for group 'cluster' are
persisted." This doesn't make sense. If no members found, then there is no
change. We should make some change in the product code.
[ Full content available at: https://github.com/apache/geode/pull/2918 ]
This message was
These acceptance test failures look unrelated to this pr and will probably pass
if run again:
org.apache.geode.management.internal.cli.commands.StopServerAcceptanceTest >
cannotStopServerByNameWhenNotConnected FAILED
org.junit.ComparisonFailure: expected:<[0]> but was:<[1]>
at
My preference would be to NOT pollute stdout with all the log data and keep
the logs going to the file they normally would. Otherwise, I will end up
having to redirect stdout to somewhere and can't see what it says without
tailing that file. It would also potentially make it more difficult to
…tend GfshCommand
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit
@Petahhh @aditya87 For your review
[ Full content available at: https://github.com/apache/geode/pull/2927 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
…ResultModel
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit
@Petahhh @aditya87 For your review.
[ Full content available at: https://github.com/apache/geode/pull/2926 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Good idea
[ Full content available at: https://github.com/apache/geode/pull/2907 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
68 matches
Mail list logo
