@aditya87 - for your review
[ Full content available at: https://github.com/apache/geode/pull/3083 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
@aditya87 @Petahhh
[ Full content available at: https://github.com/apache/geode/pull/3088 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
…ster management service to actually create the region
* inject cluster management service to the rest controller
* have the controller produce json string for response
* refactor the controller exception handler to always send back json string
Thank you for submitting a contribution to Apache
[ pull request closed by kirklund ]
[ Full content available at: https://github.com/apache/geode/pull/3068 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
smgoller merged pull request #43: GEODE-6147 - Fail benchmark task if average
latency change is 5+%
URL: https://github.com/apache/geode-benchmarks/pull/43
This is an automated message from the Apache Git Service.
To
[ pull request closed by kirklund ]
[ Full content available at: https://github.com/apache/geode/pull/3073 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This PR needs to wait for PR #3087 to be merged in.
[ Full content available at: https://github.com/apache/geode/pull/3071 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
* Change ratio to difference
* Add difference calculation to ProbeResult
* Fail analyzeRun task if average latency difference is >= 5%
Authored-by: Sean Goller
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/43
]
This message was relayed via gitbox.apache.org for
[ pull request closed by smgoller ]
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/43
]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by smgoller ]
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/42
]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by smgoller ]
[ Full content available at: https://github.com/apache/geode/pull/3085 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
smgoller merged pull request #42: GEODE-6276: use named cli options for scripts
URL: https://github.com/apache/geode-benchmarks/pull/42
This is an automated message from the Apache Git Service.
To respond to the message,
smgoller opened a new pull request #43: GEODE-6147 - Fail benchmark task if
average latency change is 5+%
URL: https://github.com/apache/geode-benchmarks/pull/43
* Change ratio to difference
* Add difference calculation to ProbeResult
* Fail analyzeRun task if average latency
It seems a bit redundant having 'CacheElement' in the name of these methods.
It's also not entirely accurate seeing that the methods will result in both
persistence and realization.
[ Full content available at: https://github.com/apache/geode/pull/3088 ]
This message was relayed via
It seems a bit redundant having 'CacheElement' in the name of these methods.
It's also not entirely accurate seeing that the methods will result in both
persistence and realization. I think they'd be better as just `cerate`,
`update` and `delete`
[ Full content available at:
It seems a bit redundant having 'CacheElement' in the name of these methods.
It's also not entirely accurate seeing that the methods will result in both
persistence and realization. I think they'd be better as just `create`,
`update` and `delete`.
[ Full content available at:
It seems a bit redundant having 'CacheElement' in the name of these methods.
It's also not entirely accurate seeing that the methods will result in both
persistence and realization. I think they'd be better as just `create`,
`update` and `delete`
[ Full content available at:
[ pull request closed by davebarnes97 ]
[ Full content available at: https://github.com/apache/geode-native/pull/435 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
should this be T instead?
[ Full content available at: https://github.com/apache/geode/pull/3083 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Seems more obvious to just use a `Properties` object here. I don't know why we
made the underlying methods use an array of (implicit) `Object[2]` arguments.
[ Full content available at: https://github.com/apache/geode/pull/3088 ]
This message was relayed via gitbox.apache.org for
What is `V` supposed to be? `V extends *SomeSpecificType` or `V extends
Object`? Without declaration of what `V` is, you might just as well return
`Object`
[ Full content available at: https://github.com/apache/geode/pull/3083 ]
This message was relayed via gitbox.apache.org for
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has
* Add default for branch under test
* Fetch dependencies before running benchmarks.
Authored-by: Sean Goller
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/45
]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
smgoller opened a new pull request #45: Fix defaults and dependencies.
URL: https://github.com/apache/geode-benchmarks/pull/45
* Add default for branch under test
* Fetch dependencies before running benchmarks.
Authored-by: Sean Goller
I see the need to move this functionality out of here. We can probably
completely get rid of this method, and have an instantiator to instantiate the
instance. e.g.
```
mutator.setCacheLoader(ConfigInstantiator.instantiate(config, cache));
```
[ Full content available at:
Maybe `T extends Declarable`
[ Full content available at: https://github.com/apache/geode/pull/3083 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ Full content available at: https://github.com/apache/geode/pull/3083 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
just to avoid having to create a Property and manipulate it based on what
webapp it is. one webapp only requires security service, another requires
security service and sslConfig, and another requires securityService and
managementService. So instead of
```
Properties properties = new
Yes - thanks!
[ Full content available at: https://github.com/apache/geode/pull/3083 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Doesn't seem to be syntactically possible, but my Generic foo is weak...
[ Full content available at: https://github.com/apache/geode/pull/3083 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
PdxInstance.equals will only act as if an instance has a field
with the default value if the class name is not empty.
If the class name is empty it will now require that both instances
have all the same identity fields.
Thank you for submitting a contribution to Apache Geode.
In order to
you'll have to define the `ConfigTypeInstantiator` as follows:
`public interface ConfigTypeInstantiator{
V newInstance(T type)
}`
and then the `DeclarableTypeInstantiator` can become:
`public class DeclarableTypeInstantiator implements
ConfigTypeInstantiator{
@Override
public T
you'll have to define the `ConfigTypeInstantiator` as follows:
`public interface ConfigTypeInstantiator{
V newInstance(T type)
}`
and then the `DeclarableTypeInstantiator` can become:
`public class DeclarableTypeInstantiator implements
ConfigTypeInstantiator{
@Override
public T
you'll have to define the `ConfigTypeInstantiator` as follows:
`public interface ConfigTypeInstantiator{
V newInstance(T type)
}`
and then the `DeclarableTypeInstantiator` can become:
`public class DeclarableTypeInstantiator implements
ConfigTypeInstantiator{
@Override
public T
We cannot change this method declaration. :( public API... or at least this
Class is not in the "internal" namespace and therefore can be seen as public.
We'd have to deprecate this in favor of the alternative of asking the
`ConfigTypeInstantiator` create this instance
[ Full content available
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has
smgoller opened a new pull request #44: Add ability to fetch dependencies.
URL: https://github.com/apache/geode-benchmarks/pull/44
Authored-by: Sean Goller
This is an automated message from the Apache Git Service.
To respond
smgoller merged pull request #44: Add ability to fetch dependencies.
URL: https://github.com/apache/geode-benchmarks/pull/44
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[ pull request closed by smgoller ]
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/44
]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Authored-by: Sean Goller
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/44
]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has
[ pull request closed by dschneider-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/3089 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by smgoller ]
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/45
]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
smgoller merged pull request #45: Fix defaults and dependencies.
URL: https://github.com/apache/geode-benchmarks/pull/45
This is an automated message from the Apache Git Service.
To respond to the message, please log on
- This test was failing fairly consistently on Windows. An initial assumption
was that the given port range would be completely free. This is typically
true in a Linux/Docker environment but is not the case on Windows.
- The logic of these modified tests is somewhat extreme as in actual use,
sounds good.
[ Full content available at: https://github.com/apache/geode/pull/3088 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by bschuchardt ]
[ Full content available at: https://github.com/apache/geode/pull/3051 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by kirklund ]
[ Full content available at: https://github.com/apache/geode/pull/3087 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This came from an internal ticket from a Pivotal customer: GEM-2367
[ Full content available at: https://github.com/apache/geode/pull/3094 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by dschneider-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/3090 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pivotal-eshu ]
[ Full content available at: https://github.com/apache/geode/pull/3082 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
smgoller opened a new pull request #46: Add debugging because reasons.
URL: https://github.com/apache/geode-benchmarks/pull/46
Authored-by: Sean Goller
This is an automated message from the Apache Git Service.
To respond to
[ pull request closed by smgoller ]
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/46
]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Authored-by: Sean Goller
[ Full content available at: https://github.com/apache/geode-benchmarks/pull/46
]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
smgoller merged pull request #46: Add debugging because reasons.
URL: https://github.com/apache/geode-benchmarks/pull/46
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Added a 1 second pause before retrying if no locators could
be contacted and locator-wait-time has been set.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all
This is needed in order to disable JMX in
PersistentPartitionedRegionRegressionTest which will then prevent that test
from deadlocking in the JMX ManagementListener.
[ Full content available at: https://github.com/apache/geode/pull/3095 ]
This message was relayed via gitbox.apache.org for
The cause of the hang in GEODE-6232 is lock ordering that involves JMX
ManagementListener. Since PersistentPartitionedRegionRegressionTest does not
need JMX, this change will disable JMX in the test.
Requires PR #3095 to be merged first. The commit in that PR is included in this
PR's branch.
58 matches
Mail list logo
