[GitHub] [geode] joeymcallister commented on pull request #3932: GEODE 6872: Add Non-Sticky configuration information to Tomcat Session module documentation

2019-08-16 Thread GitHub
I'm confused about changing the title to "non-sticky" and changing the description to "non-stick." [ Full content available at: https://github.com/apache/geode/pull/3932 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt closed pull request #3933: GEODE-7090: Copy message to isolate filter info calculation

2019-08-16 Thread GitHub
[ pull request closed by mcmellawatt ] [ Full content available at: https://github.com/apache/geode/pull/3933 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] bschuchardt closed pull request #3930: DO NOT REVIEW: Remove dependency on DataSerializer from membership classes

2019-08-16 Thread GitHub
[ pull request closed by bschuchardt ] [ Full content available at: https://github.com/apache/geode/pull/3930 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund closed pull request #3904: GEODE-7070: Remove AlertAppender usage from GMSMembershipManager

2019-08-16 Thread GitHub
[ pull request closed by kirklund ] [ Full content available at: https://github.com/apache/geode/pull/3904 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on issue #3904: GEODE-7070: Remove AlertAppender usage from GMSMembershipManager

2019-08-16 Thread GitHub
Closing this PR to investigate potential for appender recursion more. [ Full content available at: https://github.com/apache/geode/pull/3904 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on issue #3921: GEODE-7083: Adds statistics to PeerTypeRegistration

2019-08-16 Thread GitHub
I defaulted to the interface and class name but don’t have a strong preference either way. PDX is likely more recognizable by customers. [ Full content available at: https://github.com/apache/geode/pull/3921 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt opened pull request #3939: GEODE-7088: Copy message to isolate filter info calculation

2019-08-16 Thread GitHub
This fix is to handle a very specific race condition scenario as described here: Subscription HA is enabled and a server is providing a client queue image to a peer (serializing the queue). Meanwhile, a client is also just finished client subscription registration with that same server and is

[GitHub] [geode] upthewaterspout opened pull request #3940: GEODE-7085: Add dunit test of recovery with large versions

2019-08-16 Thread GitHub
Adding a dunit test that we can recover from disk store files with a large gc version. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a

[GitHub] [geode-native] codecov-io commented on issue #510: GEODE-7086: coding impacts for support of IPv6

2019-08-16 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/geode-native/pull/510?src=pr=h1) Report > Merging > [#510](https://codecov.io/gh/apache/geode-native/pull/510?src=pr=desc) > into > [develop](https://codecov.io/gh/apache/geode-native/commit/be5013eee46360fa8a962fe4f7da91de22bd83cf?src=pr=desc) > will

[GitHub] [geode] joeymcallister commented on pull request #3932: GEODE 6872: Add Non-Sticky configuration information to Tomcat Session module documentation

2019-08-16 Thread GitHub
I don't have a strong preference between "non-sticky" and "non-stick," but I do think that we ought to use one term consistently, both within this section/page and across other pages within the documentation. [ Full content available at: https://github.com/apache/geode/pull/3932 ] This message

[GitHub] [geode] joeymcallister commented on pull request #3932: GEODE 6872: Add Non-Sticky configuration information to Tomcat Session module documentation

2019-08-16 Thread GitHub
"compilter" > "compiler" [ Full content available at: https://github.com/apache/geode/pull/3932 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill commented on issue #3937: GEODE-7092: increase flaky test MEMBER_TIMEOUT

2019-08-16 Thread GitHub
@mcmellawatt please review and merge if you are happy [ Full content available at: https://github.com/apache/geode/pull/3937 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] demery-pivotal opened pull request #3942: GEODE-7099: Clean up MeterSubregistryReconnectDistributedTest

2019-08-16 Thread GitHub
Co-authored-by: Dale Emery Co-authored-by: Kirk Lund Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this

[GitHub] [geode] jinmeiliao commented on issue #3936: GEODE-6945: expand the type to related xml attributes

2019-08-16 Thread GitHub
@dschneider-pivotal please re-review. I changed the approach: instead of not expanding the attributes in `CreateRegionCommand`, I chose to expand it everywhere, including the `RegionConverter`. This is because I found the subsequent code kind of relying on the DataPolicy being set all the time

[GitHub] [geode] mcmellawatt closed pull request #3937: GEODE-7092: increase flaky test MEMBER_TIMEOUT

2019-08-16 Thread GitHub
[ pull request closed by mcmellawatt ] [ Full content available at: https://github.com/apache/geode/pull/3937 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mcmellawatt closed pull request #3916: DO NOT REVIEW: Replacing queue map with list

2019-08-16 Thread GitHub
[ pull request closed by mcmellawatt ] [ Full content available at: https://github.com/apache/geode/pull/3916 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund closed pull request #3938: GEODE-7091: Add Micrometer binders to meter registry

2019-08-16 Thread GitHub
[ pull request closed by kirklund ] [ Full content available at: https://github.com/apache/geode/pull/3938 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] mivanac commented on pull request #510: GEODE-7086: coding impacts for support of IPv6

2019-08-16 Thread GitHub
Tried this proposal, and in test, in case hostname is not resolved, get_addr() returns pointer (it is not nullptr). [ Full content available at: https://github.com/apache/geode-native/pull/510 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org