[ pull request closed by jdeppe-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/4393 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Ok, I can reproduce the failure with string literal
`u8"SimpleCQ\xF0\x90\x90\x80"` as the CQ name. This UTF-8 sequence produces the
U+10400 character "Ѐ", which has two UTF-16 code points and results in 6 bytes
of JMUTF-8 rather then 4 bytes of UTF-8.
I also found a race condition in the new
I think the differences is the later approach would give user less
opportunities to create an invalid object to begin with, whereas the the
previous approach will let user create any combination of attributes and let
validator to catch all the invalid cases.
[ Full content available at:
[ pull request closed by davebarnes97 ]
[ Full content available at: https://github.com/apache/geode/pull/4390 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I respectfully disagree:
* Just as a ballpark estimate, developers on the team spend several minutes of
build time per day running clang-format on code. This doesn't strictly need to
be done until it's time to push.
* In point of fact, formatting is *not* enforced in the build, or at least not
add javadocs describing when it will throw
also describe that it will also set the type to...l
[ Full content available at: https://github.com/apache/geode/pull/4386 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by mhansonp ]
[ Full content available at: https://github.com/apache/geode/pull/4375 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Don't want PR builds for the moment.
[ Full content available at: https://github.com/apache/geode/pull/4375 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
To enable more granular re-run in Concourse, split the Benchmarks into
independently triggerable jobs in the main pipeline.
Extract variables from the template into the jinja.variables file.
Make better use of YML anchors.
Co-authored-by: Robert Houghton
Co-authored-by: Helena Bales
[ Full
> I'd be open to a solution that allowed this target or targets to be on by
> default if they can a) be explicitly turned off via cmake variable and b) run
> for the entire code base without doing backflips on the command line. Let me
> know what you think.
`$ cmake ...
JUnit Rule that provides an ExecutorService to each VM in a distributed
test. See javadocs of both DistributedExecutorServiceRule and
ExecutorServiceRule for more info.
[ Full content available at: https://github.com/apache/geode/pull/4397 ]
This message was relayed via gitbox.apache.org for
…eartBeatDontRemoveMember
Removing time-sensitive test. There are other tests that already
exercise the checkIfAvailable health-monitor method. Two of those tests make
sure that the initiateRemoval parameter (the last parameter) to
checkIfAvailable functions properly and that the value returned
This logic, to determine if a recipients array designates "all recipients" is
both unusual and repeated. So I recommend it be put into its own method.
Repeated here:
* `ClusterDistributionManager.sendViaMembershipManager()`
* `DistributionMessage.getRecipients()`
we also have
bravissimo!
[ Full content available at: https://github.com/apache/geode/pull/4384 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
`ALL_RECIPIENTS` should not be defined in this class because it's already
defined up in the `Message` interface
[ Full content available at: https://github.com/apache/geode/pull/4384 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ x ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ]
[ pull request closed by rhoughton-pivot ]
[ Full content available at: https://github.com/apache/geode/pull/4391 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
The use of [null] to represent "forAll" was made many years ago and I don't
want to mess with that just to remove this dependency.
[ Full content available at: https://github.com/apache/geode/pull/4384 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I missed that one - I'll address it in this ticket.
[ Full content available at: https://github.com/apache/geode/pull/4384 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
@Bill maybe make a ticket to improve this separate from this PR
[ Full content available at: https://github.com/apache/geode/pull/4384 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Powerfull IntelliJ
[ Full content available at: https://github.com/apache/geode/pull/4384 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
good name change
[ Full content available at: https://github.com/apache/geode/pull/4384 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Along with other cleanup
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
[ pull request closed by rhoughton-pivot ]
[ Full content available at: https://github.com/apache/geode/pull/4402 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Is the point of this test to verify that calling `checkIfAvailable(x,x,true)`
under the following conditions, returns `false`:
1. no heartbeats have been received from the member
2. we have not yet reached the first timeout time
Notwithstanding the reasoning in the description of this PR, I
getRecipientsDescription ought to be changed but it is only used in logging
[ Full content available at: https://github.com/apache/geode/pull/4384 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Subsequent calls to GemFireCacheImpl close will now block until the
first call to close completes.
Additional changes:
* Expand unit testing of GemFireCacheImpl
* Inject dependencies into GemFireCacheImpl constructor
* Cleanup existing tests of GemFireCacheImpl
[ Full content available at:
We could registerInterest in a common place for both user and internally
created session regions.
[ Full content available at: https://github.com/apache/geode/pull/4366 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
We could registerInterest in a common place for both user and internally
created session regions.
[ Full content available at: https://github.com/apache/geode/pull/4366 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Should this be pulled into a method? It would be self documenting (no comment
needed) if the method name was correctly chosen
[ Full content available at: https://github.com/apache/geode/pull/4385 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ Full content available at: https://github.com/apache/geode/pull/4409 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
DistributionImpl is part of geode-core. Should it be using AbstractGMSMessage
(not part of the geode-membership API).
[ Full content available at: https://github.com/apache/geode/pull/4384 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Shouldn't this be MemberIdentifier, not InternalDistributedMember?
[ Full content available at: https://github.com/apache/geode/pull/4384 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This pull request **fixes 1 alert** when merging
fc37449ca2f88d0e8cdf185ddd07a40d1ea825c4 into
c6081fa106697bf787e102f2f50a54ffdfcba726 - [view on
LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-b85c3d08033014a344231e0120e392239e9b3c58)
**fixed alerts:**
* 1 for Container contents
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [x] Has
Tweak to the version variable that links to the Wiki feature description -
needs to be geode-specific
[ Full content available at: https://github.com/apache/geode/pull/4412 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has
This pull request **fixes 5 alerts** when merging
edce714bf8fb9068270d05400f02d9d2194421d2 into
c6081fa106697bf787e102f2f50a54ffdfcba726 - [view on
LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-5c4c93a09671be971b517ec31191bb1109f639c3)
**fixed alerts:**
* 2 for Potential database
The bug.
[ Full content available at: https://github.com/apache/geode/pull/4409 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
39 matches
Mail list logo
