[ pull request closed by upthewaterspout ]
[ Full content available at: https://github.com/apache/geode/pull/4592 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Co-authored-by: Dale Emery
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
@jmelchio
[ Full content available at: https://github.com/apache/geode/pull/4596 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
> The behavior as described:
> ` list gateways --senders=false --receivers=false and any combination using
> "one true and one false" will be like running list gateways.`
>
> sounds odd to me... if one is true and the other false, i would expect it to
> run similar to list gateways
The IndexWriter initialization might fail when other threads are
updating the fileAndChunkRegion, which can be triggered by other normal
operations (query, event listener, close, reindex, etc.). This doesn't
happen often and, instead of propagating the exception to the caller
and failing, Geode
I realized that the parameters can have three states ( false, true and empty )
and I was trying to use a boolean to store that state. I fixed that, and I have
simplified the use cases:
* `list gateways --senders-only` and `list gateways --senders=true` will show
only senders.
* `list gateways
[ Full content available at: https://github.com/apache/geode/pull/4598 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Is it worth extracting this string to a constant in the `PartitionedRegion`
class so that it can be consistently referred to?
[ Full content available at: https://github.com/apache/geode/pull/4598 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
