[ pull request closed by jujoramos ]
[ Full content available at: https://github.com/apache/geode/pull/4677 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
The (!isHandShakeReader) test was added here to fix a race condition between
the handshake thread and an application thread using the thread-owned
Connection. I think this test needs to remain in place.
[ Full content available at: https://github.com/apache/geode/pull/4629 ]
This message was
good change here. It shouldn't be needed since a sharedResource will only
invoke this method if isReaderThread==true but having an explicit test is a
good idea.
[ Full content available at: https://github.com/apache/geode/pull/4629 ]
This message was relayed via gitbox.apache.org for
thanks for comments. I will return check on !isHandShakeReader.
[ Full content available at: https://github.com/apache/geode/pull/4629 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
updated
[ Full content available at: https://github.com/apache/geode/pull/4629 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Nice fix. The new test for this issue cache/cache_close_reopen.js now passes.
[ Full content available at: https://github.com/apache/geode-native/pull/575 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ Full content available at: https://github.com/apache/geode/pull/4694 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
can this be turned into an await()? Thread.sleep() often causes tests to fail.
[ Full content available at: https://github.com/apache/geode/pull/4629 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Now that this changes the exception thrown... will this affect any other parts
of function service? such as retries?
[ Full content available at: https://github.com/apache/geode/pull/4690 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Done.
[ Full content available at: https://github.com/apache/geode/pull/4691 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Done.
[ Full content available at: https://github.com/apache/geode/pull/4691 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Done.
[ Full content available at: https://github.com/apache/geode/pull/4691 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Done.
[ Full content available at: https://github.com/apache/geode/pull/4691 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This pull request **fixes 1 alert** when merging
0c2481710e236ece3fb9a73ed0d0012e8fd82481 into
5dd7a8420bbe43657abc82e5b8d073eb01b51d8d - [view on
LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-cd23ab437c68669216a66d4b525875f5cbcd690a)
**fixed alerts:**
* 1 for Dereferenced
Done.
[ Full content available at: https://github.com/apache/geode/pull/4691 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Done
[ Full content available at: https://github.com/apache/geode/pull/4691 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Done
[ Full content available at: https://github.com/apache/geode/pull/4691 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Done.
[ Full content available at: https://github.com/apache/geode/pull/4691 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This is a test code change. I don't think it will affect the product behavior
of function service.
When there is no server in the cluster, I don't think there is retry for
function service. It should throw `NoAvailableServersException`.
The NullPointerException(NPE) bug (GEODE-7746) can be
There's an extra line here that could be tidied up.
[ Full content available at: https://github.com/apache/geode/pull/4689 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I think this comment is probably no longer needed, as it was originally just a
placeholder and the thing it's describing is very self-explanatory.
[ Full content available at: https://github.com/apache/geode/pull/4689 ]
This message was relayed via gitbox.apache.org for
Done.
[ Full content available at: https://github.com/apache/geode/pull/4691 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has
[ pull request closed by mhansonp ]
[ Full content available at: https://github.com/apache/geode/pull/4691 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
StressNewTest failed with OOME:
org.apache.geode.internal.cache.DestroyRegionDuringGIIDistributedTest >
classMethod FAILED
java.lang.OutOfMemoryError: Java heap
[ Full content available at: https://github.com/apache/geode/pull/4698 ]
This message was relayed via gitbox.apache.org for
[ pull request closed by jinmeiliao ]
[ Full content available at: https://github.com/apache/geode/pull/4697 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Done.
[ Full content available at: https://github.com/apache/geode/pull/4689 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Done.
[ Full content available at: https://github.com/apache/geode/pull/4689 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Done.
[ Full content available at: https://github.com/apache/geode/pull/4689 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This is a test code change. I don't think it will affect the product behavior
of function service.
When there is no server in the cluster, I don't think there is retry for
function service. It should throw `NoAvailableServersException`.
The NullPointerException(NPE) bug (GEODE-7746) can be
30 matches
Mail list logo
