[GitHub] [geode] onichols-pivotal opened a new pull request #5155: Revert "GEODE-8175: removed list, sorted set, hyperLog and transaction redis commands and code"

2020-05-22 Thread GitBox
onichols-pivotal opened a new pull request #5155: URL: https://github.com/apache/geode/pull/5155 Reverts apache/geode#5146 which caused compile error This is an automated message from the Apache Git Service. To respond to

[GitHub] [geode] onichols-pivotal opened a new pull request #5156: GEODE-8175: fix compile error

2020-05-22 Thread GitBox
onichols-pivotal opened a new pull request #5156: URL: https://github.com/apache/geode/pull/5156 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode] onichols-pivotal merged pull request #5156: GEODE-8175: fix compile error

2020-05-22 Thread GitBox
onichols-pivotal merged pull request #5156: URL: https://github.com/apache/geode/pull/5156 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] onichols-pivotal commented on pull request #5155: Revert "GEODE-8175: removed list, sorted set, hyperLog and transaction redis commands and code"

2020-05-22 Thread GitBox
onichols-pivotal commented on pull request #5155: URL: https://github.com/apache/geode/pull/5155#issuecomment-632979104 easier to just fix, see #5156 This is an automated message from the Apache Git Service. To respond to

[GitHub] [geode] onichols-pivotal closed pull request #5155: Revert "GEODE-8175: removed list, sorted set, hyperLog and transaction redis commands and code"

2020-05-22 Thread GitBox
onichols-pivotal closed pull request #5155: URL: https://github.com/apache/geode/pull/5155 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] jvarenina commented on a change in pull request #5139: GEODE-8149: New parameter and property introduced

2020-05-22 Thread GitBox
jvarenina commented on a change in pull request #5139: URL: https://github.com/apache/geode/pull/5139#discussion_r429084330 ## File path: geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java ## @@ -2032,6 +2032,23 @@ * Default: empty. All

[GitHub] [geode] jvarenina commented on pull request #5139: GEODE-8149: New parameter and property introduced

2020-05-22 Thread GitBox
jvarenina commented on pull request #5139: URL: https://github.com/apache/geode/pull/5139#issuecomment-632540478 > This PR provides documentation at the Javadoc level. > Consider where in the User Guide this should be mentioned, then > > * add a User Guide explanation as part

[GitHub] [geode] albertogpz commented on pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

2020-05-22 Thread GitBox
albertogpz commented on pull request #4928: URL: https://github.com/apache/geode/pull/4928#issuecomment-632576516 > > > The problem with the doc comments was not that they were extensive, but that they got modified when you pasted the diff here and the resulting test was not a valid diff

[GitHub] [geode] lgtm-com[bot] commented on pull request #5146: removed list, sorted set, hyperLog and transaction redis commands and code

2020-05-22 Thread GitBox
lgtm-com[bot] commented on pull request #5146: URL: https://github.com/apache/geode/pull/5146#issuecomment-632547176 This pull request **fixes 1 alert** when merging 507b9db04a041a943fc28c1c6d0a1ee1e99f97fd into 358fd7067cc56b1ceb8c3d7c271c3a5254d7ee93 - [view on

[GitHub] [geode] mivanac opened a new pull request #5148: GEODE-8172: flaky test

2020-05-22 Thread GitBox
mivanac opened a new pull request #5148: URL: https://github.com/apache/geode/pull/5148 WIP Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5142: GEODE-8138: Improve semantics of the redis-port option

2020-05-22 Thread GitBox
sabbeyPivotal commented on a change in pull request #5142: URL: https://github.com/apache/geode/pull/5142#discussion_r429255221 ## File path: geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java ## @@ -1943,6 +1931,36 @@ * Default: "" */

[GitHub] [geode] ringles commented on a change in pull request #5146: removed list, sorted set, hyperLog and transaction redis commands and code

2020-05-22 Thread GitBox
ringles commented on a change in pull request #5146: URL: https://github.com/apache/geode/pull/5146#discussion_r429278269 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ## @@ -205,281 +98,27 @@ private boolean

[GitHub] [geode] bschuchardt commented on a change in pull request #5131: GEODE-8144: endpoint identification in servers is not working

2020-05-22 Thread GitBox
bschuchardt commented on a change in pull request #5131: URL: https://github.com/apache/geode/pull/5131#discussion_r429282471 ## File path: geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java ## @@ -791,7 +792,19 @@ private boolean

[GitHub] [geode] kohlmu-pivotal merged pull request #5136: GEODE-8137 - Implement loadService.

2020-05-22 Thread GitBox
kohlmu-pivotal merged pull request #5136: URL: https://github.com/apache/geode/pull/5136 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] bschuchardt commented on a change in pull request #5131: GEODE-8144: endpoint identification in servers is not working

2020-05-22 Thread GitBox
bschuchardt commented on a change in pull request #5131: URL: https://github.com/apache/geode/pull/5131#discussion_r429282471 ## File path: geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java ## @@ -791,7 +792,19 @@ private boolean

[GitHub] [geode] jdeppe-pivotal commented on pull request #5145: GEODE-8168: Redis pipelined command responses can be corrupted

2020-05-22 Thread GitBox
jdeppe-pivotal commented on pull request #5145: URL: https://github.com/apache/geode/pull/5145#issuecomment-632707135 @prettyClouds For your review... This is an automated message from the Apache Git Service. To respond to

[GitHub] [geode] bschuchardt commented on a change in pull request #5131: GEODE-8144: endpoint identification in servers is not working

2020-05-22 Thread GitBox
bschuchardt commented on a change in pull request #5131: URL: https://github.com/apache/geode/pull/5131#discussion_r429282471 ## File path: geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java ## @@ -791,7 +792,19 @@ private boolean

[GitHub] [geode] ladyVader commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

2020-05-22 Thread GitBox
ladyVader commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r429320060 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/CreateGatewaySenderCommand.java ## @@ -75,6 +75,11 @@ public

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5140: GEODE-8151: Convert hash commands to return RedisResponse

2020-05-22 Thread GitBox
jdeppe-pivotal commented on a change in pull request #5140: URL: https://github.com/apache/geode/pull/5140#discussion_r429265420 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/hash/HExistsExecutor.java ## @@ -53,12 +54,7 @@ public void

[GitHub] [geode] alb3rtobr opened a new pull request #5149: GEODE-8108: Remove System.out.println calls from geode-redis

2020-05-22 Thread GitBox
alb3rtobr opened a new pull request #5149: URL: https://github.com/apache/geode/pull/5149 Ticket description, reported by @dschneider-pivotal : > > I noticed in SMoveExecutor a number of System.out.println calls. This should not be done. > Either remove the calls (that is what I

[GitHub] [geode] karensmolermiller commented on a change in pull request #5147: GEODE-8171: javadoc for putAll need to have accurate exception

2020-05-22 Thread GitBox
karensmolermiller commented on a change in pull request #5147: URL: https://github.com/apache/geode/pull/5147#discussion_r429308490 ## File path: geode-core/src/main/java/org/apache/geode/cache/Region.java ## @@ -1359,10 +1359,30 @@ Object selectValue(String queryPredicate)

[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #5131: GEODE-8144: endpoint identification in servers is not working

2020-05-22 Thread GitBox
pivotal-jbarrett commented on a change in pull request #5131: URL: https://github.com/apache/geode/pull/5131#discussion_r429315845 ## File path: geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java ## @@ -791,7 +792,19 @@ private boolean

[GitHub] [geode] dschneider-pivotal merged pull request #5146: GEODE-8175: removed list, sorted set, hyperLog and transaction redis commands and code

2020-05-22 Thread GitBox
dschneider-pivotal merged pull request #5146: URL: https://github.com/apache/geode/pull/5146 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] dschneider-pivotal commented on pull request #5149: GEODE-8108: Remove System.out.println calls from geode-redis

2020-05-22 Thread GitBox
dschneider-pivotal commented on pull request #5149: URL: https://github.com/apache/geode/pull/5149#issuecomment-632960137 Thanks for this work. Can you resolve the conflicts in GeodeRedisServer? This is an automated message

[GitHub] [geode] onichols-pivotal opened a new pull request #5154: GEODE-8180: add 1.14 to management wiki

2020-05-22 Thread GitBox
onichols-pivotal opened a new pull request #5154: URL: https://github.com/apache/geode/pull/5154 add new wiki page id for 1.14 to generator script, and update to support -build.n convention as well as -SNAPSHOT This is an

[GitHub] [geode] yozaner1324 opened a new pull request #5151: GEODE-8148 - Implement unloadModule.

2020-05-22 Thread GitBox
yozaner1324 opened a new pull request #5151: URL: https://github.com/apache/geode/pull/5151 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5146: removed list, sorted set, hyperLog and transaction redis commands and code

2020-05-22 Thread GitBox
dschneider-pivotal commented on a change in pull request #5146: URL: https://github.com/apache/geode/pull/5146#discussion_r429348162 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ## @@ -205,281 +98,27 @@ private boolean

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5146: removed list, sorted set, hyperLog and transaction redis commands and code

2020-05-22 Thread GitBox
dschneider-pivotal commented on a change in pull request #5146: URL: https://github.com/apache/geode/pull/5146#discussion_r429352138 ## File path: geode-redis/src/distributedTest/java/org/apache/geode/redis/RedisDistDUnitTest.java ## @@ -209,18 +209,6 @@ public void run()

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5146: removed list, sorted set, hyperLog and transaction redis commands and code

2020-05-22 Thread GitBox
dschneider-pivotal commented on a change in pull request #5146: URL: https://github.com/apache/geode/pull/5146#discussion_r429352356 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/KeyRegistrar.java ## @@ -201,11 +172,7 @@ private void

[GitHub] [geode] dschneider-pivotal merged pull request #5133: GEODE-8127: ensure that function executes on primary

2020-05-22 Thread GitBox
dschneider-pivotal merged pull request #5133: URL: https://github.com/apache/geode/pull/5133 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] yozaner1324 closed pull request #5150: GEODE-8148 - Implement unloadModule.

2020-05-22 Thread GitBox
yozaner1324 closed pull request #5150: URL: https://github.com/apache/geode/pull/5150 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] yozaner1324 opened a new pull request #5150: GEODE-8148 - Implement unloadModule.

2020-05-22 Thread GitBox
yozaner1324 opened a new pull request #5150: URL: https://github.com/apache/geode/pull/5150 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] yozaner1324 closed pull request #5143: GEODE-8148 - Implement unloadModule.

2020-05-22 Thread GitBox
yozaner1324 closed pull request #5143: URL: https://github.com/apache/geode/pull/5143 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] gesterzhou commented on a change in pull request #5147: GEODE-8171: javadoc for putAll need to have accurate exception

2020-05-22 Thread GitBox
gesterzhou commented on a change in pull request #5147: URL: https://github.com/apache/geode/pull/5147#discussion_r429359435 ## File path: geode-core/src/main/java/org/apache/geode/cache/Region.java ## @@ -1359,10 +1359,30 @@ Object selectValue(String queryPredicate) throws

[GitHub] [geode] lgtm-com[bot] commented on pull request #5146: removed list, sorted set, hyperLog and transaction redis commands and code

2020-05-22 Thread GitBox
lgtm-com[bot] commented on pull request #5146: URL: https://github.com/apache/geode/pull/5146#issuecomment-632822841 This pull request **fixes 1 alert** when merging cda3b559858d7d35bbd24ddcb28c4208d915d2da into 358fd7067cc56b1ceb8c3d7c271c3a5254d7ee93 - [view on

[GitHub] [geode] lgtm-com[bot] commented on pull request #5150: GEODE-8148 - Implement unloadModule.

2020-05-22 Thread GitBox
lgtm-com[bot] commented on pull request #5150: URL: https://github.com/apache/geode/pull/5150#issuecomment-632827303 This pull request **introduces 1 alert** when merging 58b9b877d91e1f0fe32234c70fd1d5aa66d127e5 into e0cbd78149d520f77e896426b691c217d3afcfb4 - [view on

[GitHub] [geode] jdeppe-pivotal merged pull request #5145: GEODE-8168: Redis pipelined command responses can be corrupted

2020-05-22 Thread GitBox
jdeppe-pivotal merged pull request #5145: URL: https://github.com/apache/geode/pull/5145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] kohlmu-pivotal merged pull request #5151: GEODE-8148 - Implement unloadModule.

2020-05-22 Thread GitBox
kohlmu-pivotal merged pull request #5151: URL: https://github.com/apache/geode/pull/5151 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] jdeppe-pivotal merged pull request #5140: GEODE-8151: Convert hash commands to return RedisResponse

2020-05-22 Thread GitBox
jdeppe-pivotal merged pull request #5140: URL: https://github.com/apache/geode/pull/5140 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] dschneider-pivotal merged pull request #5142: GEODE-8138: Improve semantics of the redis-port option

2020-05-22 Thread GitBox
dschneider-pivotal merged pull request #5142: URL: https://github.com/apache/geode/pull/5142 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] dschneider-pivotal merged pull request #5153: Revert GEODE-8127: the test is flakey

2020-05-22 Thread GitBox
dschneider-pivotal merged pull request #5153: URL: https://github.com/apache/geode/pull/5153 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] lgtm-com[bot] commented on pull request #5146: removed list, sorted set, hyperLog and transaction redis commands and code

2020-05-22 Thread GitBox
lgtm-com[bot] commented on pull request #5146: URL: https://github.com/apache/geode/pull/5146#issuecomment-632948660 This pull request **fixes 1 alert** when merging 96719b5042336a0cb46e878aa4fe63f1b629ad6b into af1ea6d2ff563db786abf773f572a9a09b0858d0 - [view on

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5152: Change Redis Rename Functions to Make use of Striped Executor

2020-05-22 Thread GitBox
dschneider-pivotal commented on a change in pull request #5152: URL: https://github.com/apache/geode/pull/5152#discussion_r429477577 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/CommandFunction.java ## @@ -84,10 +88,32 @@ protected Object

[GitHub] [geode] dschneider-pivotal opened a new pull request #5153: Revert GEODE-8127: the test is flakey

2020-05-22 Thread GitBox
dschneider-pivotal opened a new pull request #5153: URL: https://github.com/apache/geode/pull/5153 This reverts commit e0cbd78149d520f77e896426b691c217d3afcfb4. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the

[GitHub] [geode] jhutchison opened a new pull request #5152: Change Redis Rename Functions to Make use of Striped Executor

2020-05-22 Thread GitBox
jhutchison opened a new pull request #5152: URL: https://github.com/apache/geode/pull/5152 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all