[GitHub] [geode] albertogpz commented on pull request #5313: GEODE-8302: Fixed 'events not queued conflated' stats when group-tran…

albertogpz commented on pull request #5313: URL: https://github.com/apache/geode/pull/5313#issuecomment-651582218 > @albertogpz Good material - thanks for writing the docs for this feature. > I have some edits for clarification and consistency, in both user guide files and the javadoc

[GitHub] [geode] albertogpz commented on a change in pull request #5273: GEODE-8240: solve rolling upgrade bug with new VersionOrdinal interface

albertogpz commented on a change in pull request #5273: URL: https://github.com/apache/geode/pull/5273#discussion_r447434620 ## File path: geode-core/src/upgradeTest/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgradeDUnitTest.java ## @@ -191,20 +207,26 @@ void

[GitHub] [geode] jujoramos opened a new pull request #5329: [WIP] - GEODE-8029: Allow OplogEntryIdSet to Overflow

jujoramos opened a new pull request #5329: URL: https://github.com/apache/geode/pull/5329 Do not delete drf files during member startup as that should be only done by the compactor thread. Instead, allow the OplogEntryIdSet to grow over the default capacity and log a warning message

[GitHub] [geode] jujoramos closed pull request #5322: [WIP]: Do not review.

jujoramos closed pull request #5322: URL: https://github.com/apache/geode/pull/5322 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] pivotal-jbarrett commented on pull request #5324: Migrate to JUnit 5 framework.

pivotal-jbarrett commented on pull request #5324: URL: https://github.com/apache/geode/pull/5324#issuecomment-651845490 @dhemery can you take a quick look at the results. I fear they might be false positives. I would like two eyes on them.

[GitHub] [geode] pivotal-jbarrett commented on pull request #5324: Migrate to JUnit 5 framework.

pivotal-jbarrett commented on pull request #5324: URL: https://github.com/apache/geode/pull/5324#issuecomment-651854835 As I suspected, something is up. Far fewer tests run in distributed tests. PR: https://concourse.apachegeode-ci.info/builds/171472 Main:

[GitHub] [geode] lgtm-com[bot] commented on pull request #5330: GEODE-7864: Fix array index out of bounds alerts

lgtm-com[bot] commented on pull request #5330: URL: https://github.com/apache/geode/pull/5330#issuecomment-651976168 This pull request **fixes 9 alerts** when merging 209665716235025c0967c8ae1c8e7760647cd42e into bfe1ca113124ea958dc02dd9be90cdb0aabe5c4d - [view on

[GitHub] [geode] DonalEvans merged pull request #5330: GEODE-7864: Fix array index out of bounds alerts

DonalEvans merged pull request #5330: URL: https://github.com/apache/geode/pull/5330 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] gesterzhou merged pull request #5253: GEODE-8259: when client singlehop getAll encountered SerializationException, it should retry

gesterzhou merged pull request #5253: URL: https://github.com/apache/geode/pull/5253 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] Bill closed pull request #5278: GEODE-8240: GMSMemberData keeps VersionOrdinal

Bill closed pull request #5278: URL: https://github.com/apache/geode/pull/5278 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [geode] Bill commented on pull request #5278: GEODE-8240: GMSMemberData keeps VersionOrdinal

Bill commented on pull request #5278: URL: https://github.com/apache/geode/pull/5278#issuecomment-652050659 closing this PR. it's out of date. It was made with an early version of the GEODE-8240 fix on the `develop` branch. I'm about to make a brand new 1.12-based branch to test the

[GitHub] [geode] boglesby opened a new pull request #5331: GEODE-8324: Don't add a remote ds id to recipients unless it is running

boglesby opened a new pull request #5331: URL: https://github.com/apache/geode/pull/5331 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] rhoughton-pivot opened a new pull request #5332: buildSrc depends directly on guava. Declare it. Misc other build fixups

rhoughton-pivot opened a new pull request #5332: URL: https://github.com/apache/geode/pull/5332 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode] pivotal-eshu opened a new pull request #5333: GEODE-8323: Process QueueRemovalMessage after queue initialized.

pivotal-eshu opened a new pull request #5333: URL: https://github.com/apache/geode/pull/5333 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all