[GitHub] [geode] rhoughton-pivot commented on pull request #5291: [DRAFT] Pull up transitive dependency to clean up javax.activation and mail licenses.

2020-07-20 Thread GitBox
rhoughton-pivot commented on pull request #5291: URL: https://github.com/apache/geode/pull/5291#issuecomment-661343930 @metatype The module that pulls those in was also getting the symbols transitively. I'm not convinced that anything we can call can hit any symbols from these particular

[GitHub] [geode] kirklund opened a new pull request #5388: GEODE-8371: Move ClassGraph to MIT License

2020-07-20 Thread GitBox
kirklund opened a new pull request #5388: URL: https://github.com/apache/geode/pull/5388 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] onichols-pivotal commented on pull request #5291: [DRAFT] Pull up transitive dependency to clean up javax.activation and mail licenses.

2020-07-20 Thread GitBox
onichols-pivotal commented on pull request #5291: URL: https://github.com/apache/geode/pull/5291#issuecomment-661346610 @rhoughton-pivot don't forget to remove activation 1.1 (lines 269-270) from geode-assembly/src/main/dist/LICENSE as part of this PR, and also please add the ticket to

[GitHub] [geode] onichols-pivotal commented on pull request #5291: [DRAFT] Pull up transitive dependency to clean up javax.activation and mail licenses.

2020-07-20 Thread GitBox
onichols-pivotal commented on pull request #5291: URL: https://github.com/apache/geode/pull/5291#issuecomment-661346111 @metatype this PR is in response to the ticket you asked me to create during the last license review: GEODE-8066 Geode should not be using both activation 1.1 and

[GitHub] [geode] karensmolermiller opened a new pull request #5386: GEODE-8363: Label Micrometer docs as experimental

2020-07-20 Thread GitBox
karensmolermiller opened a new pull request #5386: URL: https://github.com/apache/geode/pull/5386 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [geode] metatype commented on pull request #5291: [DRAFT] Pull up transitive dependency to clean up javax.activation and mail licenses.

2020-07-20 Thread GitBox
metatype commented on pull request #5291: URL: https://github.com/apache/geode/pull/5291#issuecomment-661242217 IIUC, this removes javax.mail and javax.activation from the bundled dependencies. I believe that we need those dependencies until we remove the admin API entirely.

[GitHub] [geode] davebarnes97 merged pull request #5387: GEODE-7628: Block jmx mbean creation when no security manager (docs)

2020-07-20 Thread GitBox
davebarnes97 merged pull request #5387: URL: https://github.com/apache/geode/pull/5387 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] karensmolermiller merged pull request #5386: GEODE-8363: Label Micrometer docs as experimental

2020-07-20 Thread GitBox
karensmolermiller merged pull request #5386: URL: https://github.com/apache/geode/pull/5386 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] onichols-pivotal commented on pull request #5382: GEODE-8368: Upgrade ClassGraph from 4.8.52 to 4.8.87

2020-07-20 Thread GitBox
onichols-pivotal commented on pull request #5382: URL: https://github.com/apache/geode/pull/5382#issuecomment-661500736 Out of curiosity what are we changing this? Was there a specific issue with 4.8.52 you are trying to solve? I would much rather go back to 4.0.6 and fix the log4j

[GitHub] [geode] davebarnes97 opened a new pull request #5387: GEODE-7628: Block jmx mbean creation when no security manager (docs)

2020-07-20 Thread GitBox
davebarnes97 opened a new pull request #5387: URL: https://github.com/apache/geode/pull/5387 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] DonalEvans commented on a change in pull request #4848: GEODE-7670: Add Tests for PR clear

2020-07-20 Thread GitBox
DonalEvans commented on a change in pull request #4848: URL: https://github.com/apache/geode/pull/4848#discussion_r457469700 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithConcurrentOperationsDUnitTest.java ## @@

[GitHub] [geode] jdeppe-pivotal opened a new pull request #5384: GEODE-8369: Do not build docker images on Windows for geode-assembly:acceptanceTest

2020-07-20 Thread GitBox
jdeppe-pivotal opened a new pull request #5384: URL: https://github.com/apache/geode/pull/5384 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [geode] Bill merged pull request #5370: GEODE-8298: Member version comparison sense inconsistent when deciding on multicast

2020-07-20 Thread GitBox
Bill merged pull request #5370: URL: https://github.com/apache/geode/pull/5370 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [geode] rhoughton-pivot merged pull request #5384: GEODE-8369: Do not build docker images on Windows for geode-assembly:acceptanceTest

2020-07-20 Thread GitBox
rhoughton-pivot merged pull request #5384: URL: https://github.com/apache/geode/pull/5384 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] gesterzhou closed pull request #5372: Revert "GEODE-7384: Members's old Persistent Member Id should be remo…

2020-07-20 Thread GitBox
gesterzhou closed pull request #5372: URL: https://github.com/apache/geode/pull/5372 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] sabbeyPivotal opened a new pull request #5385: GEODE-8370: Add test for maxInactiveInterval

2020-07-20 Thread GitBox
sabbeyPivotal opened a new pull request #5385: URL: https://github.com/apache/geode/pull/5385 Write test verifying that maxInactiveInterval propagates correctly to all buckets This is an automated message from the Apache