[GitHub] [geode] davebarnes97 opened a new pull request #5423: GEODE-8401: User Guide - incorrect method name on "forced disconnect"…

2020-08-04 Thread GitBox
davebarnes97 opened a new pull request #5423: URL: https://github.com/apache/geode/pull/5423 … page `Cache.waitForReconnect(long, TimeUnit)` should be `Cache.waitUntilReconnected(long, TimeUnit)` This is an automated

[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation

2020-08-04 Thread GitBox
lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-668876145 This pull request **introduces 2 alerts** and **fixes 2** when merging c50c3429756811ed64e13675f2faa83b49daa71f into 53abb22cd295441f8794e15550b72ec81113ec05 - [view on

[GitHub] [geode] demery-pivotal opened a new pull request #5425: DO NOT REVIEW: Use ephemeral port knocking to find and "reserve" free ports.

2020-08-04 Thread GitBox
demery-pivotal opened a new pull request #5425: URL: https://github.com/apache/geode/pull/5425 Co-Authored-by Jacob Barrett Co-Authored-by: Dale Emery diff --git a/geode-core/src/distributedTest/java/org/apache/geode/cache30/ReconnectWithClusterConfigurationDUnitTest.java

[GitHub] [geode] davebarnes97 merged pull request #5423: GEODE-8401: User Guide - incorrect method name on "forced disconnect"…

2020-08-04 Thread GitBox
davebarnes97 merged pull request #5423: URL: https://github.com/apache/geode/pull/5423 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] demery-pivotal closed pull request #5406: DO NOT REVIEW Wip/available ports

2020-08-04 Thread GitBox
demery-pivotal closed pull request #5406: URL: https://github.com/apache/geode/pull/5406 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] bschuchardt opened a new pull request #5422: GEODE-6950: hot loop in PrimaryHandler.processRequest()

2020-08-04 Thread GitBox
bschuchardt opened a new pull request #5422: URL: https://github.com/apache/geode/pull/5422 The ticket had a suggested fix for the locator's hot loop and I've implemented that. I modified PrimaryHandler to make the issue testable and added a couple of other tests for registered and

[GitHub] [geode] agingade opened a new pull request #5424: GEODE-8394: Rewind the message Part on command failure

2020-08-04 Thread GitBox
agingade opened a new pull request #5424: URL: https://github.com/apache/geode/pull/5424 This change rewinds the message part on command failure. Without this during retry on failure, the message (Part) is sent from the place where it was previously failed, instead of starting from the

[GitHub] [geode-native] alb3rtobr commented on pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

2020-08-04 Thread GitBox
alb3rtobr commented on pull request #628: URL: https://github.com/apache/geode-native/pull/628#issuecomment-668701694 Sorry for the late answer, I have been on vacation. I have changed the PR to draft because Im still working on the tests. I have added some functionality to the

[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation

2020-08-04 Thread GitBox
lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-668746687 This pull request **introduces 2 alerts** and **fixes 2** when merging f855cfcb31700189d22469648e8584b483c006ba into 53abb22cd295441f8794e15550b72ec81113ec05 - [view on

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-04 Thread GitBox
sabbeyPivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r465148577 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-04 Thread GitBox
onichols-pivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r465158361 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-04 Thread GitBox
onichols-pivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r465158361 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] bschuchardt closed pull request #5265: work in progress

2020-08-04 Thread GitBox
bschuchardt closed pull request #5265: URL: https://github.com/apache/geode/pull/5265 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-04 Thread GitBox
sabbeyPivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464665951 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)