[GitHub] [geode] rhoughton-pivot merged pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-05 Thread GitBox
rhoughton-pivot merged pull request #5416: URL: https://github.com/apache/geode/pull/5416 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] mivanac opened a new pull request #5426: GEODE-8292: Added check if key is destroyed in CQResults

2020-08-05 Thread GitBox
mivanac opened a new pull request #5426: URL: https://github.com/apache/geode/pull/5426 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] jchen21 commented on a change in pull request #5424: GEODE-8394: Rewind the message Part on command failure

2020-08-05 Thread GitBox
jchen21 commented on a change in pull request #5424: URL: https://github.com/apache/geode/pull/5424#discussion_r466003540 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache30/ClientServerCacheOperationDUnitTest.java ## @@ -0,0 +1,200 @@ +/* + * Licensed

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
onichols-pivotal commented on a change in pull request #5427: URL: https://github.com/apache/geode/pull/5427#discussion_r466006536 ## File path: ci/scripts/delete_instance.sh ## @@ -29,6 +29,11 @@ while [ -h "$SOURCE" ]; do # resolve $SOURCE until the file is no longer a

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
onichols-pivotal commented on a change in pull request #5427: URL: https://github.com/apache/geode/pull/5427#discussion_r466006805 ## File path: ci/scripts/execute_tests.sh ## @@ -34,6 +34,11 @@ if [[ -z "${GRADLE_TASK}" ]]; then exit 1 fi +.

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
onichols-pivotal commented on a change in pull request #5427: URL: https://github.com/apache/geode/pull/5427#discussion_r466006805 ## File path: ci/scripts/execute_tests.sh ## @@ -34,6 +34,11 @@ if [[ -z "${GRADLE_TASK}" ]]; then exit 1 fi +.

[GitHub] [geode] rhoughton-pivot commented on a change in pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
rhoughton-pivot commented on a change in pull request #5427: URL: https://github.com/apache/geode/pull/5427#discussion_r466013886 ## File path: ci/scripts/execute_tests.sh ## @@ -34,6 +34,11 @@ if [[ -z "${GRADLE_TASK}" ]]; then exit 1 fi +.

[GitHub] [geode] rhoughton-pivot commented on a change in pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
rhoughton-pivot commented on a change in pull request #5427: URL: https://github.com/apache/geode/pull/5427#discussion_r466015382 ## File path: ci/scripts/delete_instance.sh ## @@ -29,6 +29,11 @@ while [ -h "$SOURCE" ]; do # resolve $SOURCE until the file is no longer a symli

[GitHub] [geode] rhoughton-pivot commented on pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
rhoughton-pivot commented on pull request #5427: URL: https://github.com/apache/geode/pull/5427#issuecomment-669521913 > does this affect PRs only or regular pipelines as well? Do I understand correctly that this will cause the jobs to run super-fast? That will mess with timing statistics

[GitHub] [geode] bschuchardt opened a new pull request #5428: GEODE-8407: MergeLogFiles fails to include files with the same name b…

2020-08-05 Thread GitBox
bschuchardt opened a new pull request #5428: URL: https://github.com/apache/geode/pull/5428 …ut in different directories I modified the upper levels of the merge process to hold a new object containing the file's display name and its inputStream. The logFiles Map now holds the

[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
pivotal-jbarrett commented on a change in pull request #5427: URL: https://github.com/apache/geode/pull/5427#discussion_r466022409 ## File path: ci/scripts/execute_tests.sh ## @@ -34,6 +34,11 @@ if [[ -z "${GRADLE_TASK}" ]]; then exit 1 fi +.

[GitHub] [geode] albertogpz commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-05 Thread GitBox
albertogpz commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r465912609 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java ## @@ -155,4 +160,38 @@ public

[GitHub] [geode] jinmeiliao commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-05 Thread GitBox
jinmeiliao commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r465920598 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java ## @@ -155,4 +160,38 @@ public

[GitHub] [geode] jinmeiliao commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-05 Thread GitBox
jinmeiliao commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r465905356 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -180,6 +180,9 @@ protected volatile

[GitHub] [geode] albertogpz commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-05 Thread GitBox
albertogpz commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r465909971 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -180,6 +180,9 @@ protected volatile

[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
pivotal-jbarrett commented on a change in pull request #5427: URL: https://github.com/apache/geode/pull/5427#discussion_r466033207 ## File path: ci/scripts/execute_tests.sh ## @@ -34,6 +34,11 @@ if [[ -z "${GRADLE_TASK}" ]]; then exit 1 fi +.

[GitHub] [geode] onichols-pivotal commented on pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
onichols-pivotal commented on pull request #5427: URL: https://github.com/apache/geode/pull/5427#issuecomment-669547485 keep the modular thing, fine, but can we have a wrapper script that encapsulates the magic list, so we just call that script 6 places?

[GitHub] [geode] dschneider-pivotal opened a new pull request #5429: GEODE-8409: S*STORE need to handle target that is not a redis set

2020-08-05 Thread GitBox
dschneider-pivotal opened a new pull request #5429: URL: https://github.com/apache/geode/pull/5429 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5420: GEODE-8333: Second attempt to fix PUBSUB hang

2020-08-05 Thread GitBox
dschneider-pivotal commented on a change in pull request #5420: URL: https://github.com/apache/geode/pull/5420#discussion_r466037897 ## File path: geode-redis/src/distributedTest/java/org/apache/geode/redis/internal/executor/pubsub/PubSubDUnitTest.java ## @@ -86,11 +89,17 @@

[GitHub] [geode] rhoughton-pivot commented on pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
rhoughton-pivot commented on pull request #5427: URL: https://github.com/apache/geode/pull/5427#issuecomment-669546743 @pivotal-jbarrett I could have, but chose instead to have it be a modular function that takes input. Makes it clear from the outside what is being tested. Or, call it

[GitHub] [geode] PurelyApplied commented on a change in pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-05 Thread GitBox
PurelyApplied commented on a change in pull request #5427: URL: https://github.com/apache/geode/pull/5427#discussion_r466052198 ## File path: ci/scripts/execute_tests.sh ## @@ -34,6 +34,11 @@ if [[ -z "${GRADLE_TASK}" ]]; then exit 1 fi +.