[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5420: GEODE-8333: Second attempt to fix PUBSUB hang

jdeppe-pivotal commented on a change in pull request #5420: URL: https://github.com/apache/geode/pull/5420#discussion_r468823814 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -59,17 +60,21 @@ public class

[GitHub] [geode] jinmeiliao commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

jinmeiliao commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468747434 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationLoopBackDUnitTest.java ## @@ -433,6

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5420: GEODE-8333: Second attempt to fix PUBSUB hang

dschneider-pivotal commented on a change in pull request #5420: URL: https://github.com/apache/geode/pull/5420#discussion_r468723671 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -138,6 +161,25 @@ public void

[GitHub] [geode] jchen21 commented on a change in pull request #5436: GEODE-7672: add dunit test to verify OQL index after PR clear.

jchen21 commented on a change in pull request #5436: URL: https://github.com/apache/geode/pull/5436#discussion_r468778063 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java ## @@ -0,0 +1,157 @@ +/* + *

[GitHub] [geode] mhansonp opened a new pull request #5448: Changes to help reduce the occurence of GEODE-8422

mhansonp opened a new pull request #5448: URL: https://github.com/apache/geode/pull/5448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] lgtm-com[bot] commented on pull request #5363: GEODE-8349: Reintroduce use of SSLSocket in cluster communications

lgtm-com[bot] commented on pull request #5363: URL: https://github.com/apache/geode/pull/5363#issuecomment-672209899 This pull request **introduces 1 alert** and **fixes 1** when merging 5b573099845881a70be91e7e3c037cdcc6b9779b into 21e26094e5178d5af1ef554448da943e07352469 - [view on

[GitHub] [geode] albertogpz commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

albertogpz commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468754561 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationLoopBackDUnitTest.java ## @@ -433,6

[GitHub] [geode] jinmeiliao commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

jinmeiliao commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468762702 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationLoopBackDUnitTest.java ## @@ -433,6

[GitHub] [geode] dschneider-pivotal opened a new pull request #5446: GEODE-8393: fix flaky test and do not throw memberDeparted

dschneider-pivotal opened a new pull request #5446: URL: https://github.com/apache/geode/pull/5446 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [geode] sabbeyPivotal opened a new pull request #5449: GEODE-8423: Updates Redis API for Geode docs 1.13

sabbeyPivotal opened a new pull request #5449: URL: https://github.com/apache/geode/pull/5449 Documentation for Redis API for Geode that will currently be published for 1.13 are not accurate and need to be updated. This is

[GitHub] [geode] mhansonp opened a new pull request #5447: Changes to help reduce the occurence of GEODE-8422

mhansonp opened a new pull request #5447: URL: https://github.com/apache/geode/pull/5447 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] albertogpz commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

albertogpz commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468768049 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationLoopBackDUnitTest.java ## @@ -433,6

[GitHub] [geode] albertogpz commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

albertogpz commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r468894539 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/GatewaySenderManageFunction.java ## @@ -0,0 +1,148

[GitHub] [geode-benchmarks] rhoughton-pivot opened a new pull request #132: allow AMI picking with arbitrary username accounts

rhoughton-pivot opened a new pull request #132: URL: https://github.com/apache/geode-benchmarks/pull/132 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [geode-native] codecov-commenter commented on pull request #630: GEODE-8102 Link and load OpenSSL library directly

codecov-commenter commented on pull request #630: URL: https://github.com/apache/geode-native/pull/630#issuecomment-672466067 # [Codecov](https://codecov.io/gh/apache/geode-native/pull/630?src=pr=h1) Report > Merging

[GitHub] [geode-native] codecov-commenter commented on pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

codecov-commenter commented on pull request #628: URL: https://github.com/apache/geode-native/pull/628#issuecomment-672466654 # [Codecov](https://codecov.io/gh/apache/geode-native/pull/628?src=pr=h1) Report > Merging

[GitHub] [geode] jinmeiliao commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

jinmeiliao commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r468909733 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/GatewaySenderManageFunction.java ## @@ -0,0 +1,148

[GitHub] [geode-native] moleske opened a new pull request #632: Remove compile option no-shorten-64-to-32

moleske opened a new pull request #632: URL: https://github.com/apache/geode-native/pull/632 Authored-by: M. Oleske curious if this is needed since quick test on my machine was compiling (so figured I'd make travis check real quick)

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5420: GEODE-8333: Second attempt to fix PUBSUB hang

jdeppe-pivotal commented on a change in pull request #5420: URL: https://github.com/apache/geode/pull/5420#discussion_r468997420 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -138,6 +161,25 @@ public void

[GitHub] [geode] gesterzhou commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

gesterzhou commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468348971 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationLoopBackDUnitTest.java ## @@ -433,6

[GitHub] [geode-native] alb3rtobr commented on pull request #629: GEODE-8364: Change log level at runtime

alb3rtobr commented on pull request #629: URL: https://github.com/apache/geode-native/pull/629#issuecomment-671786298 @pivotal-jbarrett could you please check if the changes are ok for you? Thanks This is an automated

[GitHub] [geode] gesterzhou commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

gesterzhou commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468347041 ## File path: geode-wan/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderImpl.java ## @@ -111,6 +111,7 @@ private void

[GitHub] [geode] gesterzhou commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

gesterzhou commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468346846 ## File path: geode-wan/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderImpl.java ## @@ -102,6 +102,7 @@ private void

[GitHub] [geode] gesterzhou commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

gesterzhou commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468346597 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/ParallelAsyncEventQueueCreation.java ## @@ -43,13 +43,19 @@ public void

[GitHub] [geode] gesterzhou commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

gesterzhou commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468346597 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/ParallelAsyncEventQueueCreation.java ## @@ -43,13 +43,19 @@ public void

[GitHub] [geode] mivanac opened a new pull request #5444: GEODE-8172_1: additional check added

mivanac opened a new pull request #5444: URL: https://github.com/apache/geode/pull/5444 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] albertogpz commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

albertogpz commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468439052 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationLoopBackDUnitTest.java ## @@ -433,6

[GitHub] [geode] albertogpz commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

albertogpz commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468439613 ## File path: geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/ParallelAsyncEventQueueImpl.java ## @@ -110,6 +110,7 @@ private void

[GitHub] [geode] mkevo commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

mkevo commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-671872424 Hi @jujoramos, After adding some logs I saw that in `offlineCompact` method it not executes `dsi.close() ` as it fails before on `createForOffline` while loading files in

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5420: GEODE-8333: Second attempt to fix PUBSUB hang

jdeppe-pivotal commented on a change in pull request #5420: URL: https://github.com/apache/geode/pull/5420#discussion_r468663923 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -59,17 +60,21 @@ public class

[GitHub] [geode] mivanac merged pull request #5444: GEODE-8172_1: additional check added

mivanac merged pull request #5444: URL: https://github.com/apache/geode/pull/5444 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] mivanac opened a new pull request #5445: GEODE-8421: replace cleaning of region with destroy/create

mivanac opened a new pull request #5445: URL: https://github.com/apache/geode/pull/5445 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5420: GEODE-8333: Second attempt to fix PUBSUB hang

dschneider-pivotal commented on a change in pull request #5420: URL: https://github.com/apache/geode/pull/5420#discussion_r468688937 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -138,6 +161,25 @@ public void

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5420: GEODE-8333: Second attempt to fix PUBSUB hang

dschneider-pivotal commented on a change in pull request #5420: URL: https://github.com/apache/geode/pull/5420#discussion_r468692943 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -59,17 +60,21 @@ public class

[GitHub] [geode] gesterzhou commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

gesterzhou commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r468695763 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/GatewaySenderMBean.java ## @@ -214,11 +214,6 @@ public boolean

[GitHub] [geode] jinmeiliao commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

jinmeiliao commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r468698308 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/GatewaySenderMBean.java ## @@ -214,11 +214,6 @@ public boolean

[GitHub] [geode] DonalEvans closed pull request #5443: GEODE-7864: Fix most "Statement has empty body" IDE warnings

DonalEvans closed pull request #5443: URL: https://github.com/apache/geode/pull/5443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go