[GitHub] [geode-native] alb3rtobr opened a new pull request #648: GEODE-8480: Add txmanager check in tx example

2020-09-02 Thread GitBox
alb3rtobr opened a new pull request #648: URL: https://github.com/apache/geode-native/pull/648 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode] demery-pivotal merged pull request #5493: GEODE-8404: Simplify AvailablePortHelper

2020-09-02 Thread GitBox
demery-pivotal merged pull request #5493: URL: https://github.com/apache/geode/pull/5493 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode-native] pdxcodemonkey merged pull request #644: Remove GemFireVersion.getBuildDate()

2020-09-02 Thread GitBox
pdxcodemonkey merged pull request #644: URL: https://github.com/apache/geode-native/pull/644 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode-native] pdxcodemonkey merged pull request #643: Add note that docker compose is needed

2020-09-02 Thread GitBox
pdxcodemonkey merged pull request #643: URL: https://github.com/apache/geode-native/pull/643 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] gesterzhou merged pull request #5492: GEODE-8475: Resolve a potential dead lock in ParallelGatewaySenderQueue

2020-09-02 Thread GitBox
gesterzhou merged pull request #5492: URL: https://github.com/apache/geode/pull/5492 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode-native] echobravopapa commented on a change in pull request #647: GEODE-8460: Run SNITests Based on Docker Availability

2020-09-02 Thread GitBox
echobravopapa commented on a change in pull request #647: URL: https://github.com/apache/geode-native/pull/647#discussion_r482281695 ## File path: cppcache/integration/test/sni-test-config/docker-compose.yml ## @@ -1,43 +0,0 @@ -# Review comment: second that.

[GitHub] [geode] boglesby commented on a change in pull request #5494: GEODE-8478: Refactored logThresholdExceededAlerts and modified it to …

2020-09-02 Thread GitBox
boglesby commented on a change in pull request #5494: URL: https://github.com/apache/geode/pull/5494#discussion_r482347901 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySenderEventProcessor.java ## @@ -1037,24 +1039,32 @@ public

[GitHub] [geode] DonalEvans commented on a change in pull request #5494: GEODE-8478: Refactored logThresholdExceededAlerts and modified it to …

2020-09-02 Thread GitBox
DonalEvans commented on a change in pull request #5494: URL: https://github.com/apache/geode/pull/5494#discussion_r482268033 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySenderEventProcessor.java ## @@ -1037,24 +1039,32 @@ public

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #647: GEODE-8460: Run SNITests Based on Docker Availability

2020-09-02 Thread GitBox
pdxcodemonkey commented on a change in pull request #647: URL: https://github.com/apache/geode-native/pull/647#discussion_r482166019 ## File path: cppcache/integration/test/sni-test-config/docker-compose.yml ## @@ -1,43 +0,0 @@ -# Review comment: Let's get our act

[GitHub] [geode-native] mmartell commented on a change in pull request #647: GEODE-8460: Run SNITests Based on Docker Availability

2020-09-02 Thread GitBox
mmartell commented on a change in pull request #647: URL: https://github.com/apache/geode-native/pull/647#discussion_r482669955 ## File path: cppcache/integration/test/sni-test-config/docker-compose.yml ## @@ -1,43 +0,0 @@ -# Review comment: Good catch on the

[GitHub] [geode] demery-pivotal opened a new pull request #5495: DO NOT REVIEW Give each DUnit session a unique root dir

2020-09-02 Thread GitBox
demery-pivotal opened a new pull request #5495: URL: https://github.com/apache/geode/pull/5495 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode] gesterzhou commented on pull request #5489: GEODE-8432-2: use getRegionPath instead of getRegion to avoid waitOnI…

2020-09-02 Thread GitBox
gesterzhou commented on pull request #5489: URL: https://github.com/apache/geode/pull/5489#issuecomment-686086161 This fix did not consider the region destroy will cause it return null. Close it. This is an automated

[GitHub] [geode] gesterzhou commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-09-02 Thread GitBox
gesterzhou commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r482630553 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -180,6 +180,9 @@ protected volatile

[GitHub] [geode] gesterzhou commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-09-02 Thread GitBox
gesterzhou commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r482630830 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java ## @@ -77,6 +82,9 @@ public

[GitHub] [geode] gesterzhou closed pull request #5489: GEODE-8432-2: use getRegionPath instead of getRegion to avoid waitOnI…

2020-09-02 Thread GitBox
gesterzhou closed pull request #5489: URL: https://github.com/apache/geode/pull/5489 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] gesterzhou commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-09-02 Thread GitBox
gesterzhou commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r482630830 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java ## @@ -77,6 +82,9 @@ public

[GitHub] [geode-native] mmartell commented on a change in pull request #647: GEODE-8460: Run SNITests Based on Docker Availability

2020-09-02 Thread GitBox
mmartell commented on a change in pull request #647: URL: https://github.com/apache/geode-native/pull/647#discussion_r482669955 ## File path: cppcache/integration/test/sni-test-config/docker-compose.yml ## @@ -1,43 +0,0 @@ -# Review comment: Good catch on the