[GitHub] [geode] albertogpz commented on pull request #5509: GEODE-8491: Do not store dropped events in stopped primary gateway se…

2020-09-15 Thread GitBox
albertogpz commented on pull request #5509: URL: https://github.com/apache/geode/pull/5509#issuecomment-692514634 > A few code cleanup requests, but otherwise looks good. An elegant solution. @Donal, thanks for the comments.

[GitHub] [geode] albertogpz edited a comment on pull request #5509: GEODE-8491: Do not store dropped events in stopped primary gateway se…

2020-09-15 Thread GitBox
albertogpz edited a comment on pull request #5509: URL: https://github.com/apache/geode/pull/5509#issuecomment-692514634 > A few code cleanup requests, but otherwise looks good. An elegant solution. @DonalEvans, thanks for the comments.

[GitHub] [geode] jinmeiliao commented on a change in pull request #5507: GEODE-8489: "Select *" query by DistributedSystemMBean should not hon…

2020-09-15 Thread GitBox
jinmeiliao commented on a change in pull request #5507: URL: https://github.com/apache/geode/pull/5507#discussion_r488773618 ## File path: geode-core/src/integrationTest/java/org/apache/geode/management/internal/beans/DistributedSystemMBeanIntegrationTest.java ## @@ -30,14

[GitHub] [geode] agingade commented on a change in pull request #5507: GEODE-8489: "Select *" query by DistributedSystemMBean should not hon…

2020-09-15 Thread GitBox
agingade commented on a change in pull request #5507: URL: https://github.com/apache/geode/pull/5507#discussion_r488723747 ## File path: geode-core/src/integrationTest/java/org/apache/geode/management/internal/beans/DistributedSystemMBeanIntegrationTest.java ## @@ -30,14

[GitHub] [geode] dschneider-pivotal opened a new pull request #5513: changed PubSubDUnitTest

2020-09-15 Thread GitBox
dschneider-pivotal opened a new pull request #5513: URL: https://github.com/apache/geode/pull/5513 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [geode] BenjaminPerryRoss opened a new pull request #5512: Feature/geode 7671

2020-09-15 Thread GitBox
BenjaminPerryRoss opened a new pull request #5512: URL: https://github.com/apache/geode/pull/5512 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For

[GitHub] [geode] jinmeiliao commented on a change in pull request #5507: GEODE-8489: "Select *" query by DistributedSystemMBean should not hon…

2020-09-15 Thread GitBox
jinmeiliao commented on a change in pull request #5507: URL: https://github.com/apache/geode/pull/5507#discussion_r488855631 ## File path: geode-core/src/integrationTest/java/org/apache/geode/management/internal/beans/DistributedSystemMBeanIntegrationTest.java ## @@ -30,14

[GitHub] [geode] rhoughton-pivot merged pull request #5291: [DRAFT] GEODE-8066: Pull up transitive dependency to clean up javax.activation and mail licenses.

2020-09-15 Thread GitBox
rhoughton-pivot merged pull request #5291: URL: https://github.com/apache/geode/pull/5291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] mivanac opened a new pull request #5514: GEODE-8497: added getTotalQueueSizeBytesInUse

2020-09-15 Thread GitBox
mivanac opened a new pull request #5514: URL: https://github.com/apache/geode/pull/5514 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] jchen21 closed pull request #5516: GEODE-7679 Partitioned Region clear is successful while region is being altered

2020-09-15 Thread GitBox
jchen21 closed pull request #5516: URL: https://github.com/apache/geode/pull/5516 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] boglesby commented on a change in pull request #5509: GEODE-8491: Do not store dropped events in stopped primary gateway se…

2020-09-15 Thread GitBox
boglesby commented on a change in pull request #5509: URL: https://github.com/apache/geode/pull/5509#discussion_r489081453 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -1118,6 +1115,17 @@ public void

[GitHub] [geode] jchen21 opened a new pull request #5516: GEODE-7679 Partitioned Region clear is successful while region is being altered

2020-09-15 Thread GitBox
jchen21 opened a new pull request #5516: URL: https://github.com/apache/geode/pull/5516 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] demery-pivotal opened a new pull request #5515: Give each gradle worker a unique subdir name

2020-09-15 Thread GitBox
demery-pivotal opened a new pull request #5515: URL: https://github.com/apache/geode/pull/5515 Give each gradle worker a unique subdir name. Then run each test type in the worker's unique subdir under the test type dir. Authored-by: Dale Emery Thank you for submitting a