[GitHub] [geode-native] alb3rtobr commented on pull request #654: GEODE-8514: python protocol tool

2020-09-23 Thread GitBox
alb3rtobr commented on pull request #654: URL: https://github.com/apache/geode-native/pull/654#issuecomment-697558085 @pdxcodemonkey thanks for contributing this! It's also a good excuse to refresh my Python knowledge This

[GitHub] [geode-native] pdxcodemonkey commented on pull request #654: GEODE-8514: python protocol tool

2020-09-23 Thread GitBox
pdxcodemonkey commented on pull request #654: URL: https://github.com/apache/geode-native/pull/654#issuecomment-697629814 > @pdxcodemonkey thanks for contributing this! It's also a good excuse to refresh my Python knowledge thanks, @alb3rtobr, hope you find it helpful. Just FYI, I

[GitHub] [geode] jinmeiliao commented on a change in pull request #5516: GEODE-7679 Partitioned Region clear is successful while region is being altered

2020-09-23 Thread GitBox
jinmeiliao commented on a change in pull request #5516: URL: https://github.com/apache/geode/pull/5516#discussion_r493631271 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithAlterRegionDUnitTest.java ## @@ -0,0 +1,424

[GitHub] [geode] sabbeyPivotal opened a new pull request #5544: GEODE-8515: Redis PING should respond appropriately when called from within a SUBSCRIBE/PSUBSCRIBE

2020-09-23 Thread GitBox
sabbeyPivotal opened a new pull request #5544: URL: https://github.com/apache/geode/pull/5544 From PING documentation (https://redis.io/commands/ping): If the client is subscribed to a channel or a pattern, it will instead return a multi-bulk with a "pong" in the first position and

[GitHub] [geode] demery-pivotal commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
demery-pivotal commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493761722 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode] nabarunnag opened a new pull request #5546: GEODE-8523: Session state document update

2020-09-23 Thread GitBox
nabarunnag opened a new pull request #5546: URL: https://github.com/apache/geode/pull/5546 * geode-tcp and geode-membership added to the list * removed geode-json as it does not exist anymore. This is an

[GitHub] [geode] jhuynh1 commented on pull request #5546: GEODE-8523: Session state document update

2020-09-23 Thread GitBox
jhuynh1 commented on pull request #5546: URL: https://github.com/apache/geode/pull/5546#issuecomment-697809643 This might have to be backported to previous releases based on when these jars were introduced... This is an

[GitHub] [geode] jchen21 commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
jchen21 commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493856692 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode] kirklund commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
kirklund commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493739655 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode] dschneider-pivotal merged pull request #5535: GEODE-8516: Add Redis tests for multiple subscriptions for the same client

2020-09-23 Thread GitBox
dschneider-pivotal merged pull request #5535: URL: https://github.com/apache/geode/pull/5535 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] kirklund commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
kirklund commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493738369 ## File path: geode-core/src/test/java/org/apache/geode/management/bean/stats/MemberLevelStatsTest.java ## @@ -339,6 +342,41 @@ public void

[GitHub] [geode] upthewaterspout opened a new pull request #5545: GEODE-8522: Switching a exception log back to debug

2020-09-23 Thread GitBox
upthewaterspout opened a new pull request #5545: URL: https://github.com/apache/geode/pull/5545 This log message happens during the course of normal startup of multiple locators. We should not be logging a full stack trace during normal startup. Thank you for submitting a

[GitHub] [geode-native] pdxcodemonkey commented on pull request #645: GEODE-8469: Enable no-missing-variable-declarations

2020-09-23 Thread GitBox
pdxcodemonkey commented on pull request #645: URL: https://github.com/apache/geode-native/pull/645#issuecomment-697875154 I think we can diagnose the test problem with a couple of (very tedious) hours of debugging, which is a lot better than rewriting the test. I think we're much closer

[GitHub] [geode] demery-pivotal commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
demery-pivotal commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493853151 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode] jchen21 commented on a change in pull request #5516: GEODE-7679 Partitioned Region clear is successful while region is being altered

2020-09-23 Thread GitBox
jchen21 commented on a change in pull request #5516: URL: https://github.com/apache/geode/pull/5516#discussion_r493858900 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithAlterRegionDUnitTest.java ## @@ -0,0 +1,424 @@

[GitHub] [geode] jchen21 commented on a change in pull request #5516: GEODE-7679 Partitioned Region clear is successful while region is being altered

2020-09-23 Thread GitBox
jchen21 commented on a change in pull request #5516: URL: https://github.com/apache/geode/pull/5516#discussion_r493858361 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithAlterRegionDUnitTest.java ## @@ -0,0 +1,424 @@

[GitHub] [geode] kirklund commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
kirklund commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493738369 ## File path: geode-core/src/test/java/org/apache/geode/management/bean/stats/MemberLevelStatsTest.java ## @@ -339,6 +342,41 @@ public void

[GitHub] [geode-native] pdxcodemonkey opened a new pull request #655: GEODE-8524: Add support for KEY_SET and GET_ALL_70 messages

2020-09-23 Thread GitBox
pdxcodemonkey opened a new pull request #655: URL: https://github.com/apache/geode-native/pull/655 Found a log file this morning from an app that was calling `getKeys()` and `getAll()`, and discovered these message that hadn't yet been added to the parser. @alb3rtobr @mreddington

[GitHub] [geode] sabbeyPivotal commented on pull request #5538: Bump junit from 4.12 to 4.13

2020-09-23 Thread GitBox
sabbeyPivotal commented on pull request #5538: URL: https://github.com/apache/geode/pull/5538#issuecomment-697674111 I'll take a look at this one! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [geode] jinmeiliao commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
jinmeiliao commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493821071 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode] jinmeiliao commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
jinmeiliao commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493822296 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode] demery-pivotal commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
demery-pivotal commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493890530 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode] nabarunnag merged pull request #5546: GEODE-8523: Session state document update

2020-09-23 Thread GitBox
nabarunnag merged pull request #5546: URL: https://github.com/apache/geode/pull/5546 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] jinmeiliao opened a new pull request #5547: GEODE-8496: fix rest management test after dependency bump

2020-09-23 Thread GitBox
jinmeiliao opened a new pull request #5547: URL: https://github.com/apache/geode/pull/5547 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] demery-pivotal commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
demery-pivotal commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493844666 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode-native] moleske commented on pull request #645: GEODE-8469: Enable no-missing-variable-declarations

2020-09-23 Thread GitBox
moleske commented on pull request #645: URL: https://github.com/apache/geode-native/pull/645#issuecomment-697695288 @pdxcodemonkey do you think it will be easier to rewrite those tests in the new framework rather than find and fix the problem? It may take more time but long term be more

[GitHub] [geode] jinmeiliao commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
jinmeiliao commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493896136 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode] jinmeiliao commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
jinmeiliao commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493896436 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode] onichols-pivotal merged pull request #5547: GEODE-8496: fix rest management test after dependency bump

2020-09-23 Thread GitBox
onichols-pivotal merged pull request #5547: URL: https://github.com/apache/geode/pull/5547 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #645: GEODE-8469: Enable no-missing-variable-declarations

2020-09-23 Thread GitBox
pivotal-jbarrett commented on pull request #645: URL: https://github.com/apache/geode-native/pull/645#issuecomment-697999232 > I think we can diagnose the test problem with a couple of (very tedious) hours of debugging, which is a lot better than rewriting the test. I think we're much

[GitHub] [geode] sabbeyPivotal commented on pull request #5544: GEODE-8515: Redis PING should respond appropriately when called from within a SUBSCRIBE/PSUBSCRIBE

2020-09-23 Thread GitBox
sabbeyPivotal commented on pull request #5544: URL: https://github.com/apache/geode/pull/5544#issuecomment-698047025 Distributed test failure is unrelated to this PR. This is an automated message from the Apache Git Service.

[GitHub] [geode] kohlmu-pivotal opened a new pull request #5548: GEODE-8466: Introduction of ClassLoaderService as replacement

2020-09-23 Thread GitBox
kohlmu-pivotal opened a new pull request #5548: URL: https://github.com/apache/geode/pull/5548 for the direct feature usage of ClassLoader and ClassLoaderPath Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask

[GitHub] [geode] onichols-pivotal merged pull request #5540: Bump mockito from 3.3.3 to 3.5.11

2020-09-23 Thread GitBox
onichols-pivotal merged pull request #5540: URL: https://github.com/apache/geode/pull/5540 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] jinmeiliao commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
jinmeiliao commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493961781 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode] onichols-pivotal commented on pull request #5543: GEODE-8496: fix rest management test after dependency bump

2020-09-23 Thread GitBox
onichols-pivotal commented on pull request #5543: URL: https://github.com/apache/geode/pull/5543#issuecomment-697997186 Fixed by #5547 thanks! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [geode] onichols-pivotal closed pull request #5543: GEODE-8496: fix rest management test after dependency bump

2020-09-23 Thread GitBox
onichols-pivotal closed pull request #5543: URL: https://github.com/apache/geode/pull/5543 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above