Bill commented on a change in pull request #5562:
URL: https://github.com/apache/geode/pull/5562#discussion_r496068316
##
File path:
geode-core/src/test/java/org/apache/geode/internal/tcp/MsgStreamerTest.java
##
@@ -92,9 +117,9 @@ protected BaseMsgStreamer
gesterzhou closed pull request #5381:
URL: https://github.com/apache/geode/pull/5381
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Bill commented on pull request #5545:
URL: https://github.com/apache/geode/pull/5545#issuecomment-700116245
Yeah I don't think `ClassNotFound` is appropriate for retry but, as is often
the case, I bet the original developer used the IDE to write that catch block
and since both of those
jvarenina commented on pull request #656:
URL: https://github.com/apache/geode-native/pull/656#issuecomment-699804258
Thanks for the review!
This is an automated message from the Apache Git Service.
To respond to the
upthewaterspout merged pull request #5545:
URL: https://github.com/apache/geode/pull/5545
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mreddington opened a new pull request #658:
URL: https://github.com/apache/geode-native/pull/658
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gesterzhou commented on a change in pull request #5509:
URL: https://github.com/apache/geode/pull/5509#discussion_r496146173
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java
##
@@ -1118,6 +1115,24 @@ public void
moleske commented on a change in pull request #645:
URL: https://github.com/apache/geode-native/pull/645#discussion_r496186063
##
File path: cppcache/src/ExceptionTypes.cpp
##
@@ -30,8 +30,8 @@ namespace client {
void setThreadLocalExceptionMessage(std::string exMsg);
const
upthewaterspout commented on pull request #5524:
URL: https://github.com/apache/geode/pull/5524#issuecomment-700226721
One question - I see a bunch of commits with titles like "Fix spotless
issues". Are these how this commits all went on develop? Is the below really
just all one change?
upthewaterspout opened a new pull request #5566:
URL: https://github.com/apache/geode/pull/5566
This log message happens during the course of normal startup of multiple
locators. We should not be logging a full stack trace during normal startup.
(cherry picked from commit
echobravopapa commented on a change in pull request #5562:
URL: https://github.com/apache/geode/pull/5562#discussion_r496195999
##
File path:
geode-core/src/test/java/org/apache/geode/internal/tcp/MsgStreamerTest.java
##
@@ -92,9 +117,9 @@ protected BaseMsgStreamer
onichols-pivotal merged pull request #5539:
URL: https://github.com/apache/geode/pull/5539
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jhuynh1 commented on pull request #5524:
URL: https://github.com/apache/geode/pull/5524#issuecomment-700267261
@upthewaterspout unfortunately, those are how they were merged into develop.
I think someone clicked merge instead of squash and merge. Those are all part
of a set of commits
onichols-pivotal merged pull request #5565:
URL: https://github.com/apache/geode/pull/5565
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
moleske merged pull request #645:
URL: https://github.com/apache/geode-native/pull/645
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
15 matches
Mail list logo
