[GitHub] [geode-native] alb3rtobr commented on pull request #677: GEODE-8615: Update gitignore with tools/gnmsg entries

2020-10-16 Thread GitBox
alb3rtobr commented on pull request #677: URL: https://github.com/apache/geode-native/pull/677#issuecomment-709910028 cc: @pdxcodemonkey This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [geode] lgtm-com[bot] commented on pull request #5627: GEODE-8585: Redis SCAN, HSCAN, and SSCAN do not detect illegal parameters

2020-10-16 Thread GitBox
lgtm-com[bot] commented on pull request #5627: URL: https://github.com/apache/geode/pull/5627#issuecomment-710095163 This pull request **introduces 2 alerts** when merging 681e73630254e9db9800d86663411e06b28749a0 into 4c4820207e263f1a9d11f34df5cd6cd2f9daf973 - [view on

[GitHub] [geode] sabbey37 commented on a change in pull request #5627: GEODE-8585: Redis SCAN, HSCAN, and SSCAN do not detect illegal parameters

2020-10-16 Thread GitBox
sabbey37 commented on a change in pull request #5627: URL: https://github.com/apache/geode/pull/5627#discussion_r505871824 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/key/ScanExecutor.java ## @@ -36,91 +39,87 @@ public RedisResponse

[GitHub] [geode] jdeppe-pivotal opened a new pull request #5634: GEODE-8621: Redis SPOP can return incorrect string type

2020-10-16 Thread GitBox
jdeppe-pivotal opened a new pull request #5634: URL: https://github.com/apache/geode/pull/5634 - Without a count argument, SPOP should return the result as a bulk string. Authored-by: Jens Deppe Thank you for submitting a contribution to Apache Geode. In order to

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #676: GEODE-8613: Removing exclusive access to creation/closing of pool connections

2020-10-16 Thread GitBox
pivotal-jbarrett commented on pull request #676: URL: https://github.com/apache/geode-native/pull/676#issuecomment-710089765 > > I need more time to review this for correctness. I think the locking is required here to both protect concurrent updates to the `m_poolSize` value in various

[GitHub] [geode] lgtm-com[bot] removed a comment on pull request #5627: GEODE-8585: Redis SCAN, HSCAN, and SSCAN do not detect illegal parameters

2020-10-16 Thread GitBox
lgtm-com[bot] removed a comment on pull request #5627: URL: https://github.com/apache/geode/pull/5627#issuecomment-710095163 This pull request **introduces 2 alerts** when merging 681e73630254e9db9800d86663411e06b28749a0 into 4c4820207e263f1a9d11f34df5cd6cd2f9daf973 - [view on

[GitHub] [geode] kamilla1201 closed pull request #5633: WIP

2020-10-16 Thread GitBox
kamilla1201 closed pull request #5633: URL: https://github.com/apache/geode/pull/5633 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] sabbey37 merged pull request #5627: GEODE-8585: Redis SCAN, HSCAN, and SSCAN do not detect illegal parameters

2020-10-16 Thread GitBox
sabbey37 merged pull request #5627: URL: https://github.com/apache/geode/pull/5627 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] jdeppe-pivotal merged pull request #5634: GEODE-8621: Redis SPOP can return incorrect string type

2020-10-16 Thread GitBox
jdeppe-pivotal merged pull request #5634: URL: https://github.com/apache/geode/pull/5634 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #675: GEODE-8593: Update geode-native examples to use builder pattern: C++

2020-10-16 Thread GitBox
pdxcodemonkey commented on a change in pull request #675: URL: https://github.com/apache/geode-native/pull/675#discussion_r506695830 ## File path: docs/geode-native-docs-cpp/getting-started/getting-started-nc-client.html.md.erb ## @@ -37,36 +37,37 @@ To connect to a server,

[GitHub] [geode-native] davebarnes97 commented on a change in pull request #675: GEODE-8593: Update geode-native examples to use builder pattern: C++

2020-10-16 Thread GitBox
davebarnes97 commented on a change in pull request #675: URL: https://github.com/apache/geode-native/pull/675#discussion_r506703285 ## File path: docs/geode-native-docs-cpp/getting-started/getting-started-nc-client.html.md.erb ## @@ -37,36 +37,37 @@ To connect to a server,

[GitHub] [geode-native] pdxcodemonkey merged pull request #677: GEODE-8615: Update gitignore with tools/gnmsg entries

2020-10-16 Thread GitBox
pdxcodemonkey merged pull request #677: URL: https://github.com/apache/geode-native/pull/677 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] sabbey37 commented on a change in pull request #5636: GEODE-8622: Redis INCRBYFLOAT error messages are consistent with native Redis

2020-10-16 Thread GitBox
sabbey37 commented on a change in pull request #5636: URL: https://github.com/apache/geode/pull/5636#discussion_r506675816 ## File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/string/AbstractIncrByFloatIntegrationTest.java ## @@ -15,24

[GitHub] [geode] jdeppe-pivotal opened a new pull request #5636: GEODE-8622: Redis INCRBYFLOAT error messages are consistent with native Redis

2020-10-16 Thread GitBox
jdeppe-pivotal opened a new pull request #5636: URL: https://github.com/apache/geode/pull/5636 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [geode] sabbey37 commented on a change in pull request #5636: GEODE-8622: Redis INCRBYFLOAT error messages are consistent with native Redis

2020-10-16 Thread GitBox
sabbey37 commented on a change in pull request #5636: URL: https://github.com/apache/geode/pull/5636#discussion_r506701058 ## File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/string/AbstractIncrByFloatIntegrationTest.java ## @@ -15,24

[GitHub] [geode-native] davebarnes97 merged pull request #675: GEODE-8593: Update geode-native examples to use builder pattern: C++

2020-10-16 Thread GitBox
davebarnes97 merged pull request #675: URL: https://github.com/apache/geode-native/pull/675 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] sabbey37 merged pull request #5635: GEODE-8610: Add parameter checking to unsupported Redis commands

2020-10-16 Thread GitBox
sabbey37 merged pull request #5635: URL: https://github.com/apache/geode/pull/5635 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] sabbey37 opened a new pull request #5635: GEODE-8610: Add parameter checking to unsupported Redis commands

2020-10-16 Thread GitBox
sabbey37 opened a new pull request #5635: URL: https://github.com/apache/geode/pull/5635 Create tests/add parameter check This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [geode] onichols-pivotal closed pull request #5541: Bump tomcat6 from 6.0.37 to 6.0.53

2020-10-16 Thread GitBox
onichols-pivotal closed pull request #5541: URL: https://github.com/apache/geode/pull/5541 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] onichols-pivotal commented on pull request #5541: Bump tomcat6 from 6.0.37 to 6.0.53

2020-10-16 Thread GitBox
onichols-pivotal commented on pull request #5541: URL: https://github.com/apache/geode/pull/5541#issuecomment-710711422 abandoned This is an automated message from the Apache Git Service. To respond to the message, please