Why the mixed use of `MAX_OPLOG_SIZE_IN_BYTES` and the literal `10737418240l`
from one test to the next? It's not wrong, just looks inconsistent.
[ Full content available at: https://github.com/apache/geode/pull/2449 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache
I copied that from the old test. Several tests use smaller literals and
honestly, I just didn't realize that 10737418240l was equal to
MAX_OPLOG_SIZE_IN_BYTES (is it?). I'll check if they're the same and change it.
[ Full content available at: https://github.com/apache/geode/pull/2449 ]
This mes
[ pull request closed by jinmeiliao ]
[ Full content available at: https://github.com/apache/geode/pull/2446 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Fixed!
[ Full content available at: https://github.com/apache/geode/pull/2449 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thanks. Wasn't sure it was a holdover from from pre-refactor or intentional for
a reason I didn't discern.
[ Full content available at: https://github.com/apache/geode/pull/2449 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Co-authored-by: Dick Cavender
Co-authored-by: Jacob Barrett
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with
@nabarunnag this should fix the publish step in the pipeline for release 1.7.0
if you cherry pick it.
[ Full content available at: https://github.com/apache/geode/pull/2453 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This also makes the output of the process easier to read.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has
This seems more complicated than using the junitparams.Parameter approach.
[ Full content available at: https://github.com/apache/geode/pull/2452 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode/pull/2424 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Why does this need to be done in afterEvaluate?
[ Full content available at: https://github.com/apache/geode/pull/2422 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Assertion errors within invoked runnables get wrapped in an
RMIException, so untilAsserted does not recognize them as failed
assertions. Since they are treated as unexpected errors, awaitility
does not loop. Moving the awaitility inside the invocation gives us the
expected behavior.
Signed-off-by
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [X] Has y
Found during testing, relating to GEODE-5694, remove the zip artifacts for
better signing behavior
Authored-by: Robert Houghton
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been take
@pivotal-jbarrett @smgoller @nabarunnag This changes the signing behavior a
little bit, as relates to ZIP artifacts. Please check it out.
[ Full content available at: https://github.com/apache/geode/pull/2457 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by nabarunnag ]
[ Full content available at: https://github.com/apache/geode/pull/2453 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
the notifyOnly message to trigger callbacks
And computeCompressedShort should not pack inhibitAllNotifications
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been
[ Full content available at: https://github.com/apache/geode-native/pull/349 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Would `EXPECT_THROW` not work in this case?
[ Full content available at: https://github.com/apache/geode-native/pull/347 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
On GitHub this doesn't render as list making reading it more challenging. My
understanding is that lettered lists are not valid markdown. I might suggest
using either unordered lists, numbers, or using html (since that is all
markdown is anyway)
[ Full content available at:
This is a very Mac specific command, not sure that's what you intended
[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ Full content available at: https://github.com/apache/geode-native/pull/350 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
The problem with EXPECT_THROW or ASSERT_THROW is that i cannot assert that is a
CommitConflictException only an apache::geode::client::Exception (at least i
couldn't make it work with apache::geode::client::CommitConflictException) and
to be sure that is a CommitConflictException i have to exami
Commit messages fixed
[ Full content available at: https://github.com/apache/geode-native/pull/348 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
The test code seems very fond of verbose comparisons like this - how about just
`(*pIPtr != *newPiPtr)`?
[ Full content available at: https://github.com/apache/geode-native/pull/349 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Any reason we can't just delete this commented-out code?
[ Full content available at: https://github.com/apache/geode-native/pull/349 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Same here, `== true` is redundant
[ Full content available at: https://github.com/apache/geode-native/pull/349 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode-native/pull/348 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This looks like the formatter just cleaned up this comment. I'd rather stay
away from it in this commit. I used `clang-tidy` to automate the fixes and
`clang-format` to cleanup the formatting after.
[ Full content available at: https://github.com/apache/geode-native/pull/349 ]
This message was r
Again, this was mostly automated. I'd like to keep it that way.
[ Full content available at: https://github.com/apache/geode-native/pull/349 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Again, this was mostly automated. I'd like to keep it that way.
[ Full content available at: https://github.com/apache/geode-native/pull/349 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
@pdxcodemonkey Any objects to keeping the automated minimal changes. I like
your other refactoring suggestions but I'd rather do that as a result of other
non-automated work.
[ Full content available at: https://github.com/apache/geode-native/pull/349 ]
This message was relayed via gitbox.apache
You should remove any mention of "closed"
[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
You should remove any mention of "closed" or "open"
[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thanks, I'll clean that up
[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Missed that one, will clean it up
[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I'll fix this, thanks
[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
In this case, stick with an ordered list. A set of nested numbers will be OK.
[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
In this case, the nested list could be unordered.
[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by balesh2 ]
[ Full content available at: https://github.com/apache/geode/pull/2447 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thanks Dave, that's what I settled on as well. See my latest commit.
[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Missed the list formatting on this one, will fix. Thanks Dave.
[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I like the idea of this minimal task, but I somewhat agree with Anthony that
having to remember to run `./gradlew generate` is little better than having to
remember to run `./gradlew dev`.
Is there a way to hook this into the `idea` module (and for Eclipse if
necessary)? It's been a huge pain
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [X] Has y
* file saving should be handled by the command's postExecutor to save to
appropriate places
* after saving file content to a directory already, the ResultModel turned the
FileResultModel into InfoResultModel.
* gfsh should not be the place to save files in ModelCommandResult.
Thank you for submi
This change is removed from the PR. This will be addressed as part of separate
ticket.
[ Full content available at: https://github.com/apache/geode/pull/2450 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by agingade ]
[ Full content available at: https://github.com/apache/geode/pull/2450 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
There is not a way to teach IDEA to generate or run arbitrary tasks. You can
tell it to use gradle for all tasks or for none.
[ Full content available at: https://github.com/apache/geode/pull/2422 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
- Refactor Cluster class so we can apply locators separately.
- Clean up server directories at test startup.
- Add test cases for caching proxy and proxy regions with getInitialValues set
to true
- remove extraneous comment and empty doc comments
- throw exception if gfsh exits non-zero
- use rela
Makes sense, I'm fine with it as is.
[ Full content available at: https://github.com/apache/geode-native/pull/349 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pdxcodemonkey ]
[ Full content available at: https://github.com/apache/geode-native/pull/349 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode-native/pull/350 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Made all the requested changes - thanks for all the feedback!
[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This step is not required as there is no such variable in the gradle build.
[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I am missing the referenced b-e above?
[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
* Add logging to the JUnit4DistributedTestCase for test lifecycle. The
GEODE-5501 bug may be due to tests' @After executing after the next
test has started. Extra logging as to when tests are starting and ending
will help with diagnosing this failure when it occurs.
* Touch the failing test, NetSea
Good to know - was this deprecated as part of the recent build changes? Will
fix.
[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Ack yeah this is now 2-5 with the last set of changes. Will fix, thanks!
[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by kirklund ]
[ Full content available at: https://github.com/apache/geode/pull/2449 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
It never applied to Geode.
[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Too many `*` here. This is not a documentation block, just a comment block.
[ Full content available at: https://github.com/apache/geode-native/pull/351 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Will this test pass on Windows?
[ Full content available at: https://github.com/apache/geode/pull/2460 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by mcmellawatt ]
[ Full content available at: https://github.com/apache/geode/pull/2456 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Turns out it does not. I had both generation tasks using identical formatting
for consistency, but it is not needed here. I have removed the block for this
dependency change.
[ Full content available at: https://github.com/apache/geode/pull/2422 ]
This message was relayed via gitbox.apache.org f
After recent move to Mockito, we found that this test doesn't fail when
we break the corresponding product code e.g. changing hasFlagsField() to
always return true should break tests but doesn't.
We verified that the test named like TxCommitMessageBC* do a better job
of checking serialization of T
@pivotal-jbarrett @nabarunnag @upthewaterspout
[ Full content available at: https://github.com/apache/geode/pull/2462 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
For this and the following test `mytemp` is created in the `tempFolder` so
explicit deletion shouldn't be necessary.
[ Full content available at: https://github.com/apache/geode/pull/2460 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
A more descriptive message as to why this change is desired would be great. As
it is, the change looks OK but I wouldn't know why.
Looking at the JIRA, it seems we need the value to be > 8 bytes. What is the
actual size in bytes of these string values?
[ Full content available at: https://gith
This code was not in a good state. So the code has been refactored to not only
address issues
where the code was giving bad feedback, but to address the impressive
structural duplication.
Things done:
-Extracted a bunch of methods
-Added new Test files for test subjects that should have been sep
If a user wants to extend Gradle's Docker plugin with their own tests,
setting dunitDockerVolumes to some value, then that value will be
overridden in docker.gradle. For better extensibility, do not set this
property if it is already set.
[ Full content available at: https://github.com/apache/geo
actually the exported files without absolute paths is written to the user.dir,
so we need an explicit delete both here and the test below. The test below is
deleting the wrong file. I checked a fix for that.
[ Full content available at: https://github.com/apache/geode/pull/2460 ]
This message wa
This `if` block used to live in `build.gradle`. I believe the correct fix is to
push it back there. Any 'other' projects, pulling in geode would then have the
ability to override the `dunitDockerVolumes` variable. As it stands, it is
_always_ going to be reset here which is incorrect.
[ Full co
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thanks. I stand corrected.
[ Full content available at: https://github.com/apache/geode/pull/2460 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by jinmeiliao ]
[ Full content available at: https://github.com/apache/geode/pull/2460 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Auto
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Obvious comments should be omitted.
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Auto
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Formatting seems inconsistent
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Auto
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Why muddy the example with types we have to cast?
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
> A more descriptive message as to why this change is desired would be great.
> As it is, the change looks OK but I wouldn't know why.
>
> Looking at the JIRA, it seems we need the value to be > 8 bytes. What is the
> actual size in bytes of these string values?
@pdxrunner - would "Using <8 bit
> A more descriptive message as to why this change is desired would be great.
> As it is, the change looks OK but I wouldn't know why.
>
> Looking at the JIRA, it seems we need the value to be > 8 bytes. What is the
> actual size in bytes of these string values?
@pdxrunner - would "Using <8 bit
[ pull request closed by galen-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/2464 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by upthewaterspout ]
[ Full content available at: https://github.com/apache/geode/pull/2452 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
> > A more descriptive message as to why this change is desired would be great.
> > As it is, the change looks OK but I wouldn't know why.
> > Looking at the JIRA, it seems we need the value to be > 8 bytes. What is
> > the actual size in bytes of these string values?
>
> @pdxrunner - would "Usi
@upthewaterspout @WireBaron @balesh2 Please review when you get the chance.
[ Full content available at: https://github.com/apache/geode/pull/2463 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
`pf` isn't a great name for such otherwise beautiful new code.
[ Full content available at: https://github.com/apache/geode-native/pull/351 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Will do, thanks Ken!
[ Full content available at: https://github.com/apache/geode/pull/2459 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by mcmellawatt ]
[ Full content available at: https://github.com/apache/geode/pull/2459 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Spurious failure
```
> Task :geode-core:test
org.apache.geode.internal.process.lang.AvailablePidTest >
findAvailablePidShouldNotReturnLivePid FAILED
org.junit.runners.model.TestTimedOutException: test timed out after 20
seconds
at java.nio.DirectByteBuffer.(DirectByteBuffer.java:162)
[ pull request closed by PurelyApplied ]
[ Full content available at: https://github.com/apache/geode/pull/2457 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by jhuynh1 ]
[ Full content available at: https://github.com/apache/geode/pull/2433 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by jinmeiliao ]
[ Full content available at: https://github.com/apache/geode/pull/2454 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [x] Has y
Removed tabs and fixed indentation
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Fixed
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Yeah, kinda silly. Fixed types, and fixed in other copies of
Order.cpp/Order.hpp in examples.
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Fixed
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Formatting? Why did you move from right to left spacing? I believe all the
other sources and most of Geode is right spaced.
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
1 - 100 of 9074 matches
Mail list logo
