[GitHub] [geode] Bill commented on pull request #4590: GEODE-7698: Extracting a superclass of InternalDistributedMember
now be a good time to give this method a meaningful name [ Full content available at: https://github.com/apache/geode/pull/4590 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Bill commented on pull request #4590: GEODE-7698: Extracting a superclass of InternalDistributedMember
Nice how having to call `super` forced us to put the extra logic into a method (`getInetAddress`). [ Full content available at: https://github.com/apache/geode/pull/4590 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Bill commented on pull request #4590: GEODE-7698: Extracting a superclass of InternalDistributedMember
is the reason for this change conscious uncoupling from the `MemberIdentifierFactoryImpl` class? [ Full content available at: https://github.com/apache/geode/pull/4590 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] Bill commented on pull request #4590: GEODE-7698: Extracting a superclass of InternalDistributedMember
ah I see why you moved this logic here from `InternalDataSerializer`: the latter is in `geode-core` and our new `MemberIdentifierImpl` is down in `geode-membership` and can't depend on stuff in core ✓ [ Full content available at: https://github.com/apache/geode/pull/4590 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
