[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

2020-06-24 Thread GitBox
jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r445205109 ## File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/string/StringsIntegrationTest.java ## @@ -0,0 +1,1637 @@

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

2020-06-24 Thread GitBox
jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r445204696 ## File path: geode-redis/src/test/java/org/apache/geode/redis/internal/executor/string/StringSetExecutorJUnitTest.java ## @@ -213,4 +229,34 @@ public

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

2020-06-24 Thread GitBox
jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r445204473 ## File path: geode-redis/src/test/java/org/apache/geode/redis/internal/executor/string/StringSetExecutorJUnitTest.java ## @@ -213,4 +229,34 @@ public

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

2020-06-15 Thread GitBox
jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r440443210 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/key/RenameExecutor.java ## @@ -16,34 +16,35 @@ package

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

2020-06-11 Thread GitBox
jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r439078174 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/string/SetExecutor.java ## @@ -35,105 +37,182 @@ public

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

2020-06-11 Thread GitBox
jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r439070387 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/string/SetExecutor.java ## @@ -35,105 +37,182 @@ public

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

2020-06-11 Thread GitBox
jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r439065784 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/string/SetExecutor.java ## @@ -35,105 +37,182 @@ public

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

2020-06-11 Thread GitBox
jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r439055432 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/string/SetExecutor.java ## @@ -35,105 +37,182 @@ public

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

2020-06-11 Thread GitBox
jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r439053138 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/string/SetExecutor.java ## @@ -35,105 +37,182 @@ public

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

2020-06-11 Thread GitBox
jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r439053138 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/string/SetExecutor.java ## @@ -35,105 +37,182 @@ public

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

2020-06-05 Thread GitBox
jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r436187614 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/string/SetExecutor.java ## @@ -68,72 +75,141 @@ private

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

2020-06-05 Thread GitBox
jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r436187466 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/string/SetExecutor.java ## @@ -68,72 +75,141 @@ private

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

2020-06-05 Thread GitBox
jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r436079328 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/string/SetExecutor.java ## @@ -68,72 +75,141 @@ private

[GitHub] [geode] jhutchison commented on a change in pull request #5216: Refactor set executor

2020-06-05 Thread GitBox
jhutchison commented on a change in pull request #5216: URL: https://github.com/apache/geode/pull/5216#discussion_r436079564 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/string/SetExecutor.java ## @@ -68,72 +75,141 @@ private