I'm not sure why we didn't consider "worth it" adding a `default`
implementation for `getDiskUsagePercentage` in
[GEODE-5222](https://issues.apache.org/jira/browse/GEODE-5222), I'm tagging the
original reviewers as they might have more context than me on this one.
Either way, unless there's a
Since you're already modifying the test name, can you please remove the
underscores and use camel case instead?.
[ Full content available at: https://github.com/apache/geode/pull/4067 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
The name should read something like
`givenDiskStoreIsCreatedWithMaxSizeThenDiskUsagePercentageShouldBeZeroAndDiskFreePercentageShouldBe100`.
[ Full content available at: https://github.com/apache/geode/pull/4067 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Since you're already modifying the test name, can you please remove the
underscores and use camel case instead?.
[ Full content available at: https://github.com/apache/geode/pull/4067 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This is a public interface, even though I rarely see people manually
implementing it, the addition of a new method would break backward
compatibility... would it make sense to add a `default` implementation?.
[ Full content available at: https://github.com/apache/geode/pull/4067 ]
This message
