[GitHub] [geode] jvarenina commented on pull request #5139: GEODE-8149: New parameter and property introduced

2020-06-18 Thread GitBox


jvarenina commented on pull request #5139:
URL: https://github.com/apache/geode/pull/5139#issuecomment-645803468


   Hi,
   Yes, property is introduced for future works.
   The reason I didn't update this PR is because we faced some issues when 
developing this feature which could affect this PR greatly when resolved. We 
have problem with retrieving certificates from RMI connections(e.g. jmx 
connections) and I will send more info related to this issue in dev list. We 
have also put on hold all other task related to this feature until we find the 
solution for RMI Connections. 
   @davebarnes97 thanks again for comments I will try to implement them as soon 
as possible.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [geode] jvarenina commented on pull request #5139: GEODE-8149: New parameter and property introduced

2020-05-22 Thread GitBox


jvarenina commented on pull request #5139:
URL: https://github.com/apache/geode/pull/5139#issuecomment-632540478


   > This PR provides documentation at the Javadoc level.
   > Consider where in the User Guide this should be mentioned, then
   > 
   > * add a User Guide explanation as part of this PR/JIRA combination, or
   > 
   > * add a subticket to GEODE-8118, the parent ticket of this one 
(GEODE-8149) to handle the User Guide docs.
   >   Either of the above will satisfy my concern. Thanks.
   
   OK, I will create sub-ticket to handle User Guide docs.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org