[GitHub] [geode] mcmellawatt commented on pull request #4003: GEODE-6964: Move geode log4j core classes to geode-log4j

2019-09-17 Thread GitHub 
Probably fully qualified from a move refactor

[ Full content available at: https://github.com/apache/geode/pull/4003 ]
This message was relayed via gitbox.apache.org for 
notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #4003: GEODE-6964: Move geode log4j core classes to geode-log4j

2019-09-17 Thread GitHub 
Is this TODO still relevant?  If not, can we remove it?  If so, can we address 
it in this PR or create a follow up ticket and remove the TODO?

[ Full content available at: https://github.com/apache/geode/pull/4003 ]
This message was relayed via gitbox.apache.org for 
notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #4003: GEODE-6964: Move geode log4j core classes to geode-log4j

2019-09-17 Thread GitHub 
Fully qualified?

[ Full content available at: https://github.com/apache/geode/pull/4003 ]
This message was relayed via gitbox.apache.org for 
notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #4003: GEODE-6964: Move geode log4j core classes to geode-log4j

2019-09-17 Thread GitHub 
We used `implementation` here before which would have hidden the log4j API from 
consumers of geode-core.  Is that not what we want in this new model, since we 
are now using `api`?

[ Full content available at: https://github.com/apache/geode/pull/4003 ]
This message was relayed via gitbox.apache.org for 
notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #4003: GEODE-6964: Move geode log4j core classes to geode-log4j

2019-09-17 Thread GitHub 
These header changes makes me think that maybe someone's IntelliJ formatting is 
setup differently?  Do we want these changes?

[ Full content available at: https://github.com/apache/geode/pull/4003 ]
This message was relayed via gitbox.apache.org for 
notifications@geode.apache.org

[GitHub] [geode] mcmellawatt commented on pull request #4003: GEODE-6964: Move geode log4j core classes to geode-log4j

2019-09-17 Thread GitHub 
Does AlertinService need to be fully qualified here?

[ Full content available at: https://github.com/apache/geode/pull/4003 ]
This message was relayed via gitbox.apache.org for 
notifications@geode.apache.org