[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5130: GEODE-8145: Add Redis configuration properties to gemfire_properties.html
sabbeyPivotal commented on a change in pull request #5130: URL: https://github.com/apache/geode/pull/5130#discussion_r428790389 ## File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb ## @@ -33,24 +33,26 @@ commands. Use gfsh to start at least one server with a command of the form: ``` pre -start server --name= --locators= --redis-port= --redis-bind-address= +start server --name= --locators= --redis-port= --redis-bind-address= --redis-password= ``` Replace `` with the name of your server. Replace `` with your locator port. -Replace `` with the port that the <%=vars.product_name%> server will listen on for Redis commands. The typical port used with a Redis cluster is 6379. +Replace `` with the port that the <%=vars.product_name%> server listens on for Redis commands. The typical port used with a Redis cluster is 6379. -Replace `` with the IP address of the server host. If this option is not specified, the default is determined from the `/etc/hosts` file. +Replace `` with the IP address of the server host. Review comment: Updated! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5130: GEODE-8145: Add Redis configuration properties to gemfire_properties.html
sabbeyPivotal commented on a change in pull request #5130: URL: https://github.com/apache/geode/pull/5130#discussion_r428631488 ## File path: geode-docs/reference/topics/gemfire_properties.html.md.erb ## @@ -488,26 +488,31 @@ off-heap-memory-size=120g redis-bind-address -Specifies the bind address used by Redis API for <%=vars.product_name%>. If "" or no bind address -specified, the default will be requested from the operating system. +Specifies the address on which the Redis API for <%=vars.product_name%> is listening. If set to the empty string or this property is not +specified, localhost is requested from the operating system. S -"" +`""` Review comment: Updated it! It seems to look ok now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5130: GEODE-8145: Add Redis configuration properties to gemfire_properties.html
sabbeyPivotal commented on a change in pull request #5130: URL: https://github.com/apache/geode/pull/5130#discussion_r428179280 ## File path: geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java ## @@ -1929,7 +1929,8 @@ * The static String definition of the "redis-bind-address" property * - * Description: Specifies the bind address used by Redis API for Geode + * Description: Specifies the bind address used by Redis API for Geode. If "" or no bind Review comment: I made a Jira for it: https://issues.apache.org/jira/browse/GEODE-8158 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5130: GEODE-8145: Add Redis configuration properties to gemfire_properties.html
sabbeyPivotal commented on a change in pull request #5130: URL: https://github.com/apache/geode/pull/5130#discussion_r428179280 ## File path: geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java ## @@ -1929,7 +1929,8 @@ * The static String definition of the "redis-bind-address" property * - * Description: Specifies the bind address used by Redis API for Geode + * Description: Specifies the bind address used by Redis API for Geode. If "" or no bind Review comment: I made a PR for it: https://issues.apache.org/jira/browse/GEODE-8158 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5130: GEODE-8145: Add Redis configuration properties to gemfire_properties.html
sabbeyPivotal commented on a change in pull request #5130: URL: https://github.com/apache/geode/pull/5130#discussion_r427481422 ## File path: geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java ## @@ -1929,7 +1929,8 @@ * The static String definition of the "redis-bind-address" property * - * Description: Specifies the bind address used by Redis API for Geode + * Description: Specifies the bind address used by Redis API for Geode. If "" specified, + * the default is determined from the /etc/hosts file. Review comment: We use LocalHostUtil.getLocalHost() I like your wording. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
