[GitHub] [geode-native] moleske commented on a change in pull request #645: GEODE-8469: Enable no-missing-variable-declarations

moleske commented on a change in pull request #645: URL: https://github.com/apache/geode-native/pull/645#discussion_r496186063 ## File path: cppcache/src/ExceptionTypes.cpp ## @@ -30,8 +30,8 @@ namespace client { void setThreadLocalExceptionMessage(std::string exMsg); const

[GitHub] [geode-native] moleske commented on a change in pull request #645: GEODE-8469: Enable no-missing-variable-declarations

moleske commented on a change in pull request #645: URL: https://github.com/apache/geode-native/pull/645#discussion_r488063324 ## File path: cppcache/benchmark/GeodeLoggingBM.cpp ## @@ -35,9 +35,9 @@ using apache::geode::client::internal::geode_hash; const int

[GitHub] [geode-native] moleske commented on a change in pull request #645: GEODE-8469: Enable no-missing-variable-declarations

moleske commented on a change in pull request #645: URL: https://github.com/apache/geode-native/pull/645#discussion_r481562738 ## File path: tests/cpp/security/XmlAuthzCredentialGenerator.hpp ## @@ -55,7 +55,7 @@ const opCodeList::value_type QArr[] = {OP_QUERY,

[GitHub] [geode-native] moleske commented on a change in pull request #645: GEODE-8469: Enable no-missing-variable-declarations

moleske commented on a change in pull request #645: URL: https://github.com/apache/geode-native/pull/645#discussion_r481420359 ## File path: cppcache/integration-test/fw_dunit.cpp ## @@ -71,10 +71,10 @@ using apache::geode::client::testframework::BBNamingContextServer;

[GitHub] [geode-native] moleske commented on a change in pull request #645: GEODE-8469: Enable no-missing-variable-declarations

moleske commented on a change in pull request #645: URL: https://github.com/apache/geode-native/pull/645#discussion_r481420359 ## File path: cppcache/integration-test/fw_dunit.cpp ## @@ -71,10 +71,10 @@ using apache::geode::client::testframework::BBNamingContextServer;