[jira] [Commented] (GROOVY-8269) Unclear/incorrect definition of default behavior for trait multiple inheritence conflicts

2017-08-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GROOVY-8269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125029#comment-16125029
 ] 

ASF GitHub Bot commented on GROOVY-8269:


Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/582


> Unclear/incorrect definition of default behavior for trait multiple 
> inheritence conflicts
> -
>
> Key: GROOVY-8269
> URL: https://issues.apache.org/jira/browse/GROOVY-8269
> Project: Groovy
>  Issue Type: Documentation
>  Components: Documentation
>Affects Versions: 2.4.12
>Reporter: Sasha Volokh
>Priority: Minor
> Attachments: problem.png
>
>
> In section 2.10.1, Default conflict resolution, the text says "In this case, 
> the default behavior is that methods from the last declared trait wins", when 
> in fact the order they are implemented is what decides the winning method 
> (and if this is what the wording was intending to say, then it isn't clear 
> because the example has trait B declared after trait A as well as C 
> implementing B after A).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GROOVY-8269) Unclear/incorrect definition of default behavior for trait multiple inheritence conflicts

2017-08-13 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/GROOVY-8269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125016#comment-16125016
 ] 

ASF GitHub Bot commented on GROOVY-8269:


GitHub user jwagenleitner opened a pull request:

https://github.com/apache/groovy/pull/582

GROOVY-8269: Unclear definition of default behavior for trait multipl…

…e inheritance conflicts

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jwagenleitner/groovy 8269-trait-conflict-doc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/582.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #582


commit ca3a10c1e22be899bcd8534a7aee4f5bdaf197d2
Author: John Wagenleitner 
Date:   2017-08-13T19:07:33Z

GROOVY-8269: Unclear definition of default behavior for trait multiple 
inheritance conflicts




> Unclear/incorrect definition of default behavior for trait multiple 
> inheritence conflicts
> -
>
> Key: GROOVY-8269
> URL: https://issues.apache.org/jira/browse/GROOVY-8269
> Project: Groovy
>  Issue Type: Documentation
>  Components: Documentation
>Affects Versions: 2.4.12
>Reporter: Sasha Volokh
>Priority: Minor
> Attachments: problem.png
>
>
> In section 2.10.1, Default conflict resolution, the text says "In this case, 
> the default behavior is that methods from the last declared trait wins", when 
> in fact the order they are implemented is what decides the winning method 
> (and if this is what the wording was intending to say, then it isn't clear 
> because the example has trait B declared after trait A as well as C 
> implementing B after A).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GROOVY-8269) Unclear/incorrect definition of default behavior for trait multiple inheritence conflicts

2017-08-13 Thread Sasha Volokh (JIRA)

[ 
https://issues.apache.org/jira/browse/GROOVY-8269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124834#comment-16124834
 ] 

Sasha Volokh commented on GROOVY-8269:
--

Yeah, that'd be great.

> Unclear/incorrect definition of default behavior for trait multiple 
> inheritence conflicts
> -
>
> Key: GROOVY-8269
> URL: https://issues.apache.org/jira/browse/GROOVY-8269
> Project: Groovy
>  Issue Type: Documentation
>  Components: Documentation
>Affects Versions: 2.4.12
>Reporter: Sasha Volokh
>Priority: Minor
> Attachments: problem.png
>
>
> In section 2.10.1, Default conflict resolution, the text says "In this case, 
> the default behavior is that methods from the last declared trait wins", when 
> in fact the order they are implemented is what decides the winning method 
> (and if this is what the wording was intending to say, then it isn't clear 
> because the example has trait B declared after trait A as well as C 
> implementing B after A).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GROOVY-8269) Unclear/incorrect definition of default behavior for trait multiple inheritence conflicts

2017-08-12 Thread John Wagenleitner (JIRA)

[ 
https://issues.apache.org/jira/browse/GROOVY-8269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124810#comment-16124810
 ] 

John Wagenleitner commented on GROOVY-8269:
---

Would adding a reference to the implements clause help make it more clear?

{quote}
In this case, the default behavior is that the method from the *last declared 
trait* in the {{implements}} clause wins.
{quote}

> Unclear/incorrect definition of default behavior for trait multiple 
> inheritence conflicts
> -
>
> Key: GROOVY-8269
> URL: https://issues.apache.org/jira/browse/GROOVY-8269
> Project: Groovy
>  Issue Type: Documentation
>  Components: Documentation
>Affects Versions: 2.4.12
>Reporter: Sasha Volokh
>Priority: Minor
> Attachments: problem.png
>
>
> In section 2.10.1, Default conflict resolution, the text says "In this case, 
> the default behavior is that methods from the last declared trait wins", when 
> in fact the order they are implemented is what decides the winning method 
> (and if this is what the wording was intending to say, then it isn't clear 
> because the example has trait B declared after trait A as well as C 
> implementing B after A).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GROOVY-8269) Unclear/incorrect definition of default behavior for trait multiple inheritence conflicts

2017-07-27 Thread Sasha Volokh (JIRA)

[ 
https://issues.apache.org/jira/browse/GROOVY-8269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104425#comment-16104425
 ] 

Sasha Volokh commented on GROOVY-8269:
--

Added the version number.

> Unclear/incorrect definition of default behavior for trait multiple 
> inheritence conflicts
> -
>
> Key: GROOVY-8269
> URL: https://issues.apache.org/jira/browse/GROOVY-8269
> Project: Groovy
>  Issue Type: Documentation
>  Components: Documentation
>Affects Versions: 2.4.12
>Reporter: Sasha Volokh
>Priority: Minor
> Attachments: problem.png
>
>
> In section 2.10.1, Default conflict resolution, the text says "In this case, 
> the default behavior is that methods from the last declared trait wins", when 
> in fact the order they are implemented is what decides the winning method 
> (and if this is what the wording was intending to say, then it isn't clear 
> because the example has trait B declared after trait A as well as C 
> implementing B after A).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (GROOVY-8269) Unclear/incorrect definition of default behavior for trait multiple inheritence conflicts

2017-07-26 Thread Paul King (JIRA)

[ 
https://issues.apache.org/jira/browse/GROOVY-8269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102610#comment-16102610
 ] 

Paul King commented on GROOVY-8269:
---

I haven't had time to check yet but if you can include which Groovy version(s) 
you are using, that would be great. Thanks.

> Unclear/incorrect definition of default behavior for trait multiple 
> inheritence conflicts
> -
>
> Key: GROOVY-8269
> URL: https://issues.apache.org/jira/browse/GROOVY-8269
> Project: Groovy
>  Issue Type: Documentation
>  Components: Documentation
>Reporter: Sasha Volokh
>Priority: Minor
> Attachments: problem.png
>
>
> In section 2.10.1, Default conflict resolution, the text says "In this case, 
> the default behavior is that methods from the last declared trait wins", when 
> in fact the order they are implemented is what decides the winning method 
> (and if this is what the wording was intending to say, then it isn't clear 
> because the example has trait B declared after trait A as well as C 
> implementing B after A).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)