[jira] [Commented] (GROOVY-7535) Groovy category throwing MissingMethodException and MissingPropertyException when using multiple threads

2017-05-18 Thread Jochen Kemnade (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015265#comment-16015265 ] Jochen Kemnade commented on GROOVY-7535: The updated PR looks good to me. > Groovy category

[jira] [Commented] (GROOVY-8188) Unpredictable behavior - Compiler error: groovyc: You are not allowed to override the final method

2017-05-18 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015339#comment-16015339 ] Paul King commented on GROOVY-8188: --- Ah, okay, I didn't see it before. It's a bridge method added for a

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-18 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r117188688 --- Diff: src/main/groovy/lang/MetaClassImpl.java --- @@ -1832,6 +1832,9 @@ public Object getProperty(Class sender, Object object, String name, boolean

[jira] [Comment Edited] (GROOVY-8188) Unpredictable behavior - Compiler error: groovyc: You are not allowed to override the final method

2017-05-18 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015339#comment-16015339 ] Paul King edited comment on GROOVY-8188 at 5/18/17 7:35 AM: Ah, okay, I

[jira] [Comment Edited] (GROOVY-8188) Unpredictable behavior - Compiler error: groovyc: You are not allowed to override the final method

2017-05-18 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015339#comment-16015339 ] Paul King edited comment on GROOVY-8188 at 5/18/17 7:35 AM: Ah, okay, I

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-18 Thread blackdrag
Github user blackdrag commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r117177601 --- Diff: src/main/groovy/lang/MetaClassImpl.java --- @@ -1832,6 +1832,9 @@ public Object getProperty(Class sender, Object object, String name, boolean

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-18 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r117188226 --- Diff: src/main/org/codehaus/groovy/reflection/CachedMethod.java --- @@ -90,6 +92,12 @@ public CachedClass getDeclaringClass() { public

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-18 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r117188013 --- Diff: src/main/groovy/lang/MetaClassImpl.java --- @@ -1832,6 +1832,9 @@ public Object getProperty(Class sender, Object object, String name, boolean

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-18 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r117188820 --- Diff: src/main/groovy/lang/MetaClassImpl.java --- @@ -1832,6 +1832,9 @@ public Object getProperty(Class sender, Object object, String name, boolean

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-18 Thread blackdrag
Github user blackdrag commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r117177738 --- Diff: src/main/org/codehaus/groovy/reflection/CachedMethod.java --- @@ -90,6 +92,12 @@ public CachedClass getDeclaringClass() { public

[jira] [Commented] (GROOVY-4985) null and .with{}

2017-05-18 Thread Jochen Kemnade (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015604#comment-16015604 ] Jochen Kemnade commented on GROOVY-4985: The assertion fails in 2.2.1 and succeeds in 2.2.2. >

[jira] [Commented] (GROOVY-4985) null and .with{}

2017-05-18 Thread Jochen Kemnade (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015605#comment-16015605 ] Jochen Kemnade commented on GROOVY-4985: The assertion fails in 2.2.1 and succeeds in 2.2.2. >

[jira] [Commented] (GROOVY-5769) NullObject leak

2017-05-18 Thread Jochen Kemnade (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-5769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015558#comment-16015558 ] Jochen Kemnade commented on GROOVY-5769: The script runs fine with 2.4.11. > NullObject leak >

[jira] [Commented] (GROOVY-5769) NullObject leak

2017-05-18 Thread Jochen Kemnade (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-5769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015589#comment-16015589 ] Jochen Kemnade commented on GROOVY-5769: Fixed in 2.4.6 via GROOVY-6958 > NullObject leak >

[jira] [Commented] (GROOVY-5769) NullObject leak

2017-05-18 Thread Jochen Kemnade (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-5769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015705#comment-16015705 ] Jochen Kemnade commented on GROOVY-5769: Oh, I just read the issue description, that made it

[jira] [Commented] (GROOVY-8188) Unpredictable behavior - Compiler error: groovyc: You are not allowed to override the final method

2017-05-18 Thread Jochen Theodorou (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016421#comment-16016421 ] Jochen Theodorou commented on GROOVY-8188: -- frankly I do not understand the javac behaviour here

[jira] [Commented] (GROOVY-7535) Groovy category throwing MissingMethodException and MissingPropertyException when using multiple threads

2017-05-18 Thread Jochen Theodorou (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016347#comment-16016347 ] Jochen Theodorou commented on GROOVY-7535: -- ok, let me propose an alternative fix... remove

[jira] [Commented] (GROOVY-7535) Groovy category throwing MissingMethodException and MissingPropertyException when using multiple threads

2017-05-18 Thread Jochen Theodorou (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016429#comment-16016429 ] Jochen Theodorou commented on GROOVY-7535: -- John, I thought this information is not used in the

[jira] [Commented] (GROOVY-7535) Groovy category throwing MissingMethodException and MissingPropertyException when using multiple threads

2017-05-18 Thread Jochen Theodorou (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016486#comment-16016486 ] Jochen Theodorou commented on GROOVY-7535: -- Let me modify your example from before: 1. T1 in

[jira] [Commented] (GROOVY-7535) Groovy category throwing MissingMethodException and MissingPropertyException when using multiple threads

2017-05-18 Thread Jochen Theodorou (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016499#comment-16016499 ] Jochen Theodorou commented on GROOVY-7535: -- I think I am ok with the change in total now. >

[jira] [Commented] (GROOVY-7535) Groovy category throwing MissingMethodException and MissingPropertyException when using multiple threads

2017-05-18 Thread John Wagenleitner (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016441#comment-16016441 ] John Wagenleitner commented on GROOVY-7535: --- That is true, I have not been able to find a

[jira] [Commented] (GROOVY-7535) Groovy category throwing MissingMethodException and MissingPropertyException when using multiple threads

2017-05-18 Thread John Wagenleitner (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016405#comment-16016405 ] John Wagenleitner commented on GROOVY-7535: --- I updated the PR, my assumption still being that

[jira] [Issue Comment Deleted] (GROOVY-4985) null and .with{}

2017-05-18 Thread Jochen Kemnade (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jochen Kemnade updated GROOVY-4985: --- Comment: was deleted (was: The assertion fails in 2.2.1 and succeeds in 2.2.2.) > null and

[jira] [Commented] (GROOVY-5769) NullObject leak

2017-05-18 Thread Jochen Theodorou (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-5769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015681#comment-16015681 ] Jochen Theodorou commented on GROOVY-5769: -- The issue author is complaining about this script