[GitHub] [groovy] expexes opened a new pull request #993: Added --compile-static (-cs) and --type-checked (-tc) cli options

2019-08-15 Thread GitBox
expexes opened a new pull request #993: Added --compile-static (-cs) and --type-checked (-tc) cli options URL: https://github.com/apache/groovy/pull/993 Options added to following classes: - `groovy.ui.GroovyMain` - `org.codehaus.groovy.tools.FileSystemCompiler` *also trivial

[jira] [Resolved] (GROOVY-9223) Avoid generating common methods for each groovy class

2019-08-15 Thread Daniel Sun (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun resolved GROOVY-9223. Resolution: Fixed Fixed by 

[GitHub] [groovy] danielsun1106 merged pull request #990: GROOVY-9223: Avoid generating common methods for each groovy class

2019-08-15 Thread GitBox
danielsun1106 merged pull request #990: GROOVY-9223: Avoid generating common methods for each groovy class URL: https://github.com/apache/groovy/pull/990 This is an automated message from the Apache Git Service. To respond

[GitHub] [groovy] blackdrag commented on issue #990: GROOVY-9223: Avoid generating common methods for each groovy class

2019-08-15 Thread GitBox
blackdrag commented on issue #990: GROOVY-9223: Avoid generating common methods for each groovy class URL: https://github.com/apache/groovy/pull/990#issuecomment-521622589 I am actually a bit surprised there has been no problem with the meta class invocation logic here, because I remember

[GitHub] [groovy] danielsun1106 commented on issue #990: GROOVY-9223: Avoid generating common methods for each groovy class

2019-08-15 Thread GitBox
danielsun1106 commented on issue #990: GROOVY-9223: Avoid generating common methods for each groovy class URL: https://github.com/apache/groovy/pull/990#issuecomment-521626662 Thanks for your definitive reviewing  When I saw you had approved the PR, I merged it.

[jira] [Updated] (GROOVY-9223) Avoid generating common methods for each groovy class

2019-08-15 Thread Daniel Sun (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-9223: --- Description: {{invokeMethod}}, {{getProperty}} and {{setProperty}} are common for groovy classes,

[jira] [Updated] (GROOVY-9228) CLI options for static compilation

2019-08-15 Thread Davyd Kohut (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davyd Kohut updated GROOVY-9228: External issue URL: (was: https://github.com/apache/groovy/pull/993) > CLI options for static

[jira] [Created] (GROOVY-9228) CLI options for static compilation

2019-08-15 Thread Davyd Kohut (JIRA)
Davyd Kohut created GROOVY-9228: --- Summary: CLI options for static compilation Key: GROOVY-9228 URL: https://issues.apache.org/jira/browse/GROOVY-9228 Project: Groovy Issue Type: Improvement

[jira] [Updated] (GROOVY-9228) CLI options for static compilation

2019-08-15 Thread Daniel Sun (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-9228: --- Priority: Minor (was: Trivial) > CLI options for static compilation >

[jira] [Commented] (GROOVY-9211) BUG! UNCAUGHT EXCEPTION on OpenJDK14-ea+8

2019-08-15 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908019#comment-16908019 ] Paul King commented on GROOVY-9211: --- [~blackdrag] Yes, true - I had accidentally tried an experiment

[GitHub] [groovy] expexes commented on issue #993: Added --compile-static (-cs) and --type-checked (-tc) cli options

2019-08-15 Thread GitBox
expexes commented on issue #993: Added --compile-static (-cs) and --type-checked (-tc) cli options URL: https://github.com/apache/groovy/pull/993#issuecomment-521670249 JIRA ticket:

[jira] [Commented] (GROOVY-9211) BUG! UNCAUGHT EXCEPTION on OpenJDK14-ea+8

2019-08-15 Thread Daniel Sun (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908093#comment-16908093 ] Daniel Sun commented on GROOVY-9211: Nice! > BUG! UNCAUGHT EXCEPTION on OpenJDK14-ea+8 >

[GitHub] [groovy] danielsun1106 commented on issue #993: GROOVY-9228: CLI options for static compilation

2019-08-15 Thread GitBox
danielsun1106 commented on issue #993: GROOVY-9228: CLI options for static compilation URL: https://github.com/apache/groovy/pull/993#issuecomment-521673045 LGTM. BTW, could you expand the imports, e.g. `import groovy.lang.*;`? Groovy core team has a coding convention: import the

[GitHub] [groovy] danielsun1106 commented on issue #993: Added --compile-static (-cs) and --type-checked (-tc) cli options

2019-08-15 Thread GitBox
danielsun1106 commented on issue #993: Added --compile-static (-cs) and --type-checked (-tc) cli options URL: https://github.com/apache/groovy/pull/993#issuecomment-521628370 I like your idea. Would you please create a JIRA ticket to describe your idea in details?

[jira] [Created] (GROOVY-9226) Call super.toString() with @TypeChecked or @CompileStatic will throw java.lang.StackOverflowError

2019-08-15 Thread Chih Chao Yu (JIRA)
Chih Chao Yu created GROOVY-9226: Summary: Call super.toString() with @TypeChecked or @CompileStatic will throw java.lang.StackOverflowError Key: GROOVY-9226 URL: https://issues.apache.org/jira/browse/GROOVY-9226

[jira] [Commented] (GROOVY-9225) Parser error on certain map keys

2019-08-15 Thread JIRA
[ https://issues.apache.org/jira/browse/GROOVY-9225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907907#comment-16907907 ] Søren Markert commented on GROOVY-9225: --- "Ahaaa" :P > Parser error on certain map keys >

[jira] [Comment Edited] (GROOVY-9225) Parser error on certain map keys

2019-08-15 Thread JIRA
[ https://issues.apache.org/jira/browse/GROOVY-9225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907907#comment-16907907 ] Søren Markert edited comment on GROOVY-9225 at 8/15/19 8:06 AM:

[jira] [Assigned] (GROOVY-9226) Calling super.toString() with @TypeChecked or @CompileStatic will throw java.lang.StackOverflowError

2019-08-15 Thread Daniel Sun (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun reassigned GROOVY-9226: -- Assignee: Daniel Sun > Calling super.toString() with @TypeChecked or @CompileStatic will

[jira] [Updated] (GROOVY-9226) Calling super.toString() with @TypeChecked or @CompileStatic will throw java.lang.StackOverflowError

2019-08-15 Thread Daniel Sun (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-9226: --- Fix Version/s: 3.0.0-beta-4 > Calling super.toString() with @TypeChecked or @CompileStatic will

[jira] [Updated] (GROOVY-9226) Calling super.toString() with @TypeChecked or @CompileStatic will throw java.lang.StackOverflowError

2019-08-15 Thread Chih Chao Yu (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chih Chao Yu updated GROOVY-9226: - Summary: Calling super.toString() with @TypeChecked or @CompileStatic will throw

[jira] [Closed] (GROOVY-9227) Bump gradle to 5.6

2019-08-15 Thread Daniel Sun (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun closed GROOVY-9227. -- Resolution: Fixed > Bump gradle to 5.6 > -- > > Key: GROOVY-9227 >

[jira] [Commented] (GROOVY-9226) Calling super.toString() with @TypeChecked or @CompileStatic will throw java.lang.StackOverflowError

2019-08-15 Thread Chih Chao Yu (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907941#comment-16907941 ] Chih Chao Yu commented on GROOVY-9226: -- So it won't get fixed in Groovy 2.4.x and 2.5.x? > Calling

[jira] [Commented] (GROOVY-9075) The exception message should be more clear when a GroovyObject's metaClass is wrong

2019-08-15 Thread Daniel Sun (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907871#comment-16907871 ] Daniel Sun commented on GROOVY-9075: You mean a better error message like the following one?

[jira] [Updated] (GROOVY-9223) Avoid generating common methods for each groovy class

2019-08-15 Thread Daniel Sun (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-9223: --- Description: {{invokeMethod}}, {{getProperty}} and {{setProperty}} are common for groovy classes,

[jira] [Created] (GROOVY-9227) Bump gradle to 5.6

2019-08-15 Thread Daniel Sun (JIRA)
Daniel Sun created GROOVY-9227: -- Summary: Bump gradle to 5.6 Key: GROOVY-9227 URL: https://issues.apache.org/jira/browse/GROOVY-9227 Project: Groovy Issue Type: Dependency upgrade

[GitHub] [groovy] danielsun1106 merged pull request #992: GROOVY-9215: Incorrect compile time access error is raised when using…

2019-08-15 Thread GitBox
danielsun1106 merged pull request #992: GROOVY-9215: Incorrect compile time access error is raised when using… URL: https://github.com/apache/groovy/pull/992 This is an automated message from the Apache Git Service. To

[jira] [Commented] (GROOVY-9223) Avoid generating common methods for each groovy class

2019-08-15 Thread Xiaoguang Wang (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907857#comment-16907857 ] Xiaoguang Wang commented on GROOVY-9223: Can you consider about this issue

[jira] [Commented] (GROOVY-9075) The exception message should be more clear when a GroovyObject's metaClass is wrong

2019-08-15 Thread Xiaoguang Wang (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907882#comment-16907882 ] Xiaoguang Wang commented on GROOVY-9075: Yes. Or something like: object[C1]'s metaClass

[GitHub] [groovy] danielsun1106 commented on issue #990: GROOVY-9223: Avoid generating common methods for each groovy class

2019-08-15 Thread GitBox
danielsun1106 commented on issue #990: GROOVY-9223: Avoid generating common methods for each groovy class URL: https://github.com/apache/groovy/pull/990#issuecomment-521557596 @blackdrag @paulk-asert Please review the PR :-)

[jira] [Commented] (GROOVY-9075) The exception message should be more clear when a GroovyObject's metaClass is wrong

2019-08-15 Thread Daniel Sun (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907888#comment-16907888 ] Daniel Sun commented on GROOVY-9075: Gotcha. Let me look into the issue later ;)   > The

[jira] [Updated] (GROOVY-9075) The exception message should be more clear when a GroovyObject's metaClass is wrong

2019-08-15 Thread Daniel Sun (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-9075: --- Fix Version/s: 3.0.0-beta-4 > The exception message should be more clear when a GroovyObject's

[jira] [Assigned] (GROOVY-9075) The exception message should be more clear when a GroovyObject's metaClass is wrong

2019-08-15 Thread Daniel Sun (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun reassigned GROOVY-9075: -- Assignee: Daniel Sun > The exception message should be more clear when a GroovyObject's

[jira] [Resolved] (GROOVY-9226) Calling super.toString() with @TypeChecked or @CompileStatic will throw java.lang.StackOverflowError

2019-08-15 Thread Daniel Sun (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun resolved GROOVY-9226. Resolution: Fixed Fixed by 

[jira] [Resolved] (GROOVY-9215) Incorrect compile time access error is raised when using @CompileStatic and/or @TypeChecked

2019-08-15 Thread Daniel Sun (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun resolved GROOVY-9215. Resolution: Fixed Fixed by 

[GitHub] [groovy] danielsun1106 opened a new pull request #994: GROOVY-9075: The exception message should be more clear when a Groovy…

2019-08-15 Thread GitBox
danielsun1106 opened a new pull request #994: GROOVY-9075: The exception message should be more clear when a Groovy… URL: https://github.com/apache/groovy/pull/994 …Object's metaClass is wrong This is an automated message

[jira] [Updated] (GROOVY-9228) CLI options for static compilation

2019-08-15 Thread Daniel Sun (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-9228: --- Fix Version/s: 3.0.0-beta-4 > CLI options for static compilation >

[GitHub] [groovy] danielsun1106 commented on issue #993: GROOVY-9228: CLI options for static compilation

2019-08-15 Thread GitBox
danielsun1106 commented on issue #993: GROOVY-9228: CLI options for static compilation URL: https://github.com/apache/groovy/pull/993#issuecomment-521684831 Let's wait for a while to see what other committer think about the PR. ping @paulk-asert , @remkop

[GitHub] [groovy] danielsun1106 edited a comment on issue #993: GROOVY-9228: CLI options for static compilation

2019-08-15 Thread GitBox
danielsun1106 edited a comment on issue #993: GROOVY-9228: CLI options for static compilation URL: https://github.com/apache/groovy/pull/993#issuecomment-521684831 Let's wait for a while to see what other committers think about the PR. ping @paulk-asert , @remkop

[GitHub] [groovy] danielsun1106 commented on a change in pull request #994: GROOVY-9075: The exception message should be more clear when a Groovy…

2019-08-15 Thread GitBox
danielsun1106 commented on a change in pull request #994: GROOVY-9075: The exception message should be more clear when a Groovy… URL: https://github.com/apache/groovy/pull/994#discussion_r314567245 ## File path: src/main/java/org/codehaus/groovy/runtime/MetaClassHelper.java

[GitHub] [groovy] paulk-asert commented on a change in pull request #994: GROOVY-9075: The exception message should be more clear when a Groovy…

2019-08-15 Thread GitBox
paulk-asert commented on a change in pull request #994: GROOVY-9075: The exception message should be more clear when a Groovy… URL: https://github.com/apache/groovy/pull/994#discussion_r314568581 ## File path: src/main/java/org/codehaus/groovy/runtime/MetaClassHelper.java

[GitHub] [groovy] paulk-asert commented on a change in pull request #994: GROOVY-9075: The exception message should be more clear when a Groovy…

2019-08-15 Thread GitBox
paulk-asert commented on a change in pull request #994: GROOVY-9075: The exception message should be more clear when a Groovy… URL: https://github.com/apache/groovy/pull/994#discussion_r314568581 ## File path: src/main/java/org/codehaus/groovy/runtime/MetaClassHelper.java

[GitHub] [groovy] danielsun1106 commented on a change in pull request #994: GROOVY-9075: The exception message should be more clear when a Groovy…

2019-08-15 Thread GitBox
danielsun1106 commented on a change in pull request #994: GROOVY-9075: The exception message should be more clear when a Groovy… URL: https://github.com/apache/groovy/pull/994#discussion_r314572084 ## File path: src/main/java/org/codehaus/groovy/runtime/MetaClassHelper.java

[GitHub] [groovy] paulk-asert commented on a change in pull request #994: GROOVY-9075: The exception message should be more clear when a Groovy…

2019-08-15 Thread GitBox
paulk-asert commented on a change in pull request #994: GROOVY-9075: The exception message should be more clear when a Groovy… URL: https://github.com/apache/groovy/pull/994#discussion_r314558063 ## File path: src/main/java/org/codehaus/groovy/runtime/MetaClassHelper.java

[GitHub] [groovy] paulk-asert commented on a change in pull request #994: GROOVY-9075: The exception message should be more clear when a Groovy…

2019-08-15 Thread GitBox
paulk-asert commented on a change in pull request #994: GROOVY-9075: The exception message should be more clear when a Groovy… URL: https://github.com/apache/groovy/pull/994#discussion_r314558063 ## File path: src/main/java/org/codehaus/groovy/runtime/MetaClassHelper.java

[GitHub] [groovy] danielsun1106 commented on a change in pull request #994: GROOVY-9075: The exception message should be more clear when a Groovy…

2019-08-15 Thread GitBox
danielsun1106 commented on a change in pull request #994: GROOVY-9075: The exception message should be more clear when a Groovy… URL: https://github.com/apache/groovy/pull/994#discussion_r314567178 ## File path: src/main/java/org/codehaus/groovy/runtime/MetaClassHelper.java

[GitHub] [groovy] danielsun1106 commented on a change in pull request #994: GROOVY-9075: The exception message should be more clear when a Groovy…

2019-08-15 Thread GitBox
danielsun1106 commented on a change in pull request #994: GROOVY-9075: The exception message should be more clear when a Groovy… URL: https://github.com/apache/groovy/pull/994#discussion_r314567245 ## File path: src/main/java/org/codehaus/groovy/runtime/MetaClassHelper.java