[GitHub] [groovy] danielsun1106 commented on issue #993: GROOVY-9228: CLI options for static compilation

2019-08-21 Thread GitBox
danielsun1106 commented on issue #993: GROOVY-9228: CLI options for static compilation URL: https://github.com/apache/groovy/pull/993#issuecomment-523391274 Merged. Thanks. This is an automated message from the Apache Git

[GitHub] [groovy] danielsun1106 commented on issue #993: GROOVY-9228: CLI options for static compilation

2019-08-15 Thread GitBox
danielsun1106 commented on issue #993: GROOVY-9228: CLI options for static compilation URL: https://github.com/apache/groovy/pull/993#issuecomment-521684831 Let's wait for a while to see what other committer think about the PR. ping @paulk-asert , @remkop

[GitHub] [groovy] danielsun1106 commented on issue #993: GROOVY-9228: CLI options for static compilation

2019-08-15 Thread GitBox
danielsun1106 commented on issue #993: GROOVY-9228: CLI options for static compilation URL: https://github.com/apache/groovy/pull/993#issuecomment-521673045 LGTM. BTW, could you expand the imports, e.g. `import groovy.lang.*;`? Groovy core team has a coding convention: import the