[GitHub] groovy pull request #785: GROOVY-7330: Incorrect dynamic proxy creation from...

2018-08-17 Thread paulk-asert
GitHub user paulk-asert opened a pull request:

https://github.com/apache/groovy/pull/785

GROOVY-7330: Incorrect dynamic proxy creation from map when there are…

… default methods

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paulk-asert/groovy groovy7330

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/785.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #785


commit 2c526ef1d53f8e8a5ef00f660b885a20378fc5a8
Author: Paul King 
Date:   2018-08-17T07:49:50Z

GROOVY-7330: Incorrect dynamic proxy creation from map when there are 
default methods




---


[GitHub] groovy pull request #784: support JAVA_HOME including spaces

2018-08-14 Thread am4dr
GitHub user am4dr opened a pull request:

https://github.com/apache/groovy/pull/784

support JAVA_HOME including spaces

Since Groovy 2.5.2, JAXB modules are added automatically based on detected 
Java version.
But in my environment, NoClassDefFoundError for JAXB is still thrown.

```console
$ where java
C:\Program Files\Java\jdk-10.0.2\bin\java.exe

$ groovy --version
Groovy Version: 2.5.2 JVM: 10.0.2 Vendor: "Oracle Corporation" OS: Windows 
10

$ type hello.groovy
println "hello, Groovy 2.5.2"

$ groovy hello.groovy
Caught: java.lang.NoClassDefFoundError: Unable to load class 
org.apache.groovy.jaxb.extensions.JaxbExtensions due to missing dependency 
javax/xml/bind/JAXBContext
java.lang.NoClassDefFoundError: Unable to load class 
org.apache.groovy.jaxb.extensions.JaxbExtensions due to missing dependency 
javax/xml/bind/JAXBContext
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
```

Java version detection in startGroovy.bat seems not to be able to handle 
JAVA_HOME containing spaces.

ref: version detection in startGroovy.bat

https://github.com/apache/groovy/blob/223366702a13ef369f216af2ba443670f42f02a1/src/bin/startGroovy.bat#L269-L272


Before this change, `JAVA_VERSION` is empty.
```console
# enable DEBUG to show echos
$ set DEBUG=1

$ groovy -v

...
> for /F "tokens=3" %g in ('C:\Program Files\Java\jdk-10.0.2\bin\java.exe 
-version 2>&1 | findstr /i "version"') do (SET JAVA_VERSION=%g )

> for /F "useback tokens=*" %a in ('') do set JAVA_VERSION=%~a
...
```

After, `JAVA_VERSION` set correctly.
```console
$ groovy -v

...
> for /F "tokens=3" %g in ('call "C:\Program 
Files\Java\jdk-10.0.2\bin\java.exe" -version 2>&1 | findstr /i "version"') do 
(SET JAVA_VERSION=%g )

> (SET JAVA_VERSION="10.0.2" )

> for /F "useback tokens=*" %a in ('"10.0.2"') do set JAVA_VERSION=%~a
...
```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/am4dr/groovy 
support-java_home-including-spaces

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/784.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #784


commit a3825e3b11a88059dc2d44cae0611f8da7f1054e
Author: amadarain 
Date:   2018-08-14T08:16:16Z

support JAVA_HOME including spaces




---


[GitHub] groovy pull request #783: GROOVY-8748: CompileUnit could implement NodeMetaD...

2018-08-13 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/783


---


[GitHub] groovy pull request #783: GROOVY-8748: CompileUnit could implement NodeMetaD...

2018-08-12 Thread paulk-asert
GitHub user paulk-asert opened a pull request:

https://github.com/apache/groovy/pull/783

GROOVY-8748: CompileUnit could implement NodeMetaDataHandler to act a…

…s a "global" node for metadata

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paulk-asert/groovy groovy8748

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/783.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #783


commit 027466b2a8ff104504644c541223f4c0532d7645
Author: Paul King 
Date:   2018-08-12T23:24:24Z

GROOVY-8748: CompileUnit could implement NodeMetaDataHandler to act as a 
"global" node for metadata




---


[GitHub] groovy pull request #:

2018-08-12 Thread danielsun1106
Github user danielsun1106 commented on the pull request:


https://github.com/apache/groovy/commit/ed3814a053eee8a4480c85c23485e161fd74c16a#commitcomment-30046088
  
Nice! The codebase is much cleaner than before :-)


---


[GitHub] groovy pull request #:

2018-08-11 Thread danielsun1106
Github user danielsun1106 commented on the pull request:


https://github.com/apache/groovy/commit/ec7b147b4b90c55e1d117f3bac63b060eeb79386#commitcomment-30043824
  
`UnlimitedConcurrentCache`'s `getAndPut`  on 2.5 branch is not thread safe, 
so the commit is only for the master.


---


[GitHub] groovy pull request #782: GROOVY-8741: Make single character GString behave ...

2018-08-10 Thread vmj
GitHub user vmj opened a pull request:

https://github.com/apache/groovy/pull/782

GROOVY-8741: Make single character GString behave like similar String in 
'=='

If there's interest to fix 
[GROOVY-8741](https://issues.apache.org/jira/browse/GROOVY-8741), this might be 
it.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vmj/groovy GROOVY-8741

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/782.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #782


commit ce830487dbcb86c78b42497bb093c7affda25d9b
Author: Mikko Värri 
Date:   2018-08-10T16:37:47Z

GROOVY-8741: Add tests and implementation




---


[GitHub] groovy pull request #781: GROOVY-8732: @CompileStatic refers to private fiel...

2018-08-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/781


---


[GitHub] groovy pull request #781: GROOVY-8732: @CompileStatic refers to private fiel...

2018-08-09 Thread paulk-asert
GitHub user paulk-asert opened a pull request:

https://github.com/apache/groovy/pull/781

GROOVY-8732: @CompileStatic refers to private field in parent class

Currently JavaBean style getters aren't recognised
before some preliminary provisions are made for the
case of accessing the private field in places where that
is allowed. The change is just not to proceed with those
provisions if the JavaBean getter is detected.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paulk-asert/groovy groovy8732

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/781.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #781


commit 2b4c33317f34d52c5fbeb0846639597a5f6b86fe
Author: Paul King 
Date:   2018-08-09T08:12:08Z

GROOVY-8732: @CompileStatic refers to private field in parent class
Currently JavaBean style getters aren't recognised
before some preliminary provisions are made for the
case of accessing the private field in places where that
is allowed. The change is just not to proceed with those
provisions if the JavaBean getter is detected.




---


[GitHub] groovy pull request #780: GROOVY-8722: final modifier for non-abstract metho...

2018-08-06 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/780


---


[GitHub] groovy pull request #780: GROOVY-8722: final modifier for non-abstract metho...

2018-08-05 Thread paulk-asert
GitHub user paulk-asert opened a pull request:

https://github.com/apache/groovy/pull/780

GROOVY-8722: final modifier for non-abstract methods in traits is ign…

…ored

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paulk-asert/groovy groovy8722

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/780.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #780


commit c472131950252d3da0329d24fade2897e8213ad4
Author: Paul King 
Date:   2018-08-06T02:51:14Z

GROOVY-8722: final modifier for non-abstract methods in traits is ignored




---


[GitHub] groovy pull request #777: add support for JDK 10 and JDK 11 targets

2018-08-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/777


---


[GitHub] groovy pull request #779: GROOVY-8726: Store the method node reference in Pa...

2018-08-02 Thread jameskleeh
GitHub user jameskleeh opened a pull request:

https://github.com/apache/groovy/pull/779

GROOVY-8726: Store the method node reference in Parameter

This implementation copies all parameters when they are passed to the 
method node constructor. While there will be some waste in this process, I find 
it much easier and maintainable compared to changing all of the places in the 
codebase where parameters are reused.

Note that the build on my fork is failing with an unrelated compilation 
error

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jameskleeh/groovy master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/779.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #779


commit 6710d938b557dbf709924d3112d84c8de8e97a99
Author: jameskleeh 
Date:   2018-08-02T04:03:41Z

GROOVY-8726: Store the method node reference in Parameter




---


[GitHub] groovy pull request #778: remove dependency on on dateutil from groovydoc

2018-07-31 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/778


---


[GitHub] groovy pull request #778: remove dependency on on dateutil from groovydoc

2018-07-31 Thread keeganwitt
GitHub user keeganwitt opened a pull request:

https://github.com/apache/groovy/pull/778

remove dependency on on dateutil from groovydoc



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/keeganwitt/groovy groovydoc-dateutils

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/778.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #778


commit fa06cd7764e38392a4f4dbe5f4c049e90c5b9777
Author: Keegan Witt 
Date:   2018-08-01T04:25:33Z

remove dependency on on dateutil from groovydoc




---


[GitHub] groovy pull request #777: add support for JDK 10 and JDK 11 targets

2018-07-31 Thread keeganwitt
GitHub user keeganwitt opened a pull request:

https://github.com/apache/groovy/pull/777

add support for JDK 10 and JDK 11 targets

fixed JDK 9 string to be consistent with other targets

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/keeganwitt/groovy java-10-11

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/777.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #777


commit c642cbf6395c0c0b88cb583543f3b71cbae06b7c
Author: Keegan Witt 
Date:   2018-08-01T04:32:30Z

add support for JDK 10 and JDK 11 targets
fixed JDK 9 string to be consistent with other targets




---


[GitHub] groovy pull request #776: GROOVY-8710: JAXB JDK9-11 compatibility for instal...

2018-07-25 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/776


---


[GitHub] groovy pull request #773: GROOVY-8696: TypeWrapper leaks out of DecompiledCl...

2018-07-25 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/773


---


[GitHub] groovy pull request #774: GROOVY-8282: Error while popping argument from ope...

2018-07-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/774


---


[GitHub] groovy pull request #775: GROOVY-8639: @Sortable annotation is not able to u...

2018-07-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/775


---


[GitHub] groovy pull request #776: GROOVY-8710: JAXB JDK9-11 compatibility for instal...

2018-07-24 Thread paulk-asert
GitHub user paulk-asert opened a pull request:

https://github.com/apache/groovy/pull/776

GROOVY-8710: JAXB JDK9-11 compatibility for install



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paulk-asert/groovy groovy8710

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/776.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #776


commit 87293c613c107944e493c11a51f9e2b497702064
Author: Paul King 
Date:   2018-07-24T20:47:57Z

GROOVY-8710: JDK9-11 compatibility for install




---


[GitHub] groovy pull request #:

2018-07-16 Thread remkop
Github user remkop commented on the pull request:


https://github.com/apache/groovy/commit/a798866fcfd98f7b2cd46e948b37217a8349f609#commitcomment-29728904
  
Thanks for the heads up!
The test fails because of a change in the error message format. I’ll fix 
it tonight and I’ll make sure to run the tests before pushing changes in the 
future. 


---


[GitHub] groovy pull request #:

2018-07-16 Thread danielsun1106
Github user danielsun1106 commented on the pull request:


https://github.com/apache/groovy/commit/a798866fcfd98f7b2cd46e948b37217a8349f609#commitcomment-29728201
  
Some tests failed. It seems that picocli 3.3.0 is not compatible with 3.2.0

https://travis-ci.org/apache/groovy/jobs/404235362
```
> Task :groovy-cli-picocli:test
groovy.cli.picocli.CliBuilderTest > testMixedBurstingAndLongOptions FAILED
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertTrue(Assert.java:31)
at junit.framework.TestCase.assertTrue(TestCase.java:201)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:104)
at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:326)
at 
groovy.lang.MetaClassImpl.invokeStaticMethod(MetaClassImpl.java:1554)
at 
org.codehaus.groovy.runtime.callsite.StaticMetaClassSite.callStatic(StaticMetaClassSite.java:64)
at 
org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallStatic(CallSiteArray.java:55)
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.callStatic(AbstractCallSite.java:197)
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.callStatic(AbstractCallSite.java:209)
at 
groovy.cli.picocli.CliBuilderTest.testMixedBurstingAndLongOptions(CliBuilderTest.groovy:526)
groovy.cli.picocli.CliBuilderTest > 
testLongOptionsRequireDoubleHyphenByDefault FAILED
junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertTrue(Assert.java:31)
at junit.framework.TestCase.assertTrue(TestCase.java:201)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:104)
at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:326)
at 
groovy.lang.MetaClassImpl.invokeStaticMethod(MetaClassImpl.java:1554)
at 
org.codehaus.groovy.runtime.callsite.StaticMetaClassSite.callStatic(StaticMetaClassSite.java:64)
at 
org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallStatic(CallSiteArray.java:55)
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.callStatic(AbstractCallSite.java:197)
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.callStatic(AbstractCallSite.java:209)
at 
groovy.cli.picocli.CliBuilderTest.testLongOptionsRequireDoubleHyphenByDefault(CliBuilderTest.groovy:920)
```


---


[GitHub] groovy pull request #775: GROOVY-8639: @Sortable annotation is not able to u...

2018-07-13 Thread paulk-asert
GitHub user paulk-asert opened a pull request:

https://github.com/apache/groovy/pull/775

GROOVY-8639: @Sortable annotation is not able to use accessible paren…

…t properties

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paulk-asert/groovy groovy8639

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/775.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #775


commit 6ea86bc256181417b006b1237cca2ac44a686008
Author: Paul King 
Date:   2018-07-13T09:24:51Z

GROOVY-8639: @Sortable annotation is not able to use accessible parent 
properties




---


[GitHub] groovy pull request #774: GROOVY-8282: Error while popping argument from ope...

2018-07-12 Thread paulk-asert
GitHub user paulk-asert opened a pull request:

https://github.com/apache/groovy/pull/774

GROOVY-8282: Error while popping argument from operand stack tracker …

…in class ...$Trait$Helper

Bare named argument parameters are captured in a TupleExpression rather 
than an ArgumentListExpression.
While it would be nice to retrofit APP to have the correct type, that would 
impact many more places.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paulk-asert/groovy groovy8282

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/774.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #774


commit f4baa9c82720bcf2ceda57f5c793b81ac6b8b5f4
Author: Paul King 
Date:   2018-07-12T11:30:54Z

GROOVY-8282: Error while popping argument from operand stack tracker in 
class ...$Trait$Helper

Bare named argument parameters are captured in a TupleExpression rather 
than an ArgumentListExpression.
While it would be nice to retrofit APP to have the correct type, that would 
impact many more places.




---


[GitHub] groovy pull request #773: GROOVY-8696: TypeWrapper leaks out of DecompiledCl...

2018-07-11 Thread paulk-asert
GitHub user paulk-asert opened a pull request:

https://github.com/apache/groovy/pull/773

GROOVY-8696: TypeWrapper leaks out of DecompiledClassNode



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paulk-asert/groovy groovy8696

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/773.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #773






---


[GitHub] groovy pull request #772: GROOVY-8281: Final field is null in trait, but it ...

2018-07-10 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/772


---


[GitHub] groovy pull request #767: GROOVY-8233: Java stub generation incorrect for st...

2018-07-10 Thread paulk-asert
Github user paulk-asert closed the pull request at:

https://github.com/apache/groovy/pull/767


---


[GitHub] groovy pull request #772: GROOVY-8281: Final field is null in trait, but it ...

2018-07-10 Thread paulk-asert
GitHub user paulk-asert opened a pull request:

https://github.com/apache/groovy/pull/772

GROOVY-8281: Final field is null in trait, but it has assigned value



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paulk-asert/groovy groovy8281

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/772.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #772


commit be7834c73ff967372f7714bad3ec1c5b662d1456
Author: Paul King 
Date:   2018-07-10T11:51:57Z

GROOVY-8281: Final field is null in trait, but it has assigned value




---


[GitHub] groovy pull request #771: GROOVY-8623: Show Groovy version in about help

2018-07-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/771


---


[GitHub] groovy pull request #770: GROOVY-8690 bump picocli to v3.2.0 from 3.1.0

2018-07-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/770


---


[GitHub] groovy pull request #771: GROOVY-8623: Show Groovy version in about help

2018-07-06 Thread jacekmusial
GitHub user jacekmusial opened a pull request:

https://github.com/apache/groovy/pull/771

GROOVY-8623: Show Groovy version in about help

Show current version of the Groovy in Groovy Object Browser in about->help
Jira: https://issues.apache.org/jira/browse/GROOVY-8623

How it looks like:

![obraz](https://user-images.githubusercontent.com/7474972/42387453-96f0e828-8142-11e8-85d1-1b6704b78577.png)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jacekmusial/groovy master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/771.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #771


commit bb62f662b6ccb5fcba8380d71d5a60b6dac534a0
Author: Jacek Musiał 
Date:   2018-07-06T15:30:16Z

GROOVY-8623: Show Groovy version in about help

Show current version of the Groovy in Groovy Object Browser in about->help




---


[GitHub] groovy pull request #770: GROOVY-8690 bump picocli to v3.2.0 from 3.1.0

2018-07-06 Thread remkop
GitHub user remkop opened a pull request:

https://github.com/apache/groovy/pull/770

GROOVY-8690 bump picocli to v3.2.0 from 3.1.0

Details in https://issues.apache.org/jira/browse/GROOVY-8690

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remkop/groovy 
GROOVY-8690-upgrade-to-picocli-v3.2.0

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/770.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #770


commit 82b6bd5d96cb93667dd51f410388dee8394b6de4
Author: Remko Popma 
Date:   2018-07-06T13:31:51Z

GROOVY-8690 bump picocli to v3.2.0 from 3.1.0




---


[GitHub] groovy pull request #769: Make Groovy/master work with Java 11 / JSR 181 + a...

2018-07-06 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/769


---


[GitHub] groovy pull request #768: Make Groovy/2.5.x work with Java 11 / JSR 181 + ad...

2018-07-06 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/768


---


[GitHub] groovy pull request #769: Make Groovy/master work with Java 11 / JSR 181 + a...

2018-07-06 Thread snazy
GitHub user snazy opened a pull request:

https://github.com/apache/groovy/pull/769

Make Groovy/master work with Java 11 / JSR 181 + add maven plugin



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/snazy/groovy java11-master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/769.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #769


commit b06433eb9d1f9c89e20c700208e177dcdf5728bb
Author: Robert Stupp 
Date:   2018-07-04T14:10:42Z

Make Groovy work with Java 11 + add maven plugin




---


[GitHub] groovy pull request #768: Make Groovy/2.5.x work with Java 11 / JSR 181 + ad...

2018-07-06 Thread snazy
GitHub user snazy opened a pull request:

https://github.com/apache/groovy/pull/768

Make Groovy/2.5.x work with Java 11 / JSR 181 + add maven plugin



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/snazy/groovy java11-2_5_X

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/768.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #768


commit a86e2527d5577c606a579c0fca12b0a344ddc770
Author: Robert Stupp 
Date:   2018-07-04T14:10:42Z

Make Groovy work with Java 11 + add maven plugin




---


[GitHub] groovy pull request #767: GROOVY-8233: Java stub generation incorrect for st...

2018-07-05 Thread paulk-asert
GitHub user paulk-asert opened a pull request:

https://github.com/apache/groovy/pull/767

GROOVY-8233: Java stub generation incorrect for static properties of …

…traits

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paulk-asert/groovy groovy8233

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/767.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #767


commit 2048d680490a2bc8710a59b907a50770593e97e0
Author: Paul King 
Date:   2018-07-05T13:26:23Z

GROOVY-8233: Java stub generation incorrect for static properties of traits




---


[GitHub] groovy pull request #766: GROOVY-8664 : Switch from findbugs to spotbugs

2018-07-03 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/766


---


[GitHub] groovy pull request #762: BigDecimalMath.MAX_DIVISION_SCALE is hard-coded to...

2018-07-03 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/762


---


[GitHub] groovy pull request #:

2018-07-02 Thread danielsun1106
Github user danielsun1106 commented on the pull request:


https://github.com/apache/groovy/commit/3143944c30f340208be40e9452e2e5be2e4a33be#commitcomment-29574669
  
In src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
In src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java on line 
673:
Done.

https://github.com/apache/groovy/commit/c7272cfa2571a4beb5974d044127bbafaf1e71d9


---


[GitHub] groovy pull request #:

2018-07-02 Thread paulk-asert
Github user paulk-asert commented on the pull request:


https://github.com/apache/groovy/commit/3143944c30f340208be40e9452e2e5be2e4a33be#commitcomment-29574608
  
In src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
In src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java on line 
673:
Better to use SystemUtil#getSystemPropertySafe?


---


[GitHub] groovy pull request #765: GROOVY-8675: GenericsUtils.PARAMETERIZED_TYPE_CACH...

2018-07-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/765


---


[GitHub] groovy pull request #766: GROOVY-8664 : Switch from findbugs to spotbugs

2018-07-02 Thread shrutigupta23
GitHub user shrutigupta23 opened a pull request:

https://github.com/apache/groovy/pull/766

GROOVY-8664 : Switch from findbugs to spotbugs

**Description** : Findbugs hasn't been updated in a few years. The 
community has since forked it and created Spotbugs.

**Changes** : Updated build to use spotbugs plugin

Screenshot below of SpotBugs Test report
https://user-images.githubusercontent.com/10268220/42178609-adcbf41c-7e4e-11e8-894c-f030abf538f7.png;>


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shrutigupta23/groovy groovy8664

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/766.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #766


commit f185adf033387671dfc61252b898c74b0da25c21
Author: Shruti Gupta 
Date:   2018-07-02T17:25:43Z

GROOVY-8664:switch from findbugs to spotbugs

commit 4b67ffef6eb9dd0fb9f8fc3c797def11c972c991
Author: Shruti Gupta 
Date:   2018-07-02T17:37:18Z

GROOVY-8664:Added spotbugs annotations

commit 322aad0ed6bc1ad5ae5f214a4f0ee79901a051cf
Author: Shruti Gupta 
Date:   2018-07-02T17:42:54Z

GROOVY-8664:Applied plugin to all modules




---


[GitHub] groovy pull request #763: GROOVY-8670: Make groovy-bsf an optional "module" ...

2018-07-01 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/763


---


[GitHub] groovy pull request #764: GROOVY-8671: Move JaxbGroovyMethods into their own...

2018-07-01 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/764


---


[GitHub] groovy pull request #765: GROOVY-8675: GenericsUtils.PARAMETERIZED_TYPE_CACH...

2018-07-01 Thread danielsun1106
GitHub user danielsun1106 opened a pull request:

https://github.com/apache/groovy/pull/765

GROOVY-8675: GenericsUtils.PARAMETERIZED_TYPE_CACHE is static and pri…

…vate

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danielsun1106/groovy GROOVY-8675

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/765.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #765


commit 211d3a1fe79a6b10bf35e9aed9fd23503bd30500
Author: Daniel Sun 
Date:   2018-07-02T01:12:11Z

GROOVY-8675: GenericsUtils.PARAMETERIZED_TYPE_CACHE is static and private




---


[GitHub] groovy pull request #764: GROOVY-8671: Move JaxbGroovyMethods into their own...

2018-07-01 Thread paulk-asert
GitHub user paulk-asert opened a pull request:

https://github.com/apache/groovy/pull/764

GROOVY-8671: Move JaxbGroovyMethods into their own optional groovy-ja…

…xb "module"

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paulk-asert/groovy groovy8671

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/764.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #764


commit 3f6672b8939fa4b3dc68c51eea016a6958e4214f
Author: Paul King 
Date:   2018-07-01T12:54:01Z

GROOVY-8671: Move JaxbGroovyMethods into their own optional groovy-jaxb 
"module"




---


[GitHub] groovy pull request #763: GROOVY-8670: Make groovy-bsf an optional "module" ...

2018-07-01 Thread paulk-asert
GitHub user paulk-asert opened a pull request:

https://github.com/apache/groovy/pull/763

GROOVY-8670: Make groovy-bsf an optional "module" for 2.5.1+, i.e. no…

…t reference by groovy-all

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paulk-asert/groovy groovy8670

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/763.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #763


commit 4bf127fcc3e592a4540e3425865a8cd8320dde6a
Author: Paul King 
Date:   2018-07-01T09:45:11Z

GROOVY-8670: Make groovy-bsf an optional "module" for 2.5.1+, i.e. not 
reference by groovy-all




---


[GitHub] groovy pull request #762: BigDecimalMath.MAX_DIVISION_SCALE is hard-coded to...

2018-06-27 Thread pierrepinon
GitHub user pierrepinon opened a pull request:

https://github.com/apache/groovy/pull/762

BigDecimalMath.MAX_DIVISION_SCALE is hard-coded to 10 digits

The "scale" for BigDecimal division is hard-coded to 10 
(BigDecimalMath.MAX_DIVISION_SCALE), which is fewer than the roughly equivalent 
16-17 digits for double (64-bit) division. It seems like the default scale 
should be at least as accurate as double division. Also it is probably 
desirable for this setting to be configurable in some way, maybe more than one. 
Maybe a global Java system property setting, and then some form of context 
related override (per-thread, per-script, etc.).

I use this fix for 2 years without side effects on a software for a big 
company. For comparison, Excel use a round with 15 digit after decimal

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pierrepinon/groovy master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/762.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #762


commit e5bbe6fd94f36389242b415a8d2c685f03ac51d9
Author: Pierre Pinon 
Date:   2018-06-27T07:35:10Z

Update BigDecimalMath.java

Fix GROOVY-2675




---


[GitHub] groovy pull request #734: GROOVY-8635: Make some groovy classes of groovy co...

2018-06-25 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/734


---


[GitHub] groovy pull request #760: GROOVY-8224: Stubs for classes implementing traits...

2018-06-21 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/760


---


[GitHub] groovy pull request #761: GROOVY-8654: fixed documentation build command

2018-06-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/761


---


[GitHub] groovy pull request #757: GROOVY-8008: AIOOB inner class ctor params with ru...

2018-06-20 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/757


---


[GitHub] groovy pull request #761: GROOVY-8654: fixed documentation build command

2018-06-20 Thread ab2
GitHub user ab2 opened a pull request:

https://github.com/apache/groovy/pull/761

GROOVY-8654: fixed documentation build command

changed the command to build GroovyDoc as suggested by Paul King in JIRA

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ab2/groovy master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/761.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #761


commit 46316b6797990d61496b8471e01baf3b2da8a620
Author: Andrej Balles 
Date:   2018-06-20T15:54:19Z

GROOVY-8654: fixed documentation build command




---


[GitHub] groovy pull request #760: GROOVY-8224: Stubs for classes implementing traits...

2018-06-19 Thread paulk-asert
GitHub user paulk-asert opened a pull request:

https://github.com/apache/groovy/pull/760

GROOVY-8224: Stubs for classes implementing traits with fields don't …

…include getters/setters

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paulk-asert/groovy groovy8224

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/760.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #760


commit 4f3e6a6282f9ba777faa4dd4c9a29a63412b4493
Author: Paul King 
Date:   2018-06-19T11:15:24Z

GROOVY-8224: Stubs for classes implementing traits with fields don't 
include getters/setters




---


[GitHub] groovy pull request #758: GROOVY-8637: @NamedVariant processing error

2018-06-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/758


---


[GitHub] groovy pull request #759: GROOVY-8627: Compile error using NamedParam with v...

2018-06-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/759


---


[GitHub] groovy pull request #756: GROOVY-8614: Invalid reference generated in InnerC...

2018-06-18 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/756


---


[GitHub] groovy pull request #757: GROOVY-8008: AIOOB inner class ctor params with ru...

2018-06-18 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request:

https://github.com/apache/groovy/pull/757#discussion_r196172656
  
--- Diff: src/main/java/org/codehaus/groovy/vmplugin/v5/Java5.java ---
@@ -405,6 +408,32 @@ public void configureClassNode(CompileUnit 
compileUnit, ClassNode classNode) {
 }
 }
 
+/**
+ * Synthetic parameters such as those added for inner class 
constructors may not be
+ * included in the parameter annotations array.  This is the case when 
at least one
+ * parameter of an inner class constructor is annotated with a RUNTIME 
retention
+ * policy.  This method will normalize the annotation array so that it 
contains the
+ * same number of elements as the array returned from {@link 
Constructor#getParameterTypes()}.
+ *
+ * If adjustment is required, the adjusted array will be pre-pended 
will zero-length
--- End diff --

Fixed, thanks.


---


[GitHub] groovy pull request #757: GROOVY-8008: AIOOB inner class ctor params with ru...

2018-06-17 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request:

https://github.com/apache/groovy/pull/757#discussion_r195962344
  
--- Diff: src/main/java/org/codehaus/groovy/vmplugin/v5/Java5.java ---
@@ -405,6 +408,32 @@ public void configureClassNode(CompileUnit 
compileUnit, ClassNode classNode) {
 }
 }
 
+/**
+ * Synthetic parameters such as those added for inner class 
constructors may not be
+ * included in the parameter annotations array.  This is the case when 
at least one
+ * parameter of an inner class constructor is annotated with a RUNTIME 
retention
+ * policy.  This method will normalize the annotation array so that it 
contains the
+ * same number of elements as the array returned from {@link 
Constructor#getParameterTypes()}.
+ *
+ * If adjustment is required, the adjusted array will be pre-pended 
will zero-length
--- End diff --

minor typo: second 'will' should be 'with'


---


[GitHub] groovy pull request #759: GROOVY-8627: Compile error using NamedParam with v...

2018-06-15 Thread paulk-asert
GitHub user paulk-asert opened a pull request:

https://github.com/apache/groovy/pull/759

GROOVY-8627: Compile error using NamedParam with value



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paulk-asert/groovy groovy8627

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/759.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #759


commit 55dfeb3fce54f674aca9645b989b2779fec06475
Author: Paul King 
Date:   2018-06-16T03:52:21Z

GROOVY-8627: Compile error using NamedParam with value




---


[GitHub] groovy pull request #758: GROOVY-8637: @NamedVariant processing error

2018-06-15 Thread paulk-asert
GitHub user paulk-asert opened a pull request:

https://github.com/apache/groovy/pull/758

GROOVY-8637: @NamedVariant processing error



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/paulk-asert/groovy groovy8637

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/758.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #758


commit 8995c0c470096ddce606c1009e045c93b9770d82
Author: Paul King 
Date:   2018-06-16T02:34:00Z

GROOVY-8637: @NamedVariant processing error




---


[GitHub] groovy pull request #757: GROOVY-8008: AIOOB inner class ctor params with ru...

2018-06-14 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request:

https://github.com/apache/groovy/pull/757

GROOVY-8008: AIOOB inner class ctor params with runtime annotations

Should also address 
[GROOVY-8505](https://issues.apache.org/jira/browse/GROOVY-8505) which is the 
same issue.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jwagenleitner/groovy 
8008-aioob-inner-class-ctor-param-annos

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/757.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #757


commit e5e8da40dc3e2d1d141280ee5162247da7ed3083
Author: John Wagenleitner 
Date:   2018-06-15T02:37:56Z

GROOVY-8008: AIOOB inner class ctor params with runtime annotations




---


[GitHub] groovy pull request #756: GROOVY-8614: Invalid reference generated in InnerC...

2018-06-14 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request:

https://github.com/apache/groovy/pull/756

GROOVY-8614: Invalid reference generated in InnerClasses attribute fo…

…r nested interface

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jwagenleitner/groovy 
8614-invalid-inner-nested-interface

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/756.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #756


commit 97c9d108de7197dcdc1aa55a8fc9af18a8880e17
Author: John Wagenleitner 
Date:   2018-06-15T02:31:59Z

GROOVY-8614: Invalid reference generated in InnerClasses attribute for 
nested interface




---


[GitHub] groovy pull request #753: GROOVY-8632: Groovy 2.5.0 fails to compile Google ...

2018-06-14 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/753


---


[GitHub] groovy pull request #755: Fix inferring return type issues

2018-06-14 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/755


---


[GitHub] groovy pull request #755: Fix inferring return type issues

2018-06-14 Thread danielsun1106
GitHub user danielsun1106 opened a pull request:

https://github.com/apache/groovy/pull/755

Fix inferring return type issues

When methods are mixed with other expressions in the return statement, 
`isNestedOrSandwichedMethodCall` fails to handle all cases and the source of 
issues. As `isNestedOrSandwichedMethodCall` is a temporary solution, it's 
useless and can be removed now.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danielsun1106/groovy infer-return-type

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/755.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #755


commit 09a8aa7c3db575be529e860d068e2702262970a0
Author: Daniel Sun 
Date:   2018-06-14T06:39:17Z

Fix inferreing return type issues




---


[GitHub] groovy pull request #754: reword one small section of the documentation on s...

2018-06-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/754


---


[GitHub] groovy pull request #754: reword one small section of the documentation on s...

2018-06-11 Thread jlstrater
GitHub user jlstrater opened a pull request:

https://github.com/apache/groovy/pull/754

reword one small section of the documentation on string interpolation



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jlstrater/groovy 
reword-one-small-section-of-the-docs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/754.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #754


commit 7bd8ebc6c869cd02497a40f9e5dcad193a7b556f
Author: Jennifer Strater 
Date:   2018-06-11T11:59:23Z

reword one small section of the documentation on string interpolation




---


[GitHub] groovy pull request #753: GROOVY-8632: Groovy 2.5.0 fails to compile Google ...

2018-06-08 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request:

https://github.com/apache/groovy/pull/753

GROOVY-8632: Groovy 2.5.0 fails to compile Google Java Client sample code

Class files can contain INNERCLASS references to other
classes inner classes whose name may be the same name as a
contained inner class. By storing modifiers in a map keyed
by short class name there is a possibility for the wrong
modifiers to be stored.

Since generated class files for inner classes contain an INNERCLASS
self reference, the logic can be simplified to look for a matching
name and storing those access modifiers. This eliminates the need
to search the outer class for the INNERCLASS reference.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jwagenleitner/groovy 
8632-decompiled-cn-nested-classes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/753.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #753


commit 8b0d57cfc8c600296763b31a9d9f5166b17ef4f1
Author: John Wagenleitner 
Date:   2018-06-09T00:00:16Z

GROOVY-8632: Groovy 2.5.0 fails to compile Google Java Client sample code

Class files can contain INNERCLASS references to other
classes inner classes whose name may be the same name as a
contained inner class. By storing modifiers in a map keyed
by short class name there is a possibility for the wrong
modifiers to be stored.

Since generated class files for inner classes contain an INNERCLASS
self reference, the logic can be simplified to look for a matching
name and storing those access modifiers. This eliminates the need
to search the outer class for the INNERCLASS reference.




---


[GitHub] groovy pull request #748: GROOVY-8628: Groovydoc fails to parse Java static ...

2018-06-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/748


---


[GitHub] groovy pull request #752: Add openjdk10 build

2018-06-06 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/752


---


[GitHub] groovy pull request #751: GROOVY-8636: Bump asm to 6.2

2018-06-06 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/751


---


[GitHub] groovy pull request #748: GROOVY-8628: Groovydoc fails to parse Java static ...

2018-06-06 Thread av-m
Github user av-m commented on a diff in the pull request:

https://github.com/apache/groovy/pull/748#discussion_r193378890
  
--- Diff: src/main/antlr2/org/codehaus/groovy/antlr/java/java.g ---
@@ -402,10 +402,9 @@ wildcardType
(("extends" | "super")=> typeArgumentBounds)?
;
 
-typeArgumentsDiamond
-{Token first = LT(1);}
+typeArgumentsOrDiamond
 :   LT! GT!
-{#typeArgumentsDiamond = #(create(TYPE_ARGUMENTS, 
"TYPE_ARGUMENTS",first,LT(1)), #typeArgumentsDiamond);}
--- End diff --

Since this concerns diamond operators I could not think of any case where 
actual type arguments could be extracted.


---


[GitHub] groovy pull request #752: Add openjdk10 build

2018-06-06 Thread danielsun1106
GitHub user danielsun1106 opened a pull request:

https://github.com/apache/groovy/pull/752

Add openjdk10 build



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danielsun1106/groovy java10

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/752.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #752


commit 544be957a197d0a6f6534e22fc110d9b704dfd85
Author: Daniel Sun 
Date:   2018-06-06T11:18:16Z

Add openjdk10 build




---


[GitHub] groovy pull request #751: Bump asm to 6.2

2018-06-06 Thread danielsun1106
GitHub user danielsun1106 opened a pull request:

https://github.com/apache/groovy/pull/751

Bump asm to 6.2



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danielsun1106/groovy bump-asm-62

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/751.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #751


commit 629e1bd2907722075ad85cb8f2a6d2b5069c81cb
Author: Daniel Sun 
Date:   2018-06-06T10:57:21Z

Bump asm to 6.2




---


[GitHub] groovy pull request #748: GROOVY-8628: Groovydoc fails to parse Java static ...

2018-06-06 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request:

https://github.com/apache/groovy/pull/748#discussion_r193360798
  
--- Diff: 
subprojects/groovy-groovydoc/src/test/groovy/org/codehaus/groovy/tools/groovydoc/testfiles/JavaStaticNestedClassWithDiamond.java
 ---
@@ -18,12 +18,17 @@
  */
 package org.codehaus.groovy.tools.groovydoc.testfiles;
 
-public abstract class JavaStaticNestedClassWithDiamond {
+public class JavaStaticNestedClassWithDiamond {
--- End diff --

OK. I see. It does not matter IMO.


---


[GitHub] groovy pull request #748: GROOVY-8628: Groovydoc fails to parse Java static ...

2018-06-06 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request:

https://github.com/apache/groovy/pull/748#discussion_r193360554
  
--- Diff: src/main/antlr2/org/codehaus/groovy/antlr/java/java.g ---
@@ -402,10 +402,9 @@ wildcardType
(("extends" | "super")=> typeArgumentBounds)?
;
 
-typeArgumentsDiamond
-{Token first = LT(1);}
+typeArgumentsOrDiamond
 :   LT! GT!
-{#typeArgumentsDiamond = #(create(TYPE_ARGUMENTS, 
"TYPE_ARGUMENTS",first,LT(1)), #typeArgumentsDiamond);}
--- End diff --

Could you explain the reason why the line should be removed?


---


[GitHub] groovy pull request #748: GROOVY-8628: Groovydoc fails to parse Java static ...

2018-06-06 Thread av-m
Github user av-m commented on a diff in the pull request:

https://github.com/apache/groovy/pull/748#discussion_r193308528
  
--- Diff: 
subprojects/groovy-groovydoc/src/test/groovy/org/codehaus/groovy/tools/groovydoc/testfiles/JavaStaticNestedClassWithDiamond.java
 ---
@@ -18,12 +18,17 @@
  */
 package org.codehaus.groovy.tools.groovydoc.testfiles;
 
-public abstract class JavaStaticNestedClassWithDiamond {
+public class JavaStaticNestedClassWithDiamond {
--- End diff --

It did not see any reason for the test class being abstract. Please let me 
know if I should revert the line in question.


---


[GitHub] groovy pull request #748: GROOVY-8628: Groovydoc fails to parse Java static ...

2018-06-05 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request:

https://github.com/apache/groovy/pull/748#discussion_r193270629
  
--- Diff: 
subprojects/groovy-groovydoc/src/test/groovy/org/codehaus/groovy/tools/groovydoc/testfiles/JavaStaticNestedClassWithDiamond.java
 ---
@@ -18,12 +18,17 @@
  */
 package org.codehaus.groovy.tools.groovydoc.testfiles;
 
-public abstract class JavaStaticNestedClassWithDiamond {
+public class JavaStaticNestedClassWithDiamond {
--- End diff --

Why should `abstract` be removed?


---


[GitHub] groovy pull request #747: GROOVY-8583: Fail to infer auto-return type from t...

2018-06-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/747


---


[GitHub] groovy pull request #748: GROOVY-8628: Groovydoc fails to parse Java static ...

2018-06-05 Thread av-m
Github user av-m commented on a diff in the pull request:

https://github.com/apache/groovy/pull/748#discussion_r193147784
  
--- Diff: 
subprojects/groovy-groovydoc/src/test/groovy/org/codehaus/groovy/tools/groovydoc/testfiles/JavaStaticNestedClassWithDiamond.java
 ---
@@ -0,0 +1,33 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one
+ *  or more contributor license agreements.  See the NOTICE file
+ *  distributed with this work for additional information
+ *  regarding copyright ownership.  The ASF licenses this file
+ *  to you under the Apache License, Version 2.0 (the
+ *  "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing,
+ *  software distributed under the License is distributed on an
+ *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *  KIND, either express or implied.  See the License for the
+ *  specific language governing permissions and limitations
+ *  under the License.
+ */
+package org.codehaus.groovy.tools.groovydoc.testfiles;
+
+public abstract class JavaStaticNestedClassWithDiamond {
+
+JavaStaticNestedClassWithDiamond() {
+}
+
+static class Nested extends JavaStaticNestedClassWithDiamond {
--- End diff --

Sure, please see the changes made in ff2d499


---


[GitHub] groovy pull request #749: GROOVY-8629: Groovy STC fails on the nested method...

2018-06-04 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/749


---


[GitHub] groovy pull request #750: GROOVY-8630: Refine the parameterized type cache

2018-06-04 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/750


---


[GitHub] groovy pull request #750: Refine the parameterized type cache

2018-06-04 Thread danielsun1106
GitHub user danielsun1106 opened a pull request:

https://github.com/apache/groovy/pull/750

Refine the parameterized type cache

Use `SoftReference` instance to hold value to release memory after STC is 
done.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danielsun1106/groovy 
refine-parameterized-type-cache

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/750.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #750


commit ba08108d01d748394e4cfb5d774bb768182e03a2
Author: Daniel Sun 
Date:   2018-06-04T10:42:56Z

Refine the parameterized type cache




---


[GitHub] groovy pull request #749: GROOVY-8629: Groovy STC fails on return of nested ...

2018-06-04 Thread danielsun1106
GitHub user danielsun1106 opened a pull request:

https://github.com/apache/groovy/pull/749

GROOVY-8629: Groovy STC fails on return of nested class using generics



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danielsun1106/groovy GROOVY-8629

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/749.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #749


commit 03e01742722e6436a315508de373b8a600cc8471
Author: Daniel Sun 
Date:   2018-06-04T07:22:03Z

GROOVY-8629: Groovy STC fails on return of nested class using generics




---


[GitHub] groovy pull request #748: GROOVY-8628: Groovydoc fails to parse Java static ...

2018-06-03 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request:

https://github.com/apache/groovy/pull/748#discussion_r192608515
  
--- Diff: 
subprojects/groovy-groovydoc/src/test/groovy/org/codehaus/groovy/tools/groovydoc/testfiles/JavaStaticNestedClassWithDiamond.java
 ---
@@ -0,0 +1,33 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one
+ *  or more contributor license agreements.  See the NOTICE file
+ *  distributed with this work for additional information
+ *  regarding copyright ownership.  The ASF licenses this file
+ *  to you under the Apache License, Version 2.0 (the
+ *  "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing,
+ *  software distributed under the License is distributed on an
+ *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *  KIND, either express or implied.  See the License for the
+ *  specific language governing permissions and limitations
+ *  under the License.
+ */
+package org.codehaus.groovy.tools.groovydoc.testfiles;
+
+public abstract class JavaStaticNestedClassWithDiamond {
+
+JavaStaticNestedClassWithDiamond() {
+}
+
+static class Nested extends JavaStaticNestedClassWithDiamond {
--- End diff --

Would you mind add some javadoc to this inner class and test whether its 
javadoc can be extracted properly?


---


[GitHub] groovy pull request #748: GROOVY-8628: Groovydoc fails to parse Java static ...

2018-06-03 Thread av-m
GitHub user av-m opened a pull request:

https://github.com/apache/groovy/pull/748

GROOVY-8628: Groovydoc fails to parse Java static nested classes with…

… diamond operator

java.g grammar file:
* Added support for Java static nested class with diamond operator,
  e.g. new Class.Nested<>()
* Simplified classOrInterfaceType with typeArgumentsOrDiamond

groovydoc test:
* Added groovydoc tool test for Java static nested class with diamond
  operator

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/av-m/groovy GROOVY-8628

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/748.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #748


commit 02c7d8e0d911ca4fb4a7c51f348183dd5a061fd8
Author: Marco-Antonio Avallone 
Date:   2018-06-03T20:36:17Z

GROOVY-8628: Groovydoc fails to parse Java static nested classes with 
diamond operator

java.g grammar file:
* Added support for Java static nested class with diamond operator,
  e.g. new Class.Nested<>()
* Simplified classOrInterfaceType with typeArgumentsOrDiamond

groovydoc test:
* Added groovydoc tool test for Java static nested class with diamond
  operator




---


[GitHub] groovy pull request #747: GROOVY-8583: Fail to infer auto-return type from t...

2018-06-02 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request:

https://github.com/apache/groovy/pull/747

GROOVY-8583: Fail to infer auto-return type from ternary operator



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jwagenleitner/groovy 8583-stc-ternary

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/747.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #747


commit 884ddeb4d9aca6c4a68f22f7fbd7ce2ab77f51f1
Author: John Wagenleitner 
Date:   2018-06-03T02:17:08Z

GROOVY-8583: Fail to infer auto-return type from ternary operator




---


[GitHub] groovy pull request #746: Refine the rule for missing right parenthesis

2018-06-02 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/746


---


[GitHub] groovy pull request #746: Refine the rule for missing right parenthesis

2018-06-02 Thread danielsun1106
GitHub user danielsun1106 opened a pull request:

https://github.com/apache/groovy/pull/746

Refine the rule for missing right parenthesis



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danielsun1106/groovy 
refine-missing-right-parenthesis

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/746.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #746


commit f1f507aabdaa859e6fa2c0365f76e381fc376b62
Author: Daniel Sun 
Date:   2018-06-02T15:25:00Z

Refine the rule for missing right parenthesis




---


[GitHub] groovy pull request #745: GROOVY-8621 Grape command line tool synopsis impro...

2018-06-02 Thread remkop
Github user remkop closed the pull request at:

https://github.com/apache/groovy/pull/745


---


[GitHub] groovy pull request #745: GROOVY-8621 Grape command line tool synopsis impro...

2018-06-01 Thread remkop
GitHub user remkop opened a pull request:

https://github.com/apache/groovy/pull/745

GROOVY-8621 Grape command line tool synopsis improvement version2

see https://issues.apache.org/jira/browse/GROOVY-8621

Previously merged PR had layout issues. Fixed in this PR.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remkop/groovy GROOVY-8621-grape-synopsis-v2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/745.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #745


commit 8b03ab824170207d90e1aa5d905985655b7a46c5
Author: Remko Popma 
Date:   2018-06-02T01:01:40Z

GROOVY-8621 Grape command line tool synopsis improvement version2




---


[GitHub] groovy pull request #744: GROOVY-8613: GCE in elvis assignment evaluation

2018-06-01 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/744


---


[GitHub] groovy pull request #744: GROOVY-8613: GCE in elvis assignment evaluation

2018-06-01 Thread danielsun1106
GitHub user danielsun1106 opened a pull request:

https://github.com/apache/groovy/pull/744

GROOVY-8613: GCE in elvis assignment evaluation



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danielsun1106/groovy GROOVY-8613

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/744.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #744


commit 402b6ab6879bffc402f6056061efc7a97c194406
Author: Daniel Sun 
Date:   2018-06-01T16:32:44Z

GROOVY-8613: GCE in elvis assignment evaluation




---


[GitHub] groovy pull request #743: GROOVY-8621 Grape command line tool synopsis impro...

2018-06-01 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/743


---


[GitHub] groovy pull request #743: GROOVY-8621 Grape command line tool synopsis impro...

2018-06-01 Thread remkop
GitHub user remkop opened a pull request:

https://github.com/apache/groovy/pull/743

GROOVY-8621 Grape command line tool synopsis improvement

see https://issues.apache.org/jira/browse/GROOVY-8621

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remkop/groovy 
GROOVY-8621-better-grape-synopsis

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/743.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #743


commit 9cb4e3fe831a47eb6b3ce6893566baedba67619a
Author: Remko Popma 
Date:   2018-06-01T11:59:46Z

GROOVY-8621 Grape command line tool synopsis improvement




---


[GitHub] groovy pull request #742: GROOVY-8620 Update docs for Grape dependency manag...

2018-06-01 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/742


---


[GitHub] groovy pull request #742: GROOVY-8620 Update docs for Grape dependency manag...

2018-06-01 Thread remkop
GitHub user remkop opened a pull request:

https://github.com/apache/groovy/pull/742

GROOVY-8620 Update docs for Grape dependency manager

see https://issues.apache.org/jira/browse/GROOVY-8620

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remkop/groovy GROOVY-8620-docs-grape

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/742.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #742


commit ac9a0580bc3327247c8910455966d14e5a03c619
Author: Remko Popma 
Date:   2018-06-01T11:16:39Z

GROOVY-8620 Update docs for Grape dependency manager




---


  1   2   3   4   5   6   7   8   9   10   >