[GitHub] groovy pull request #424: GROOVY-7933: fix method selection for boolean and ...

2016-09-25 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/424


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] groovy pull request #424: GROOVY-7933: fix method selection for boolean and ...

2016-09-17 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request:

https://github.com/apache/groovy/pull/424

GROOVY-7933: fix method selection for boolean and char primitives

boolean and char were not factored into the primitive distance tables which
would cause methods with Object to be selected in preference to those
with boolean/char and their respective Wrapper.

Inserted `boolean` and `char` (and their wrappers) in the distance table 
and kept all distances the same for the existing classes in the table (adding 
boolean and char as the farthest dist from the existing classes).

Had to fix one test because `HashCodeHelper` has overloaded methods and 
prior to this change it was selecting the method with `Object` instead of 
`boolean`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jwagenleitner/groovy GROOVY-7933

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/424.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #424


commit 156d3f72db9e80db6f62bdc3829f2d3767c9544e
Author: John Wagenleitner 
Date:   2016-09-18T05:41:06Z

GROOVY-7933: fix method selection for boolean and char primitives

boolean and char were not factored into the primitive distance tables which
would cause methods with Object to be selected in preference to those
with boolean/char and their respective Wrapper.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---