[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-18 Thread Jochen Theodorou (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480671#comment-16480671 ] Jochen Theodorou commented on GROOVY-8570: -- @mgroovy I would make this an optional and separate

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-17 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479866#comment-16479866 ] Paul King commented on GROOVY-8570: --- That issue is only 3 days old but the topic has been discussed

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-17 Thread mgroovy (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479845#comment-16479845 ] mgroovy commented on GROOVY-8570: - @[~blackdrag]: When would that converter run ? And who would implement

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-17 Thread mgroovy (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479840#comment-16479840 ] mgroovy commented on GROOVY-8570: - @[~paulk]: You mean https://issues.apache.org/jira/browse/GROOVY-8580

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-16 Thread Jochen Theodorou (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478349#comment-16478349 ] Jochen Theodorou commented on GROOVY-8570: -- "Groovy-to-idiomatic-Groovy converter" is what I did

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-16 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478283#comment-16478283 ] Paul King commented on GROOVY-8570: --- But there has been discussion about having a special semantics

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-16 Thread mgroovy (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478097#comment-16478097 ] mgroovy commented on GROOVY-8570: - @[~paulk]: But how is someone to tell that "var" is bad style, and

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-14 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474177#comment-16474177 ] Paul King commented on GROOVY-8570: --- I am okay with Groovy devs using bad style. I encourage them to

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-11 Thread mgroovy (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472033#comment-16472033 ] mgroovy commented on GROOVY-8570: - @[~paulk]: The question this boils down to for me is: Are you OK with

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-11 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471773#comment-16471773 ] Paul King commented on GROOVY-8570: --- I am +1 on the idea of warning support in general. But with a

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-10 Thread mgroovy (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470897#comment-16470897 ] mgroovy commented on GROOVY-8570: - And in general: Come on guys, it's only support for warnings, which

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-10 Thread mgroovy (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470699#comment-16470699 ] mgroovy commented on GROOVY-8570: - (For any converter (formatter/transformer) which the user is not

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-10 Thread mgroovy (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470681#comment-16470681 ] mgroovy commented on GROOVY-8570: - @[~blackdrag]: Do you mean a Java-to-Groovy converter, or a

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-10 Thread Jochen Theodorou (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470303#comment-16470303 ] Jochen Theodorou commented on GROOVY-8570: -- I think what you advocate for is not warnings in

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-08 Thread mgroovy (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468101#comment-16468101 ] mgroovy commented on GROOVY-8570: - Let me advocate back: Curly braces and var should make your list of

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-08 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468021#comment-16468021 ] Paul King commented on GROOVY-8570: --- I can see both sides to this suggestion. There have been numerous

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-08 Thread mgroovy (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467875#comment-16467875 ] mgroovy commented on GROOVY-8570: - (shalt not type while riding the tram... - continued) ... that e.g. @

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-08 Thread mgroovy (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467870#comment-16467870 ] mgroovy commented on GROOVY-8570: - @[~paulk]: Hi Paul, an opt-in codenarc hook might be useful, but it is

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-08 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467466#comment-16467466 ] Paul King commented on GROOVY-8570: --- I thought I had made a previous comment for this but it was right

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-06 Thread mgroovy (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465225#comment-16465225 ] mgroovy commented on GROOVY-8570: - @[~emilles]: The difference to the scenario you describe here is not

[jira] [Commented] (GROOVY-8570) Support Warnings in Groovy Compiler

2018-05-06 Thread Eric Milles (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465211#comment-16465211 ] Eric Milles commented on GROOVY-8570: - When faced with multiple options for simple idioms in Java,