[jira] [Commented] (GROOVY-8908) Bump gradle to 5.0
[
https://issues.apache.org/jira/browse/GROOVY-8908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707517#comment-16707517
]
ASF GitHub Bot commented on GROOVY-8908:
Github user danielsun1106 commented on a diff in the pull request:
https://github.com/apache/groovy/pull/835#discussion_r238350588
--- Diff: subprojects/parser-antlr4/build.gradle ---
@@ -30,9 +30,11 @@ def srcBase = "subprojects/parser-antlr4/src"
def srcMain = "$srcBase/main"
def srcTest = "$srcBase/test"
-final PARSER_PACKAGE_NAME = 'org.apache.groovy.parser.antlr4'
generateGrammarSource {
+maxHeapSize = '1g'
--- End diff --
https://travis-ci.org/danielsun1106/groovy/jobs/460259483
```
> Task :generateGrammarSource FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':generateGrammarSource'.
> Java heap space
```
Groovy's grammar is quite complicated, so more memory will be consumed. As
you can see, the `generateGrammarSource` task fails if the heap size is a bit
small, e.g. `512m`. Also, you can try to clone apache/groovy and set the heap
size to `maxHeapSize = '512m'` then run `gradlew clean generateGrammarSource
--no-build-cache` locally, I believe OOM can be reproduced.
> Bump gradle to 5.0
> --
>
> Key: GROOVY-8908
> URL: https://issues.apache.org/jira/browse/GROOVY-8908
> Project: Groovy
> Issue Type: Dependency upgrade
>Reporter: Daniel Sun
>Assignee: Daniel Sun
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GROOVY-8908) Bump gradle to 5.0
[
https://issues.apache.org/jira/browse/GROOVY-8908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707503#comment-16707503
]
ASF GitHub Bot commented on GROOVY-8908:
Github user melix commented on a diff in the pull request:
https://github.com/apache/groovy/pull/835#discussion_r238345659
--- Diff: subprojects/parser-antlr4/build.gradle ---
@@ -30,9 +30,11 @@ def srcBase = "subprojects/parser-antlr4/src"
def srcMain = "$srcBase/main"
def srcTest = "$srcBase/test"
-final PARSER_PACKAGE_NAME = 'org.apache.groovy.parser.antlr4'
generateGrammarSource {
+maxHeapSize = '1g'
--- End diff --
From my tests it seems we can reduce to `512m`, otherwise LGTM :+1:
> Bump gradle to 5.0
> --
>
> Key: GROOVY-8908
> URL: https://issues.apache.org/jira/browse/GROOVY-8908
> Project: Groovy
> Issue Type: Dependency upgrade
>Reporter: Daniel Sun
>Assignee: Daniel Sun
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GROOVY-8908) Bump gradle to 5.0
[ https://issues.apache.org/jira/browse/GROOVY-8908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707491#comment-16707491 ] ASF GitHub Bot commented on GROOVY-8908: Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/835 > Bump gradle to 5.0 > -- > > Key: GROOVY-8908 > URL: https://issues.apache.org/jira/browse/GROOVY-8908 > Project: Groovy > Issue Type: Dependency upgrade >Reporter: Daniel Sun >Assignee: Daniel Sun >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GROOVY-8908) Bump gradle to 5.0
[ https://issues.apache.org/jira/browse/GROOVY-8908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707373#comment-16707373 ] ASF GitHub Bot commented on GROOVY-8908: GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/835 GROOVY-8908: Bump gradle to 5.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy GROOVY-8908 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/835.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #835 commit e4c993d9c58d0296b3a49ee80b3984a535e2b478 Author: danielsun1106 Date: 2018-12-03T15:31:27Z GROOVY-8908: Bump gradle to 5.0 > Bump gradle to 5.0 > -- > > Key: GROOVY-8908 > URL: https://issues.apache.org/jira/browse/GROOVY-8908 > Project: Groovy > Issue Type: Dependency upgrade >Reporter: Daniel Sun >Assignee: Daniel Sun >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
