[GitHub] [ignite] Sega76 commented on a change in pull request #7566: Ignite 12832

[GitBox]

Sega76 commented on a change in pull request #7566: Ignite 12832
URL: https://github.com/apache/ignite/pull/7566#discussion_r397662421
 
 

 ##
 File path: modules/core/src/test/resources/user-attribute.properties
 ##
 @@ -0,0 +1 @@
+attr3=val3
 
 Review comment:
   newline


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] Sega76 commented on a change in pull request #7566: Ignite 12832

[GitBox]

Sega76 commented on a change in pull request #7566: Ignite 12832
URL: https://github.com/apache/ignite/pull/7566#discussion_r397652677
 
 

 ##
 File path: 
modules/core/src/test/java/org/apache/ignite/internal/commandline/CommandHandlerParsingTest.java
 ##
 @@ -204,7 +215,9 @@ public void testFindAndDeleteGarbage() {
 return res;
 }
 
-/** */
+/**
+ *
 
 Review comment:
   replace / ** */


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] Sega76 commented on a change in pull request #7566: Ignite 12832

[GitBox]

Sega76 commented on a change in pull request #7566: Ignite 12832
URL: https://github.com/apache/ignite/pull/7566#discussion_r397652032
 
 

 ##
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/commandline/ConnectionAndSslParameters.java
 ##
 @@ -71,6 +73,9 @@
 /** Truststore Password. */
 private char[] sslTrustStorePassword;
 
+/** Truststore Password. */
 
 Review comment:
   rename comments


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [ignite] Sega76 commented on a change in pull request #7566: Ignite 12832

[GitBox]

Sega76 commented on a change in pull request #7566: Ignite 12832
URL: https://github.com/apache/ignite/pull/7566#discussion_r397646229
 
 

 ##
 File path: 
modules/core/src/main/java/org/apache/ignite/internal/commandline/CommonArgParser.java
 ##
 @@ -310,20 +332,38 @@ ConnectionAndSslParameters 
parseAndValidate(Iterator rawArgIter) {
 
 break;
 
+case CMD_USER_ATTR:
+userAttrStr = argIter.nextArg("Expected user attribute 
string.");
+;
 
 Review comment:
   excess ';'


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services