pavlukhin commented on issue #6917: IGNITE-12189 Implementation correct limit
for TextQuery
URL: https://github.com/apache/ignite/pull/6917#issuecomment-548703356
Once again about `List.sublist`.
Unfortunately it is a common practice in Ignite. We do not have cheap
performance measurement feedback loop, consequently we are trying to use faster
approaches but possibly sacrificing code simplicity. There were a lot of cases
from a real practice where a single "innocent" code line (not lock and not
system call) caused visible performance drop.
Also I can thing about another option. Apparently a collection coming to
enqueue method is always a List. We can try to do a refactoring and change an
argument type to List. Then List.sublist method could be used directly.
Possibly, it deserves a separate ticket. What do you think?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
